Re: [PATCH 1/2] testsuite: arm: remove arm32 check from a few effective-targets

2025-08-08 Thread Christophe Lyon
On Fri, 8 Aug 2025 at 16:58, Richard Earnshaw wrote: > > On 04/07/2025 23:00, Christophe Lyon wrote: > > A few arm effective-targets call check_effective_target_arm32 even > > though they would force a -march=XXX flag which supports Arm and/or > > Thumb-2, thus making

Re: [PATCH] testsuite: arm: add needed -mcpu / -march to arm_crypto_ok

2025-08-08 Thread Christophe Lyon
On Fri, 8 Aug 2025 at 16:51, Richard Earnshaw wrote: > > On 26/05/2025 17:08, Christophe Lyon wrote: > > This effective target implicitly expects -march=armv8-a, otherwise > > with a toolchain configured for instance with > > --with-cpu=cortex-m0 --with-float=soft, >

Re: [PATCH 2/2] testsuite: arm: factorize arm_v8_neon_ok flags

2025-08-08 Thread Christophe Lyon
On Fri, 8 Aug 2025 at 17:04, Richard Earnshaw wrote: > > On 04/07/2025 23:00, Christophe Lyon wrote: > > Like we do in other effective-targets, add > > "-mcpu=unset -march=armv8-a" > > directly when setting et_arm_v8_neon_flags in arm_v8_neon_ok_nocache, > >

[PATCH] aarch64: libgcc: Honor disable-werror [PR117600]

2025-08-08 Thread Christophe Lyon
In commit r15-4417-g71c7b446b98aa5, I made -werror mandatory when building libgcc for aarch64. While it achieved its goal (make us fix problems unnoticed so far), there has a been a lot of debate because it couldn't be disabled easily. This patch adds support for --enable-werror/--disable-werror

Re: [PATCH] testsuite: Restore dg-do run on pr116906 and pr78185 tests

2025-07-28 Thread Christophe Lyon
Ping? Le lun. 7 juil. 2025, 19:07, Christophe Lyon a écrit : > On Mon, 7 Jul 2025 at 15:47, Torbjorn SVENSSON > wrote: > > > > > > > > On 2025-07-03 15:02, Christophe Lyon wrote: > > > ping^2 ? > > > > Looks fine to me, but as you know, my app

Re: [PATCH] arm: always enable both simd and mve builtins

2025-07-28 Thread Christophe Lyon
ping? On Sat, 5 Jul 2025 at 00:04, Christophe Lyon wrote: > > We get lots of error messages when compiling arm_neon.h under > e.g. -mcpu=cortex-m55, because Neon builtins are enabled only when > !TARGET_HAVE_MVE. This has been the case since MVE support was > introduced. > &g

Re: [PATCH] arm: Fix CMSE nonecure calls [PR 120977]

2025-07-28 Thread Christophe Lyon
ping? On Thu, 10 Jul 2025 at 16:08, Christophe Lyon wrote: > > As discussed in > https://gcc.gnu.org/pipermail/gcc-patches/2025-June/685733.html > the operand of the call should be a mem rather than an unspec. > > This patch moves the unspec to an additional argument of

Re: [PATCH 2/2] testsuite: arm: factorize arm_v8_neon_ok flags

2025-07-28 Thread Christophe Lyon
ping? On Sat, 5 Jul 2025 at 00:01, Christophe Lyon wrote: > > Like we do in other effective-targets, add > "-mcpu=unset -march=armv8-a" > directly when setting et_arm_v8_neon_flags in arm_v8_neon_ok_nocache, > to avoid having to add these two flags in all users of arm_v8

Re: [PATCH 1/2] testsuite: arm: remove arm32 check from a few effective-targets

2025-07-28 Thread Christophe Lyon
ping? On Sat, 5 Jul 2025 at 00:01, Christophe Lyon wrote: > > A few arm effective-targets call check_effective_target_arm32 even > though they would force a -march=XXX flag which supports Arm and/or > Thumb-2, thus making the arm32 check useless. This has an impact when > t

Re: [PATCH] testsuite: arm: Add effective-target vect_early_break to vect-tsvc-*

2025-07-11 Thread Christophe Lyon
Hi Torbjörn, On Fri, 11 Jul 2025 at 10:47, Torbjörn SVENSSON wrote: > > Ok for trunk, gcc-15 and gcc-14. > > I discovered that the dg-require-effective-target is missing on gcc-14, > but it's probably the right thing to add on gcc-15 and trunk too. > > Without the `dg-require-effective-target vec

Re: [PATCH v3] arm.cc: fix thumb1 size-optimized function prolog violates -ffixed-rX [PR117366]

2025-07-10 Thread Christophe Lyon
Thanks for the update. Like in your other email, there are still formatting issues. Here is the version I applied manually and used in CI. Christophe On Thu, 10 Jul 2025 at 01:46, Matt Parks wrote: > > This patch fixes PR117366: > arm thumb1 epilogue size optimizer violates -ffixed-r4. > > gcc

Re: [PATCH v2] arm.cc: fix thumb1 prologue high reg restore violates -ffixed-rX [PR117468]

2025-07-10 Thread Christophe Lyon
Hi, Thanks for the update. There are still some formatting problems, some of which might be caused by your mailer. I manually applied the patch and manually triggered CI, the new test passed without regression. Here is the version I tested, let's wait for Richard's feedback. Christophe On Thu

[PATCH] arm: Fix CMSE nonecure calls [PR 120977]

2025-07-10 Thread Christophe Lyon
RE_MEM (we need to remove -slim for that). The tests enable an FPU via -march so that the test passes whether the testing harness forces -mfloat-abi or not. 2025-07-08 Christophe Lyon PR target/120977 gcc/ * config/arm/arm.md (call): Move unspec parameter t

Re: [PATCH][PR117468] arm.cc: fix thumb1 prologue high reg restore violates -ffixed-rX

2025-07-09 Thread Christophe Lyon
Hi, Thanks for your patch, I think the same comments apply as the ones I just sent for your other patch (https://gcc.gnu.org/pipermail/gcc-patches/2025-July/689121.html) Christophe On Thu, 26 Jun 2025 at 01:35, Matt Parks wrote: > > Fixing issue with thumb1 code generation clobbering register.

Re: [PATCH v2][PR117366] arm.cc: fix thumb1 size-optimized function prolog violates -ffixed-rX

2025-07-09 Thread Christophe Lyon
Hi, Thanks for the patch, the code change looks sensible to me, but you'll have to wait for Richard (in cc) as he is the maintainer. However I have a few comments below: On Thu, 26 Jun 2025 at 00:57, Matt Parks wrote: > > Trying again, hopefully formatted correctly this time, and now including a

Re: [PATCH v2] testsuite: arm: Update function body for scheduler

2025-07-09 Thread Christophe Lyon
On Wed, 9 Jul 2025 at 10:25, Torbjörn SVENSSON wrote: > > Ok for trunk and releases/gcc-15? > > Changes since v1: > - Removed the acceptance of LDR as it's only generated without > r15-7373-g5163cf2ae14. Since > I'm currently looking into gcc-14 release, and made the patch in that > scope, I r

Re: [PATCH] testsuite: arm: Update function body for scheduler

2025-07-08 Thread Christophe Lyon
On Tue, 8 Jul 2025 at 17:17, Torbjörn SVENSSON wrote: > > Ok for trunk and releases/gcc-15? > > -- > > The scheduler allows the `and` instruction to be placed at 3 different > locations. Update the function body to contain all 3 locations. > Also, armv8.1-m.main can use `ldr` instead of `pop` to r

Re: [PATCH] testsuite: Restore dg-do run on pr116906 and pr78185 tests

2025-07-07 Thread Christophe Lyon
On Mon, 7 Jul 2025 at 15:47, Torbjorn SVENSSON wrote: > > > > On 2025-07-03 15:02, Christophe Lyon wrote: > > ping^2 ? > > Looks fine to me, but as you know, my approval does not count. > Thanks for confirming I didn't miss anything from your intentions. Christ

Re: [PATCH] arm_neon.h: remove useless push/pop pragmas

2025-07-04 Thread Christophe Lyon
ping? On Tue, 27 May 2025 at 08:33, Christophe Lyon wrote: > > On Mon, 26 May 2025 at 18:14, Christophe Lyon > wrote: > > > > Remove #pragma GCC target ("arch=armv8.2-a+bf16") and preceding > > target and is thus useless. > I guess this should read: >

Re: [PATCH] testsuite: arm: add needed -mcpu / -march to arm_crypto_ok

2025-07-04 Thread Christophe Lyon
ping? On Mon, 26 May 2025 at 18:08, Christophe Lyon wrote: > > This effective target implicitly expects -march=armv8-a, otherwise > with a toolchain configured for instance with > --with-cpu=cortex-m0 --with-float=soft, > it fails even when trying > -mfpu=crypto-neon-fp-armv8

[PATCH] arm: always enable both simd and mve builtins

2025-07-04 Thread Christophe Lyon
We get lots of error messages when compiling arm_neon.h under e.g. -mcpu=cortex-m55, because Neon builtins are enabled only when !TARGET_HAVE_MVE. This has been the case since MVE support was introduced. This patch uses an approach similar to what we do on aarch64, but only partially since Neon i

[PATCH 2/2] testsuite: arm: factorize arm_v8_neon_ok flags

2025-07-04 Thread Christophe Lyon
Like we do in other effective-targets, add "-mcpu=unset -march=armv8-a" directly when setting et_arm_v8_neon_flags in arm_v8_neon_ok_nocache, to avoid having to add these two flags in all users of arm_v8_neon_ok. This avoids duplication and possible typos / oversights. gcc/testsuite/ChangeLog:

[PATCH 1/2] testsuite: arm: remove arm32 check from a few effective-targets

2025-07-04 Thread Christophe Lyon
A few arm effective-targets call check_effective_target_arm32 even though they would force a -march=XXX flag which supports Arm and/or Thumb-2, thus making the arm32 check useless. This has an impact when the toolchain is configured with a default -march or -mcpu which supports Thumb-1 only: in su

Re: [PATCH] testsuite: Restore dg-do run on pr116906 and pr78185 tests

2025-07-03 Thread Christophe Lyon
ping^2 ? On Wed, 18 Jun 2025 at 12:11, Christophe Lyon wrote: > > ping? > > On Mon, 26 May 2025 at 17:26, Christophe Lyon > wrote: > > > > On Mon, 26 May 2025 at 17:14, Christophe Lyon > > wrote: > > > > > > Commit r15-7152-g57b706d141

Re: [PATCH] testsuite: Restore dg-do run on pr116906 and pr78185 tests

2025-06-18 Thread Christophe Lyon
ping? On Mon, 26 May 2025 at 17:26, Christophe Lyon wrote: > > On Mon, 26 May 2025 at 17:14, Christophe Lyon > wrote: > > > > Commit r15-7152-g57b706d141b87c removed > > /* { dg-do run { target*-*-linux* *-*-gnu* *-*-uclinux* } } */ > > > > from these

[gcc-14][PATCH 0/2] testsuite: backport Reduce iteration counts for gcc.dg/vect/tsvc tests.

2025-06-17 Thread Christophe Lyon
We often see timeouts when running these tests on simulator, and Joern's patch apply cleanly (and fix the problem). OK to backport to gcc-14? Thanks, Christophe Joern Rennecke (2): Reduce iteration counts for gcc.dg/vect/tsvc tests. Fix PR testsuite/116271, gcc.dg/vect/tsvc/vect-tsvc-s176.c

[PATCH 1/2] Reduce iteration counts for gcc.dg/vect/tsvc tests.

2025-06-17 Thread Christophe Lyon
From: Joern Rennecke testsuite/ * gcc.dg/vect/tsvc/tsvc.h (iterations): Allow to override, default to 10. (get_expected_result): Add values for iterations counts 10, 256 and 3200. (run): Add code to output values for new iterations counts. * gcc.dg/

[PATCH 2/2] Fix PR testsuite/116271, gcc.dg/vect/tsvc/vect-tsvc-s176.c fails

2025-06-17 Thread Christophe Lyon
From: Joern Rennecke gcc/testsuite: PR testsuite/116271 * gcc.dg/vect/tsvc/vect-tsvc-s176.c [TRUNCATE_TEST]: Make sure that m stays the same as the loop bound of the middle loop. * gcc.dg/vect/tsvc/tsvc.h (get_expected_result) [TRUNCATE_TEST]: Adjust expec

Re: [Fortran, Patch, PR120483, v1] Fix wrong type of saved allocatable strings.

2025-06-03 Thread Christophe Lyon
Hi! On Mon, 2 Jun 2025 at 20:53, Andre Vehreschild wrote: > > Hi Thomas, > > thanks for the ok. Unfortunately does the patch regress in gomp (test case > gomp/pr104382 when I am not mistaken ; the one with the lone 'save' > statement). This was reported by the regression testing host at first

[PATCH] testsuite: Add tls_link effective target

2025-05-27 Thread Christophe Lyon
Some tests have 'dg-do link' but currently require 'tls' which is a compile-only check. In some configurations of arm-none-eabi, the 'tls' effective-target can be successful although these tests fail to link with undefined reference to `__aeabi_read_tp' This patch as a new tls_link effective targ

[PATCH] testsuite: arm: remove arm32 check from a few effective-targets

2025-05-27 Thread Christophe Lyon
A few arm effective-targets call check_effective_target_arm32 even though they would force an -march=XXX flag which support Arm and/or Thumb-2, thus making the arm32 check useless. This has an impact when the toolchain is configured with a default -march or -mcpu which supports Thumb-1 only: in su

Re: [PATCH] arm: always enable both simd and mve builtins

2025-05-26 Thread Christophe Lyon
On Mon, 26 May 2025 at 18:35, Christophe Lyon wrote: > > We get lots of error messages when compiling arm_neon.h under > e.g. -mcpu=cortex-m55, because Neon builtins are enabled only when > !TARGET_HAVE_MVE. This has been the case since MVE support was > introduced. > &g

Re: [PATCH] arm_neon.h: remove useless push/pop pragmas

2025-05-26 Thread Christophe Lyon
On Mon, 26 May 2025 at 18:14, Christophe Lyon wrote: > > Remove #pragma GCC target ("arch=armv8.2-a+bf16") and preceding > target and is thus useless. I guess this should read: Remove #pragma GCC target ("arch=armv8.2-a+bf16") since it matches the preceding pragma G

[PATCH] arm: always enable both simd and mve builtins

2025-05-26 Thread Christophe Lyon
We get lots of error messages when compiling arm_neon.h under e.g. -mcpu=cortex-m55, because Neon builtins are enabled only when !TARGET_HAVE_MVE. This has been the case since MVE support was introduced. This patch uses an approach similar to what we do on aarch64, but only partially since Neon i

[PATCH] arm_neon.h: remove useless push/pop pragmas

2025-05-26 Thread Christophe Lyon
Remove #pragma GCC target ("arch=armv8.2-a+bf16") and preceding target and is thus useless. gcc/ChangeLog: * config/arm/arm_neon.h: Remove useless push/pop pragmas. --- gcc/config/arm/arm_neon.h | 5 - 1 file changed, 5 deletions(-) diff --git a/gcc/config/arm/arm_neon.h b/gcc/confi

[PATCH] testsuite: arm: add needed -mcpu / -march to arm_crypto_ok

2025-05-26 Thread Christophe Lyon
This effective target implicitly expects -march=armv8-a, otherwise with a toolchain configured for instance with --with-cpu=cortex-m0 --with-float=soft, it fails even when trying -mfpu=crypto-neon-fp-armv8 -mfloat-abi=softfp: arm_neon.h:45:2: error: #error "NEON intrinsics not available with the s

[PATCH] testsuite, arm: factorize arm_v8_neon_ok flags

2025-05-26 Thread Christophe Lyon
Like we do in other effective-targets, add "-mcpu=unset -march=armv8-a" directly when setting et_arm_v8_neon_flags in arm_v8_neon_ok_nocache, to avoid having to add these two flags in all users of arm_v8_neon_ok. This avoids duplication and possible typos. gcc/testsuite/ChangeLog: * lib/t

Re: [PATCH] testsuite: Restore dg-do run on pr116906 and pr78185 tests

2025-05-26 Thread Christophe Lyon
On Mon, 26 May 2025 at 17:14, Christophe Lyon wrote: > > Commit r15-7152-g57b706d141b87c removed > /* { dg-do run { target*-*-linux* *-*-gnu* *-*-uclinux* } } */ > > from these tests, turning them into 'compile' only tests, even when > they could be executed. > >

[PATCH] testsuite: Restore dg-do run on pr116906 and pr78185 tests

2025-05-26 Thread Christophe Lyon
Commit r15-7152-g57b706d141b87c removed /* { dg-do run { target*-*-linux* *-*-gnu* *-*-uclinux* } } */ from these tests, turning them into 'compile' only tests, even when they could be executed. This patch adds /* { dg-do run } */ which is OK since the tests are correctly skipped if needed thank

Re: [PATCH] testsuite: Fix pr101145inf*.c testcases [PR117494]

2025-05-26 Thread Christophe Lyon
,, On Mon, 26 May 2025 at 12:54, Andrew Pinski (QUIC) wrote: > > > -Original Message- > > From: Christophe Lyon > > Sent: Monday, May 26, 2025 3:09 AM > > To: Andrew Pinski (QUIC) > > Cc: gcc-patches@gcc.gnu.org > > Subject: Re: [PATCH]

Re: [PATCH] testsuite: Fix pr101145inf*.c testcases [PR117494]

2025-05-26 Thread Christophe Lyon
Hi Andrew, On Sun, 17 Nov 2024 at 22:49, Andrew Pinski wrote: > > Instead of doing a dg-run with a specific target check for linux. > Use signal as the effective-target since this requires the use > of ALARM signal to do the testing. > Also use check_vect in the main and renames main to main1 to

Re: [PATCH] testsuite: aarch64: arm: Fix -mcpu=unset support in shared effective targets

2025-05-21 Thread Christophe Lyon
On Wed, 21 May 2025 at 10:56, Richard Sandiford wrote: > > Christophe Lyon writes: > > Many tests became unsupported on aarch64 when -mcpu=unset was added to > > several arm_* effective targets, because this flag is only supported > > on arm. > > > > Since the

[PATCH] testsuite: aarch64: arm: Fix -mcpu=unset support in shared effective targets

2025-05-20 Thread Christophe Lyon
Many tests became unsupported on aarch64 when -mcpu=unset was added to several arm_* effective targets, because this flag is only supported on arm. Since these effective targets are used on arm and aarch64, the patch adds -mcpu=unset on arm only, and restores "" on aarch64. This re-enables lots o

Re: [PATCH] [gcc-14] testsuite: Improve check-function-bodies

2025-05-20 Thread Christophe Lyon
On Tue, 20 May 2025 at 06:27, Alexandre Oliva wrote: > > The backport of commit 205515da82a2914d765e74ba73fd2765e1254112 to > gcc-14 as 8b1146fe46e62f8b03bd9ddee48995794e192e82, rewriting > gcc.target/arm/fp16-aapcs-[1234].c into check-function-bodies, requires > the following patch for the one-ch

Re: [PATCH] [testsuite] [arm] adjust fp16-aapcs for gcc-14

2025-05-20 Thread Christophe Lyon
On Tue, 20 May 2025 at 06:30, Alexandre Oliva wrote: > > > (The backport I've only just posted is not enough for the tests to pass; > there's another problem) > > r14-10824 is a backport of r15-4549, that rewrote and extended into > check-function-bodies the save/restore expectations introduced in

Re: [PATCH] testsuite: arm: Fix unsigned-extend-2.c [PR116445]

2025-05-08 Thread Christophe Lyon
Ping? Le ven. 11 avr. 2025, 18:36, Christophe Lyon a écrit : > The test was designed to pass with thumb2, but code generation changed > with the introduction of Low Overhead Loops, so the test can fail if > one overrides the flags when running the testsuite. > > In addition, u

Re: [PATCH] testsuite: g++.dg/cpp2a/decomp2.C requires tls_runtime

2025-05-08 Thread Christophe Lyon
Ping? Le jeu. 17 avr. 2025, 11:21, Christophe Lyon a écrit : > Since this test is a 'dg-do run', it requires tls_runtime rather than > just tls. > > This makes the test UNSUPPORTED on targets such as arm-non-eabi, > instead of FAIL/UNRESOLVED because __aeabi_read_tp is

Re: [PATCH] testsuite: g++.dg/cpp2a/constinit16.C requires tls

2025-05-08 Thread Christophe Lyon
Ping? Le jeu. 17 avr. 2025, 11:21, Christophe Lyon a écrit : > This test is 'dg-do compile', so require tls instead of tls_runtime. > > This enables it on targets such as arm-none-eabi configured with > --enable-threads=no. > > gcc/testsuite/ChangeLog: > >

Re: Adjust 'libgomp.c++/target-exceptions-pr118794-1.C' for 'targetm.arm_eabi_unwinder' [PR118794] (was: [Linaro-TCWG-CI] gcc-15-9463-gaa3e72f9430: 2 regressions on arm)

2025-04-22 Thread Christophe Lyon
Hi! On Tue, 22 Apr 2025 at 13:55, Thomas Schwinge wrote: > > Hi! > > On 2025-04-17T18:15:50+, ci_notify--- via Gcc-regression > wrote: > > Our automatic CI has detected problems related to your patch(es). Please > > find some details below. > > > > In bootstrap_check master-arm-check_boots

[PATCH] testsuite: g++.dg/cpp2a/constinit16.C requires tls

2025-04-17 Thread Christophe Lyon
This test is 'dg-do compile', so require tls instead of tls_runtime. This enables it on targets such as arm-none-eabi configured with --enable-threads=no. gcc/testsuite/ChangeLog: * g++.dg/cpp2a/constinit16.C: Require tls. --- gcc/testsuite/g++.dg/cpp2a/constinit16.C | 2 +- 1 file chan

[PATCH] testsuite: g++.dg/cpp2a/decomp2.C requires tls_runtime

2025-04-17 Thread Christophe Lyon
Since this test is a 'dg-do run', it requires tls_runtime rather than just tls. This makes the test UNSUPPORTED on targets such as arm-non-eabi, instead of FAIL/UNRESOLVED because __aeabi_read_tp is not provided (e.g. when GCC is configured with --enable-threads=no. gcc/testsuite/ChangeLog:

Re: [PATCH] testsuite: Add support for GCOV_UNDER_TEST

2025-04-16 Thread Christophe Lyon
On Wed, 16 Apr 2025 at 16:14, Hans-Peter Nilsson wrote: > > > From: Christophe Lyon > > Date: Wed, 16 Apr 2025 14:41:17 +0200 > > > ping? > > Since you directed it at me and CC:ed the list; in case that > was deliberate: I can only repeat "still ok"

Re: [PATCH] testsuite: Add support for GCOV_UNDER_TEST

2025-04-16 Thread Christophe Lyon
ping? On Thu, 10 Apr 2025 at 15:48, Hans-Peter Nilsson wrote: > > > From: Christophe Lyon > > Date: Thu, 10 Apr 2025 15:38:48 +0200 > > > On Thu, 10 Apr 2025 at 15:29, Hans-Peter Nilsson wrote: > > > > > > > From: Christophe Lyon > > > &

[PATCH] testsuite: arm: Fix unsigned-extend-2.c [PR116445]

2025-04-11 Thread Christophe Lyon
The test was designed to pass with thumb2, but code generation changed with the introduction of Low Overhead Loops, so the test can fail if one overrides the flags when running the testsuite. In addition, useless subtract / extension instructions require -O2 to remove them (-O is not sufficient),

Re: [PATCH] testsuite: arm: rename arm_v8_1_lob_ok into arm_v8_1_lob_hw

2025-04-11 Thread Christophe Lyon
Hi! On Thu, 10 Apr 2025 at 19:13, Richard Earnshaw (lists) wrote: > > On 10/04/2025 14:55, Christophe Lyon wrote: > > All arm effective-targets using check_runtime use the "_hw" or > > "_multilib" suffix, so rename arm_v8_1_lob_ok into arm_v8_1_lob_hw for

Re: [PATCH] testsuite: Add support for GCOV_UNDER_TEST

2025-04-10 Thread Christophe Lyon
On Thu, 10 Apr 2025 at 15:29, Hans-Peter Nilsson wrote: > > > From: Christophe Lyon > > Date: Thu, 10 Apr 2025 15:21:23 +0200 > > Not sure why I'm CC:ed on this one, not being a maintainer > of the testsuite or targets where gcov tests are exercised, Because yo

[PATCH] testsuite: arm: rename arm_v8_1_lob_ok into arm_v8_1_lob_hw

2025-04-10 Thread Christophe Lyon
All arm effective-targets using check_runtime use the "_hw" or "_multilib" suffix, so rename arm_v8_1_lob_ok into arm_v8_1_lob_hw for consistency. gcc/testsuite/ChangeLog * lib/target-supports.exp: Rename arm_v8_1_lob_ok into arm_v8_1_lob_hw. * gcc.target/arm/lob1.c: Likew

Re: [PATCH] testsuite: Add support for GCOV_UNDER_TEST

2025-04-10 Thread Christophe Lyon
ping? On Tue, 1 Apr 2025 at 22:37, Christophe Lyon wrote: > > After commit r15-8947-g8ed2d5d219e999, which added new tests using > gcov, the CI noticed failures because it was calling 'gcov' instead of > $target-gcov. > > This is because the CI scripts override G

Re: [Patch, fortran] PR119460 - gfortran.dg/reduce_1.f90 FAILs

2025-04-07 Thread Christophe Lyon
On Sun, 6 Apr 2025 at 14:39, Paul Richard Thomas wrote: > > Hi All, > > As far as I can tell, the attached patch fixes the problems with the reduce > intrinsic. I would be grateful to the reporters if they would confirm that > this is the case. > > The key to the fix appears in reduce_3.f90, whi

[PATCH] testsuite: arm: Tighten compile options for short-vfp-1.c [PR119556]

2025-04-06 Thread Christophe Lyon
The previous version of this test required arch v6+ (for sxth), and the number of vmov depended on the float-point ABI (where softfp needed more of them to transfer floating-point values to and from general registers). With this patch we require arch v7-a, vfp FPU and -mfloat-abi=hard, we also use

[PATCH 03/10] testsuite: aarch64: restore torture options in bf16_dup.c

2025-04-05 Thread Christophe Lyon
Remove dg-options, so that the test is executed as expected using the options defined by advsimd-intrinsics.exp. (Previously we pretend we do, but in fact all torture options are silently overriden with -O2) We skip it at -O0, because the tested optimizations does not take place at this level.

[PATCH 04/10] testsuite: aarch64: restore torture options in vml[as]_float_not_used.c

2025-04-05 Thread Christophe Lyon
Remove dg-options, so that the test is executed as expected using the options defined by advsimd-intrinsics.exp. gcc/testsuite/ * gcc.target/aarch64/advsimd-intrinsics/vmla_float_not_fused.c: Remove dg-options. * gcc.target/aarch64/advsimd-intrinsics/vmls_float_not_

[PATCH 07/10] testsuite: aarch64: arm: Enable vld1x?.c and vst1x?.c on arm [PR71233]

2025-04-05 Thread Christophe Lyon
r14-7202-gc8ec3e1327cb1e added vld1xN and vst1xN intrinsics and some tests on arm, but didn't enable some existing tests. Since these tests are shared with aarch64, this patch removes the 'dg-skip-if "unimplemented" { arm*-*-* }' directives and relies on the advsimd-intrinsics.exp driver to define

Re: [PATCH] opcodes: fix wrong code in expand_binop_directly [PR117811]

2025-04-05 Thread Christophe Lyon
On Fri, 21 Mar 2025 at 11:39, Richard Biener wrote: > > On Fri, 21 Mar 2025, Richard Earnshaw wrote: > > > If expand_binop_directly fails to add a REG_EQUAL note it tries to > > unwind and restart. But it can unwind too far if expand_binop changed > > some of the operands before calling it. We d

Re: [PATCH 06/10] testsuite: aarch64: arm: Add -mfpu=auto to arm_v8_2a_bf16_neon_ok

2025-04-04 Thread Christophe Lyon
On Fri, 21 Mar 2025 at 11:18, Richard Earnshaw (lists) wrote: > > On 20/03/2025 16:15, Christophe Lyon wrote: > > Depending on if/how the testing flags are overridden, the first value > > we try("") might not do what we want. > > > > For instance, if the

[PATCH] testsuite: arm: Fix dg-final in short-vfp-1.c [PR119556]

2025-04-04 Thread Christophe Lyon
Recent syntactic fixes enabled the test, but the result was failing. It turns out it was missing a space between the register arguments in the scan-assembler-times directives. gcc/testsuite/ChangeLog: PR target/119556 * gcc.target/arm/short-vfp-1.c: Add missing spaces. --- gcc/t

Re: [PATCH 06/10] testsuite: aarch64: arm: Add -mfpu=auto to arm_v8_2a_bf16_neon_ok

2025-04-04 Thread Christophe Lyon
On Fri, 21 Mar 2025 at 16:15, Christophe Lyon wrote: > > On Fri, 21 Mar 2025 at 15:25, Richard Earnshaw (lists) > wrote: > > > > On 21/03/2025 14:05, Christophe Lyon wrote: > > > On Fri, 21 Mar 2025 at 11:18, Richard Earnshaw (lists) > > > wrote: > &

[PATCH] testsuite: Remove guality xfails for aarch64*-*-*

2025-04-02 Thread Christophe Lyon
Since r15-7878-ge1c49f413c8, these tests appear as XPASS on aarch64, so we can remove the xfails introduced by r12-102-gf31ddad8ac8f11. gcc/testsuite/ChangeLog: * gcc.dg/guality/pr90074.c: Remove xfail for aarch64. * gcc.dg/guality/pr90716.c: Likewise. --- gcc/testsuite/gcc.dg/gu

[PATCH] testsuite: Add support for GCOV_UNDER_TEST

2025-04-01 Thread Christophe Lyon
After commit r15-8947-g8ed2d5d219e999, which added new tests using gcov, the CI noticed failures because it was calling 'gcov' instead of $target-gcov. This is because the CI scripts override GXX_UNDER_TEST, but still run the testsuite in-tree, and gcc-transform-out-of-tree only depends on TESTING

Re: [committed] testsuite: Fix up atomic-inst-ldlogic.c

2025-03-30 Thread Christophe Lyon
Le dim. 30 mars 2025, 22:10, Sam James a écrit : > Jakub Jelinek writes: > > > Hi! > > > > r15-8956 changed in the test: > > -/* { dg-final { scan-assembler-times "ldclr\t" 16} */ > > +/* { dg-final { scan-assembler-times "ldclr\t" 16 } */ > > which made it even worse than before, when the direc

[PATCH] testsuite: Add options for float16 for test [PR119133]

2025-03-27 Thread Christophe Lyon
Some targets (like arm) need some flags to enable _Float16 support. gcc/testsuite/ChangeLog: PR target/119133 * gcc.dg/torture/pr119133.c: Add options for float16. --- gcc/testsuite/gcc.dg/torture/pr119133.c | 1 + 1 file changed, 1 insertion(+) diff --git a/gcc/testsuite/gcc.dg

Re: [PATCH 06/10] testsuite: aarch64: arm: Add -mfpu=auto to arm_v8_2a_bf16_neon_ok

2025-03-25 Thread Christophe Lyon
On Mon, 24 Mar 2025 at 16:13, Richard Earnshaw (lists) wrote: > > On 24/03/2025 14:52, Christophe Lyon wrote: > > On Mon, 24 Mar 2025 at 15:13, Richard Earnshaw (lists) > > wrote: > >> > >> On 21/03/2025 17:30, Christophe Lyon wrote: > >>> On Fr

Re: [PATCH 06/10] testsuite: aarch64: arm: Add -mfpu=auto to arm_v8_2a_bf16_neon_ok

2025-03-24 Thread Christophe Lyon
On Mon, 24 Mar 2025 at 15:13, Richard Earnshaw (lists) wrote: > > On 21/03/2025 17:30, Christophe Lyon wrote: > > On Fri, 21 Mar 2025 at 16:51, Richard Earnshaw (lists) > > wrote: > >> > >> On 21/03/2025 15:15, Christophe Lyon wrote: > >>> On Fr

Re: [PATCH 06/10] testsuite: aarch64: arm: Add -mfpu=auto to arm_v8_2a_bf16_neon_ok

2025-03-22 Thread Christophe Lyon
On Fri, 21 Mar 2025 at 18:30, Christophe Lyon wrote: > > On Fri, 21 Mar 2025 at 16:51, Richard Earnshaw (lists) > wrote: > > > > On 21/03/2025 15:15, Christophe Lyon wrote: > > > On Fri, 21 Mar 2025 at 15:25, Richard Earnshaw (lists) > > > wrote: > &

[PATCH 06/10] testsuite: aarch64: arm: Add -mfpu=auto to arm_v8_2a_bf16_neon_ok

2025-03-21 Thread Christophe Lyon
Depending on if/how the testing flags are overridden, the first value we try("") might not do what we want. For instance, if the whole testsuite is executed with (A) -mthumb -march=armv7-m -mtune=cortex-m3 -mfloat-abi=softfp bf16_neon_ok is first compiled with (A) (B) where B = -mcpu=unset -march

Re: [PATCH 06/10] testsuite: aarch64: arm: Add -mfpu=auto to arm_v8_2a_bf16_neon_ok

2025-03-21 Thread Christophe Lyon
On Fri, 21 Mar 2025 at 16:51, Richard Earnshaw (lists) wrote: > > On 21/03/2025 15:15, Christophe Lyon wrote: > > On Fri, 21 Mar 2025 at 15:25, Richard Earnshaw (lists) > > wrote: > >> > >> On 21/03/2025 14:05, Christophe Lyon wrote: > >>> On Fr

Re: [PATCH 06/10] testsuite: aarch64: arm: Add -mfpu=auto to arm_v8_2a_bf16_neon_ok

2025-03-21 Thread Christophe Lyon
On Fri, 21 Mar 2025 at 15:25, Richard Earnshaw (lists) wrote: > > On 21/03/2025 14:05, Christophe Lyon wrote: > > On Fri, 21 Mar 2025 at 11:18, Richard Earnshaw (lists) > > wrote: > >> > >> On 20/03/2025 16:15, Christophe Lyon wrote: > >>> Depe

[PATCH 08/10] testsuite: aarch64: arm: Fix -mcpu=unset support in some effective targets

2025-03-20 Thread Christophe Lyon
Many tests became unsupported on aarch64 when -mcpu=unset was added to arm_v8_2a_fp16_neon_ok and arm_v8_2a_bf16_neon_ok effective targets, because this flag is only supported on arm. Since these effective targets are used on arm and aarch64, the patch adds -mcpu=unset on arm only, and restores ""

[PATCH 10/10] testsuite: aarch64: arm: Fix -mcpu=unset -mfpu=auto support in more effective targets

2025-03-20 Thread Christophe Lyon
Like previous patches, fix the use of -mcpu=unset and -mfpu=auto in several effective target shared between aarch64 and arm. aarch64 does not support these flags, so we use them only on arm. Replace "" with -mfpu=auto in the first flags we try on arm to make sure the intended FPU effect of -march

[PATCH 09/10] testsuite: aarch64: arm: Fix -mfpu=auto support in fp16_neon_ok

2025-03-20 Thread Christophe Lyon
Like a previous patch, replace "" with -mfpu=auto to match the intended effect of -march=armv8.2-a+fp16. No visible change because the effect is masked by other effective targets used in the tests, done for consistency. gcc/testsuite/ * lib/target-supports.exp (check_effec

[PATCH 02/10] testsuite: aarch64: arm: move saturating_arithmetic_autovect tests to simd/

2025-03-20 Thread Christophe Lyon
These tests force dg-options because they rely on -ftree-vectorize and do not make use of torture options, so move them to simd/ where they belong. gcc/testsuite/ * gcc.target/aarch64/advsimd-intrinsics/saturating_arithmetic_autovect.inc: Move to gcc.target/aarch64/simd/.

[PATCH 05/10] testsuite: aarch64: arm: Remove redundant dg-do run in advsimd-intrinsics tests

2025-03-20 Thread Christophe Lyon
Tests under advsimd-intrinsics are controlled by advsimd-intrinsics.exp which computes the adequate dg-do-what depending on the actual target, it should not be redefined in the tests, except when the action can never be 'run'. This currently makes no difference, but it would when we remove dg-skip

[PATCH 01/10] testsuite: arm: remove duplicate -mcpu=unset in arm_v8_1_lob_ok

2025-03-20 Thread Christophe Lyon
This was probably a typo / oversight. gcc/testsuite/ * lib/target-supports.exp (check_effective_target_arm_v8_1_lob_ok): Remove duplicate -mcpu=unset. --- gcc/testsuite/lib/target-supports.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/

[PATCH 00/10] testsuite: aarch64: arm: Fixes in effective-targets

2025-03-20 Thread Christophe Lyon
ally extends testing coverage, especially on aarch64 where many tests had inadvertently become unsupported. Christophe Lyon (10): testsuite: arm: remove duplicate -mcpu=unset in arm_v8_1_lob_ok testsuite: aarch64: arm: move saturating_arithmetic_autovect tests to simd/ testsuite: aarc

Re: [PATCH] contrib/gcc-changelog: Accept only [PRnnnn] in subject

2025-03-15 Thread Christophe Lyon
On Wed, 12 Mar 2025 at 08:05, Richard Biener wrote: > > On Tue, Mar 11, 2025 at 5:58 PM Christophe Lyon > wrote: > > > > In https://gcc.gnu.org/contribute.html#patches we ask to use [PR] > > without the Bugzilla component identifier and with no space between &

Re: [PATCH] aarch64: arm: testsuite: Enable vld1xN and vst1xN tests [PR71233]

2025-03-13 Thread Christophe Lyon
On Tue, 11 Mar 2025 at 17:21, Christophe Lyon wrote: > > r14-7202-gc8ec3e1327cb1e added vld1xN and vst1xN intrinsics and some > tests on arm, but didn't enable some existing tests. > > Since these tests are shared with aarch64, this patch replaces the > 'dg-s

[PATCH] arm: Fix REVERSIBLE_CC_MODE [PR110796...]

2025-03-13 Thread Christophe Lyon
Since we have vcmp and vcmpe instructions (vcmpe raises an "Invalid Operation" exception in presence of a NaN operand), we need to tell the compiler it is not safe to reverse comparisons of floating-point arguments. On armv8-m.main+dsp+fp (cortex-m33): PASS: gcc.dg/torture/builtin-iseqsig-1.c at -

Re: [PATCH] arm: [MVE] Fix predicates for vec_cmp, vec_vcmpu and vcond_mask (PR 115439)

2025-03-11 Thread Christophe Lyon
On Mon, 10 Mar 2025 at 13:00, Richard Earnshaw (lists) wrote: > > On 16/01/2025 14:20, Christophe Lyon wrote: > > When compiling c-c++-common/vector-compare-3.c with > > -march=armv8.1-m.main+mve+fp.dp -mfloat-abi=hard -mfpu=auto > > (which enables MVE), we fail to

[PATCH] contrib/gcc-changelog: Accept only [PRnnnn] in subject

2025-03-11 Thread Christophe Lyon
In https://gcc.gnu.org/contribute.html#patches we ask to use [PR] without the Bugzilla component identifier and with no space between 'PR' and the number, but git_check_commit.py accepts all forms. The patch enforces what we document. Note that this would reject a few of the recent commits.

[PATCH] aarch64: arm: testsuite: Enable vld1xN and vst1xN tests [PR71233]

2025-03-11 Thread Christophe Lyon
r14-7202-gc8ec3e1327cb1e added vld1xN and vst1xN intrinsics and some tests on arm, but didn't enable some existing tests. Since these tests are shared with aarch64, this patch replaces the 'dg-skip-if "unimplemented" { arm*-*-* }' directives with: dg-require-effective-target arm_neon_ok { target a

Re: [COMMITTED] Sanitizer: Mention -g option in documentation [PR56682]

2025-03-10 Thread Christophe Lyon
Hi! On Fri, 7 Mar 2025 at 23:57, Sandra Loosemore wrote: > > gcc/ChangeLog > PR sanitizer/56682 > * doc/invoke.texi (Instrumentation Options): Document that -g > is useful with -fsanitize=thread and -fsanitize=address. > Also mention -fno-omit-frame-pointer per th

Re: [PATCH] arm: testsuite: improve guard checks for arm_neon.h

2025-03-06 Thread Christophe Lyon
On Thu, 6 Mar 2025 at 11:03, Christophe Lyon wrote: > > On Wed, 5 Mar 2025 at 12:59, Richard Earnshaw wrote: > > > > The header file arm_neon.h provides the Advanced SIMD intrinsics that > > are available on armv7 or later A & R profile cores. However, they > >

Re: [PATCH] arm: testsuite: improve guard checks for arm_neon.h

2025-03-06 Thread Christophe Lyon
On Wed, 5 Mar 2025 at 12:59, Richard Earnshaw wrote: > > The header file arm_neon.h provides the Advanced SIMD intrinsics that > are available on armv7 or later A & R profile cores. However, they > are not compatible with M-profile and we also need to ensure that the > FP instructions are enabled

[PATCH] arm: Handle fixed PIC register in require_pic_register (PR target/115485)

2025-03-04 Thread Christophe Lyon
Commit r9-4307-g89d7557202d25a forgot to accept a fixed PIC register when extending the assert in require_pic_register. arm_pic_register can be set explicitly by the user (e.g. -mpic-register=r9) or implicitly as the default value with -fpic/-fPIC/-fPIE and -mno-pic-data-is-text-relative -mlong-ca

Re: [PATCH]AArch64: force operand to fresh register to avoid subreg issues [PR118892]

2025-03-03 Thread Christophe Lyon
On Mon, 3 Mar 2025 at 12:29, Richard Sandiford wrote: > > Tamar Christina writes: > >> -Original Message- > >> From: Richard Sandiford > >> Sent: Monday, March 3, 2025 10:12 AM > >> To: Tamar Christina > >> Cc: gcc-patches@gcc.gnu.org; nd ; Richard Earnshaw > >> ; ktkac...@gcc.gnu.org >

Re: [PATCH] arm: Fix signedness of some vld1q intrinsic parameters for ARM NEON

2025-02-20 Thread Christophe Lyon
Hi, On Thu, 20 Feb 2025 at 15:18, Hannes Braun wrote: > > vld1q_s8_x3, vld1q_s16_x3, vld1q_s8_x4 and vld1q_s16_x4 were expecting > pointers to unsigned integers. These parameters should be pointers to > signed integers. > > gcc/ChangeLog: > > * config/arm/arm_neon.h (vld1q_s8_x3): Use in

Re: [PATCH] arm: Remove inner 'fix:HF/SF/DF' from fixed-point patterns (PR 117712)

2025-02-18 Thread Christophe Lyon
On Tue, 18 Feb 2025 at 13:49, Richard Earnshaw (lists) wrote: > > On 18/02/2025 08:37, Christophe Lyon wrote: > > As discussed in the PR, removing the inner 'fix:HF/SD/DF' fixes the > > problem, like other targets do. > > > > The double-'fix&#x

[PATCH] arm: Remove inner 'fix:HF/SF/DF' from fixed-point patterns (PR 117712)

2025-02-18 Thread Christophe Lyon
As discussed in the PR, removing the inner 'fix:HF/SD/DF' fixes the problem, like other targets do. gcc/ChangeLog: PR rtl-optimization/117712 * config/arm/arm.md (fix_trunchfsi2): Remove inner fix:HF. (fix_trunchfdi2): Likewise. (fix_truncsfsi2): Remove inner fix:S

[PATCH] arm: gimple fold aes[ed] [PR114522]

2025-02-12 Thread Christophe Lyon
Almost a copy/paste from the recent aarch64 version of this patch, this one is a bit more intrusive because it also introduces arm_general_gimple_fold_builtin. With this patch, gcc.target/arm/aes_xor_combine.c scan-assembler-not veor passes again. gcc/ChangeLog: PR target/114522

Re: [PATCH] arm: testsuite: Adapt mve-vabs.c to improved codegen

2025-02-03 Thread Christophe Lyon
On Sun, 2 Feb 2025 at 21:18, Thiago Jung Bauermann wrote: > > Since commit r15-491-gc290e6a0b7a9de this failure happens on on > armv8l-linux-gnueabihf and arm-eabi: > > Running gcc:gcc.target/arm/simd/simd.exp ... > gcc.target/arm/simd/mve-vabs.c: memmove found 0 times > FAIL: gcc.target/arm/simd/

  1   2   3   4   5   6   7   8   9   10   >