Re: [PATCH] wwwdocs: contribute.html: Update consensus on patch content.

2024-05-23 Thread Christophe Lyon
On Mon, 20 May 2024 at 15:23, Nick Clifton wrote: > > Hi Christophe, > > > I have a follow-up one: I think the same applies to binutils, but I > > don't think any maintainer / contributor expressed an opinion, and > > IIUC patch policy for binutils is (lightly) documented at > >

Re: [PATCH] [testsuite] conditionalize dg-additional-sources on target and type

2024-05-23 Thread Christophe Lyon
Hi Alexandre, On Thu, 23 May 2024 at 15:29, Alexandre Oliva wrote: > > On Apr 30, 2024, Christophe Lyon wrote: > > > On Tue, 30 Apr 2024 at 01:31, Alexandre Oliva wrote: > >> >> for gcc/testsuite/ChangeLog > >> >> > >> >>

Re: [COMMITTED] Regenerate cygming.opt.urls and mingw.opt.urls

2024-05-12 Thread Christophe Lyon
Thank you Mark and sorry for missing this during the reviews. Christophe Le dim. 12 mai 2024, 14:54, Mark Wielaard a écrit : > The new cygming.opt.urls and mingw.opt.urls in the > gcc/config/mingw/cygming.opt.urls directory need to generated by make > regenerate-opt-urls in the gcc

[PATCH v2] arm: [MVE intrinsics] Fix support for predicate constants [PR target/114801]

2024-05-07 Thread Christophe Lyon
are interpreted byte-by-byte at instruction level, see https://developer.arm.com/documentation/101028/0012/14--M-profile-Vector-Extension--MVE--intrinsics. This is a workaround until we change such predicates representation to V16BImode. 2024-05-06 Christophe Lyon Jakub Jelinek PR

Re: [PATCH v3 00/12] Add aarch64-w64-mingw32 target

2024-05-07 Thread Christophe Lyon
Hi, I've just pushed this patch series, congratulations! Thanks, Christophe On Thu, 11 Apr 2024 at 15:40, Evgeny Karpov wrote: > > Hello, > > Thank you for reviewing v2! > v3 addresses all comments on v2. > > v3 Changes: > - Exclude the aarch64_calling_abi declaration from the patch series.

Re: [PATCH] libgm2: re-generate with autoreconf

2024-05-02 Thread Christophe Lyon
On Thu, 2 May 2024 at 15:47, Gaius Mulley wrote: > > Simon Marchi writes: > > > > > I don't have access to the gcc repo, so could you please push the patch > > on my behalf? > > all done - many thanks for the patch! > Great, I think we now have to update autoregen.py on the buildbot so that it

Re: [PATCH] libgfortran: Fix up the autoreconf warnings.

2024-05-02 Thread Christophe Lyon
On Thu, 2 May 2024 at 23:13, FX Coudert wrote: > > > libgfortran/ChangeLog: > > * Makefile.am: Use sub-dirs, amend recipies accordingly. > > * Makefile.in: Regenerate. > > Thanks Iain, I’ve tested it both with and without maintainer mode, and > regenerated files with no issue. I can also confirm

Re: [PATCH] fixincludes: add AC_CONFIG_MACRO_DIRS to configure.ac

2024-05-02 Thread Christophe Lyon
On Tue, 30 Apr 2024 at 17:47, Simon Marchi wrote: > > On 4/30/24 4:54 AM, Christophe Lyon wrote: > > On Tue, 30 Apr 2024 at 04:25, Simon Marchi wrote: > >> > >> Add an "AC_CONFIG_MACRO_DIRS" call in configure.ac, with the same > >> directories

Re: [PATCH] decay vect tests from run to link for pr95401

2024-04-30 Thread Christophe Lyon
Hi Alexandre, On Tue, 30 Apr 2024 at 01:31, Alexandre Oliva wrote: > > On Apr 22, 2024, Richard Biener wrote: > > >> Regstrapped on x86_64-linux-gnu and ppc64el-linux-gnu. Also tested with > >> gcc-13 on ppc64-vx7r2 and ppc-vx7r2. Ok to install? > > > That makes sense. OK > > >> for

Re: [PATCH] fixincludes: add AC_CONFIG_MACRO_DIRS to configure.ac

2024-04-30 Thread Christophe Lyon
On Tue, 30 Apr 2024 at 04:25, Simon Marchi wrote: > > Add an "AC_CONFIG_MACRO_DIRS" call in configure.ac, with the same > directories as specified in "ACLOCAL_AMFLAGS", in Makefile.in. > > This makes it possible to re-generate aclocal.m4 using "autoreconf". Thanks, this LGTM, although like in

Re: [PATCH] libgm2: re-generate with autoreconf

2024-04-30 Thread Christophe Lyon
On Tue, 30 Apr 2024 at 04:01, Simon Marchi wrote: > > I get a diff when running "autoreconf" in this directory. I think that > the current state is erroneous: it appears to have been generated using > > aclocal -I ../config -I .. > > even though configure.ac and Makefile.am list the include

Re: [PATCH] arm: [MVE intrinsics] Fix support for predicate constants [PR target/114801]

2024-04-29 Thread Christophe Lyon
On Mon, 29 Apr 2024 at 15:29, Jakub Jelinek wrote: > > On Fri, Apr 26, 2024 at 11:10:12PM +, Christophe Lyon wrote: > > --- /dev/null > > +++ b/gcc/testsuite/gcc.target/arm/mve/pr114801.c > > @@ -0,0 +1,36 @@ > > +/* { dg-do compile } */ > > +/* { dg-requi

Re: [PATCH] rust: Add rust.install-dvi and rust.install-html rules

2024-04-29 Thread Christophe Lyon
d, as soon as > trunk reopens fully for 15.1. > Thanks! Note that I already pushed the patch as r14-9865-g73fb0a6153f478 so you may have conflicts (easy to fix ;-) ) Christophe > Best, > > Arthur > > On 4/4/24 18:27, Christophe Lyon wrote: > > rust has the (empty) rust.d

[PATCH] arm: [MVE intrinsics] Fix support for predicate constants [PR target/114801]

2024-04-26 Thread Christophe Lyon
In this PR, we have to handle a case where MVE predicates are supplied as a const_int, where individual predicates have illegal boolean values (such as 0xc for a 4-bit boolean predicate). To avoid the ICE, we canonicalize them, replacing a non-null value with -1. 2024-04-26 Christophe Lyon

Re: [PATCH] wwwdocs: contribute.html: Update consensus on patch content.

2024-04-26 Thread Christophe Lyon
On Fri, 26 Apr 2024 at 10:25, Christophe Lyon wrote: > > On Thu, 25 Apr 2024 at 17:44, Carlos O'Donell wrote: > > > > Discussion is here: > > https://inbox.sourceware.org/gcc/CAPS5khZeWkAD=v8ka9g5eecdnk3bdhfnzjumpvc+hedmkvj...@mail.gmail.com/ > > > > Rough c

Re: [PATCH] wwwdocs: contribute.html: Update consensus on patch content.

2024-04-26 Thread Christophe Lyon
On Thu, 25 Apr 2024 at 17:44, Carlos O'Donell wrote: > > Discussion is here: > https://inbox.sourceware.org/gcc/CAPS5khZeWkAD=v8ka9g5eecdnk3bdhfnzjumpvc+hedmkvj...@mail.gmail.com/ > > Rough consensus from Jakub Jelinek, Richard Biener and others is > that maintainers are for the change. > > This

Re: [pushed] c++/modules: make bits_in/out move-constructible

2024-04-21 Thread Christophe Lyon
Hi Patrick, On Sat, 13 Apr 2024 at 22:12, Patrick Palka wrote: > > Pushed as obvious after verifying C++11 bootstrap is restored. I guess this also fixes the bootstrap_ubsan breakage on aarch64 reported by Linaro CI? See https://linaro.atlassian.net/browse/GNU-1199 (I think you also received a

Re: [PATCH] contrib: Add autoregen.py

2024-04-19 Thread Christophe Lyon
On Fri, 19 Apr 2024 at 11:03, Christophe Lyon wrote: > > This script is a copy of the current script used by Sourceware's > autoregen buildbots. > > It is intended as a helper to regenerate files managed by autotools > (autoconf, automake, aclocal, ), as well as the topl

[PATCH] contrib: Add autoregen.py

2024-04-19 Thread Christophe Lyon
maintainer-mode, but this is not covered by this script. 2024-04-19 Christophe Lyon contrib/ * autogen.py: New script. --- contrib/autoregen.py | 221 +++ 1 file changed, 221 insertions(+) create mode 100755 contrib/autoregen.py diff

Re: [PATCH] libgcc: Fix up __divmodbitint4 [PR114755]

2024-04-18 Thread Christophe Lyon
On Thu, 18 Apr 2024 at 09:37, Jakub Jelinek wrote: > > Hi! > > The following testcase aborts on aarch64-linux but does not on x86_64-linux. > In both cases there is UB in the __divmodbitint4 implemenetation. > When the divisor is negative with most significant limb (even when partial) > all ones,

[PATCH] libcpp: Regenerate aclocal.m4 and configure [PR 114748]

2024-04-17 Thread Christophe Lyon
As discussed in the PR, aclocal.m4 and configure were incorrectly regenerated at some point. 2024-04-17 Christophe Lyon PR preprocessor/114748 libcpp/ * aclocal.m4: Regenerate. * configure: Regenerate. --- libcpp/aclocal.m4 | 1 + libcpp/configure | 3 +++ 2

Re: [PATCH] [testsuite] Fix pretty printers regexps for GDB output

2024-04-10 Thread Christophe Lyon
ping? On Tue, 6 Feb 2024 at 10:26, Christophe Lyon wrote: > > ping? > > On Thu, 25 Jan 2024 at 16:54, Christophe Lyon > wrote: > > > > On Wed, 24 Jan 2024 at 12:02, Jonathan Wakely wrote: > > > > > > On Wed, 24 Jan 2024 at 10:48, Christophe Lyon

[PATCH] rust: Add rust.install-dvi and rust.install-html rules

2024-04-04 Thread Christophe Lyon
rust has the (empty) rust.dvi and rust.html rules, but lacks the (empty) rust.install-dvi and rust.install-html ones. 2024-04-04 Christophe Lyon gcc/rust/ * Make-lang.in (rust.install-dvi, rust.install-html): New rules. --- gcc/rust/Make-lang.in | 2 ++ 1 file changed, 2

[PATCH] modula2: Add m2.install-dvi in gcc/m2/Make-lang.in

2024-04-04 Thread Christophe Lyon
m2 has a m2.dvi build rule, but lacks the m2.install-dvi one. 2024-04-04 Christophe Lyon gcc/m2/ * Make-lang.in (m2.install-dvi): New rule. --- gcc/m2/Make-lang.in | 12 1 file changed, 12 insertions(+) diff --git a/gcc/m2/Make-lang.in b/gcc/m2/Make-lang.in

[PATCH] go: Add go.install-dvi rule in go/Make-lang.in

2024-04-04 Thread Christophe Lyon
go has a go.dvi build rule, but lacks the go.install-dvi one. 2024-04-04 Christophe Lyon gcc/go/ * Make-lang.in (go.install-dvi): New rule. --- gcc/go/Make-lang.in | 10 ++ 1 file changed, 10 insertions(+) diff --git a/gcc/go/Make-lang.in b/gcc/go/Make-lang.in index

[PATCH 2/2] modula2: Fix m2.install-info in gcc/m2/Make-lang.in

2024-03-29 Thread Christophe Lyon
Fix a few typos: the generated filename is m2.info (not gm2.info, and gm2$(exeext) is a file not a directory (so test -d would always fail). 2024-03-29 Christophe Lyon gcc/m2/ * Make-lang.in (m2.install-info): Fix rule. --- gcc/m2/Make-lang.in | 14 +++--- 1 file

[PATCH 1/2] modula2: Add m2.install-html rule to gcc/m2/Make-lang.in

2024-03-29 Thread Christophe Lyon
This rule was missing, and 'make install-html' was failing. It is copied from the corresponding one in fortran. 2024-03-29 Christophe Lyon gcc/m2/ * Make-lang.in (install-html): New rule. --- gcc/m2/Make-lang.in | 19 +++ 1 file changed, 19 insertions(+) diff

[committed] [aarch64, testsuite]: Fix lrcpc3 testcase

2024-03-29 Thread Christophe Lyon
There was a typo in the testcase, with GCC_CPUINFO pointing to the wrong file. Committed as obvious. 2024-03-29 Christophe Lyon gcc/testsuite/ * gcc.target/aarch64/cpunative/native_cpu_24.c: Fix GCC_CPUINFO. --- gcc/testsuite/gcc.target/aarch64/cpunative/native_cpu_24.c | 2

[PATCH] aarch64: Fix typo in comment about FEATURE_STRING

2024-03-29 Thread Christophe Lyon
Fix the comment to document FEATURE_STRING instead of FEAT_STRING. 2024-03-29 Christophe Lyon gcc/ * config/aarch64/aarch64-option-extensions.def: Fix comment. --- gcc/config/aarch64/aarch64-option-extensions.def | 16 1 file changed, 8 insertions(+), 8

Re: [PATCH] libgcc: arm: fix build for FDPIC target

2024-03-25 Thread Christophe Lyon
Hi, On 3/22/24 21:14, Max Filippov wrote: libgcc/ * unwind-arm-common.inc (__gnu_personality_sigframe_fdpic): Cast last argument of _Unwind_VRS_Set to void *. --- libgcc/unwind-arm-common.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v2 08/13] aarch64: Add Cygwin and MinGW environments for AArch64

2024-03-19 Thread Christophe Lyon
On Mon, 18 Mar 2024 at 22:35, Evgeny Karpov wrote: > > Monday, March 18, 2024 2:27 PM > Christophe Lyon wrote: > > > > +/* Disable SEH and declare the required SEH-related macros that are > > > +still needed for compilation. */ #undef TARGET_SEH #define > > &g

Re: [PATCH v2 00/13] Add aarch64-w64-mingw32 target

2024-03-18 Thread Christophe Lyon
On Thu, 7 Mar 2024 at 21:48, Evgeny Karpov wrote: > > Monday, March 4, 2024 > Evgeny Karpov wrote: > > > > > Changes from v1 to v2: > > Adjust the target name to aarch64-*-mingw* to exclude the big-endian target > > from support. > > Exclude 64-bit ISA. > > Rename enum calling_abi to

Re: [PATCH v2 08/13] aarch64: Add Cygwin and MinGW environments for AArch64

2024-03-18 Thread Christophe Lyon
Hi! On Mon, 4 Mar 2024 at 18:44, Evgeny Karpov wrote: > > From: Zac Walker > Date: Fri, 1 Mar 2024 10:49:28 +0100 > Subject: [PATCH v2 08/13] aarch64: Add Cygwin and MinGW environments for > AArch64 > > Define Cygwin and MinGW environment such as types, SEH definitions, > shared libraries,

[PATCH] arm: [MVE intrinsics] Fix support for loads [PR target/114323]

2024-03-15 Thread Christophe Lyon
t; attribute instead, and solves the problem. 2024-03-15 Christophe Lyon PR target/114323 gcc/ * config/arm/arm-mve-builtins.cc (function_instance::reads_global_state_p): Take CP_READ_MEMORY into account. gcc/testsuite/ * gcc.target/arm/mve/pr114

Re: [PATCH] aarch64: Add +lse128 architectural extension command-line flag

2024-03-15 Thread Christophe Lyon
On Fri, 15 Mar 2024 at 12:15, Victor Do Nascimento wrote: > > Given how, at present, the choice of using LSE128 atomic instructions > by the toolchain is delegated to run-time selection in the form of > Libatomic ifuncs, responsible for querying target support, the > `+lse128' target architecture

Re: [PATCH] c++: Fix ICE due to folding a call to constructor on cdtor_returns_this arches (aka arm32) [PR113083]

2024-02-23 Thread Christophe Lyon
On Fri, 23 Feb 2024 at 10:13, Christophe Lyon wrote: > > On Fri, 23 Feb 2024 at 09:42, Jakub Jelinek wrote: > > > > Hi! > > > > When targetm.cxx.cdtor_returns_this () (aka on arm32 TARGET_AAPCS_BASED) > > constructor is supposed to return this pointer, but

Re: [PATCH] c++: Fix ICE due to folding a call to constructor on cdtor_returns_this arches (aka arm32) [PR113083]

2024-02-23 Thread Christophe Lyon
On Fri, 23 Feb 2024 at 09:42, Jakub Jelinek wrote: > > Hi! > > When targetm.cxx.cdtor_returns_this () (aka on arm32 TARGET_AAPCS_BASED) > constructor is supposed to return this pointer, but when we cp_fold such > a call, we don't take that into account and just INIT_EXPR the object, > so we can

Re: [PATCH] gcc/Makefile.in: Fix install-info target if BUILD_INFO is empty

2024-02-12 Thread Christophe Lyon
On Mon, 12 Feb 2024 at 11:27, Jakub Jelinek wrote: > > On Mon, Feb 12, 2024 at 11:13:49AM +0100, Christophe Lyon wrote: > > On Sun, 11 Feb 2024 at 06:56, Alexandre Oliva wrote: > > > > > > Hello, Christophe, > > > > > > On Feb 10, 2024,

Re: [PATCH] rtl-optimization/113597 - recover base term for argument pointers

2024-02-12 Thread Christophe Lyon
On Mon, 12 Feb 2024 at 09:00, Richard Biener wrote: > > On Sat, Feb 10, 2024 at 10:21 PM Toon Moene wrote: > > > > I managed to try this patch on aarch64-linux-gnu: > > > > This is the test run without your patch: > > > > https://gcc.gnu.org/pipermail/gcc-testresults/2024-February/807637.html >

Re: [PATCH] gcc/Makefile.in: Fix install-info target if BUILD_INFO is empty

2024-02-12 Thread Christophe Lyon
On Sun, 11 Feb 2024 at 06:56, Alexandre Oliva wrote: > > Hello, Christophe, > > On Feb 10, 2024, Christophe Lyon wrote: > > > gcc/ > > * Makefile.in: Add no-info dependency. > > * configure.ac: Set BUILD_INFO=no-info if makeinfo is not > >

Re: [PATCH] gcc/Makefile.in: Fix install-info target if BUILD_INFO is empty

2024-02-10 Thread Christophe Lyon
Hi! On Tue, 6 Feb 2024 at 06:37, Alexandre Oliva wrote: > > Hello, Christophe, > > Thanks for the patch. > > On Feb 5, 2024, Christophe Lyon wrote: > > > In order to save build time, our CI overrides BUILD_INFO="", which > > works when invoking 'm

Re: [PATCH] [testsuite] Fix pretty printers regexps for GDB output

2024-02-06 Thread Christophe Lyon
ping? On Thu, 25 Jan 2024 at 16:54, Christophe Lyon wrote: > > On Wed, 24 Jan 2024 at 12:02, Jonathan Wakely wrote: > > > > On Wed, 24 Jan 2024 at 10:48, Christophe Lyon wrote: > > > > > > GDB emits end of lines as \r\n, we currently match the reverse \n

Re: [PATCH] gcc/configure: Re-introduce INSTALL_INFO

2024-02-05 Thread Christophe Lyon
On Fri, 2 Feb 2024 at 11:40, Christophe Lyon wrote: > > On Fri, 2 Feb 2024 at 11:10, wrote: > > > > On 1 February 2024 18:15:34 CET, Christophe Lyon > > wrote: > > >BUILD_INFO is currently a byproduct of checking makeinfo > > >presence/version.

[PATCH] gcc/Makefile.in: Fix install-info target if BUILD_INFO is empty

2024-02-05 Thread Christophe Lyon
e 'install' depends on 'install-info', which depends on $(DESTDIR)$(infodir)/gccint.info (among others). This patch makes the 'install-info' dependency in 'install' conditioned by BUILD_INFO. 2024-02-05 Christophe Lyon gcc/ * Makefile.in: Use install-info only if BUILD_INFO is

Re: [PATCH] gcc/configure: Re-introduce INSTALL_INFO

2024-02-02 Thread Christophe Lyon
On Fri, 2 Feb 2024 at 11:10, wrote: > > On 1 February 2024 18:15:34 CET, Christophe Lyon > wrote: > >BUILD_INFO is currently a byproduct of checking makeinfo > >presence/version. INSTALL_INFO used to be defined similarly, but was > >re

[PATCH] gcc/configure: Re-introduce INSTALL_INFO

2024-02-01 Thread Christophe Lyon
e 'install' depends on 'install-info', which depends on $(DESTDIR)$(infodir)/gccint.info (among others). This patch replaces the 'install-info' dependency in 'install' with $(INSTALL_INFO), thus enabling to skip this step. 2024-02-01 Christophe Lyon gcc/ * Makefile.in: Add IN

Re: [PATCH] [testsuite] Fix pretty printers regexps for GDB output

2024-01-25 Thread Christophe Lyon
On Wed, 24 Jan 2024 at 12:02, Jonathan Wakely wrote: > > On Wed, 24 Jan 2024 at 10:48, Christophe Lyon wrote: > > > > GDB emits end of lines as \r\n, we currently match the reverse \n\r, > > We currently match [\n\r]+ which should match any of \n, \r, \n\r or \r\n &g

[PATCH] [testsuite] Fix pretty printers regexps for GDB output

2024-01-24 Thread Christophe Lyon
to match the right order implied fixing the second one, to skip the empty lines. Tested on aarch64-linux-gnu. [1] https//github.com/bminor/binutils-gdb/blob/master/gdb/testsuite/README#L269 2024-01-24 Christophe Lyon libstdc++-v3/ * testsuite/lib/gdb-test.exp (gdb-test): Fix regexps

Re: [PATCH] testsuite: Disable test for PR113292 on targets without TLS support

2024-01-19 Thread Christophe Lyon
On Fri, 19 Jan 2024 at 08:41, Nathaniel Shead wrote: > > Tested on x86_64-pc-linux-gnu using a cross-compiler to > arm-unknown-linux-gnueabihf with --enable-threads=0 that the link test > is correctly skipped. OK for trunk? > > -- >8 -- > > This disables the new test added by r14-8168 on machines

[PATCH] Allow overriding EXPECT

2023-12-21 Thread Christophe Lyon
their respective upstream repo, so should not be patched here. [1] https://github.com/bminor/binutils-gdb/blob/master/gdb/testsuite/README#L269 2023-12-21 Christophe Lyon gcc/ * Makefile.in: Allow overriding EXEPCT. libgm2/ * Makefile.am: Allow overriding EXEPCT

Re: [PATCH] testsuite, arm: Fix up pr112337.c test

2023-12-01 Thread Christophe Lyon
On Fri, 1 Dec 2023 at 13:44, Richard Earnshaw (lists) wrote: > > On 01/12/2023 11:28, Saurabh Jha wrote: > > Hey, > > > > I introduced this test "gcc/testsuite/gcc.target/arm/mve/pr112337.c" in > > this commit 2365aae84de030bbb006edac18c9314812fc657b before. This had an > > error which I

[PATCH] testsuite/arm: Fix bfloat16_vector_typecheck_[12].c tests

2023-11-30 Thread Christophe Lyon
error message. 2023-11-30 Christophe Lyon gcc/testsuite/ * gcc.target/arm/bfloat16_vector_typecheck_1.c: Update expected error message. * gcc.target/arm/bfloat16_vector_typecheck_2.c: Likewise. --- gcc/testsuite/gcc.target/arm/bfloat16_vector_typecheck_1.c | 4

Re: [patch] OpenMP: Add -Wopenmp and use it

2023-11-27 Thread Christophe Lyon
On Mon, 27 Nov 2023 at 11:33, Tobias Burnus wrote: > > Hi, > > On 27.11.23 11:20, Christophe Lyon wrote: > > > I think the lack of final '.' in: > > Indeed - but you are lagging a bit behind: > > https://gcc.gnu.org/pipermail/gcc-patches/2023-November/638128.ht

Re: [patch] OpenMP: Add -Wopenmp and use it

2023-11-27 Thread Christophe Lyon
Hi! On Fri, 24 Nov 2023 at 15:08, Jakub Jelinek wrote: > > On Fri, Nov 24, 2023 at 02:51:28PM +0100, Tobias Burnus wrote: > > Following the general trend to add a "[-W...]" to the warning messages > > for both better grouping of the warnings and - more importantly - for > > providing > > a

Re: [PATCH] testsuite, lib: Re-allow mulitple function start labels.

2023-11-23 Thread Christophe Lyon
On Thu, 23 Nov 2023 at 17:35, Iain Sandoe wrote: > > Hi > > > On 23 Nov 2023, at 16:11, Christophe Lyon > > wrote: > > > > Hi Iain, > > > > Thanks for dealing with this :-) > > > > On Thu, 23 Nov 2023 at 10:58, Iain Sandoe wrote: >

Re: [PATCH] testsuite, lib: Re-allow mulitple function start labels.

2023-11-23 Thread Christophe Lyon
Hi Iain, Thanks for dealing with this :-) On Thu, 23 Nov 2023 at 10:58, Iain Sandoe wrote: > > Tested on a cross to armv8l-unknown-linux-gnueabihf where the failing > testcase is restored, and on aarch64-linux-gnu where no change is seen > on the aarch64.exp suite. Also tested on arm64 Darwin

Re: [PATCH 3/6] arm: [MVE intrinsics] Add support for contiguous loads and stores

2023-11-23 Thread Christophe Lyon
Hi! On Thu, 23 Nov 2023 at 14:29, Jan-Benedict Glaw wrote: > > On Thu, 2023-11-16 15:26:14 +, Christophe Lyon > wrote: > > diff --git a/gcc/config/arm/arm-mve-builtins-functions.h > > b/gcc/config/arm/arm-mve-builtins-functions.h > > index eba1f071af0..6d234

[PATCH] arm: [MVE intrinsics] Add default clause to full_width_access::memory_vector_mode

2023-11-23 Thread Christophe Lyon
My recent commit 0c2037d9d93a8f768cb11698ff794278246bb31f added a switch statement lacking a default clause, leading to warnings or errors when building with --enable-werror-always. Fix by adding an empty default. Committed as obvious. 2023-11-23 Christophe Lyon gcc

Re: [PATCH] testsuite, Darwin: Add support for Mach-O function body scans.

2023-11-23 Thread Christophe Lyon
On Thu, 23 Nov 2023 at 10:09, Iain Sandoe wrote: > > Hi Christophe. > > > On 23 Nov 2023, at 09:02, Christophe Lyon > > wrote: > > > > Hi Iain, > > > > On Mon, 6 Nov 2023 at 11:58, Richard Sandiford > > wrote: > >> > >> Iai

Re: [PATCH] testsuite, Darwin: Add support for Mach-O function body scans.

2023-11-23 Thread Christophe Lyon
Hi Iain, On Mon, 6 Nov 2023 at 11:58, Richard Sandiford wrote: > > Iain Sandoe writes: > > Hi Richard, > > > >> On 5 Nov 2023, at 12:11, Richard Sandiford > >> wrote: > >> > >> Iain Sandoe writes: > > > On 26 Oct 2023, at 21:00, Iain Sandoe wrote: > >>> > > On 26 Oct 2023, at

Re: [PATCH v2] gcov: Fix integer types in gen_counter_update()

2023-11-22 Thread Christophe Lyon
Hi, On Tue, 21 Nov 2023 at 12:22, Sebastian Huber wrote: > > On 21.11.23 11:46, Jakub Jelinek wrote: > > On Tue, Nov 21, 2023 at 11:42:06AM +0100, Sebastian Huber wrote: > >> > >> On 21.11.23 11:34, Jakub Jelinek wrote: > --- a/gcc/tree-profile.cc > +++ b/gcc/tree-profile.cc > @@

Re: Fix 'gcc.dg/tree-ssa/return-value-range-1.c' for 'char' defaulting to 'unsigned' (was: Propagate value ranges of return values)

2023-11-22 Thread Christophe Lyon
Hi! On Tue, 21 Nov 2023 at 22:24, Thomas Schwinge wrote: > > Hi! > > On 2023-11-19T16:05:42+0100, Jan Hubicka wrote: > > --- /dev/null > > +++ b/gcc/testsuite/gcc.dg/tree-ssa/return-value-range-1.c > > Pushed to master branch commit a0240662b22312ffb3e3fefb85f258ab0e7010f4 > "Fix

[PATCH] arm: [MVE intrinsics] Fix typo

2023-11-22 Thread Christophe Lyon
In commt 0c2037d9d93a8f768cb11698ff794278246bb31f (Add support for contiguous loads and stores), I added a spurious line which broke bootstrap because of an unused variable error. This patch removes it. Committed as obvious. 2023-11-22 Christophe Lyon gcc/ChangeLog: * config/arm

Re: [PATCH] testsuite: Fix up pr111309-2.c on arm [PR111309]

2023-11-21 Thread Christophe Lyon
On Tue, 21 Nov 2023 at 09:48, Jakub Jelinek wrote: > > Hi! > > ARM defaults to -fshort-enums and the following testcase FAILs there in 2 > lines. The difference is that in C++, E0 has enum E type, which normally > has unsigned int underlying type, so it isn't int nor something that > promotes to

Re: Propagate value ranges of return values

2023-11-21 Thread Christophe Lyon
Hi! On Sun, 19 Nov 2023 at 16:05, Jan Hubicka wrote: > > Hi, > this is updated version which also adds testuiste compensation > I lost earlier while maintaining the patch in my testing tree. > There are quite few testcases that use constant return values to hide > something from optimizer. > >

Re: [committed 03/22] arm: testsuite: avoid hard-float ABI incompatibility with -march

2023-11-20 Thread Christophe Lyon
On Mon, 20 Nov 2023 at 15:39, Richard Earnshaw wrote: > > > > On 20/11/2023 14:24, Christophe Lyon wrote: > > On Mon, 20 Nov 2023 at 14:58, Richard Earnshaw > > wrote: > >> > >> > >> > >> On 20/11/2023 13:36, Christophe Lyon

Re: [committed 03/22] arm: testsuite: avoid hard-float ABI incompatibility with -march

2023-11-20 Thread Christophe Lyon
On Mon, 20 Nov 2023 at 14:58, Richard Earnshaw wrote: > > > > On 20/11/2023 13:36, Christophe Lyon wrote: > > On Mon, 20 Nov 2023 at 13:44, Richard Earnshaw > > wrote: > >> > >> > >> > >> On 20/11/2023 10:23, Christophe Lyon wrote

Re: [committed 03/22] arm: testsuite: avoid hard-float ABI incompatibility with -march

2023-11-20 Thread Christophe Lyon
On Mon, 20 Nov 2023 at 13:44, Richard Earnshaw wrote: > > > > On 20/11/2023 10:23, Christophe Lyon wrote: > > Hi Richard, > > > > On Mon, 13 Nov 2023 at 15:28, Richard Earnshaw wrote: > >> > >> > >> A number of tests in the gcc testsui

Re: [committed 02/22] arm: testsuite: correctly detect hard_float

2023-11-20 Thread Christophe Lyon
Hi Richard, On Mon, 13 Nov 2023 at 15:27, Richard Earnshaw wrote: > > > Add an arm-specific test to check_effective_target_hard_float for > Arm to handle cases where we only have single-precision FP in hardware. > > gcc/testsuite: > > * lib/target-supports.exp

Re: [committed 03/22] arm: testsuite: avoid hard-float ABI incompatibility with -march

2023-11-20 Thread Christophe Lyon
Hi Richard, On Mon, 13 Nov 2023 at 15:28, Richard Earnshaw wrote: > > > A number of tests in the gcc testsuite, especially for arm-specific > targets, add various flags to control the architecture. These run > into problems when the compiler is configured with -mfpu=auto if the > new

Re: [PATCH] Add a REG_P check for inc and dec for Arm MVE

2023-11-20 Thread Christophe Lyon
Hi Saurabh, On Tue, 14 Nov 2023 at 15:51, Kyrylo Tkachov wrote: > > Hi Saurabh, > > > -Original Message- > > From: Saurabh Jha > > Sent: Thursday, November 9, 2023 10:12 AM > > To: gcc-patches@gcc.gnu.org; Richard Earnshaw > > ; Richard Sandiford > > > > Subject: [PATCH] Add a REG_P

Re: [PATCH 5/6] arm: [MVE intrinsics] fix vst1 tests

2023-11-16 Thread Christophe Lyon
On Thu, 16 Nov 2023 at 16:30, Kyrylo Tkachov wrote: > > > > > -Original Message- > > From: Christophe Lyon > > Sent: Thursday, November 16, 2023 3:26 PM > > To: gcc-patches@gcc.gnu.org; Richard Sandiford > > ; Richard Earnshaw > > ; Kyrylo

[PATCH 6/6] arm: [MVE intrinsics] rework vldq1 vst1q

2023-11-16 Thread Christophe Lyon
Implement vld1q, vst1q using the new MVE builtins framework. 2023-11-16 Christophe Lyon gcc/ * config/arm/arm-mve-builtins-base.cc (vld1_impl, vld1q) (vst1_impl, vst1q): New. * config/arm/arm-mve-builtins-base.def (vld1q, vst1q): New. * config/arm/arm

[PATCH 3/6] arm: [MVE intrinsics] Add support for contiguous loads and stores

2023-11-16 Thread Christophe Lyon
as needed. 2023-11-16 Christophe Lyon gcc/ * config/arm/arm-mve-builtins-functions.h (multi_vector_function) (full_width_access): New classes. * config/arm/arm-mve-builtins.cc (find_type_suffix_for_scalar_type, infer_pointer_type

[PATCH 5/6] arm: [MVE intrinsics] fix vst1 tests

2023-11-16 Thread Christophe Lyon
vst1q intrinsics return void, so we should not do 'return vst1q_f16 (base, value);' This was OK so far, but will trigger an error/warning with the new implementation of these intrinsics. This patch just removes the 'return' keyword. 2023-11-16 Christophe Lyon gcc/testsuite

[PATCH 2/6] arm: [MVE intrinsics] Add support for void and load/store pointers as argument types.

2023-11-16 Thread Christophe Lyon
This patch adds support for '_', 'al' and 'as' for void, load pointer and store pointer argument/return value types in intrinsic signatures. It also adds a mew memory_scalar_type() helper to function_instance, which is used by 'al' and 'as'. 2023-11-16 Christophe Lyon gcc

[PATCH 4/6] arm: [MVE intrinsics] add load and store shapes

2023-11-16 Thread Christophe Lyon
This patch adds the load and store shapes descriptions. 2023-11-16 Christophe Lyon gcc/ * config/arm/arm-mve-builtins-shapes.cc (load, store): New. * config/arm/arm-mve-builtins-shapes.h (load, store): New. --- gcc/config/arm/arm-mve-builtins-shapes.cc | 67

[PATCH 1/6] arm: Fix arm_simd_types and MVE scalar_types

2023-11-16 Thread Christophe Lyon
type note: expected 'int *' but argument is of type 'int32_t *' {aka 'long int *'} This patch uses get_typenode_from_name (INT32_TYPE) instead, which defines the types as appropriate for the target/C library. 2023-11-16 Christophe Lyon gcc/ * config/arm/arm-builtins.cc

Re: [committed 01/22] arm: testsuite: correctly detect armv6t2 hardware for acle execution tests

2023-11-14 Thread Christophe Lyon
Hi, On 11/13/23 15:26, Richard Earnshaw wrote: diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp index 1a7bea96c1e..d414cddf4dc 100644 --- a/gcc/testsuite/lib/target-supports.exp +++ b/gcc/testsuite/lib/target-supports.exp @@ -5590,6 +5590,24 @@ proc

Re: [PATCH 5/5] aarch64: Add rsr128 and wsr128 ACLE tests

2023-11-08 Thread Christophe Lyon
On 11/7/23 23:51, Richard Sandiford wrote: Victor Do Nascimento writes: Extend existing unit tests for the ACLE system register manipulation functions to include 128-bit tests. gcc/testsuite/ChangeLog: * gcc/testsuite/gcc.target/aarch64/acle/rwsr.c (get_rsr128): New.

[PATCH] testsuite: Force use of -c when precompiling headers

2023-10-27 Thread Christophe Lyon
, this could be seen as a dejagnu bug: in gcc-dg-test-1 (in gcc-dg.exp), we set compile_type to "precompiled_header", which is not one of the supported values in dejagnu's default_target_compile (in target.exp). 2023-10-27 Christophe Lyon gcc/testsuite/ * lib/dg-pch.exp

Re: [pushed] [RA]: Modify cost calculation for dealing with pseudo equivalences

2023-10-27 Thread Christophe Lyon
On Fri, 27 Oct 2023 at 16:19, Vladimir Makarov wrote: > > > On 10/27/23 09:56, Christophe Lyon wrote: > > Hi Vladimir, > > > > On Thu, 26 Oct 2023 at 16:00, Vladimir Makarov > > wrote: > >> This is the second attempt to improve RA cost calculation for

Re: [pushed] [RA]: Modify cost calculation for dealing with pseudo equivalences

2023-10-27 Thread Christophe Lyon
Hi Vladimir, On Thu, 26 Oct 2023 at 16:00, Vladimir Makarov wrote: > > This is the second attempt to improve RA cost calculation for pseudos > with equivalences. The patch explanation is in the log message. > > The patch was successfully bootstrapped and tested on x86-64, aarch64, > and

Re: [PATCH] libcpp: Improve the diagnostic for poisoned identifiers [PR36887]

2023-10-26 Thread Christophe Lyon
On Thu, 26 Oct 2023 at 19:44, Lewis Hyatt wrote: > > On Thu, Oct 26, 2023 at 12:48 PM Christophe Lyon > wrote: > > > > On Thu, 26 Oct 2023 at 18:18, Lewis Hyatt wrote: > > > > > > On Thu, Oct 26, 2023 at 4:49 AM Christophe Lyon > > > wrote:

Re: [PATCH] libcpp: Improve the diagnostic for poisoned identifiers [PR36887]

2023-10-26 Thread Christophe Lyon
On Thu, 26 Oct 2023 at 18:18, Lewis Hyatt wrote: > > On Thu, Oct 26, 2023 at 4:49 AM Christophe Lyon > wrote: > > We have noticed that the new tests fail on aarch64 with: > > .../aarch64-unknown-linux-gnu/libc/usr/lib/crt1.o: in function `_start': > > .../sysdeps/aarc

Re: [PATCH] libcpp: Improve the diagnostic for poisoned identifiers [PR36887]

2023-10-26 Thread Christophe Lyon
Hi! On Wed, 20 Sept 2023 at 06:12, Lewis Hyatt wrote: > > Hello- > > This patch implements the PR's request to add more information to the > diagnostic issued for using a poisoned identifier. Bootstrapped + regtested > all languages on x86-64 Linux. Does it look OK please? Thanks! > > -Lewis > >

Re: [PATCH] testsuite: Fix gcc.target/arm/mve/mve_vadcq_vsbcq_fpscr_overwrite.c

2023-10-24 Thread Christophe Lyon
Ping? Le lun. 2 oct. 2023, 10:23, Christophe Lyon a écrit : > ping? maybe this counts as obvious? > > > On Thu, 14 Sept 2023 at 11:13, Christophe Lyon > wrote: > >> ping? >> >> On Fri, 8 Sept 2023 at 10:43, Christophe Lyon >> wrote: >> &g

Re: [PATCH 1/2] testsuite: Add and use thread_fence effective-target

2023-10-24 Thread Christophe Lyon
Ping? Le lun. 2 oct. 2023, 10:24, Christophe Lyon a écrit : > ping? > > On Sun, 10 Sept 2023 at 21:31, Christophe Lyon > wrote: > >> Some targets like arm-eabi with newlib and default settings rely on >> __sync_synchronize() to ensure synchronization. N

Re: Ping: [PATCH v2 2/2] testsuite: Replace many dg-require-thread-fence with dg-require-atomic-cmpxchg-word

2023-10-12 Thread Christophe Lyon
LGTM but I'm not a maintainer ;-) On Thu, 12 Oct 2023 at 04:22, Hans-Peter Nilsson wrote: > > Ping. > > > From: Hans-Peter Nilsson > > Date: Wed, 4 Oct 2023 19:08:16 +0200 > > > > s/atomic-exchange/atomic-cmpxchg-word/g. > > Tested as v1. > > > > Ok to commit? > > -- >8 -- > > These tests

Re: Ping: [PATCH v2 1/2] testsuite: Add dg-require-atomic-cmpxchg-word

2023-10-12 Thread Christophe Lyon
LGTM but I'm not a maintainer ;-) On Thu, 12 Oct 2023 at 04:21, Hans-Peter Nilsson wrote: > > Ping. > > > From: Hans-Peter Nilsson > > Date: Wed, 4 Oct 2023 19:04:55 +0200 > > > > > From: Hans-Peter Nilsson > > > Date: Wed, 4 Oct 2023 17:15:28 +0200 > > > > > New version coming up. > > > >

Re: [PATCH] __atomic_test_and_set: Fall back to library, not non-atomic code

2023-10-04 Thread Christophe Lyon
> > > From: Christophe Lyon > > Date: Tue, 3 Oct 2023 18:06:21 +0200 > > > On Tue, 3 Oct 2023 at 17:16, Hans-Peter Nilsson wrote: > > > > > > From: Christophe Lyon > > > > Date: Tue, 3 Oct 2023 15:20:39 +0200 > > > > &

Re: [PATCH] __atomic_test_and_set: Fall back to library, not non-atomic code

2023-10-03 Thread Christophe Lyon
Hi! On Tue, 26 Sept 2023 at 16:34, Hans-Peter Nilsson wrote: > Tested cris-elf, native x86_64-pc-linux-gnu and arm-eabi. > > For arm-eabi, notably lacking any atomic support for the > default multilib, with --target_board=arm-sim it regressed > 29_atomics/atomic_flag/cons/value_init.cc with the

Re: [PATCH 1/2] testsuite: Add and use thread_fence effective-target

2023-10-02 Thread Christophe Lyon
ping? On Sun, 10 Sept 2023 at 21:31, Christophe Lyon wrote: > Some targets like arm-eabi with newlib and default settings rely on > __sync_synchronize() to ensure synchronization. Newlib does not > implement it by default, to make users aware they have to take special > care. &g

Re: [PATCH] testsuite: Fix gcc.target/arm/mve/mve_vadcq_vsbcq_fpscr_overwrite.c

2023-10-02 Thread Christophe Lyon
ping? maybe this counts as obvious? On Thu, 14 Sept 2023 at 11:13, Christophe Lyon wrote: > ping? > > On Fri, 8 Sept 2023 at 10:43, Christophe Lyon > wrote: > >> The test was declaring 'int *carry;' and wrote to '*carry' without >> initializing 'carry' first, lea

Re: [PATCH] testsuite: Fix gcc.target/arm/mve/mve_vadcq_vsbcq_fpscr_overwrite.c

2023-09-14 Thread Christophe Lyon via Gcc-patches
ping? On Fri, 8 Sept 2023 at 10:43, Christophe Lyon wrote: > The test was declaring 'int *carry;' and wrote to '*carry' without > initializing 'carry' first, leading to an attempt to write at address > zero, and a crash. > > Fix by declaring 'int carry;' and passing '' in

Re: [PATCH] libstdc++: Remove some more unconditional uses of atomics

2023-09-14 Thread Christophe Lyon via Gcc-patches
On Thu, 14 Sept 2023 at 11:06, Jonathan Wakely wrote: > On Thu, 14 Sept 2023 at 09:41, Christophe Lyon > wrote: > > > > > > > > On Thu, 14 Sept 2023 at 10:17, Jonathan Wakely > wrote: > >> > >> On Thu, 14 Sept 2023 at 0

[PATCH v2 2/2] libstdc++: Add dg-require-thread-fence in several tests

2023-09-14 Thread Christophe Lyon via Gcc-patches
effective target in the tests that need it, making them UNSUPPORTED instead of FAIL and UNRESOLVED. 2023-09-10 Christophe Lyon libstdc++-v3/ * testsuite/29_atomics/atomic/compare_exchange_padding.cc: Likewise. * testsuite/29_atomics/atomic/cons/value_init.cc: Likewise

Re: [PATCH] libstdc++: Remove some more unconditional uses of atomics

2023-09-14 Thread Christophe Lyon via Gcc-patches
On Thu, 14 Sept 2023 at 10:17, Jonathan Wakely wrote: > On Thu, 14 Sept 2023 at 08:44, Christophe Lyon > wrote: > > > > Hi, > > > > > > On Wed, 13 Sept 2023 at 14:32, Jonathan Wakely > wrote: > >> > >> Tested x86_64-linux and aarch

Re: [PATCH] libstdc++: Remove some more unconditional uses of atomics

2023-09-14 Thread Christophe Lyon via Gcc-patches
Hi, On Wed, 13 Sept 2023 at 14:32, Jonathan Wakely wrote: > Tested x86_64-linux and aarch64-linux. I intend to push this to trunk. > > -- >8 -- > > These atomics cause linker errors on arm4t where __sync_synchronize is > not defined. For single-threaded targets we don't need the atomics. > > I

Re: [PATCH 2/2] libstdc++: Add dg-require-thread-fence in several tests

2023-09-13 Thread Christophe Lyon via Gcc-patches
On Tue, 12 Sept 2023 at 11:07, Jonathan Wakely wrote: > On Tue, 12 Sept 2023 at 08:59, Christophe Lyon > wrote: > > > > > > > > On Mon, 11 Sept 2023 at 18:11, Jonathan Wakely > wrote: > >> > >> On Mon, 11 Sept 2023 at 16:40, Christophe Lyon

  1   2   3   4   5   6   7   8   9   10   >