Bordering on obvious, tested on darwin where the test case fails before (and
now passes).
OK to commit?
FX
0001-Testsuite-fix-contructor-priority-test.patch
Description: Binary data
A rather trivial fix for fprintf() specifier of a HOST_WIDE_INT value.
Tested on aarch64-apple-darwin. OK to commit?
FX
0001-aarch64-fix-format-specifier.patch
Description: Binary data
and libgcc.
Currently regtesting on x86_64 linux and darwin (it was fine before I split up
into three commits, so I’m re-testing to make sure I didn’t screw anything up).
OK to commit?
FX
0001-core-Support-heap-based-trampolines.patch
Description: Binary data
0002-target-Support-heap-based
6 weeks later, I’d like to ask a global maintainer to review this.
The idea was okay’ed previously by Joseph Myers, but he asked for testing of
both the quiet and signalling NaN cases, which is now done.
FX
> Le 6 juin 2023 à 20:15, FX Coudert a écrit :
>
> Hi,
>
> (It
Hi,
> Since this affects the ABI of libgcc I think we don't want that part
> to be user configurable but rather determined by
> some static list of targets that opt-in to this config.
If I do that, do the Linux maintainers want Linux in or out?
> You mention setjmp/longjmp - on darwin and
.
OK to commit?
FX
0001-core-Support-heap-based-trampolines.patch
Description: Binary data
ping**3
>> Le 6 juin 2023 à 20:15, FX Coudert a écrit :
>>
>> Hi,
>>
>> (It took me a while to get back to this.)
>>
>> This is a new and improved version of the patch at
>> https://gcc.gnu.org/pipermail/gcc-patches/2022-October/602
ping**2
> Le 6 juin 2023 à 20:15, FX Coudert a écrit :
>
> Hi,
>
> (It took me a while to get back to this.)
>
> This is a new and improved version of the patch at
> https://gcc.gnu.org/pipermail/gcc-patches/2022-October/602932.html
> It addresses the comment
n the case of both quiet and signaling NaNs, which is now done
> systematically.
>
> Bootstrapped and regtested on x86_64-pc-linux-gnu
> OK to commit?
>
> FX
0001-Add-__builtin_iseqsig.patch
Description: Binary data
“IEEE_SUPPORT_*” functions.
FX
> OK, thanks.
Committed at
https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=ecc96eb5d2a0e5dd93365ef76a58d7f754273934
See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109373
I don’t believe it is widely used, and it was removed from everywhere else in
gcc.
Bootstrapped and regtested on x86_64-pc-linux-gnu.
OK to commit?
FX
0001-libgfortran-remove-support-for-enable-intermodule.patch
Description: Binary data
EFAULT_STK_CLASH_GUARD_SIZE
which I think are because this commit
https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=0a85544e1aaeca41133ecfc438cda913dbc0f122
should have regenerated and committed config.in <http://config.in/>
Christina, can you please have a look?
FX
Given the agreement that the patch is not making things for powerpc worse, and
the review by Steve, I have committed as
https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=17bccd1d2c0fa1f08e0483c8ed841994a95febb0
Best,
FX
one for each ABI. I am sure this was
considered and rejected, do you remember what was the rationale?
Thanks,
FX
to get an OK on the middle-end part first, but I consider the
Fortran part approved.
Thanks,
FX
0001-Add-__builtin_iseqsig.patch
Description: Binary data
0002-Fortran-add-IEEE_QUIET_-and-IEEE_SIGNALING_-comparis.patch
Description: Binary data
Thanks for the frank description, Thomas. To be honest, it reinforces my
feeling from when this was originally proposed and added: why are we doing so
much extra work for a feature that is used by such a tiny fraction of our user
base.
FX
e parameter as X.
As you saw, the module built as part of libgfortran deals with that. In the
longer term, we would need a revamp of those modules to handle everything as
intrinsic modules, which would give us more flexibility, but I never found the
time to do this migration :(
Best,
FX
(),
which I posted for review at:
https://gcc.gnu.org/pipermail/gcc-patches/2023-June/620801.html
Bootstrapped and regtested on x86_64-pc-linux-gnu, OK to commit (once the
middle-end patch is accepted)?
FX
0002-Fortran-add-IEEE_QUIET_-and-IEEE_SIGNALING_-comparis.patch
Description: Binary data
o kind=17 mention in them anywhere.
Actually, where is the kind=17 documented?
FX
is now done systematically.
Bootstrapped and regtested on x86_64-pc-linux-gnu
OK to commit?
FX
0001-Add-__builtin_iseqsig.patch
Description: Binary data
Hi,
This patch adds four IEEE functions from the Fortran 2018 standard:
IEEE_MIN_NUM, IEEE_MAX_NUM, IEEE_MIN_NUM_MAG, and IEEE_MAX_NUM_MAG.
Bootstrapped and regtested on x86_64-pc-linux-gnu, both 32 and 64-bit. OK to
commit?
FX
0001-Fortran-add-Fortran-2018-IEEE_-MIN-MAX-functions.patch
pick it up and finish, otherwise it will have to
wait for the next version.
FX
all for GCC 13.
FX
ping*3
please?
> Le 21 sept. 2022 à 11:40, FX a écrit :
>
> ping*2
>
> <0001-Add-__builtin_iseqsig.patch>
>
>> Le 9 sept. 2022 à 19:55, FX a écrit :
>>
>> ping
>>
>>
>>> Le 1 sept. 2022 à 23:02, FX a écrit :
>>>
&g
ping*2
0001-Add-__builtin_iseqsig.patch
Description: Binary data
> Le 9 sept. 2022 à 19:55, FX a écrit :
>
> ping
>
>
>> Le 1 sept. 2022 à 23:02, FX a écrit :
>>
>> Attached patch adds __builtin_iseqsig() to the middle-end and C family
>> front-en
Follow-up patch, including a test, committed as attached.
FX
0001-Fortran-handle-RADIX-kind-in-IEEE_SET_ROUNDING_MODE.patch
Description: Binary data
I forgot to include the gfortran.map part of the patch, and so the test failed
on platforms that have symbol versioning.
Fix below committed to master.
FX
commit ce8aed75a38b468490ecab4c318e3eb08d468608 (HEAD -> master)
Author: Francois-Xavier Coudert
Date: 2022-09-21 10:04:22 +0
that only radix 2 is supported.
That also makes sense. I’ll propose a patch.
Thanks,
FX
at do you mean by that? The behavior is not unexpected, the value returned by
IEEE_GET_ROUNDING_MODE for RADIX=10 is irrelevant and cannot be used for
anything useful.
FX
Committed as
https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=4637a1d293c978816ad622ba33e3a32a78640edd
FX
> Le 10 sept. 2022 à 12:21, FX a écrit :
>
> ping
> (with fix for the typo Bernhard noticed)
>
> <0001-Fortran-F2018-rounding-modes-changes.patch>
>
>
Hi Mikael,
> Looks good, thanks.
Thank you for your reviews. This patch is committed to trunk:
https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=4637a1d293c978816ad622ba33e3a32a78640edd
FX
nt-end, but it
is a big task.
> Another possibility is mimicking or modifying gfc_resolve_intrinsic, which
> already does a similar job for intrinsic procedures.
That’s probably the best place to put it for now, indeed. Thanks for the advice.
FX
r two instructions only, but that would need a
> new set of functions in all config/fpu-* files.
>
> This was regtested on aarch64-darwin, which does not support underflow modes,
> so I will further test on x86_64-linux when I finish travelling in a couple
> of days.
> OK to co
ping
(with fix for the typo Bernhard noticed)
0001-Fortran-F2018-rounding-modes-changes.patch
Description: Binary data
> Le 31 août 2022 à 20:29, FX a écrit :
>
> This adds new F2018 features, that are not really enabled (because their
> runtime support is optional).
>
&
tches, then intend to document the
current state of things once the dust has settled.
FX
ping
> Le 1 sept. 2022 à 23:02, FX a écrit :
>
> Attached patch adds __builtin_iseqsig() to the middle-end and C family
> front-ends.
> Testing does not currently check whether the signaling part works, because
> with optimisation is actually does not (preexisting comp
k I should introduce it now.
Any hard objection to committing as it is? In the middle term, I intend to
revamp this part anyway, as I said in my previous email.
Thanks,
FX
ow how to handle.
FX
the code, because I wrote the original IEEE
implementation so I know it very well. I believe it would probably be better to
commit this and have it tested on mainline, that wait for too long. I intend to
submit further patches and improvements in this area, once those are merged.
Best,
FX
>
, but that would need a
new set of functions in all config/fpu-* files.
This was regtested on aarch64-darwin, which does not support underflow modes,
so I will further test on x86_64-linux when I finish travelling in a couple of
days.
OK to commit?
FX
0001-Fortran-add-IEEE_MODES_TYPE-IEEE_GET_MODES
-02/msg00105.html
Will replace those abort calls, then.
FX
art from aesthetics I don’t see why.
FX
, both 32- and 64-bit. Depends on a
patch currently under review for the middle-end
(https://gcc.gnu.org/pipermail/gcc-patches/2022-September/600840.html).
OK to commit?
FX
0001-Fortran-add-IEEE_QUIET_-and-IEEE_SIGNALING_-comparis.patch
Description: Binary data
and regtested on x86_64-linux.
OK to commit?
(I’m not very skilled for middle-end hacking, so I’m sure there will be
modifications to make.)
FX
0001-Add-__builtin_iseqsig.patch
Description: Binary data
> + case GFC_FPE_GFC_FPE_AWAY:
>
> typo?
Absolutely. Didn’t break the build because glibc currently doesn’t define
FE_TONEARESTFROMZERO, but it should in the future (when C2x is included).
FX
This adds new F2018 features, that are not really enabled (because their
runtime support is optional).
1. Add the new IEEE_AWAY rounding mode. It is unsupported on all known targets,
but could be supported by glibc and AIX as part of the C2x proposal. Testing
for now is minimal, but once a
- and
64-bit.
OK to commit?
FX
0001-fortran-Add-IEEE_SIGNBIT-and-IEEE_FMA-functions.patch
Description: Binary data
instruction (as expected).
Regression-tested on x86_64-pc-linux-gnu. OK to commit?
FX
0001-fortran-Add-IEEE_SIGNBIT-and-IEEE_FMA-functions.patch
Description: Binary data
library code
for now, but when the patch is committed we can add the removal of IEEE_VALUE
and IEEE_CLASS from the library to this list:
https://gcc.gnu.org/wiki/LibgfortranAbiCleanup
FX
t; + break;
Do we need a default label? It’s not like this is a more likely case than
anything else…
Thanks,
FX
for now
(for ABI compatibility) but can remove them at the next breakage. Is one
planned? Where is this tracked, is it still at
https://gcc.gnu.org/wiki/LibgfortranAbiCleanup or do we have another place
(e.g. in bugzilla)?
Thanks,
FX
is checked by check_effective_target_issignaling in
gcc/testsuite/lib/target-supports.exp, and probes the support for the
issignaling macro in . I think it would make sense to adjust those
tests to run on a wider range of targets, using the new built-in.
FX
nd report both here. This
will help investigate.
Thanks,
FX
signature.asc
Description: Message signed with OpenPGP
> Given that 12 has been branched off, is it OK now to commit this patch?
How does the patch affect the results of “make check-gfortran”? How many tests
that failed or were unsupported pass?
FX
Hi,
> can you check the following patch?
Why restrict it to powerpc-freebsd only, and not all freebsd? Do they differ?
Otherwise it looks ok to me, but probably should be tested on a glibc non-x86
target.
In any case, this will be for the new branch, when stage 1 reopens.
FX
> /usr/include/fenv.h.
I see. Then we probably can use AC_CHECK_FUNCS, or design a specific check, so
that it gives the right value on both glibc and FreeBSD targets.
Could you test something on your end?
FX
tion
8 | extern double b2 __attribute__((alias("a2")));
| ^~
FX
oes the patch affect the results of “make check-gfortran”?
Thanks,
FX
Hi Uroš,
> Please note that check_effective_target_ia32 test tries to compile code that
> uses __i386__ target-dependent preprocessor definition, so it is guaranteed
> to fail on all non-ia32 targets.
Thanks, I didn’t know the difference!
OK to push.
FX
whether the first double is a sNaN or qNaN.
>
> Ok for trunk?
It doesn’t hurt to provide an implementation, in any case. OK to push, and
thanks for the patch.
FX
m hoping my use of macros is enough to make it build on all target, and I’ll
follow the gcc-testresults and other lists to see if there is any trouble. If
you see something (or something is reported), feel free to CC me on it…
FX
> Then it’s OK to commit for me, but you will need approval from release
> managers at this stage.
Hum… I submitted it before stage 4 started, does that count?
FX
code generic, but if you think it’s a problem I can remove that part
and make it error out.
I followed the logic used in glibc to deal with bit layout and endianness, so
it should be safe as currently proposed.
FX
This patch is the third in my “signaling NaN” series. For targets with IEEE
support but without the issignaling macro in libc (i.e., everywhere except
glibc), this allows us to provide a fallback implementation. In order to keep
the code in ieee_helper.c relatively readable, I’ve put that new
allow us to meaningfully pass signaling NaNs in float
and double types, sadly.
FX
Thanks Mikael,
> This looks good to me. Thanks.
Thanks. Pushed:
https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=90045c5df5b3c8853e7740fb72a11aead1c489bb
FX
> Thanks. Just a nit, it is cc1 that reports the warning, not f951.
I confirm the patch fixes the testcase failure. And I fixed the comment in a
follow-up commit.
Thanks!
FX
because I had run “make
install” before the testsuite. The patch I pushed at
https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=6b14100b9504800768da726dcb81f1857db3b493
should fix the failure, then.
FX
(or confirm when the error message is
posted).
FX
test.patch
Description: Binary data
how they did not seem to show up on my test machine. I’m launching a fresh
bootstrap, but it will take a while.
FX
y of evidence saying it’s allowed (just quoting a few, but there
are a lot):
./gfortran.dg/PR94331.f90:! { dg-additional-sources PR94331.c }
./gfortran.dg/global_vars_c_init.f90:! { dg-additional-sources
global_vars_c_init_driver.c }
./gfortran.dg/c_char_tests.f03:! { dg-additional-sources c_char_driver.c }
FX
-trap=invalid is set. It passed before, but only by
accident, because we were not actually generating signaling NaNs. I’m not sure
what is the expected behaviour, but the patch does not affect the real
behaviour.
Bootstrapped and regtested on x86_64-pc-gnu-linux. OK to commit?
FX
0001-Fortran
(not with this patch, but with the next ones) is some
targets have really weird floating-point formats, and I cannot test on all
possible targets. Feel free to poke me on any issue that arises, in ML or in
bugzilla.
Best,
FX
ping
> Le 2 janv. 2022 à 11:50, FX a écrit :
>
> Hi,
>
> This is the first part of a three-patch series to fix PR 82207
> (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82207), making gfortran handle
> signaling NaNs. This part fixes the library code implementing IE
“other
built-ins” doc page to be quite confusing to read:
https://gcc.gnu.org/onlinedocs/gcc/Other-Builtins.html
Thanks!
FX
that don’t have
it.
Bootstrapped and regtested on x86_64-pc-gnu-linux. OK to commit?
FX
0001-Fortran-Allow-IEEE_CLASS-to-identify-signaling-NaNs.patch
Description: Binary data
Hi,
The darwin system headers error out on __FLT_EVAL_METHOD__ == 16, which
occurs when the compiler is called with -mavx512fp16 on i386. Allow this
value to proceed past the check (nothing else depends on it in the
system headers). See https://gcc.gnu.org/pipermail/gcc/2021-December/237972.html
-darwin21 (port
under development).
OK to commit?
FX
0001-Libquadmath-Add-nansq-function.patch
Description: Binary data
Attached patch pushed as cb48166e52c0f159eb80a0666c4847825e294ec0
Confirmed by Dave to make the testcase pass on hppa-unknown-linux-gnu
FX
0001-Fortran-Fix-test-on-targets-without-REAL128.patch
Description: Binary data
part of the library. Thew new values are not used (yet), so it is
currently harmless, but better fix it.
I’ve pushed on master as obvious after testing on x86_64-pc-gnu-linux.
FX
0001-Fortran-keep-values-of-IEEE_CLASS_TYPE-in-sync.patch
Description: Binary data
/bugzilla/show_bug.cgi?id=47334
ChangeLog and patch description amended.
OK to commit?
FX
0001-LTO-Prune-some-warnings-in-the-testsuite.patch
Description: Binary data
, and
bootstrapped the attached patch on x86_64-pc-linux-gnu.
FX
static_assert.diff
Description: Binary data
to commit?
FX
0001-LTO-Prune-some-warnings-in-the-testsuite.patch
Description: Binary data
ses, exercising the passing of
char by value, and as integer, and their interoperability.
It was regtested on x86_64-pc-gnu-linux, on aarch64-apple-darwin (because its
ABI is picky).
OK to commit?
FX
0001-Fortran-Emit-correct-types-for-CHARACTER-C_CHAR-VALU.patch
Description: Binary data
irection of libgfortran's I/O system (which are necessary because of the
rich I/O formatting allowed by the standard).
Best,
FX
but if someone who is already set up to do can fire a
quick regtest, that would be great ;)
FX
someone have access to that?
Once tested on a 32-bit target, OK to commit?
FX
itoa-faster.patch
Description: Binary data
timing.f90
Description: Binary data
.
Bootstrapped and regtested on x86_64-pc-linux-gnu.
OK to commit?
FX
itoa.patch
Description: Binary data
Make < 4. And GCC requires "GNU make version 3.80 (or
later)".
The portable solution is given in the autoconf manual:
https://www.gnu.org/software/autoconf/manual/autoconf-2.69/html_node/Newlines-in-Make-Rules.html
Attached is a patch that fixes it. Tested on x86_64-apple-darwi
Thanks Thomas, pushed as 228173565eafbe34e44c1600c32e32a323eb5aab
228173565eafbe34e44c1600c32e32a323eb5aab.patch
Description: Binary data
Hi Thomas,
> OK, and thanks for the patch!
Thanks for the review, committed a slightly amended patch as
220b9bdfe8faebdd2aea0ab7cea81c162d42d8e0 with underflow control support added.
FX
ieee.patch
Description: Binary data
there is a long double, but
the long double is neither kind 10 neither kind 16. I don’t think there is such
a platform currently (otherwise it wouldn’t have worked).
Best,
FX
> I think such patches are OK under the "trivial and obvious rules”.
Committed as ba64166bf81b6eaa6e12e1aab786f22f6605401f
FX
Hi,
Not sure who can review/approve this patch. These two tests have been failing
on darwin, apparently since they were introduced earlier this year. Mark them
with dg-require-alias.
Tested on aarch64-apple-darwin21.
OK to commit?
FX
alias.patch
Description: Binary data
> Yes, but please put this ^^ explanation into the git commit log, and prepend
> the title line with Darwin:
Thanks, committed.
FX
ng faster integer I/O for
libgfortran at https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98076
Comments are welcome on the proposed design, I think the current proposal is a
low-hanging fruit (not risky, much faster).
Best,
FX
, to retain legibility of the library code.
Bootstrapped and regtested on x86_64-pc-linux-gnu.
OK to commit?
FX
pr95177.patch
Description: Binary data
Patch committed, after changing “call abort” to “stop”.
Thanks for the review.
FX
> OK after fixing the above, and thanks for the patch!
Patch committed, after changing “call abort” to “stop”.
Thanks for the review.
FX
101 - 200 of 596 matches
Mail list logo