Re: PR pretty-print/67567 do not pass NULL as a string

> PING: https://gcc.gnu.org/ml/gcc-patches/2015-09/msg01219.html Given that this comes from submodules, which were recently introduced by Paul, I hoped he could comment. Paul? FX

Re: PR pretty-print/67567 do not pass NULL as a string

t fixed when this is still fresh (submodules were just implemented few weeks ago), then it’s better! If Paul doesn’t reply in 2 days, then OK to commit. FX

[libgfortran,committed] Fix some issues revealed by sanitizer

undefined behavior, I committed the attached patch to trunk to fix them. Regtested on x86_64-apple-darwin15. Issues are latent, so I don’t think a backport is in order. Cheers, FX lib.diff Description: Binary data

Re: [Patch, fortran] PR66993 - Spurious ambiguous symbol error with submodules

> 2015-08-10 Paul Thomas > >PR fortran/66993 >* module.c (read_module): If a symtree exists and the symbol has >been associated in a submodule from a parent (sub)module, attach >the symbol to a 'unique symtree' and the new symbol to the >existing symtree.

Re: [PATCH] fortran/67526 -- fix NULL pointer issue

> 2015-09-09 Steven G. Kargl > > PR fortran/67526 > * gfortran.dg/pr67526.f90: New test. > > 2015-09-09 Steven G. Kargl > > PR fortran/67526 > * expr.c (gfc_check_init_expr): Do not dereference a NULL pointer. OK. Thanks for

Re: [Patch, fortran] Submodules and private entities

meone has new arguments against it”. Also: could you document the module/submodule behavior in the user doc? Thanks, FX

Re: [Patch, fortran] PR66681 - Wrong result in assigning this_image() to a complex coarray

ea in the first place. FX

Re: [PATCH, fortran] PR 53379 Backtrace on error termination

standing how the non-constant filename can give an overflow error. Or maybe the error is wrong, and it’s O_RDONLY | O_BINARY | O_CLOEXEC that have crazy values? This looks like a valid POSIX construct to me. FX

Re: [PATCH, fortran] PR 53379 Backtrace on error termination

r nothing, but libbacktrace is compiled and its headers provided in all cases. Can you please give us something to investigate? Like, the error message you’re seeing. FX

Re: [PATCH, fortran] PR 53379 Backtrace on error termination

libbacktrace patch, you need Ian to approve it, it’s his area. FX

Re: [PATCH, fortran] PR 53379 Backtrace on error termination

> #define _FCLOEXEC 0x0010L > #define O_CLOEXEC _FCLOEXEC /* sets FD_CLOEXEC on open */ That’s weird, and definitely an AIX bug: http://pubs.opengroup.org/onlinepubs/9699919799/functions/open.html How does that even work? open() takes int as second arg. FX

[fortran,committed] Trivial MVBITS cleanup

The attached patch, committed as rev. 227502 after regtesting on x86_64-apple-darwin15, removes an unused simplify function for MVBITS. FX z.diff Description: Binary data

Re: [PATCH, fortran] PR 53379 Backtrace on error termination

’ve just closed PR 63930 as WONTFIX.) Thanks for the patch! FX

Re: [Patch, libfortran] PR 67414 Improve error handling

> Hmm, in that case errnum must be set to 0. What about the attached > patch, which prints the existing message if errnum == 0, and the new > and improved only for errnum > 0? OK. Thanks for the patch. FX

Re: [Patch, libfortran] PR 67414 Improve error handling

mmap", errno); mmapio.c: error_callback (data, "mmap", errno); mmapio.c:error_callback (data, "munmap", errno); posix.c: error_callback (data, "close", errno); read.c: error_callback (data, "lseek", errno); read.c: error_callback (data, "read", errno); FX

[fortran,committed] Don't check for NULL pointers before calling free()

. 227336 after bootstrap and regtesting on x86_64-apple-darwin15. FX free.ChangeLog Description: Binary data free.diff Description: Binary data

Re: [patch,libgfortran] Fix configure test for weakref support

And: very sorry about the breakage. FX

Re: [patch,libgfortran] Fix configure test for weakref support

tached patch to fix it: we retain the old macros for gthr.h’s sake, and use the new one internally. Testsuite clean so far on x86_64-linux. FX z.diff Description: Binary data

[fortran,committed] Simplify code for memory allocation and freeing

, shorter and more unified. Committed as revision 227316, after regtesting on x86_64-pc-linux-gnu. FX x.ChangeLog Description: Binary data x.diff Description: Binary data

Re: [patch, libgfortran] PR67367 Program crashes on READ

Hi Jerry, The patch is OK, but I’m a bit puzzled about what the testcase does. It tests that we can OPEN a directory, but not READ from it? I didn’t know that was expected (to be able to OPEN a directory), and I find it somewhat puzzling. Can you shed light on that? Thanks, FX

[libgfortran,committed] Cleanups

Committed the two attached patches doing some minor cleanup in libgfortran: - removed unused “min” macro in io/unix.c - remove some unused configure checks (functions we check for but don’t use the result) Regtested on x86_64-apple-darwin15, then committed separately. FX z1.diff

Re: [patch,libgfortran] Fix configure test for weakref support

ping**2 Given that it’s a configury-patch, I think what it needs is real exposure on unusual targets more than formal review, so I intend to commit it in 48 hours unless someone objects in the meantime. Then I’ll be around to fix things if some fall apart… FX Le 14 août 2015 à 17:06, FX

[fortran,committed] Emit direct calls to malloc() and free()

regtesting on x86_64-apple-darwin15. I have updated the wiki ABI cleanup page. FX z.diff Description: Binary data

Re: [Patch, fortran] F2008 - implement pointer function assignment

= 1 f(x) = x x = 2 print *, f(x) end touille /tmp $ cat b.f90 integer :: f integer :: x = 1 f(x) = x x = 2 print *, f(x) end touille /tmp $ gfortran a.f90 ./a.out 0 touille /tmp $ gfortran b.f90 ./a.out 2 FX

Re: [patch] Remove unsupported hosts/builds from gcc/config.*

This patch was committed without regenerating gcc/configure. Thanks for spotting that. Committed regenerated gcc/configure as revision 227266. FX

Re: [libgfortran,patch] Remove never-used debugging code

OK. Just checking. Thanks for the code cleanup. Thanks for the review. Committed as rev. 227208. FX

[libgfortran,committed] Fix SHAPE intrinsic with KIND values 1 and 2

descriptor is accessed. But it’s cleaner that way. Committed as revision 227210, after bootstrapping and regtesting on x86_64-apple-darwin15. FX shape.ChangeLog Description: Binary data shape.diff Description: Binary data

Re: [libgfortran,patch] Remove never-used debugging code

Turns out I missed some of the dead code. And I now also fixed comments and some formatting. libgfortran/runtime/environ.c is now much more readable than before. The patch is still a no-op, in terms of user functionality. OK to commit to trunk? FX unusedcode.ChangeLog Description: Binary

Re: [Patch] Add to the libgfortran/newlib bodge to detect ftruncate support in ARM/AArch64/SH

, even though it’s in libgfortran configury, you should decide and commit what’s best. I don’t think we have any newlib expert in the Fortran maintainers. Wait for 48 hours to see if anyone else objects, though. Cheers, FX

[libgfortran,committed] Fix default SIGN mode on preconnected/internal units

to figure out how to test that in the testuite, though.) FX sign.ChangeLog Description: Binary data sign.diff Description: Binary data

Re: [libgfortran,patch] Remove never-used debugging code

t show_string T _gfortrani_show_locus Nope, none of those functions are actually publicly exported. They are not in gfortran.map, being either static, or having _gfortrani_ prefix which means internal libgfortran use. FX

Re: Build break on SPU (and other non-mmap systems?) (Re: [patch,libgfortran,toplevel] Use libbacktrace in libgfortran)

a AC_EGREP_HEADER test, as is currently done for dl_interate_phdr()? FX

Re: Build break on SPU (and other non-mmap systems?) (Re: [patch,libgfortran,toplevel] Use libbacktrace in libgfortran)

I guess we can always just hard-code that SPU does not have mmap, similar to how Solaris is hard-coded to not have dl_iterate_phdr. Would something like the below be OK (if it passes testing)? Looks good to me, though I cannot approve it. FX

[libgfortran,patch] Use type-generic built-ins in float I/O routines

are expanded inline, rather than requiring a function call. Bootstrapped and regtested on x86_64-apple-darwin15. OK to commit to trunk? FX float.ChangeLog Description: Binary data float.diff Description: Binary data

Re: Fix libbacktrace -fPIC breakage from Use libbacktrace in libgfortran

before try to compile with that? FX

Re: Patch for fortran/62536 and fortran/66175

- reformated date and PR entries in ChangeLog Thanks again, FX block.diff Description: Binary data

Re: Fix libbacktrace -fPIC breakage from Use libbacktrace in libgfortran

this time…) That looks better :) But I can’t approve the patch. FX

[libgfortran,patch] Remove never-used debugging code

implemented in gfortran. And show_variables() isn’t very useful. OK to commit to trunk? FX unusedcode.ChangeLog Description: Binary data unusedcode.diff Description: Binary data

Re: [patch,doc] Remove dead/inactive links for GCC binaries

with me :) FX

Re: [patch,libgfortran,toplevel] Use libbacktrace in libgfortran

). In realize this is mostly taste an very subjective, so with this nugget of extra input, I leave the final decision to you: let me know what you think best, between readability and conformance to GDB format. Cheers, FX

Re: [patch,libgfortran] Handle invalid command line in EXECUTE_COMMAND_LINE

10-day *ping* for my 3 Fortran patches: - Handle invalid command line in EXECUTE_COMMAND_LINE (https://gcc.gnu.org/ml/gcc-patches/2015-08/msg00758.html) - Use libbacktrace in libgfortran (https://gcc.gnu.org/ml/gcc-patches/2015-08/msg00762.html) - Fix configure test for weakref support

Re: [patch,libgfortran,toplevel] Use libbacktrace in libgfortran

ABI. */ ; } Please also add a note to the libgfortran ABI cleanup wiki page so we don't forget about it. Done. With these changes, Ok for trunk. Thanks a lot for working on this! Committed as revision 227106 with the changes above. Thanks for reviewing the patch. FX

Re: [patch,libgfortran] Handle invalid command line in EXECUTE_COMMAND_LINE

() is C90: http://clc-wiki.net/wiki/strncat Thus, safe to use, I think. I committed as submitted, as revision 227105. Thanks for the review. FX

[patch,doc] Remove dead/inactive links for GCC binaries

2.95.2 - ftp.thewrittenword.com only offers gcc 4.0.2 Tested with make pdf info html, OK to commit? FX binaries.ChangeLog Description: Binary data binaries.diff Description: Binary data

Re: [patch] Remove unsupported hosts/builds from gcc/config.*

OK Thanks. Committed, along with the additional patch for m68k-hp-hpux*, which I had forgotten (but was deprecated in 2008 along with the others). FX Index: ChangeLog === --- ChangeLog (revision 227077) +++ ChangeLog

[patch] Remove unsupported hosts/builds from gcc/config.*

-*-vsta - powerpc-*-beos* All were deleted as targets in 2008, except for i386-*-vsta which was removed in 2004. OK to commit to trunk? FX config.ChangeLog Description: Binary data config.diff Description: Binary data

Should we remove remnants of UWIN support in gcc/config.* files?

UWIN support was apparently removed from GCC in 2008. Yet some traces can still be found in gcc/config.* files. Attached patch would remove them. OK to commit? FX PS: gcc/config.host and gcc/config.build include some other such targets… without checking them all, I think the following could

Re: Should we remove remnants of UWIN support in gcc/config.* files?

, they are not supported.) FX

Re: [middle-end,patch] Making __builtin_signbit type-generic

, but yes, with the type-generic __builtin_signbit you can revert that patch with no change to the generated code. FX

Re: [middle-end,patch] Making __builtin_signbit type-generic

removed, as revision 226990. Thanks for the review. FX

[middle-end,patch] Making __builtin_signbit type-generic

to expand inline). Tested on x86_64-apple-darwin14, OK to commit? FX gcc/ 2015-08-17 Francois-Xavier Coudert fxcoud...@gcc.gnu.org PR middle-end/36757 * builtins.c (expand_builtin_signbit): Add asserts to make sure we can expand BUILT_IN_SIGNBIT inline. * builtins.def

[fortran,committed] Document behavior of I/O on symbolic links

Committed attached patch as rev. 226923 to document the behavior of gfortran when opening closing symbolic links. Clearing up some of the old libgfortran PRs... FX Index: ChangeLog === --- ChangeLog (revision 226922

[fortran,committed] Make BUILT_IN_SIGNBIT type-generic

libquadmath function call signbitq(). Regtested on x86_64-apple-darwin14, covered by existing testcases in gfortran.dg/ieee/. FX PS: I figured, since few gfortran maintainers appear to be around right now, and I’m probably the one who knows that area best, I’d commit it directly rather than

[fortran,committed] Fix quad-prec NORM2 by creating missing decl for quad-prec BUILT_IN_SQRT

BUILT_IN_SQRT is a bit special in the Fortran front-end, because it’s part of our math built-ins which map one-to-one to Fortran intrinsics (and get special treatment for that), but it is only a built-in we call directly in the front-end when emitting code for NORM2. I didn’t realize this

Re: Add checkpoint to libgomp dg-shouldfail tests (was: [PR testsuite/65205] Fix dg-shouldfail usage in OpenACC libgomp tests)

*, CheCKpOInT + FLUSH OUTPUT_UNIT END I hope this helps, FX

[patch,libgfortran] Handle invalid command line in EXECUTE_COMMAND_LINE

that the shell could not be executed. The attached testcase checks that. Bootstrapped and regtested on x86_64-apple-darwin14. OK to commit to trunk? FX PS: I’ve also taken the opportunity to rework a bit the runtime error message issued when CMDSTAT is not present, to actually include

[patch,libgfortran,toplevel] Use libbacktrace in libgfortran

3. In libgfortran, we remove our own code and substitute calls to libbacktrace Bootstrapped and regtested on x86_64-pc-linux-gnu (which has full libbacktrace support) and x86_64-apple-darwin14 (which has minimal libbacktrace support). OK to commit to trunk? FX -- The fine print

Re: [patch,libgfortran,toplevel] Use libbacktrace in libgfortran

is unreadable for me … Sending again, this time with .txt extension, hoping this makes it go through OK. FX 2015-08-14 Francois-Xavier Coudert fxcoud...@gcc.gnu.org PR libfortran/54572 * Makefile.def: Make libgfortran depend on libbacktrace. * Makefile.in: Regenerate

[patch,libgfortran] Fix configure test for weakref support

as it should, and x86_64-apple-darwin14, where SUPPORTS_WEAKREF gets defined to 0 as it should. Then regtested on both targets. OK to commit to trunk? FX 2015-08-14 Francois-Xavier Coudert fxcoud...@gcc.gnu.org PR libfortran/47571 * acinclude.m4 (LIBGFOR_GTHREAD_WEAK): Remove

[fortran,committed] Restore libgfortran build on mingw32

Attached patch committed as rev. 226750, to restore build on mingw32. We don’t use umask() around mkstemp() on mingw32 because it doesn’t support the interesting permissions (“group” and “others”). FX mingw_umask.diff Description: Binary data mingw_umask.ChangeLog Description: Binary data

Re: [fortran,patch] Extend IEEE support to all real kinds

2015-08-06 Uros Bizjak ubiz...@gmail.com PR fortran/64022 * gfortran.dg/ieee/large_4.f90: New test. Tested on x86_64-linux-gnu {,-m32} and alphaev68-linux-gnu. OK for mainline? OK. Thanks for the patch! FX

Re: [libquadmath, patch] Add logbq() to libquadmath

for the IEEE modules on __float128, and requires logbq(). Bootstrapped and regtested on x86_64-apple-darwin14. OK to commit to trunk? FX logbq.diff Description: Binary data logbq.ChangeLog Description: Binary data

Re: [libquadmath, patch] Add logbq() to libquadmath

In the apparent absence of the libquadmath maintainers, could a global reviewer approve this rather simple patch, please? OK Committed as rev. 226748. Thanks. FX

[fortran,committed] Adjust gfortran --version output

Trivial patch below committed as rev. 226734 to bring the output of “gfortran --version” in line with “gcc --version”. FX Index: ChangeLog === --- ChangeLog (revision 226733) +++ ChangeLog (working copy) @@ -1,3 +1,8 @@ +2015

Re: [fortran,patch] Allow some IEEE functions in constant and specification expressions

to achieve, because identification of the target triplet is not sufficient. We need to test some functions/macros too. FX

Re: [fortran,patch] Extend IEEE support to all real kinds

libquadmath patch :( Sorry, FX

[libgfortran,patch] FPU initialization

Attached patch fixes libgfortran’s FPU initialization by only performing it when the user explicitly asked for it, with option -ffpe-trap. Bootstrapped and regtested on x86_64-apple-darwin14. OK to commit to trunk? FX fpu.ChangeLog Description: Binary data fpu.diff Description: Binary data

Re: [libquadmath, patch] Add logbq() to libquadmath

for __float128. Indeed. I fixed the code, but forgot to commit the testcase. Now done as revision 226665. FX

Re: [fortran,patch] Extend IEEE support to all real kinds

Can you please also introduce tests for ieee exceptions for long double and __float128 types (as is done for real and double in gfortran.dg/ieee/ieee_1.F90) as well as test for supported rounding modes as done for real and double in gfortran.dg/ieee/rounding_1.f90 ? On x86_64, these new

[fortran,patch] Allow some IEEE functions in constant and specification expressions

?) for the future. Bootstrapped and regtested on x86_64-apple-darwin14. OK to commit to trunk? FX ieee.ChangeLog Description: Binary data ieee.diff Description: Binary data

Re: [fortran,patch] Extend IEEE support to all real kinds

FAIL: gfortran.dg/ieee/large_1.f90 -O0 (test for excess errors) Excess errors: large_1.f90:(.text+0x1792): undefined reference to `logbq’ Fixed by the patch there: https://gcc.gnu.org/ml/gcc-patches/2015-08/msg00124.html Waiting for review. FX

Re: [libquadmath, patch] Add logbq() to libquadmath

on gcc-patches. Attached is the full diff, including Makefile.in. FX x.diff Description: Binary data

[libquadmath, patch] Add logbq() to libquadmath

The attached patch adds logbq() to libquadmath, with code lifted from glibc. It is made necessary by an upcoming patch for gfortran, adding full support for the IEEE modules on __float128, and requires logbq(). Bootstrapped and regtested on x86_64-apple-darwin14. OK to commit to trunk? FX

[fortran,patch] Extend IEEE support to all real kinds

exclusively mechanical changes (adding the necessary variants to the interfaces, etc.). Bootstrapped and regtested on x86_64-apple-darwin14 (with associated libquadmath patch: https://gcc.gnu.org/ml/gcc-patches/2015-08/msg00124.html). OK to commit to trunk? FX PS: Once this is in, I intend

Re: Patch for fortran/62536 and fortran/66175

is. FX

Re: Patch for fortran/62536 and fortran/66175

a copyright assignment in place with the FSF? FX

Re: [Bug fortran/52846] [F2008] Support submodules - part 3/3

Why do you initialize a static variable to false? You mean because false is equal to zero and it will be the default initialization anyway? I quite like that the default value is explicit. FX

Re: [PATCH, libgfortran]: Avoid left shift of negative value warning

2015-07-29 Uros Bizjak ubiz...@gmail.com PR libgfortran/66650 * libgfortran.h (GFC_DTYPE_SIZE_MASK): Rewrite to avoid left shift of negative value warning. OK. Thanks for the patch. FX

Re: [PATCH] Fix-up for PR fortran/66724 and fortran/66725

2015-07-16 Steven G. Kargl ka...@gcc.gnu.org * io.c (is_char_type): Call gfc_resolve_expr(). (match_open_element, match_dt_element, match_inquire_element): Fix ASYNCHRONOUS case. OK to commit

Re: [PATCH, fortran] Fix numerous ICEs in IO statements with IOMSG

* gfortran.dg/iomsg_2.f90: New test. OK to commit, thanks! FX

[fortran, patch] Remove libgfortranbegin.a

not indicate any real use in existing build systems, but quite a few cases of people confused by its existence and purpose. I’m saying we get rid of it. Attached patch bootstrapped and tested on x86_64-apple-darwin. OK to commit? FX libgfortranbegin.diff Description: Binary data

Re: [PATCH] PR fortran/66725 -- Fix multiple ICEs

. Thanks! FX

Re: [Patch, fortran] PR52846 - [F2008] Support submodules

submodules)? Cheers, and thanks for this patch! FX

Re: [PATCH, Fortran] fix EQUIVALENCE in MODULE issues

equivalence-objects 2015-06-03 Steven G. Kargl ka...@gcc.gnu.org PR fortran/66377 gfortran.dg/equiv_9.f90: New test. OK. I agree the other test case is not suitable for the testsuite. FX

Re: [PATCH] PR fortran/66380 -- Remove assert() to allow error condition

2015-05-27 Steven G. Kargl ka...@gcc.gnu.org * simplify.c (gfc_simplify_reshape): Convert assert into returning NULL, which triggers an error condition. OK to commit.

Re: [PATCH] fortran/66057 -- detect malformed GENERIC statement

Yes, the patch appears to catch those as well. Then: OK to commit. Thanks! FX

Re: [PATCH] fortran/66045 -- NULL() on RHS of assignment

PR fortran/66045 * expr.c (gfc_check_assign): Check for assignment of NULL() instead of the (intended) pointer assignment. OK

Re: [patch, fortran] fix for PR 60780, PR 40958

, but normal strings.) Russell, you said “tested on x86_64-linux”. Could you explicitly confirm that you have bootstrapped it and regression-tested the full gfortran testsuite ? Cheers, FX

Re: [PATCH] fortran/66043 -- Check for NULL() in STORAGE_SIZE()

(and testcase pattern). FX

Re: [PATCH] fortran/66106 -- Enforce C1202 from F2008

) - Maybe not doing all the tests (those after The following if-statements”) if op == INTRINSIC_NONE, as all the s2 comparisons will be false. - The PR number in the ChangeLog is wrong (both times) With the above fixed, it’s OK. Thanks for taking care of all this! FX

Re: [PATCH] fortran/66043 -- Check for NULL() in STORAGE_SIZE()

condition (here, I guess it’s “undefined pointer”)? Regarding the other example mention in the PR’s comment #2, I guess there’s no requirement for the compiler to diagnose this, is there? FX

Re: [PATCH] fortran/64925 -- fix conflict between names

2015-05-XX Steven G. Kargl ka...@gcc.gnu.org PR fortran/64925 * symbol.c(check_conflict): Check for a conflict between a dummy argument and an internal procedure name. 2015-05-XX Steven G. Kargl ka...@gcc.gnu.org PR fortran/64925 *

Re: [PATCH] fortran/66106 -- Enforce C1202 from F2008

Whoops, sorry about that. As you can see I have small patches sitting in my tree. I tried to untangle the 'svn diff’ Thanks for cleaning and submitting those! I’ll try to review them over the next 2 days, if nobody beats me to it :) FX

Re: [PATCH] fortran/66057 -- detect malformed GENERIC statement

Does it also catch the other cases shown in the PR? Things like: generic :: 2 generic :: 2 = generic :: 1 = x generic :: ? etc. OK if so. If not, maybe it’s worth adding them at the same time? FX

Re: [PATCH] fortran/66039 -- Check for mangled file positioning

2015-05-XX Steven G. Kargl ka...@gcc.gnu.org PR fortran/66039 * io.c (match_filepos): Check for incomplete/mangled REWIND, FLUSH, BACKSPACE, and ENDFILE statements 2015-05-XX Steven G. Kargl ka...@gcc.gnu.org PR fortran/66039 *

Re: [PATCH] fortran/66044 -- Convert ICE into ordinary error

2015-05-XX Steven G. Kargl ka...@gcc.gnu.org PR fortran/66044 * decl.c(gfc_match_entry): Change a gfc_internal_error() into a gfc_error() 2015-05-XX Steven G. Kargl ka...@gcc.gnu.org PR fortran/66044 * gfortran.dg/entry_21.f90: New test. OK

Re: [PATCH] fortran/66040 -- convert internal error into normal error

2015-05-XX Steven G. Kargl ka...@gcc.gnu.org PR fortran/66040 * parse.c(verify_st_order): Replace a gfc_internal_error with your generic gfc_error. 2015-05-XX Steven G. Kargl ka...@gcc.gnu.org PR fortran/66040 * gfortran.dg/misplaced_statement.f90:

Re: [Patch, fortran] PR65024 - [4.9/5 Regression] [OOP] ICE concerning unlimited polymorphic pointer

things and seems safe, so let’s do it. OK to commit. FX

Re: [PATCH, libgfortran] PR 65200 Handle EPERM as EACCES

-dependent value is not a constant, it depends on the file chosen (and its permissions). I believe that’s still within “processor dependent”. And it certainly makes more sense that the other possibilities. Thus, OK to commit. FX

Re: [PATCH, fortran] Add gfc_define_builtin_with_spec

to the codebase. A quick grep through the current front-end and middle-end confirms that. Because it’s not used and not tested, it could bitrot and adds to the maintainance cost. FX

<    1   2   3   4   5   6   >