I just thought about something..
Earlier I said that ALL line_table issues were resolved after this
patch (as it ignores the re-included headers that were guarded, as the
non-pph compiler does naturally).
One problem remains however, I'm pretty sure that re-included
non-pph'ed header's
:
On 11-10-13 17:55 , Gabriel Charette wrote:
I'm not sure exactly how you skip headers already parsed now (we
didn't used to when I wrote this code and that was the only problem
remaining in the line_table (i.e. duplicate entries for guarded
headers in the non-pph compile)), but couldn't you
Just looked at the line_table related sections, but see comments below:
On Tue, Oct 11, 2011 at 4:26 PM, Diego Novillo dnovi...@google.com wrote:
Currently, the consistency check done on pre-processor symbols is
triggering on symbols that are not really problematic (e.g., symbols
used for
More comments to come on [3/3], for now just a single comment below on
this specific patch:
diff --git a/gcc/cp/pph-streamer-in.c b/gcc/cp/pph-streamer-in.c
index 0bd4d64..b267833 100644
--- a/gcc/cp/pph-streamer-in.c
+++ b/gcc/cp/pph-streamer-in.c
@@ -439,7 +439,10 @@ pph_in_cxx_binding_1
Very nice!
I really like where this is heading :)!
I think it would be great to instrument this to know how many times we
need to use a PPH_RECORD_MREF, to avoid trashing the cache (i.e.
potentially there are specific cases where only a small field's value
changes and pickling the entire tree
On Wed, Sep 28, 2011 at 5:31 PM, Diego Novillo dnovi...@google.com wrote:
On Wed, Sep 28, 2011 at 17:23, Gabriel Charette gcharet...@gmail.com wrote:
More comments to come on [3/3], for now just a single comment below on
this specific patch:
diff --git a/gcc/cp/pph-streamer-in.c b/gcc/cp/pph
Oops forgot to reply all the first time...
On Fri, Sep 9, 2011 at 4:54 PM, Diego Novillo dnovi...@google.com wrote:
This was not causing any failures, but it is pretty wasteful to read
the same PPH more than once.
We cannot just skip them, however. We need to read the line table to
properly
Oops forgot to reply all...
On Mon, Sep 12, 2011 at 7:40 AM, Diego Novillo dnovi...@google.com wrote:
This patch removes all the XPASS noise from pph.exp runs by pruning
the output from the base compiles (thanks Ian for the pointer). It
add some comments as well.
Lawrence, I noticed that we
.
There is no implementation change in this patch, every macro used resolves to
what we it replaces, if anything this will make the pph code slightly more
robust to trunk merges.
Tested with boostrap and pph regression testing on x64.
Cheers,
Gab
2011-08-25 Gabriel Charette gch...@google.com
I'm getting the following pph test failure output after this patch
(I'll commit my patch on top of it anyways as I get the same errors
with a clean build and with my patch, which itself had a clean test
output before this recent pull before my commit).
XPASS: g++.dg/pph/x7rtti.cc
-08-24 Gabriel Charette gch...@google.com
* pph-streamer-in.c (ALLOC_AND_REGISTER): Take a pph_pickle_cache*
as a first parameter instead of a pph_stream*.
Update all users.
(ALLOC_AND_REGISTER_ALTERNATE): Likewise.
* pph-streamer.c (pph_cache_insert_at
allowing
us to play tricks later if we need to, i.e. by adding a modified preloaded
structure's reference in the main cache to get the hit we want earlier and
control the result...?)
Tested with bootstrap and pph regression testing.
Cheers,
Gab
2011-08-24 Gabriel Charette gch...@google.com
This memory problem was probably due to the big line_table being created with
the incorrect code before.
This test now passes and this FIXME was irrelevant, removed it.
Trivial patch, already discussed with Diego, committed to pph.
2011-08-23 Gabriel Charette gch...@google.com
* g
regression testing on x64.
Cheers,
Gab
2011-08-22 Gabriel Charette gch...@google.com
* pph-streamer-in.c (pph_loc_offset): Add FIXME to move this variable
to pph_stream.encoder.r
(pph_in_include): New.
(pph_in_line_table_and_includes): Remove LINETAB parameter
is how to handle headers with no .h extensions, will we
ever pph any of those? I currently support them in this patch.
Cheers,
Gab
2011-08-19 Gabriel Charette gch...@google.com
gcc/cp/ChangeLog.pph
* pph-streamer-in.c (pph_in_includes): Remove.
(pph_in_linetable_marker
Tom: ok for trunk?
fortran@: The fortran change just reflects the fix from libcpp,
fortran bootstrap and tests passed.
Thanks,
Gabriel
On Wed, Aug 17, 2011 at 1:04 PM, Dodji Seketeli do...@seketeli.org wrote:
Hello Gabriel,
gch...@google.com (Gabriel Charette) a écrit:
Here is the updated
in p4eabi.cc
It also affects the line number of some expected failures (I think those are
now the correct line numbers for the builtins that we are failing on).
Tested on x64 with bootstrap and pph regression testing.
Cheers,
Gab
2011-08-18 Gabriel Charette gch...@google.com
gcc/cp
definitely map an index to the
post-order traversal of the include tree, but it won't be as fast as a simple
index in a flat vector), I didn't do it for now..
Cheers,
Gab
2011-08-17 Gabriel Charette gch...@google.com
gcc/cp/ChangeLog.pph
* pph-streamer-in.c
Thinking more about this on my way back...
I will only need includes directly included by the current pph, not
the full include tree as I added in version 2 of this patch thinking I
would need it for the line_table...
Can you approve version 1 instead?!
I really like the way this is implemented! In particular having our
own cache is so great!
A few comments inline below.
Cheers,
Gab
On Mon, Aug 15, 2011 at 8:05 PM, Diego Novillo dnovi...@google.com wrote:
This patch finishes the support for external references to symbols in
other PPH files.
patch pending review).
Gab
2011-08-16 Gabriel Charette gch...@google.com
gcc/c-family/ChangeLog.pph
* c-opts.c (c_finish_options): Force BUILTINS_LOCATION for tokens
defined in cpp_init_builtins and c_cpp_builtins.
libcpp/ChangeLog.pph
* init.c
the quality of the pph line_table (closer and closer to the
non-pph line_table, but not perfect yet).
Tested with bootstrap and pph regression testing.
Gab
2011-08-16 Gabriel Charette gch...@google.com
gcc/cp/ChangeLog.pph
* pph-streamer-in.c (pph_read_file_1): Set location
and reads its children...).
I'm working on a better linemap streaming, but I must rely on the list of
includes consisting only of the top-level includes (direct children) for the
current pph.
Committed to pph.
Gab
2011-08-16 Gabriel Charette gch...@google.com
* g++.dg/pph/c0deepincl1.h
...@redhat.com wrote:
Gabriel == Gabriel Charette gch...@google.com writes:
Gabriel Removed LINEMAP_POSITION_FOR_COLUMN, it did the EXACT same
Gabriel thing as linemap_position_for_column, so maintaining both in
Gabriel parallel seems like overkill to me. The only thing I can think
Gabriel of is that it's
On Mon, Aug 15, 2011 at 1:39 PM, Ian Lance Taylor i...@google.com wrote:
Gabriel Charette gch...@google.com writes:
Ian: can you approve the go changes in this patch?
The changes to the Go frontend are fine, but they need to be applied to
the master repository for the Go frontend. I can
Forwarding this patch to pph (which was just committed to trunk in
issue4874043).
Committed to pph branch.
2011-08-11 Gabriel Charette gch...@google.com
libcpp/ChangeLog
* include/line-map.h (LINEMAP_POSITION_FOR_COLUMN): Remove.
Update all users to use
-in already; thus it doesn't show up in this updated patch
obviously.
)
Ok for trunk?
Gabriel
2011-08-15 Gabriel Charette gch...@google.com
gcc/c-family/ChangeLog
* c-opts.c (c_finish_options): Force BUILTINS_LOCATION for tokens
defined in cpp_init_builtins and c_cpp_builtins
On Thu, Aug 11, 2011 at 7:22 AM, Dodji Seketeli do...@seketeli.org wrote:
Hello,
gch...@google.com (Gabriel Charette) a écrit:
diff --git a/gcc/c-family/c-opts.c b/gcc/c-family/c-opts.c
index 3227f7b..1af8e7b 100644
--- a/gcc/c-family/c-opts.c
+++ b/gcc/c-family/c-opts.c
@@ -1306,13
On Thu, Aug 11, 2011 at 12:27 AM, Richard Guenther
richard.guent...@gmail.com wrote:
On Wed, Aug 10, 2011 at 8:22 PM, Gabriel Charette gch...@google.com wrote:
There was a bug where c_finish_options would create some builtins and assign
them source_locations in the linemap other than
On Thu, Aug 11, 2011 at 10:14 AM, Richard Guenther
richard.guent...@gmail.com wrote:
On Thu, Aug 11, 2011 at 6:54 PM, Gabriel Charette gch...@google.com wrote:
On Thu, Aug 11, 2011 at 12:27 AM, Richard Guenther
richard.guent...@gmail.com wrote:
On Wed, Aug 10, 2011 at 8:22 PM, Gabriel Charette
I also removed LINEMAP_POSITION_FOR_COLUMN, it did the EXACT same thing as
linemap_position_for_column, so maintaining both in parallel seems like
overkill to me. The only thing I can think of is that it's more optimal as
it's inlined (but if that's really needed we can always make
++0x tests it seems.
Diego said we don't care about those yet, so I changed my test run to be `make
check-g++ RUNTESTFLAGS=pph.exp` ran from bld/gcc/
Gab
2011-08-10 Gabriel Charette gch...@google.com
* g++.dg/pph/x5dynarray7.h: Remove 2 bogus errors.
* g++.dg/pph/x6dynarray6.h
wrote:
Let me know if my recent push has not solved this problem.
On 8/5/11, Gabriel Charette gch...@google.com wrote:
I now get the following test failure output after pulling this patch
(potentially from the almost concurrent checkin of my linetable
patch?)
I can send you my diff's if you
overkill to me. The only thing I can think of is that it's more optimal as it's
inlined (but if that's really needed we can always make
linemap_position_for_column an inline function).
Gabriel
2011-08-10 Gabriel Charette gch...@google.com
* c-opts.c (c_finish_options): Don't create
Tested with bootstrap and full regression testing on x64.
On Wed, Aug 10, 2011 at 11:22 AM, Gabriel Charette gch...@google.com wrote:
There was a bug where c_finish_options would create some builtins and assign
them source_locations in the linemap other than BUILTINS_LOCATION == 1.
Thus
Gah. I was going to commit this separately but forgot. Sorry about that.
K, why does this fix the test? seems weird that we had an infinite
loop before and changing the flags gets rid of it?
It wasn't an infinite loop but an ICE in the tree caches. The
different options were producing
[+ccoutant]
Added lto streamer hooks to do this, but Cary (ccoutant) was saying he'd
want it directly in lto.
Do we want to apply the changes to libcpp to trunk now or wait??
How urgent is the merge? It wouldn't hurt to run a few more test
cases. I have some hidden in my client
On Fri, Aug 5, 2011 at 10:37 AM, Tom Tromey tro...@redhat.com wrote:
Gabriel == Gabriel Charette gch...@google.com writes:
Gabriel This hack, has described in more details in the email labeled
Gabriel Line 0 Hack??, was now causing problem when serializing the
Gabriel line_table in pph.
I
This is the test I was talking would potentially fail with our current
implementation.
And it does.
It has an assembly difference in the order of the global variables, like we
used to have in simpler tests.
Gab
2011-08-05 Gabriel Charette gch...@google.com
* (x0hardorder1.h): New
to apply the changes to libcpp to trunk now or wait??
Tested with bootstrap and pph regression testing.
Gab
2011-08-04 Gabriel Charette gch...@google.com
* decl.c (finish_function): Remove line 0 hack.
* pph-streamer-in.c (pph_loc_offset): New global variable
remove_useless_stmts_warn_notreached refered to by steven in his
2005 commit has been removed on 2009-10-08 by m...@suse.de according to
ChangeLog-2009.
This patch removes this hack which appears to be no longer necessary.
Tested with a full bootstrap build and regression testing on x64.
Gabriel
2011-08-01 Gabriel
The last_listed field in struct line_maps was never used, removed it.
Gab
2011-07-28 Gabriel Charette gch...@google.com
* libcpp/include/line-map.h (struct line_maps):
Remove unused field last_listed.
diff --git a/libcpp/include/line-map.h b/libcpp/include/line-map.h
index
See comments inline.
+
+/* PPH write/read */
+
+
+/* Emit a tinst_level list TINST to STREAM. */
+
+static void
+pph_out_tinst_level (pph_stream *stream, struct tinst_level *tinst)
+{
+ int count;
+ struct tinst_level *cur;
+
+ /* Count the number of items. */
+ for (cur =
.
Tested with pph regression testing.
Gab
diff --git a/gcc/testsuite/ChangeLog.pph b/gcc/testsuite/ChangeLog.pph
index 7ffeaf2..c90ab86 100644
--- a/gcc/testsuite/ChangeLog.pph
+++ b/gcc/testsuite/ChangeLog.pph
@@ -1,3 +1,10 @@
+2011-07-22 Gabriel Charette gch...@google.com
+
+ * g++.dg/pph
build and pph regression testing.
diff --git a/libcpp/ChangeLog.pph b/libcpp/ChangeLog.pph
index de21994..c0ef9f6 100644
--- a/libcpp/ChangeLog.pph
+++ b/libcpp/ChangeLog.pph
@@ -1,3 +1,7 @@
+2011-07-20 Gabriel Charette gch...@google.com
+
+ * symtab.c (cpp_lt_capture): Filter out builtin
Changed to use new cpp_is_builtin inline function.
Gab
diff --git a/libcpp/ChangeLog.pph b/libcpp/ChangeLog.pph
index de21994..36369a5 100644
--- a/libcpp/ChangeLog.pph
+++ b/libcpp/ChangeLog.pph
@@ -1,3 +1,9 @@
+2011-07-20 Gabriel Charette gch...@google.com
+
+ * include/cpplib.h
On Sat, Jul 16, 2011 at 12:59 AM, Andreas Schwab sch...@linux-m68k.org wrote:
gch...@google.com (Gabriel Charette) writes:
+ set expectedSum [exec tr -d \} [exec cut -f 4 -d\
$xdiff_entry]]
$xdiffentry is set to something like {{pph asm diff 123456}}, so i
need tr and cut
functions
as suggested by Andreas Schwab in issue 4744043 (which was already commited
then).
2011-07-18 Gabriel Charette gch...@google.com
* lib/dg-pph.exp (dg-pph-pos): Output actualSum on unexpected diff.
Use native TCL functions instead of exec calls to tr and cut.
diff --git
On Mon, Jul 18, 2011 at 3:05 PM, Andreas Schwab sch...@linux-m68k.org wrote:
Gabriel Charette gch...@google.com writes:
On Sat, Jul 16, 2011 at 12:59 AM, Andreas Schwab sch...@linux-m68k.org
wrote:
gch...@google.com (Gabriel Charette) writes:
+ set expectedSum [exec tr -d
The issue was that we were compiling the pph with some flags and weren't doing
so in the rest of the compilation (pph and non-pph), resulting in different
outputs.
The fact that pph would let this happen is potentially a problem and I opened a
separate thread Flags and pph... to discuss this.
Nice solution :)! A few things inline below:
+ /* Read and process the symbol table. */
+ pph_in_symtab (stream);
}
Why read the symbol table last? I would expect that we would read this
first, before reading the bindings, then we don't need to change the
actual pph_in_* functions to
2011-07-15 Gabriel Charette gch...@google.com
* g++.dg/pph/c1builtin-integral.cc: Add expected diff checksum.
* g++.dg/pph/c1eabi1.cc: Add expected diff checksum.
* g++.dg/pph/p4eabi1.cc: Add expected diff checksum.
* lib/dg-pph.exp (dg-pph-pos): Expect checksums
Reviewed in person by Lawrence.
Shortened XFAIL message from previous patch.
Also, quick side note, in the first description of this patch I said I used
exec grep, I meant exec diff.
Gab
2011-07-15 Gabriel Charette gch...@google.com
* g++.dg/pph/c1builtin-integral.cc: Add expected
from
pph_register_decls_in_symtab. Update all users.
Do not call nreverse on bl-names and bl-namespaces.
Call pph_register_decl_in_symtab.
(pph_read_file_contents): Register decls in
FILE_STATIC_AGGREGATES.
2011-07-12 Gabriel Charette gch...@google.com
why lto doesn't call lto_output_chain, but simply
lto_output_tree to output the chains for struct/union?
Gab
On Tue, Jul 12, 2011 at 12:21 PM, Diego Novillo dnovi...@google.com wrote:
On Fri, Jul 8, 2011 at 21:20, Gabriel Charette gch...@google.com wrote:
2011-07-08 Gabriel Charette gch
On Tue, Jul 12, 2011 at 3:25 PM, Diego Novillo dnovi...@google.com wrote:
On 11-07-12 16:34 , Gabriel Charette wrote:
We probably want pph_register_decl_in_symtab to be inline as it does
so little now.
It doesn't really matter all that much. Given that it's a static function,
the compiler
On Tue, Jul 12, 2011 at 3:32 PM, Diego Novillo dnovi...@google.com wrote:
On 11-07-12 16:43 , Gabriel Charette wrote:
Even if this doesn't break tests anymore, we probably still want this,
no point adding stuff to the pph image that is not needed...
Actually, the reverse is true. We want
lto_streamer_cache_get
and I'm pretty sure this is the same bug, not a new one introduced by this
patch.
Tested with bootstrap build and pph regression testing.
2011-07-11 Gabriel Charette gch...@google.com
* pph-streamer-in.c (pph_add_bindings_to_namespace): Don't reverse
names
Gabriel Charette gch...@google.com
* pph-streamer-in.c (pph_in_function_decl): Stream in
DECL_CHAIN of FUNCTION_DECL only if it's part of a RECORD_OR_UNION_TYPE
(pph_read_tree): Stream in DECL_CHAIN of VAR_DECL only if it's part
of a RECORD_OR_UNION_TYPE.
* pph
to assert, but
not skip if it's NULL in my opinion.
Tested with bootstrap and pph regression testing.
Gab
2011-07-08 Gabriel Charette gch...@google.com
* gcc/cp/pph-streamer-in.c (pph_add_bindings_to_namespace):
NAMESPACE_LEVEL should never be null for a namespace, removed check
On Tue, Jul 5, 2011 at 9:08 PM, Diego Novillo dnovi...@google.com wrote:
* pph-streamer-in.c (pph_add_bindings_to_namespace):
diff --git a/gcc/cp/pph-streamer-in.c b/gcc/cp/pph-streamer-in.c
index 72536a5..0bab93b 100644
--- a/gcc/cp/pph-streamer-in.c
+++ b/gcc/cp/pph-streamer-in.c
this is not in the front-end
it is not as easy as checking pph_out_file != NULL here.
Gab
diff --git a/gcc/ChangeLog.pph b/gcc/ChangeLog.pph
index b9aeb4d..2776bf0 100644
--- a/gcc/ChangeLog.pph
+++ b/gcc/ChangeLog.pph
@@ -1,3 +1,7 @@
+2011-07-06 Gabriel Charette gch...@google.com
After having a look at how pph.exp works last Friday I think I could
do this myself easily enough.
Or are you still modifying the tests and want me to avoid touching this for now?
Gab
On Fri, Jul 1, 2011 at 5:51 PM, Lawrence Crowl cr...@google.com wrote:
On 7/1/11, Gabriel Charette gch
Hey,
so I really like the new clean testing system, so that we always
quickly see what we fixed/broked with a local change.
One problem now though: `// pph asm xdiff`, only flags for asm diffs,
but those could be different diffs after a change (for the better or
worse) and this won't be caught.
realized I didn't put a comment in the code for that fix, should I add
one?
2011-07-01 Gabriel Charette gch...@google.com
* gcc/cp/pph-streamer-in.c (pph_add_bindings_to_namespace):
Rebuild the varpool for global variables coming in from the pph.
* gcc/testsuite/g++.dg/pph
test (nor does it even change any pph asm (I
diff'ed the old bad assemblies (*.s+pph) with the new ones)).
Tested with bootstrap build and pph regression testing.
2011-06-30 Gabriel Charette gch...@google.com
* Make-lang.in (pph-streamer-out.o): Add dependence on output.h
(pph
).
Gab
On Thu, Jun 30, 2011 at 4:33 PM, Diego Novillo dnovi...@google.com wrote:
On Thu, Jun 30, 2011 at 16:24, Gabriel Charette gch...@google.com wrote:
first/weak_global_object_name are part of the global state.
This seems to be used to produce the assembler names. They are set only once
the
redundant logic.
Tested with bootstrap build and pph regression testing.
2011-06-29 Gabriel Charette gch...@google.com
* pph-streamer.h (struct pph_stream): Fix comment of data_in field.
(pph_out_string_with_length): lto_output_string_with_length now handles
NULL
the keyed_classes tree eventually when working with
multiple pph's.
2011-06-28 Gabriel Charette gch...@google.com
* pph-streamer.c (pph_preload_common_nodes):
Add cp_global_trees[] to cache.
* g++.dg/pph/x1typerefs.cc: Remove xfail.
diff --git a/gcc/cp/pph-streamer.c b/gcc/cp
Couldn't we have headers look for their corresponding .pph file by
default when -fpph-map is on? (especially since pph.map is only
temporary for the implementation phase)
I would see it like this:
if -fpph-map is not NULL:
look for mapping in file
if not found:
look for default mapping
Just wondering why you're naming x finishing by an underscore x_,
this is a valid name, but just thinking it's tricky syntax, does this
test anything more? or is it just a preference for private members?
LGTM
On Mon, Jun 27, 2011 at 9:39 AM, Diego Novillo dnovi...@google.com wrote:
We are very
On Mon, Jun 27, 2011 at 10:06 AM, Diego Novillo dnovi...@google.com wrote:
On Mon, Jun 27, 2011 at 13:01, Gabriel Charette gch...@google.com wrote:
Couldn't we have headers look for their corresponding .pph file by
default when -fpph-map is on? (especially since pph.map is only
temporary
On Mon, Jun 27, 2011 at 10:18 AM, Diego Novillo dnovi...@google.com wrote:
On Mon, Jun 27, 2011 at 13:13, Gabriel Charette gch...@google.com wrote:
On Mon, Jun 27, 2011 at 10:06 AM, Diego Novillo dnovi...@google.com wrote:
On Mon, Jun 27, 2011 at 13:01, Gabriel Charette gch...@google.com wrote
with bootstrap and pph regression testing.
2011-06-27 Gabriel Charette gch...@google.com
* pph-streamer-in.c (pth_get_type_from_index): Moved from pph.c.
(pth_load_number): Moved from pph.c.
(pth_load_token_value): Moved from pph.c.
(pth_load_token): Moved from pph.c
Renamed all functions to reflect pph naming schemes (pph_in/out_*).
Also reordered parameters so that the first parameter is always pph_stream*
Tested with bootstrap and pph regression testing.
2011-06-27 Gabriel Charette gch...@google.com
* pph-streamer-in.c (pph_get_type_from_index
Added myself to write after approval maintainers list.
2011-06-27 Gabriel Charette gch...@google.com
* MAINTAINERS (Write After Approval): Add myself.
diff --git a/MAINTAINERS b/MAINTAINERS
index 9dead4f..f6a768e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -324,6 +324,7 @@ Christian
On Mon, Jun 27, 2011 at 1:40 PM, dnovi...@google.com wrote:
On 2011/06/27 20:33:26, Gabriel Charette wrote:
2011-06-27 Gabriel Charette mailto:gch...@google.com
Remove the 'mailto:' prefix.
Weird, that's not in the actual patch, probably gmail putting it in...
Commited as rev r175568
need
this new test?
This fixes all of the assembly mismatches in c1limits-externalid.cc however!
Tested with bootstrap build and pph regression testing.
2011-06-27 Gabriel Charette gch...@google.com
* pph-streamer-in.c (pph_add_bindings_to_namespace): Reverse names and
namespaces
with it's own break?
2011-06-24 Gabriel Charette gch...@google.com
* gcc/cp/pph-streamer-in.c (pph_read_tree):
Stream in DECL_CHAIN of VAR_DECL.
Stream in DECL_CHAIN of FUNCTION_DECL.
* gcc/cp/pph-streamer-out.c (pph_write_tree):
Stream out DECL_CHAIN
Yes I did fill the form, included you as an approver, haven't heard
back from it yet.
Gab
On Thu, Jun 23, 2011 at 10:23 AM, Diego Novillo dnovi...@google.com wrote:
On Thu, Jun 23, 2011 at 13:21, Diego Novillo dnovi...@google.com wrote:
I've made a couple of minor edits to comments and
The names_size member of cp_binding_level was write only. Removed it.
Seems like it was introduced for java in 2002, but it's not used anywhere
anymore in the code.
Tested with bootstrap and full regression testing.
2011-06-23 Gabriel Charette gch...@google.com
* name-lookup.h
Also:
Tested on x86-64. Ok to commit to trunk?
On Thu, Jun 23, 2011 at 2:32 PM, Gabriel Charette gch...@google.com wrote:
The names_size member of cp_binding_level was write only. Removed it.
Seems like it was introduced for java in 2002, but it's not used anywhere
anymore in the code
which was
to dump the namespace READ in.
This is actually a good thing, because I just realized some of the bindings
are read, but not merged correctly (working on that next), and this exposes
it.
2011-06-22 Gabriel Charette gch...@google.com
* gcc/cp/pph-streamer-in.c
cp/name-lookup.h to the list of dependencies for cp/pph.o
in cp/Make-lang.in.
I simply removed the include, I originally added it because it holds
global_namespace, but it
compiles without it (which I guess is fine if we don't try to stick to include
what you use).
2011-06-22 Gabriel Charette
I've had these two small changes around for a while after making a search and
replace
for extra spaces in my own added code last week.
Tested with bootstrap and pph regression testing, you never know ;)
2011-06-22 Gabriel Charette gch...@google.com
* gcc/cp/pph-streamer-out.c
the ICE... I'll have to re-upload the patch as the script already
submitted the files...)
2011-06-22 Gabriel Charette gch...@google.com
* gcc/cp/name-lookup.h (cp_binding_level): Removed unused
member names_size. Update all users.
diff --git a/gcc/cp/name-lookup.c b/gcc/cp/name
See previous message. This patch only adds the fix to the dg-bogus comment for
the failing pph test.
2011-06-22 Gabriel Charette gch...@google.com
* gcc/cp/name-lookup.h (cp_binding_level): Removed unused
member names_size. Update all users.
diff --git a/gcc/cp/name-lookup.c
And it looks like this wasn't sent to anyone directly...
Adding back dnovillo and crowl (Diego I don't think Jason was ever
added to the original message...?)
Gab
On Wed, Jun 22, 2011 at 5:02 PM, Gabriel Charette gch...@google.com wrote:
See previous message. This patch only adds the fix
testing.
2011-06-21 Gabriel Charette gch...@google.com
* gcc/cp/pph-streamer-in.c (pph_in_tree_vec): Make static.
(pph_add_names_to_namespace): Moved from pph.c.
(wrap_macro_def): Moved from pph.c.
(report_validation_error): Moved from pph.c
and it appears that the compiler
changes it's inlining decisions based on very picky details. In this particular
case, inlining the function resulted in an error.
Tested with bootstrap build and pph regression testing.
2011-06-17 Gabriel Charette gch...@google.com
* gcc/cp/pph-streamer-in.c
There were two pph_start_record functions, one for the in part, one for the out
part. I renamed them to have different names to avoid confusion for the reader
(and it also makes it easier for tags).
2011-06-17 Gabriel Charette gch...@google.com
* gcc/cp/pph-streamer-in.c
writting.
This was tested with a bootstrap build and pph regression testing.
2011-06-14 Gabriel Charette gch...@google.com
* pph-streamer-in.c (pph_in_binding_level): Fix read
of shadowed_labels.
(pph_in_binding_level): Removed *sl.
Index: pph-streamer-in.c
===
--- ChangeLog.pph (revision 174853)
+++ ChangeLog.pph (working copy)
@@ -1,3 +1,8 @@
+2011-06-09 Gabriel Charette gch...@google.com
+
+ * pph-streamer-out.c (pph_out_tree_header): Rename from
+ pph_output_tree_header. Update all users.
+
2011-06-08 Diego
16
# of expected failures46
/usr/local/google/gchare/gcc-clean/bld/gcc/testsuite/g++/../../g++ version
4.7.0-pph 20110606 (experimental) (GCC)
2011-06-07 Gabriel Charette gch...@google.com
* gcc/cp/pph-streamer-in.c (pph_read_tree):
Read TREE_TYPE from
: There might be header files that are now unused due to the code removed.
2011-06-06 Gabriel Charette gch...@google.com
* gcc/c-family/c.opt (fpth): Remove. Update all users.
(fpth-debug): Likewise.
(fpth-stats). Likewise.
(fpth-md5). Likewise.
* gcc/cp/pph.c
(sorry about the triple-posting, just learnt this mailing list
required plain text emails... hopefully, this works now..)
Additional note: The patch was tested with a full bootstrap build and
regression testing (no new bugs introduced).
There might be header files that are now unused due to the
Removed the 3 PPH timevars used in pph instrumentation. Those are not used
anymore following the instrumentation removal patch.
Bootstrap build and regression testing were successful.
2011-06-03 Gabriel Charette gch...@google.com
* timevar.def (TV_PPH_CACHE_IN): Remove
97 matches
Mail list logo
