Re: VEC re-write [patch 01/25]

2012-11-18 Thread Hans-Peter Nilsson
On Sat, 17 Nov 2012, Diego Novillo wrote: I have now committed all 25 parts of this patch as rev 193595. Please CC me on any problems that you think may be related to this rewrite. That seems to have trigged some bug in gcc-4.4-era. See PR55381. There are a lot of suspicious warnings from

Re: VEC re-write [patch 01/25]

2012-11-18 Thread Hans-Peter Nilsson
On Sun, 18 Nov 2012, Diego Novillo wrote: My cris-elf builds worked fine, but config-list.mk only builds stage 1, it does not build libgfortran. Can you give me instructions on how to build your target on my x86 workstation? Better see the PR for cc1 command-line and preprocessed C-file.

Re: VEC re-write [patch 01/25]

2012-11-18 Thread Hans-Peter Nilsson
On Sun, 18 Nov 2012, Andreas Tobler wrote: Is there a minimum gcc to bootstrap current trunk? I currently fail to bootstrap trunk with a 4.2.1 gcc, but a 4.6 succeeds. A gcc-4.1.2 has worked for me in the past, before this recent vec.h change. I think that's the minimum version reportedly

Re: VEC re-write [patch 01/25]

2012-11-18 Thread Hans-Peter Nilsson
On Sun, 18 Nov 2012, Andreas Tobler wrote: On 18.11.12 20:11, Hans-Peter Nilsson wrote: On Sun, 18 Nov 2012, Andreas Tobler wrote: Is there a minimum gcc to bootstrap current trunk? I currently fail to bootstrap trunk with a 4.2.1 gcc, but a 4.6 succeeds. A gcc-4.1.2 has worked

Re: PATCH: Add --with-build-config=bootstrap-asan support

2012-11-18 Thread Hans-Peter Nilsson
On Sun, 18 Nov 2012, Paolo Bonzini wrote: Il 18/11/2012 16:59, Hans-Peter Nilsson ha scritto: Nice, but I agree with the other poster that this'd IMHO be better as --enable-checking=asan (or actually, --enable-checking=all,asan). Yeah, that's a good thing to support too. However, you

Re: [PATCH, generic] New RTL primitive: `define_subst'

2012-11-17 Thread Hans-Peter Nilsson
On Wed, 14 Nov 2012, Jakub Jelinek wrote: Which brings us to the question of what to do with the patch for 4.8. It's true that you made the deadline for stage1 closure. But there will be no users of this feature, so it begs the question of why we should apply it now. Have you a

Re: [COMMITTED] Move libsanitizer configure logic to subdirectory

2012-11-16 Thread Hans-Peter Nilsson
On Tue, 13 Nov 2012, Richard Henderson wrote: As discussed elsewhere. Tested on x86_64-linux. +2012-11-13 Richard Henderson r...@redhat.com + + * configure.ac: Move libsanitizer logic to subdirectory. + * configure: Regenerate. + Thanks and sorry for copypasting the wrong

Re: [Committed] Add testcase

2012-11-15 Thread Hans-Peter Nilsson
On Fri, 9 Nov 2012, Andrew Pinski wrote: Committed the testcase as obvious after a quick test to make sure it works. Note someone might need to mark the testcase as only executable on targets which have 32bit ints. Someone like you? There are plenty of greppable effective-target attributes

Regression with [C++11] PR54413 Option for turning off compiler extensions for numeric literals.

2012-11-14 Thread Hans-Peter Nilsson
From: Ed Smith-Rowland 3dw...@verizon.net Date: Fri, 9 Nov 2012 05:55:16 +0100 libcpp 2012-11-09 Ed Smith-Rowland 3dw...@verizon.net PR c++/54413 * include/cpplib.h (cpp_interpret_float_suffix): Add cpp_reader* arg. (cpp_interpret_int_suffix): Add cpp_reader*

Re: Committed: framework bits for disabling libsanitizer. RFC on which targets for which to disable it.

2012-11-13 Thread Hans-Peter Nilsson
From: Dodji Seketeli do...@redhat.com Date: Tue, 13 Nov 2012 16:04:12 +0100 I guess when the issue of the missing files is resolved, we can enable building libsanitizer on Darwin proper. Here is the patchlet I am proposing so far http://gcc.gnu.org/ml/gcc-patches/2012-11/msg00993.html.

Re: Committed: framework bits for disabling libsanitizer. RFC on which targets for which to disable it.

2012-11-13 Thread Hans-Peter Nilsson
From: Richard Henderson r...@redhat.com Date: Tue, 13 Nov 2012 21:38:40 +0100 On 11/13/2012 05:24 AM, Jakub Jelinek wrote: Yes. And it shouldn't be just based on target CPU, but also based on target OS, I don't think libsanitizer supports anything but linux (glibc + maybe android) right

Re: Committed: framework bits for disabling libsanitizer. RFC on which targets for which to disable it.

2012-11-13 Thread Hans-Peter Nilsson
From: Richard Henderson r...@redhat.com Date: Wed, 14 Nov 2012 02:34:32 +0100 On 11/13/2012 05:20 PM, Hans-Peter Nilsson wrote: Right. And, I think it's worth to repeat ;) that IMHO best to there simply check that -faddress-sanitizer can compile error-free (i.e

Committed: framework bits for disabling libsanitizer. RFC on which targets for which to disable it.

2012-11-12 Thread Hans-Peter Nilsson
While the fallout(*) from the libsanitizer commit is handled, it's obvious it should have a noconfigdirs= section in toplevel/configure.ac like the other target libs. Here's what I committed after observing that a cris-elf build passed, where it previously failed building libsanitizer which

Committed: Fix PR55257: g++.dg/debug/dwarf2/non-virtual-thunk.C and heads-up target maintainers

2012-11-12 Thread Hans-Peter Nilsson
...those of you who don't have the equivalent of the patch below in your ports, that is. You'll likely only notice through a slightly reduced debugging experience and g++.dg/debug/dwarf2/non-virtual-thunk.C failing. Yes, the docs should mention these functions need to be called IMHO obviously,

[RFA:] fix PR55030, wrong code from __builtin_setjmp_receiver

2012-11-11 Thread Hans-Peter Nilsson
The problem exposed in PR55030 (repeatable on x86_64-linux with -m32 at r192676) is that the fake-frame-pointer frame is replaced with the actual-frame-pointer bp in cse1, around the critical insn in __builtin_setjmp_receiver that restores their defined offset. The patch in PR55030/r192676

Re: patch fixing a test for PR55151

2012-11-08 Thread Hans-Peter Nilsson
On Wed, 7 Nov 2012, Vladimir Makarov wrote: On 12-11-07 5:27 PM, H.J. Lu wrote: You should check !ia32 target: /* { dg-do compile { target { ! { ia32 } } } } */ Thanks, H.J. I've just fixed it. Index: testsuite/ChangeLog

Re: [RFA:] PR55186 - gcc.dg/const-uniq-1.c fails due to vector not in the constant pool

2012-11-05 Thread Hans-Peter Nilsson
From: Eric Botcazou ebotca...@adacore.com Date: Mon, 5 Nov 2012 15:29:11 +0100 But, for cris-elf (and reasonably the same for other targets) there might not be such a constant-pool entry in the first place: the vectors are too short to rule out piecewise initialization as optimal for

Re: [PATCH, generic] New RTL primitive: `define_subst'

2012-11-04 Thread Hans-Peter Nilsson
On Sun, 4 Nov 2012, Kirill Yukhin wrote: Hi, But... I don't really understand it, so here's some feedback on the documentation: Regarding the language, a definite article is Patch with fixed doc is attached. Changelog is the same Is it OK? The structure is much improved and quite

[RFA:] PR55186 - gcc.dg/const-uniq-1.c fails due to vector not in the constant pool

2012-11-02 Thread Hans-Peter Nilsson
Due to weird circumstances detailed in the PR, this test briefly passed (it has always failed before), so technically I'm fixing a regression. :) The test checks that a certain label is mentioned twice; being mentioned once infers that there are two identical initializer vectors in the

Re: [PATCH] Fix CDDCE miscompilation (PR tree-optimization/55018)

2012-11-01 Thread Hans-Peter Nilsson
From: Steven Bosscher stevenb@gmail.com Date: Sun, 28 Oct 2012 19:33:29 +0100 On Mon, Oct 22, 2012 at 11:09 PM, Jakub Jelinek wrote: On Mon, Oct 22, 2012 at 10:51:43PM +0200, Steven Bosscher wrote: Wouldn't it be way cheaper to just export dfs_find_deadend from cfganal.c and call it

Re: [PATCH, generic] New RTL primitive: `define_subst'

2012-10-31 Thread Hans-Peter Nilsson
(CC list trimmed.) On Wed, 31 Oct 2012, Kirill Yukhin wrote: Hi, This patch introduces a new RTL expression called define_subst and required by it define_subst_attr. The new feature allows to make MD-files more compact - it defines a rule by which a parser could generate modified versions

Re: [PATCH 3/3] [asan] Instrument built-in memory access function calls

2012-10-29 Thread Hans-Peter Nilsson
On Wed, 24 Oct 2012, Dodji Seketeli wrote: Jakub Jelinek ja...@redhat.com writes: On Tue, Oct 23, 2012 at 03:11:29PM +0200, Dodji Seketeli wrote: * asan.c (insert_if_then_before_iter) (instrument_mem_region_access) (maybe_instrument_builtin_call, maybe_instrument_call): New

Re: [RFA:] Fix frame-pointer-clobbering in builtins.c:expand_builtin_setjmp_receiver

2012-10-22 Thread Hans-Peter Nilsson
On Tue, 23 Oct 2012, Dominique Dhumieres wrote: This patch (r192676) is probably causing FAIL: gcc.c-torture/execute/builtins/memcpy-chk.c execution, -Os FAIL: gcc.c-torture/execute/builtins/memmove-chk.c execution, -Os FAIL: gcc.c-torture/execute/builtins/mempcpy-chk.c execution, -Os

Committed: fix gcc.dg/webizer.c (the trivial part :)

2012-10-21 Thread Hans-Peter Nilsson
Committed as obvious. Without this, mmix-knuth-mmixware exited with 2256, likely a return-address left over in the return-value-register. I used __builtin_exit just to avoid declarations or includes; the default implicit declaration apparently incompatible with this use. I saw nothing in the

Re: Committed: fix gcc.dg/webizer.c (the trivial part :)

2012-10-21 Thread Hans-Peter Nilsson
On Sun, 21 Oct 2012, Andreas Schwab wrote: Hans-Peter Nilsson h...@bitrange.com writes: I used __builtin_exit just to avoid declarations or includes; A return 0 would have worked just as well. It's not the preferred method. Fail: abort(). Pass: exit(0). Don't remember where I read

Committed, libgcc MMIX: implement static marking of program and data memory

2012-10-20 Thread Hans-Peter Nilsson
- PUSHJ $2,_init #ifdef __MMIX_ABI_GNU__ brgds, H-PCopyright 2012 Hans-Peter Nilsson. This file may be freely copied and distributed, provided that no changes whatsoever are made. Ah, just kidding: you may change it as you like, except that this paragraph, including the above attribution

Ping: [RFA:] Fix frame-pointer-clobbering in builtins.c:expand_builtin_setjmp_receiver

2012-10-20 Thread Hans-Peter Nilsson
CC:ing middle-end maintainers this time. I was a bit surprised when Eric Botcazou wrote in his review, quoted below, that he's not one of you. Maybe approve that too? On Mon, 15 Oct 2012, Hans-Peter Nilsson wrote: On Fri, 12 Oct 2012, Eric Botcazou wrote: (insn 168 49 51 3 (set (reg/f:DI

Committed: skip testsuite/23_containers/bitset/45713.cc for mmix-*-*.

2012-10-20 Thread Hans-Peter Nilsson
For mmix-knuth-mmixware, MAX_FIXED_MODE_SIZE is the default, GET_MODE_BITSIZE (DImode), which of course isn't larger than the size-type, the same size on this 64-bit target. I don't think making it larger (i.e. TImode) would help: that seems instead likely to introduce awkward spurious

breakage with [v3] (almost) finish scoped_allocator

2012-10-19 Thread Hans-Peter Nilsson
From: Jonathan Wakely jwakely@gmail.com Date: Fri, 19 Oct 2012 18:16:51 +0200 This adds support for piecewise construction of std::pair by scoped_allocator_adaptor. The only thing missing from scoped_allocator_adaptor now is that my definition of OUTERMOST isn't recursive so doesn't

Committed, MMIX: fix */builtin-apply-2.c for an instrumented setup.

2012-10-15 Thread Hans-Peter Nilsson
When running the test-suite for these tests on an instrumented mmix simulator (plus gcc and newlib patches to match) that, instead of silently allocating zeros, barfs on accesses beyond the defined stack, these tests fail because of that check. There are no stack parameters to copy, so there's

Re: [RFA:] Fix frame-pointer-clobbering in builtins.c:expand_builtin_setjmp_receiver

2012-10-15 Thread Hans-Peter Nilsson
On Fri, 12 Oct 2012, Eric Botcazou wrote: (insn 168 49 51 3 (set (reg/f:DI 253 $253) (plus:DI (reg/f:DI 253 $253) (const_int 24 [0x18]))) /tmp/mmiximp2/gcc/gcc/testsuite/gcc.c-torture/execute/built-in-setjmp.c:21 -1 (nil)) (insn 51 168 52 3 (clobber (reg/f:DI 253

Committed, MMIX: fix INCOMING_REGNO / OUTGOING_REGNO for return-value

2012-10-14 Thread Hans-Peter Nilsson
Back then, I must've missed that INCOMING_REGNO / OUTGOING_REGNO are used to map return-value-register/s too. Fixes: FAIL: gcc.dg/builtin-apply4.c execution test ... FAIL: gcc.dg/builtin-return-1.c execution test ... FAIL: gcc.dg/torture/stackalign/builtin-apply-4.c -O0 execution test FAIL:

Committed, PR54897 (was: [C++ PATCH] -Wsizeof-pointer-memaccess warning (take 2))

2012-10-11 Thread Hans-Peter Nilsson
From: Hans-Peter Nilsson h...@axis.com Date: Thu, 11 Oct 2012 02:13:32 +0200 There's now an excess error: x/libstdc++-v3/testsuite/23_containers/bitset/45713.cc:24:55: error: size of array 'test' is not an integral constant-expression int test[sizeof(std::bitset0x) != 1 ? 1 : -1

[RFA:] Fix frame-pointer-clobbering in builtins.c:expand_builtin_setjmp_receiver

2012-10-11 Thread Hans-Peter Nilsson
The md.texi entry for nonlocal_goto_receiver says A typical reason why you might need this pattern is if some value, such as a pointer to a global table, must be restored when the frame pointer is restored. Note that a nonlocal goto only occurs within a unit-of-translation, so a global table

Re: libbacktrace patch committed: Trace through shared libraries

2012-10-10 Thread Hans-Peter Nilsson
On Tue, 9 Oct 2012, Ian Lance Taylor wrote: It's an incorrect warning from an old version of GCC. Fixed like so. Bootstrapped and ran libbacktrace testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Another two in libbackend/elf.c, committed as obvious after build passed the

Re: [C++ PATCH] -Wsizeof-pointer-memaccess warning (take 2)

2012-10-10 Thread Hans-Peter Nilsson
From: Jakub Jelinek ja...@redhat.com Date: Tue, 2 Oct 2012 14:56:29 +0200 2012-10-02 Jakub Jelinek ja...@redhat.com cp/ * cp-tree.h (SIZEOF_EXPR_TYPE_P): Define. * tree.c (cp_tree_equal): Handle SIZEOF_EXPR with SIZEOF_EXPR_TYPE_P. ...etc. Looks like this

Re: PATCH to acinclude.m4 to fix gas version detection

2012-10-10 Thread Hans-Peter Nilsson
On Thu, 4 Oct 2012, Jason Merrill wrote: Recent versions of binutils seem to have started putting ' around the version number in bfd/configure.in, which was confusing gcc configure. This patch allows us to detect the version number again. OK for trunk? I committed my already-approved patch

Re: libbacktrace patch committed: Trace through shared libraries

2012-10-09 Thread Hans-Peter Nilsson
On Tue, 9 Oct 2012, Ian Lance Taylor wrote: Patch bootstrapped and ran libbacktrace and Go testsuites on x86_64-unknown-linux-gnu. Committed to mainline. Trying x86_64 host gcc 4.1.2 (--target=rl78-elf but not the issue) at r192285: /bin/sh ./libtool --tag=CC --mode=compile gcc

Build failure with [PATCH] PR 53528 c++/ C++11 Generalized Attribute support

2012-10-08 Thread Hans-Peter Nilsson
From: Dodji Seketeli do...@redhat.com Date: Mon, 8 Oct 2012 14:12:04 +0200 Jason Merrill ja...@redhat.com writes: OK. Thanks. Committed to trunk at revision r192199. This caused a build failure, see PR54860. brgds, H-P

Breakage with [v3] patch, configuring GCC --disable-libgomp causes libstdc++ abi check to fail.

2012-09-28 Thread Hans-Peter Nilsson
MIME-Version: 1.0 From: Benjamin De Kosnik b...@redhat.com Date: Fri, 28 Sep 2012 22:02:46 +0200 There's no reason for this unintentional ABI breakage with this configure flag. 2012-09-28 Benjamin Kosnik b...@redhat.com * acinclude.m4 (GLIBCXX_ENABLE_PARALLEL): Remove

Re: [patch] PR54645 move location_adhoc_data map into GC

2012-09-24 Thread Hans-Peter Nilsson
On Fri, 21 Sep 2012, Dehao Chen wrote: This patch moves location_adhoc_data into GC, and also rebuild the hash table when reading in the PCH. After the patch, PCH can work as expected. Bootstrapped and passed gcc regression tests on x8664_linux. If you have a moment to consider improvements

Re: [Patch] PR54635: Add addr_space_t argument to mode_dependent_address_p

2012-09-20 Thread Hans-Peter Nilsson
On Thu, 20 Sep 2012, Georg-Johann Lay wrote: mode_dependent_address_p is not sensitive to the address space of the passed address. Thus, add an addr_space_t parameter to the hook. Borderline obvious. :) (J/k; the added functionality seems obvious but the implementation may have non-obvious

Re: [Patch] PR54635: Add addr_space_t argument to mode_dependent_address_p

2012-09-20 Thread Hans-Peter Nilsson
On Thu, 20 Sep 2012, Georg-Johann Lay wrote: Hans-Peter Nilsson wrote: Georg-Johann Lay wrote: mode_dependent_address_p is not sensitive to the address space of the passed address. Thus, add an addr_space_t parameter to the hook. Borderline obvious. :) (J/k; the added functionality

Re: [committed] Fix g++.dg/debug/dwarf2/nested-3.C to handle hppa assembler comment

2012-09-18 Thread Hans-Peter Nilsson
From: John David Anglin d...@hiauly1.hia.nrc.ca Date: Sun, 16 Sep 2012 19:13:19 +0200 This adjusts the regexp to work on hppa. Tested on hppa2.0w-hp-hpux11.11 and hppa64-hp-hpux11.11. Committed to trunk. 2012-09-16 John David Anglin dave.ang...@nrc-cnrc.gc.ca PR debug/54460

Re: [PATCH,mmix] convert to constraints.md

2012-09-14 Thread Hans-Peter Nilsson
On Wed, 12 Sep 2012, Hans-Peter Nilsson wrote: On Wed, 12 Sep 2012, Nathan Froyd wrote: - Keeping old layout of mmix_reg_or_8bit_operand. That looked like a spurious change and I prefer the ior construct to the if_then_else. ISTR without this change, there were lots of assembly

Re: [PATCH,mmix] convert to constraints.md

2012-09-12 Thread Hans-Peter Nilsson
On Wed, 12 Sep 2012, Nathan Froyd wrote: - Original Message - Nathan, again thanks. There are a few minor tweaks compared to your version: Thanks for fixing this up! - Keeping old layout of mmix_reg_or_8bit_operand. That looked like a spurious change and I prefer the ior

Re: [PATCH,mmix] convert to constraints.md

2012-09-11 Thread Hans-Peter Nilsson
On Fri, 31 Aug 2012, Hans-Peter Nilsson wrote: On Fri, 3 Aug 2012, Hans-Peter Nilsson wrote: Sorry, but I need more time to get test-results for a recent trunk revision to a state where testing patches makes sense. I'll test the patch and commit that or a variant. Thanks for your work

Re: [PATCH] Add -fmem-report-wpa

2012-09-08 Thread Hans-Peter Nilsson
On Thu, 6 Sep 2012, Andi Kleen wrote: From: Andi Kleen a...@linux.intel.com Passed bootstrap and testsuite on x86_64. +++ b/gcc/lto/lto.c @@ -2016,6 +2016,8 @@ do_whole_program_analysis (void) /* Show the LTO report before launching LTRANS. */ if (flag_lto_report)

Re: [middle-end] Add machine_mode to address_cost target hook

2012-09-08 Thread Hans-Peter Nilsson
Oleg Endo wrote: On Thu, 2012-09-06 at 14:41 +0200, Georg-Johann Lay wrote: The change is definitely in the right direction, but I wonder how it helps to fix code bloats of 300%-400% as in PR52543? I'm not familiar with the AVR parts. BTW, There was a small change in lower-subreg which

Re: Fold VEC_PERM_EXPR a little more

2012-09-02 Thread Hans-Peter Nilsson
On Sat, 1 Sep 2012, Marc Glisse wrote: gcc/ * fold-const.c (fold_ternary_loc): Constant-propagate after removing dead operands. gcc/testsuite/ * gcc.dg/fold-perm.c: Improve test. (adding a line and a parameter to the function containing the test-code) JFTR: generally

ping [RFA:] fix configury version checks for in-tree binutils

2012-09-02 Thread Hans-Peter Nilsson
Ping with CC to build maintainers. (Further pings, if any are needed, will be with URL only.) On Sun, 26 Aug 2012, Hans-Peter Nilsson wrote: Found while investigating PR54373. A combined tree (in-tree binutils) using binutils post-2.22 is semi-broken at the moment: the version

Re: [PATCH,mmix] convert to constraints.md

2012-08-31 Thread Hans-Peter Nilsson
On Fri, 3 Aug 2012, Hans-Peter Nilsson wrote: On Thu, 2 Aug 2012, Nathan Froyd wrote: H-P, if you'd like to test beforehand, that'd be great. ...yes, I'd like to test this before, please. Thanks for your work. (Let's set a timeout at the end of August; ok to commit Sep 1 have I not got

Re: out-of-line and arch-specific random_device

2012-08-30 Thread Hans-Peter Nilsson
From: Ulrich Drepper drep...@gmail.com Date: Tue, 28 Aug 2012 05:57:08 +0200 This patch (commit r190787) broke build for non-_GLIBCXX_USE_RANDOM_TR1 targets. (See libstdc++-v3/configure.ac and its crossconfig.m4 for a list.) Index: libstdc++-v3/include/bits/random.h

Re: [google/gcc-4_7, trunk] Fix problem with -fdebug-types-section and template instantiations, take 2

2012-08-29 Thread Hans-Peter Nilsson
On Tue, 28 Aug 2012, Cary Coutant wrote: 2012-08-28 Cary Coutant ccout...@google.com * gcc/dwarf2out.c (clone_tree_partial): Remove. (copy_decls_walk): Don't copy children of a declaration into a type unit. Can't say anything about the patch but watch out with the

Re: [PATCH] rs6000: Add a builtin to read the time base register on PowerPC

2012-08-29 Thread Hans-Peter Nilsson
On Wed, 29 Aug 2012, Segher Boessenkool wrote: +++ b/gcc/testsuite/gcc.target/powerpc/ppc-get-timebase.c @@ -0,0 +1,22 @@ +/* { dg-do run { target { powerpc*-*-* } } } */ + +/* Test if __builtin_ppc_get_timebase() is compatible with the current + processor and if it's changing

Re: [PATCH] rs6000: Add a builtin to read the time base register on PowerPC

2012-08-29 Thread Hans-Peter Nilsson
On Wed, 29 Aug 2012, Michael Meissner wrote: On Wed, Aug 29, 2012 at 01:56:05PM -0400, Hans-Peter Nilsson wrote: On Wed, 29 Aug 2012, Segher Boessenkool wrote: On some systems the timebase runs at a rather low frequency, say 20MHz. This test will spuriously fail there. Waste a million

Re: [MIPS, committed] Add missing COSTS_N_INSNS call.

2012-08-29 Thread Hans-Peter Nilsson
On Wed, 29 Aug 2012, Richard Sandiford wrote: Richard Sandiford rdsandif...@googlemail.com writes: I'm testing a patch to make the testsuite work out the default -m{no,}synci, which ought to be enough. The usual rules should then kick in and force -mno-synci where necessary. Hopefully.

Re: [MIPS, committed] Add missing COSTS_N_INSNS call.

2012-08-28 Thread Hans-Peter Nilsson
On Tue, 28 Aug 2012, Richard Sandiford wrote: Hans-Peter Nilsson h...@bitrange.com writes: On Sun, 26 Aug 2012, Richard Sandiford wrote: I'm preparing a patch to turn gcc.target/mips into a torture-like testsuite. While on the subject of gcc.target/mips and its extensions, it also

Re: [MIPS, committed] Add missing COSTS_N_INSNS call.

2012-08-27 Thread Hans-Peter Nilsson
On Sun, 26 Aug 2012, Richard Sandiford wrote: I'm preparing a patch to turn gcc.target/mips into a torture-like testsuite. While on the subject of gcc.target/mips and its extensions, it also doesn't handle a build configured with --with-synci=yes. (Well, not on the 4.7 branch at least.) brgds,

[RFA:] fix configury version checks for in-tree binutils

2012-08-26 Thread Hans-Peter Nilsson
Found while investigating PR54373. A combined tree (in-tree binutils) using binutils post-2.22 is semi-broken at the moment: the version of the assembler and linker can't be found. The configury doesn't expect the single-quote that has appeared; i.e. VERSION=2.22.0 vs. VERSION='2.23.51' You

Committed, btest-gcc.sh: make fortran tests optional

2012-08-26 Thread Hans-Peter Nilsson
Some targets, like mmix-knuth-mmixware, has fortran turned off. This patch has seen a large amount of testing, both for targets with fortran on and off. A similar patch in the past (http://gcc.gnu.org/ml/gcc-patches/2005-04/msg00766.html) made the libstdc++ tests optional, so I'm calling it

To-be-committed: fix configure case when assembler COMDAT group support is lacking

2012-08-26 Thread Hans-Peter Nilsson
If the out-of-tree target assembler supports neither: .section .text,axG,@progbits,.foo,comdat (tsk tsk no leading space, though that's a red herring) nor: .section .text,axG,%progbits,.foo,comdat then gcc/configure.ac drops through into the system-specific case seen in the patch, where for

To-be-committed: correct out-of-tree .hidden support for mmix-knuth-mmixware

2012-08-26 Thread Hans-Peter Nilsson
GCC configure should say that the linker does *not* support .hidden. For static-only linking (the only mode supported on this simulator-only system) this shouldn't really matter. But, different code is actually used (not just the attribute-hidden decorations), so different bugs are exposed. Like

Re: [PATCH v2, middle-end]: Introduce TARGET_REJECT_COMBINED_INSN target hook

2012-08-25 Thread Hans-Peter Nilsson
On Sat, 25 Aug 2012, Uros Bizjak wrote: Hello! v2 patch differences: - moves hook description text to target.def - fixes error path to clear clobbers, as expected by recog_for_combine callers 2012-08-25 Uros Bizjak ubiz...@gmail.com * target.def (reject_combined_insn): New target

Re: [PATCH v2, middle-end]: Introduce TARGET_REJECT_COMBINED_INSN target hook

2012-08-25 Thread Hans-Peter Nilsson
On Sat, 25 Aug 2012, Uros Bizjak wrote: On Sat, Aug 25, 2012 at 7:22 PM, Hans-Peter Nilsson h...@bitrange.com wrote: Maybe mention that the default is to allow all combinations for which a pattern match? And that the reason to disallow them can be that they're known to result in suboptimal

Committed: old patch to btest-gcc.sh: Add libmudflap.sum, if it exists.

2012-08-25 Thread Hans-Peter Nilsson
I had a nagging feeling there was a patch I didn't commit. Patch approval link, having link to the patch: http://gcc.gnu.org/ml/gcc-patches/2009-03/msg01509.html (modulo obvious adjustments to copyright line) brgds, H-P

Re: [bootstrap] Tentative fix for PR 54281

2012-08-17 Thread Hans-Peter Nilsson
From: Diego Novillo dnovi...@google.com Date: Thu, 16 Aug 2012 21:12:56 +0200 On 12-08-16 15:00 , Diego Novillo wrote: This is the patch I'm currently testing. I need someone with a very old toolchain (4.1 or earlier) to also give this a try (the original problem does not occur in g++

Re: CXX conversion: min g++ version pre-requisite?

2012-08-17 Thread Hans-Peter Nilsson
On Fri, 17 Aug 2012, Gary Funck wrote: Paul Hargrove noted the following build failure on an older x86-32 Linux (Redhat 8.0) system. wow. old. The g++ version is: g++ (GCC) 3.4.0 Currently, install.texi states: @heading Tools/packages necessary for building GCC @table @asis

Re: [RFA:] fix PR54261, reverse operator emitted for compare_and_swap-libfunc targets

2012-08-16 Thread Hans-Peter Nilsson
From: Hans-Peter Nilsson h...@axis.com Date: Wed, 15 Aug 2012 02:20:37 +0200 I looked around and it seems only cris{v32,}-axis-linux-gnu is affected. Still, besides that target, for a 4.7/r189762 import and c/c++ testing, boot+regtest in progress for x86_64-linux and cross-test for cris

Re: combine permutations in gimple

2012-08-16 Thread Hans-Peter Nilsson
On Wed, 15 Aug 2012, Richard Guenther wrote: On Wed, Aug 15, 2012 at 1:56 PM, Ramana Radhakrishnan ramana.radhakrish...@linaro.org wrote: Of-course, the problem here is this change of semantics with the hook TARGET_VEC_PERM_CONST_OK. Targets were expanding to generic permutes with

Re: add strnlen to libiberty (was Re: Assembly output optimisations)

2012-08-07 Thread Hans-Peter Nilsson
On Mon, 6 Aug 2012, Ian Lance Taylor wrote: On Mon, Aug 6, 2012 at 10:44 PM, Dimitrios Apostolou ji...@gmx.net wrote: What else is missing to make this patch appropriate for libiberty? Should I change the prolog in strnlen.c, since I only copied it intact from gnulib? We generally try to

Re: Assembly output optimisations (was: PR 51094 - fprint_w() in output_addr_const() reinstated)

2012-08-06 Thread Hans-Peter Nilsson
On Tue, 7 Aug 2012, Dimitrios Apostolou wrote: Thanks Andreas, hp, Mike, for your comments. Mike I'd appreciate if you elaborated on how to speed-up sprint_uw_rev(), I don't think I understood what you have in mind. I just commented on comments and just above the nit-level; formatting and

Re: [PATCH,mmix] convert to constraints.md

2012-08-03 Thread Hans-Peter Nilsson
On Thu, 2 Aug 2012, Nathan Froyd wrote: As $SUBJECT says. There's not too much interesting here. I did a fairly literal-minded conversion, so it's possible there's smarter ways to do some things. Doesn't look too bad though, but ... Compiled with cross to mmix-knuth-mmixware and

Re: [PATCH v2] Target-specific limits on vector alignment

2012-07-29 Thread Hans-Peter Nilsson
From: Ulrich Weigand uweig...@de.ibm.com Date: Fri, 27 Jul 2012 17:24:08 +0200 Richard (Earnshaw) has asked me to take over working on this patch now. I've now made the change requested above and removed the size argument. The target is now simply asked to return the required alignment for

Re: [PATCH/MIPS] Emit stack executable note

2012-07-26 Thread Hans-Peter Nilsson
On Wed, 25 Jul 2012, Andrew Pinski wrote: Hi, The Linux kernel already supports non-executable stack since around February 2010. This patch has GCC emit the notes that are associated with non-executable stack. What does the kernel do when the note isn't present? OK? Bootstrapped and

Re: [patch] Move lowering of switches to bit tests to GIMPLE

2012-07-25 Thread Hans-Peter Nilsson
On Tue, 24 Jul 2012, Richard Henderson wrote: On 07/21/2012 06:10 AM, Oleg Endo wrote: I think on SH the cost test in lshift_cheap_p with gen_rtx_ASHIFT (word_mode, const1_rtx, reg), speed_p); will always 'fail', because of sh.c (shiftcosts): /* There is no pattern for constant

Re: [RFC] Target-specific limits on vector alignment

2012-07-25 Thread Hans-Peter Nilsson
From: Ulrich Weigand uweig...@de.ibm.com Date: Tue, 24 Jul 2012 19:38:15 +0200 I've implemented this as a separate hook, rather than using the existing hooks because there's a strong likelihood of breaking some existing ABIs if I did it another way. There are a couple of tests

Re: Commit: ARM: Document -munaligned-access

2012-07-23 Thread Hans-Peter Nilsson
On Fri, 20 Jul 2012, Ryan Mansfield wrote: On 12-07-19 05:33 PM, Hans-Peter Nilsson wrote: Index: changes.html +some source codes generates code that accesses memory on unaligned +adresses. This will require the kernel of those systems to enable adresses - addresses

Committed: executable-stack note for CRIS

2012-07-22 Thread Hans-Peter Nilsson
Tested crisv32-linux (much as you can do without actually installing a new /lib/ld.so.1 with the changed defaults). Yep, this is actually a change of the default in glibc (port to be submitted), but changing it this way is safe: with old libraries lacking a note, they default to not having an

Committed: testsuite updates for recent changes in atomics for cris*-linux*

2012-07-22 Thread Hans-Peter Nilsson
I changed the defaults for cris*-linux*, but didn't fix the test-suite to go with that, so with unaligned accesses working, the test-suite still checked that they trapped, doh. Here's the update, checked trunk cris-elf and crisv32-elf (because of difference in atomics) and crisv32-linux* on the

Committed, CRIS: remove unused variables from cris_asm_output_ident

2012-07-20 Thread Hans-Peter Nilsson
Looks like these were left from Steven's ident-cleanup. Steven, for future reference, you might want to use contrib/warn_summary on the build-logs. ;) Incidentally, the magic option to increase diff context for svn is -x -UN as in -x -U5 below, just to show there's not much else in that function.

Yet another gcc.c-torture/execute/20101011-1.c DO_TEST 0

2012-07-20 Thread Hans-Peter Nilsson
The #elif defined ... #define DO_TEST 0 exceptions are accumulating. Maybe the DO_TEST = 1 case should be the exception... Committed. gcc/testsuite: * gcc.c-torture/execute/20101011-1.c (DO_TEST): Define as 0 for CRIS. Index: gcc.c-torture/execute/20101011-1.c

Re: [RESEND-2][PATCH] Allow printing of escaped curly braces in assembler directives with operands

2012-07-20 Thread Hans-Peter Nilsson
On Wed, 18 Jul 2012, Siddhesh Poyarekar wrote: Hi, Resending. I did not get any responses the last two times and I too forgot about it. Can someone please review this? This is *not* an approver-review. An assembler directive with an operand is filtered through output_asm_insn (or

Re: Commit: ARM: Document -munaligned-access

2012-07-20 Thread Hans-Peter Nilsson
From: nick clifton ni...@redhat.com Date: Fri, 20 Jul 2012 09:18:52 +0200 approved - please apply. Thanks! I see the last sentence could do with better punctuation, so I added the obvious comma. Installed as follows. Index: changes.html

Re: Commit: ARM: Document -munaligned-access

2012-07-19 Thread Hans-Peter Nilsson
From: Nick Clifton ni...@redhat.com Date: Wed, 18 Jul 2012 08:51:16 +0200 2012-07-18 Nick Clifton ni...@redhat.com * doc/invoke.texi (ARM Options): Document -munaligned-access. Index: gcc/doc/invoke.texi === ---

Re: CRIS atomics revisited 4/4: give up on alignment of atomic data, RFC for is_lock_free hook

2012-07-17 Thread Hans-Peter Nilsson
From: Andrew MacLeod amacl...@redhat.com Date: Tue, 17 Jul 2012 14:24:48 +0200 On 07/15/2012 11:49 PM, Hans-Peter Nilsson wrote: Well, give up by default that is, and fix it up in a helper function in glibc to hold a global byte-sized atomic lock for the duration. (Sorry!) Yes

Re: CRIS atomics revisited 4/4: give up on alignment of atomic data, RFC for is_lock_free hook

2012-07-17 Thread Hans-Peter Nilsson
From: Andrew MacLeod amacl...@redhat.com Date: Tue, 17 Jul 2012 14:24:48 +0200 Any PR's you open related this this, copy me on them and I'll try to get them addressed. I could separate the issues I saw into PRs 54003-6. That's all, hopefully ...at least for now. :) BTW, your @gcc.gnu.org

Re: CRIS atomics revisited 4/4: give up on alignment of atomic data

2012-07-16 Thread Hans-Peter Nilsson
From: Hans-Peter Nilsson h...@axis.com Date: Mon, 16 Jul 2012 05:49:00 +0200 gcc: * config/cris/sync.md (atomic_fetch_atomic_op_namemode) (cris_atomic_fetch_atomic_op_namemode_1) (atomic_compare_and_swapmode) (cris_atomic_compare_and_swapmode_1): Make

CRIS atomics revisited 0/4: summary

2012-07-15 Thread Hans-Peter Nilsson
These were spotted while debugging usage of atomics within glibc. The kind of changes are microoptimizations, nanooptimizations, a buglet and a major issue. Micro: the load-store-conditional sequence for compare-and-swap I originally committed was an earlier version improved later.

CRIS atomics revisited 1/4: use need_atomic_barrier_p.

2012-07-15 Thread Hans-Peter Nilsson
Use the new need_atomic_barrier_p. gcc: * config/cris/sync.md (atomic_fetch_atomic_op_namemode) (atomic_compare_and_swapmode): Gate expand_mem_thread_fence calls on result of call to need_atomic_barrier_p. Index: config/cris/sync.md

CRIS atomics revisited 2/4: don't allow a memory operand (with possible side-effects)

2012-07-15 Thread Hans-Peter Nilsson
Buglet in atomic_compare_and_swapmode, allowing (in theory) a volatile or post-increment memory operand. Simplest and safest fixed by excluding all memory operands. gcc: * config/cris/sync.md (atomic_compare_and_swapmode): Change predicate to nonmemory_operand for operand 3. Add

CRIS atomics revisited 3/4: pattern improvements

2012-07-15 Thread Hans-Peter Nilsson
Microoptimizations for the atomic patterns themselves. Constant operands are so common that it seems wasteful not to handle the most common cases and avoid wasting a register. gcc/testsuite: * gcc.target/cris/20011127-1.c: Adjust to %P being a valid register operand output

CRIS atomics revisited 4/4: give up on alignment of atomic data, RFC for is_lock_free hook

2012-07-15 Thread Hans-Peter Nilsson
Well, give up by default that is, and fix it up in a helper function in glibc to hold a global byte-sized atomic lock for the duration. (Sorry!) Yes, this means that fold_builtin_atomic_always_lock_free is wrong. It knows about alignment in general but doesn't handle the case where the default

Fixing gcc.c-torture/compile/pr44707.c for CRIS v32 1/2.

2012-07-15 Thread Hans-Peter Nilsson
Buglet in cris_preferred_reload_class, incidental, apparently without effect at least regarding failing test-cases. A class disjunct from the input was returned as preferred. It could arguably be gcc_asserted as a sanity-check by the caller that the returned class is a subset of the original

Fixing gcc.c-torture/compile/pr44707.c for CRIS v32 2/2: RFC: CONSTANT_ADDRESS_P and its default are evil!

2012-07-15 Thread Hans-Peter Nilsson
I think CONSTANT_ADDRESS_P can and should be eliminated, replaced by something like CONSTANT_P (x) targetm.legitimate_address_p (QImode, x, false) (or QImode replaced by the known used mode) in the code currently calling it. It should, because the default definition is redundant and evil; easy

Re: Fix PR53908

2012-07-13 Thread Hans-Peter Nilsson
From: Richard Sandiford rsand...@nildram.co.uk Date: Thu, 12 Jul 2012 21:18:54 +0200 if (CALL_P (insn)) { if (RTL_CONST_OR_PURE_CALL_P (insn)) /* Pure functions can read from memory. Const functions can read from arguments that the ABI has forced

Re: Fix PR53908

2012-07-13 Thread Hans-Peter Nilsson
From: Richard Guenther richard.guent...@gmail.com Date: Fri, 13 Jul 2012 09:37:13 +0200 On Fri, Jul 13, 2012 at 9:21 AM, Steven Bosscher stevenb@gmail.com wrote: On Fri, Jul 13, 2012 at 8:47 AM, Hans-Peter Nilsson hans-peter.nils...@axis.com wrote: From: Richard Sandiford rsand

Re: Fix PR53908

2012-07-13 Thread Hans-Peter Nilsson
From: Richard Guenther richard.guent...@gmail.com Date: Fri, 13 Jul 2012 10:08:05 +0200 On Fri, Jul 13, 2012 at 9:59 AM, Hans-Peter Nilsson hans-peter.nils...@axis.com wrote: Ok for 4.7 too? Of course. Committed to trunk as follows, including the test-case which doesn't fail on trunk

Re: [PATCH] [LM32] Fix lm32-elf-gcc build error by remove unnecessary constant legitimate check.

2012-07-12 Thread Hans-Peter Nilsson
On Thu, 12 Jul 2012, Jia Liu wrote: May you give me more comment? I wanna fix it. Sorry, I'll leave that to the lm32 maintainer, I just wasnted to clear a misunderstanding regarding TARGET_LEGITIMATE_CONSTANT_P. brgds, H-P

Re: Fix gcc.dg/lower-subreg-1.c failure, revisited.

2012-07-12 Thread Hans-Peter Nilsson
From: Hans-Peter Nilsson h...@axis.com Date: Sun, 8 Jul 2012 01:02:34 +0200 PR rtl-optimization/53176 * rtlanal.c (rtx_cost): Adjust default cost for X with a UNITS_PER_WORD factor for all X according to the size of its mode, not just for SUBREGs with untieable

<    4   5   6   7   8   9   10   11   12   >