Re: [PATCH] libstdc++: hashtable: No need to update before begin node in _M_remove_bucket_begin

2024-01-18 Thread Huanghui Nie
s gcc is currently in dev stage 4 that is to say only bug > fixes normally. > > François > On 17/01/2024 09:11, Huanghui Nie wrote: > > Hi. > > When I implemented a hash table with reference to the C++ STL, I found > that when the hash table in the C++ STL deletes elements

Re: [PATCH] libstdc++: hashtable: No need to update before begin node in _M_remove_bucket_begin

2024-01-17 Thread Huanghui Nie
I'm sorry for CC the gcc@ list. Waiting for your review results there. Thanks. 2024年1月17日(水) 16:18 Jonathan Wakely : > > > On Wed, 17 Jan 2024, 08:14 Huanghui Nie via Gcc, wrote: > >> Thanks. Done. >> > > And don't CC the main gcc@ list, that's not for pat

Re: [PATCH] libstdc++: hashtable: No need to update before begin node in _M_remove_bucket_begin

2024-01-17 Thread Huanghui Nie
Thanks. Done. 2024年1月17日(水) 12:39 Sam James : > > Huanghui Nie writes: > > > Hi. > > Please CC the libstdc++ LM for libstdc++ patches, per > > https://gcc.gnu.org/onlinedocs/libstdc++/manual/appendix_contributing.html#list.patches > . > > > [...] > >

[PATCH] libstdc++: hashtable: No need to update before begin node in _M_remove_bucket_begin

2024-01-17 Thread Huanghui Nie
/operations/count.cc 23_containers/unordered_map/requirements/exception/basic.cc Regression tested on x86_64-pc-linux-gnu. Is it OK to commit? --- ChangeLog: libstdc++: hashtable: No need to update before begin node in _M_remove_bucket_begin 2024-01-16 Huanghui Nie gcc/ * libstdc++-v3/include/

[PATCH] libstdc++: hashtable: No need to update before begin node in _M_remove_bucket_begin

2024-01-16 Thread Huanghui Nie
Hi. When I implemented a hash table with reference to the C++ STL, I found that when the hash table in the C++ STL deletes elements, if the first element deleted is the begin element, the before begin node is repeatedly assigned. This creates unnecessary performance overhead. First, let’s see