[PATCH/RFC] target, hooks: Allow a target to trap on unreachable [PR109267].

2024-04-09 Thread Iain Sandoe
ps): New. * doc/invoke.texi: Document -munreachable-traps. * doc/tm.texi: Regenerate. * doc/tm.texi.in: Document TARGET_UNREACHABLE_SHOULD_TRAP. * target.def (TARGET_UNREACHABLE_SHOULD_TRAP): New hook. Signed-off-by: Iain Sandoe --- gcc/builtins.cc| 7 +++ gc

Re: [PATCH] build: Check for cargo when building rust language

2024-04-09 Thread Iain Sandoe
Hi Arthur, > On 9 Apr 2024, at 13:01, Arthur Cohen wrote: > > On 4/9/24 10:55, Iain Sandoe wrote: >> Hi Arthur, >>> On 9 Apr 2024, at 11:40, Arthur Cohen wrote: >>> On 4/9/24 09:47, John Paul Adrian Glaubitz wrote: >>>> Hello, >>>&

Re: [PATCH] build: Check for cargo when building rust language

2024-04-09 Thread Iain Sandoe
Hi Arthur, > On 9 Apr 2024, at 11:40, Arthur Cohen wrote: > On 4/9/24 09:47, John Paul Adrian Glaubitz wrote: >> Hello, >> On Mon, 2024-04-08 at 18:33 +0200, pierre-emmanuel.pa...@embecosm.com wrote: >>> The rust frontend requires cargo to build some of it's components, >>> it's presence was not

Re: [PATCH/RFC] On the use of -funreachable-traps to deal with PR 109627

2024-04-09 Thread Iain Sandoe
> On 9 Apr 2024, at 08:48, Jakub Jelinek wrote: > > On Tue, Apr 09, 2024 at 09:44:01AM +0200, Richard Biener wrote: >> (why not do it at each such switch?) > > Because the traps would then be added even to the bbs which later > end up in the middle of the function. If we defer the unreachabl

[PATCH/RFC] On the use of -funreachable-traps to deal with PR 109627

2024-04-08 Thread Iain Sandoe
Hi PR 109627 is about functions that have had their bodies completely elided, but still have the wrappers for EH frames (either .cfi_xxx or LFSxx/LFExx). These are causing issues for some linkers because such functions result in FDEs with a 0 code extent. The simplest representation of this is

[pushed] Darwin: Sync coverage specs with gcc/gcc.cc.

2024-04-08 Thread Iain Sandoe
ate coverage specs. Signed-off-by: Iain Sandoe --- gcc/config/darwin.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/config/darwin.h b/gcc/config/darwin.h index 31019a0c49d..c09b9e9dc94 100644 --- a/gcc/config/darwin.h +++ b/gcc/config/darwin.h @@ -406,7 +40

[pushed] testsuite, Darwin: Account for block labels in function body scans.

2024-04-05 Thread Iain Sandoe
ite/ChangeLog: * lib/scanasm.exp: Add 'LB*' to the local labels that are ignored for Darwin. Signed-off-by: Iain Sandoe --- gcc/testsuite/lib/scanasm.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/testsuite/lib/scanasm.exp b/gcc/testsuite/lib/scanas

Re: [PATCH] libstdc++: Fix infinite loop in std::istream::ignore(n, delim) [PR93672]

2024-04-04 Thread Iain Sandoe
> On 4 Apr 2024, at 16:29, Jonathan Wakely wrote: > > I would appreciate more eyes on this to confirm my conclusions about > negative int_type values, and the proposed fix, make sense. > > Tested x86_64-linux. > > -- >8 -- > > A negative value for the delim value passed to std::istream::ign

Re: [PATCH] Include safe-ctype.h after C++ standard headers, to avoid over-poisoning

2024-04-03 Thread Iain Sandoe
Hi Richard, > On 7 Mar 2024, at 13:40, FX Coudert wrote: > >> I think it's an obvious change ... > > Thanks, pushed. > > Dimitry, I suggest you post the second patch for review. Given that the two patches here (for https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111632) were considered obvious

[PATCH] libphobos, Darwin: Enable libphobos for most Darwin.

2024-04-02 Thread Iain Sandoe
s for Darwin >= 12. Signed-off-by: Iain Sandoe --- libphobos/configure.tgt | 9 + 1 file changed, 9 insertions(+) diff --git a/libphobos/configure.tgt b/libphobos/configure.tgt index 13879380416..7159688 100644 --- a/libphobos/configure.tgt +++ b/libphobos/configure.tgt @@ -27,6 +27,9 @

Ping: [PATCH] jit: Ensure ssize_t is defined.

2024-04-02 Thread Iain Sandoe
> On 29 Jan 2024, at 11:26, Iain Sandoe wrote: > I guess the solution here depends on the scope over which we expect > the header to be used. > >> On 28 Jan 2024, at 23:13, Iain Sandoe wrote: >>> On 28 Jan 2024, at 21:25, Eric Gallager wrote: >>> On Sun,

Re: [PATCH] jit, Darwin: Implement library exports list.

2024-04-02 Thread Iain Sandoe
Hi David, > On 25 Jan 2024, at 10:16, Iain Sandoe wrote: > >> On 24 Jan 2024, at 18:31, David Malcolm wrote: >> >> On Tue, 2024-01-16 at 11:10 +, Iain Sandoe wrote: >>> Tested on x86_64, i686 Darwin and x86_64 Linux, >>> OK for trunk? when ? &

[pushed] testsuite: Remove duplicate -lgcov [PR114034]

2024-04-02 Thread Iain Sandoe
ere is no need to put an extra one in the options. PR testsuite/114034 gcc/testsuite/ChangeLog: * g++.dg/gcov/gcov-dump-1.C: Remove extra -lgcov. * g++.dg/gcov/gcov-dump-2.C: Likewise. Signed-off-by: Iain Sandoe --- gcc/testsuite/g++.dg/gcov/gcov-dump-1.C | 2 +-

[pushed] testsuite, Darwin: Allow for an undefined symbol [PR114036].

2024-04-02 Thread Iain Sandoe
ote that the symbol is expected to be undefined. PR testsuite/114036 gcc/testsuite/ChangeLog: * gcc.misc-tests/gcov-14.c: Allow for 'Foo' to be undefined on Darwin link lines. Signed-off-by: Iain Sandoe --- gcc/testsuite/gcc.misc-tests/gcov-14.c | 2 +-

[pushed] Darwin: Correct a version check.

2024-04-02 Thread Iain Sandoe
so use 700 in the check. gcc/ChangeLog: * config/darwin.cc (darwin_override_options): Update the clang major version value in the dsymutil check. Signed-off-by: Iain Sandoe --- gcc/config/darwin.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/con

[pushed] Darwin: Do not emit .macinfo when dsymutil cannot consume it.

2024-04-02 Thread Iain Sandoe
by -gstrict-dwarf (although the objects will contain macinfo; dsymutil will not produce a .dSYM with it). gcc/ChangeLog: * config/darwin.cc (darwin_override_options): Reduce the debug level to 2 if dsymutil cannot handle .macinfo sections. Signed-off-by: Iain Sandoe --- gcc/con

[pushed] testsuite, Darwin: Update bad-mapper-1 after libiberty changes.

2024-04-02 Thread Iain Sandoe
gcc/testsuite/ChangeLog: * g++.dg/modules/bad-mapper-1.C: Update expected test output for earlier Darwin. Signed-off-by: Iain Sandoe --- gcc/testsuite/g++.dg/modules/bad-mapper-1.C | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/testsuite/g++.dg/modules/bad-map

[pushed] testsuite, Darwin: Use the IOKit framework in framework-1.c [PR114049].

2024-03-19 Thread Iain Sandoe
use of IOKit. PR target/114049 gcc/testsuite/ChangeLog: * gcc.dg/framework-1.c: Use an IOKit header instead of a Kernel one. Signed-off-by: Iain Sandoe --- gcc/testsuite/gcc.dg/framework-1.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/gcc/tes

[pushed] libstdc++: Sync the atomic_link_flags implementation with GCC.

2024-03-19 Thread Iain Sandoe
e uninstalled libatomic. Signed-off-by: Iain Sandoe --- libstdc++-v3/testsuite/lib/dg-options.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libstdc++-v3/testsuite/lib/dg-options.exp b/libstdc++-v3/testsuite/lib/dg-options.exp index bc387d17ed7..00ca678a53a 100644 --- a

[PATCH] libstdc++, Darwin: Do not use dev/null as the file for executables.

2024-03-19 Thread Iain Sandoe
-v3/ChangeLog: * testsuite/lib/libstdc++.exp (v3_target_compile): Instead of /dev/null, use a temporary file for test executables on Darwin. Signed-off-by: Iain Sandoe --- libstdc++-v3/testsuite/lib/libstdc++.exp | 20 +++- 1 file changed, 19 insertions(+), 1 delet

[pushed] Darwin: Fix bootstrap break on X86.

2024-03-16 Thread Iain Sandoe
-by: Iain Sandoe --- gcc/config/i386/darwin.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/config/i386/darwin.h b/gcc/config/i386/darwin.h index 2f773924d6e..12cdc34a19e 100644 --- a/gcc/config/i386/darwin.h +++ b/gcc/config/i386/darwin.h @@ -109,8 +109,8 @@ along with

Re: [PATCH] Fix libcc1plugin and libc1plugin to avoid poisoned identifiers

2024-03-13 Thread Iain Sandoe
Hi Dimitry, > On 7 Mar 2024, at 16:48, Dimitry Andric wrote: > > Ref: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111632 > > Use INCLUDE_VECTOR before including system.h, instead of directly > including , to avoid running into poisoned identifiers. I would say that the patch itself is obvious

Re: [PATCH] Include safe-ctype.h after C++ standard headers, to avoid over-poisoning

2024-03-06 Thread Iain Sandoe
Hi Dimitry, folks, > On 6 Mar 2024, at 23:02, Dimitry Andric wrote: > > On 6 Mar 2024, at 15:57, FX Coudert wrote: >> >>> Hmm I recall trying it and finding a problem - was there some different fix >>> applied >>> in the end? >> >> The bug is still open, I don’t think a patch was applied, an

Re: [PATCH] Include safe-ctype.h after C++ standard headers, to avoid over-poisoning

2024-03-06 Thread Iain Sandoe
> On 6 Mar 2024, at 13:54, Sam James wrote: > > FX Coudert writes: > >> I would like to patch this patch from September 2023: >> https://gcc.gnu.org/pipermail/gcc-patches/2023-September/631611.html >> >> This bug is now hitting macOS in the latest version of Xcode (it was >> originally see

Re: [C++ coroutines] Initial implementation pushed to master.

2024-03-06 Thread Iain Sandoe
> On 5 Mar 2024, at 17:31, H.J. Lu wrote: > > On Sat, Jan 18, 2020 at 4:54 AM Iain Sandoe wrote: >> >> 2020-01-18 Iain Sandoe >> >>* Makefile.in: Add coroutine-passes.o. >>* builtin-types.def (BT_CONST_SIZE

Re: [PATCH] lto, Darwin: Fix offload section names.

2024-02-29 Thread Iain Sandoe
Hi Thomas, > On 29 Feb 2024, at 14:37, Thomas Schwinge wrote: > On 2024-01-16T15:00:16+, Iain Sandoe wrote: >> Currently, these section names have wrong syntax for Mach-O. >> Although they were added some time ago; recently added tests are >> now emitting them

Re: [PATCH RFA] build: drop target libs from LD_LIBRARY_PATH [PR105688]

2024-02-23 Thread Iain Sandoe
> On 21 Feb 2024, at 23:36, Iain Sandoe wrote: > >> On 21 Feb 2024, at 23:06, Jason Merrill wrote: >> >> On 2/20/24 00:45, Alexandre Oliva wrote: >>> On Feb 16, 2024, Jason Merrill wrote: >>>> So, for stage2+, let's add just prev- libgcc.

Re: [PATCH RFA] build: drop target libs from LD_LIBRARY_PATH [PR105688]

2024-02-22 Thread Iain Sandoe
Hi Gaius, > On 22 Feb 2024, at 18:06, Gaius Mulley wrote: > > Iain Sandoe writes: > >> Right now, AFAIK the only target runtimes used by host tools are >> libstdc++, libgcc and libgnat. I agree that might change with rust - >> since the rust folks are talking a

Re: [PATCH v1 03/13] aarch64: Mark x18 register as a fixed register for MS ABI

2024-02-22 Thread Iain Sandoe
> On 22 Feb 2024, at 17:45, Andrew Pinski wrote: > > On Thu, Feb 22, 2024 at 3:56 AM Richard Earnshaw (lists) > wrote: >> >> On 21/02/2024 18:30, Evgeny Karpov wrote: >>> >> +/* X18 reserved for the TEB on Windows. */ >> +#ifdef TARGET_ARM64_MS_ABI >> +# define FIXED_X18 1 >> +# define CAL

Re: [PATCH RFA] build: drop target libs from LD_LIBRARY_PATH [PR105688]

2024-02-21 Thread Iain Sandoe
> On 21 Feb 2024, at 23:06, Jason Merrill wrote: > > On 2/20/24 00:45, Alexandre Oliva wrote: >> On Feb 16, 2024, Jason Merrill wrote: >>> So, for stage2+, let's add just prev- libgcc. >> I'm pretty sure this will break bootstrap-lean where libgcc_s isn't a >> system library, and we're buildi

Re: [PATCH] libgccjit: Add option to allow special characters in function names

2024-02-20 Thread Iain Sandoe
> On 20 Feb 2024, at 20:50, David Malcolm wrote: > > On Thu, 2024-02-15 at 17:08 -0500, Antoni Boucher wrote: >> Hi. >> This patch adds a new option to allow special characters like . and $ >> in function names. >> This is useful to allow for mangling using those characters. >> Thanks for the

[PATCH] libgcc, aarch64: Allow for BE platforms in heap trampolines.

2024-02-20 Thread Iain Sandoe
s a byte array so that the order is independent of memory byte order. (struct aarch64_trampoline): Likewise. Signed-off-by: Iain Sandoe --- libgcc/config/aarch64/heap-trampoline.c | 30 - 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/lib

[PATCH] aarch64: Allow aarch64-linux-muscl for heap trampolines [PR113971].

2024-02-20 Thread Iain Sandoe
gcc/ChangeLog: * config/aarch64/heap-trampoline.c: Allow all linux variants. Signed-off-by: Iain Sandoe --- libgcc/config/aarch64/heap-trampoline.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libgcc/config/aarch64/heap-trampoline.c b/libgcc/config/aarch64/h

Re: [PATCH RFA] build: drop target libs from LD_LIBRARY_PATH [PR105688]

2024-02-19 Thread Iain Sandoe
> On 16 Feb 2024, at 21:05, Jason Merrill wrote: > > On 2/14/24 18:33, Iain Sandoe wrote: >>> On 14 Feb 2024, at 22:59, Iain Sandoe wrote: >>>> On 12 Feb 2024, at 19:59, Jason Merrill wrote: >>>> >>>> On 2/10/24 07:30, Iain Sandoe

[PATCH] libstdc++, Darwin: Handle a linker warning [PR112397].

2024-02-18 Thread Iain Sandoe
e.am: If we are building for Darwin, then suppress hot/cold partitioning for the array allocators. * libsupc++/Makefile.in: Regenerated. Signed-off-by: Iain Sandoe Co-authored-by: Jonathan Wakely --- libstdc++-v3/configure | 35 +++--- libs

[PATCH] libiberty: Fix error return value in pex_unix_exec_child [PR113957].

2024-02-16 Thread Iain Sandoe
me for the routine. Signed-off-by: Iain Sandoe --- libiberty/pex-unix.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libiberty/pex-unix.c b/libiberty/pex-unix.c index af98062a94c..f3a1cc95ada 100644 --- a/libiberty/pex-unix.c +++ b/libiberty/pex-unix.c @@ -695,6 +695,7 @@ pex_unix_exec

Re: [PATCH] aarch64, acle header: Cast uint64_t pointers to DIMode.

2024-02-16 Thread Iain Sandoe
> On 15 Feb 2024, at 18:05, Richard Sandiford wrote: > > Iain Sandoe writes: >>> On 5 Feb 2024, at 14:56, Iain Sandoe wrote: >>> >>> Tested on aarch64-linux,darwin and a cross from aarch64-darwin to linux, >>> OK for trunk, or some alternative i

Re: [PATCH RFA] build: drop target libs from LD_LIBRARY_PATH [PR105688]

2024-02-14 Thread Iain Sandoe
> On 14 Feb 2024, at 22:59, Iain Sandoe wrote: >> On 12 Feb 2024, at 19:59, Jason Merrill wrote: >> >> On 2/10/24 07:30, Iain Sandoe wrote: >>>> On 10 Feb 2024, at 12:07, Jason Merrill wrote: >>>> >>>> On 2/10/24 05:46, Iain Sandoe

Re: [PATCH RFA] build: drop target libs from LD_LIBRARY_PATH [PR105688]

2024-02-14 Thread Iain Sandoe
> On 12 Feb 2024, at 19:59, Jason Merrill wrote: > > On 2/10/24 07:30, Iain Sandoe wrote: >>> On 10 Feb 2024, at 12:07, Jason Merrill wrote: >>> >>> On 2/10/24 05:46, Iain Sandoe wrote: >>>>> On 9 Feb 2024, at 23:21, Iain Sandoe wrote:

Re: [PATCH v2] x86: Support x32 and IBT in heap trampoline

2024-02-14 Thread Iain Sandoe
> On 14 Feb 2024, at 18:12, H.J. Lu wrote: > > On Tue, Feb 13, 2024 at 8:46 AM Jakub Jelinek wrote: >> >> On Tue, Feb 13, 2024 at 08:40:52AM -0800, H.J. Lu wrote: >>> Add x32 and IBT support to x86 heap trampoline implementation with a >>> testcase. >>> >>> 2024-02-13 Jakub Jelinek >>>

Re: [PATCH] x86, libgcc: Implement ia32 basic heap trampoline [PR113855].

2024-02-10 Thread Iain Sandoe
> On 10 Feb 2024, at 17:46, Jakub Jelinek wrote: > > On Sat, Feb 10, 2024 at 05:14:44PM +0000, Iain Sandoe wrote: >> PR target/113855 >> >> gcc/ChangeLog: >> >> * config/i386/darwin.h (DARWIN_HEAP_T_LIB): Moved to be >> availa

[PATCH] x86, libgcc: Implement ia32 basic heap trampoline [PR113855].

2024-02-10 Thread Iain Sandoe
I have so far tested this on i686-darwin17 and on x86_64-linux (with 32b multilib )with the following permutations: C (dg.exp=*nest*), Ada : \{-m64,-m32\}\{,-ftrampoline-impl=heap\}\{,-shared-libgcc\} Fortran \{-m64,-m32\}\{,-ftrampoline-impl=heap\} The only fails [gnat] are expected (scanning fo

Re: [PATCH] Darwin, testsuite: -multiply_defined is obsolete

2024-02-10 Thread Iain Sandoe
> On 10 Feb 2024, at 14:54, FX Coudert wrote: > > With Xcode 15, gcc.dg/ssp-2.c fails due to a warning: -multiply_defined is > obsolete > > The patches ignores the warning when present. > OK to push? yes, thanks. Iain … although part of me is curious about whether we still have any support

Re: [PATCH RFA] build: drop target libs from LD_LIBRARY_PATH [PR105688]

2024-02-10 Thread Iain Sandoe
> On 10 Feb 2024, at 12:07, Jason Merrill wrote: > > On 2/10/24 05:46, Iain Sandoe wrote: >>> On 9 Feb 2024, at 23:21, Iain Sandoe wrote: >>> >>> >>> >>>> On 9 Feb 2024, at 10:56, Iain Sandoe wrote: >>>>> On 8 Feb 2

Re: [PATCH] Darwin, testsuite: -bind_at_load is deprecated

2024-02-10 Thread Iain Sandoe
Hi FX, > On 10 Feb 2024, at 11:58, FX Coudert wrote: > > With Xcode 15, gcc.dg/darwin-ld-2.c fails due to a warning: > ld: warning: -bind_at_load is deprecated on macOS > > The patches ignores the warning when present. > OK to push? Yes, thanks. Iain I guess for GCC-15 we might need to see w

Re: [PATCH RFA] build: drop target libs from LD_LIBRARY_PATH [PR105688]

2024-02-10 Thread Iain Sandoe
> On 9 Feb 2024, at 23:21, Iain Sandoe wrote: > > > >> On 9 Feb 2024, at 10:56, Iain Sandoe wrote: >>> On 8 Feb 2024, at 21:44, Jason Merrill wrote: >>> >>> On 2/8/24 12:55, Paolo Bonzini wrote: >>>> On 2/8/24 18:16, Jason Merrill

Re: [PATCH RFA] build: drop target libs from LD_LIBRARY_PATH [PR105688]

2024-02-09 Thread Iain Sandoe
> On 9 Feb 2024, at 10:56, Iain Sandoe wrote: >> On 8 Feb 2024, at 21:44, Jason Merrill wrote: >> >> On 2/8/24 12:55, Paolo Bonzini wrote: >>> On 2/8/24 18:16, Jason Merrill wrote: >>>>>> >>>>> >>>>> Hmm. In

Re: [PATCH RFA] build: drop target libs from LD_LIBRARY_PATH [PR105688]

2024-02-09 Thread Iain Sandoe
> On 8 Feb 2024, at 21:44, Jason Merrill wrote: > > On 2/8/24 12:55, Paolo Bonzini wrote: >> On 2/8/24 18:16, Jason Merrill wrote: > Hmm. In stage 1, when we build with the system gcc, I'd think we want the just-built gnat1 to find the system libgcc. In stage

[pushed] libgcc, Darwin: Update symbol exports to include bitint and bf.

2024-02-09 Thread Iain Sandoe
Tested on i686-darwin8, x86_64-darwin{14,17,19,21,23} pushed to trunk. thanks, Iain --- 8< --- Some exports were missed from the GCC-13 cycle, these are added here along with the bitint-related ones added in GCC-14. libgcc/ChangeLog: * config/i386/libgcc-darwin.ver: Export bf and bitint

Re: [PATCH RFA] build: drop target libs from LD_LIBRARY_PATH [PR105688]

2024-02-08 Thread Iain Sandoe
> On 8 Feb 2024, at 19:25, Jason Merrill wrote: > > On 2/8/24 12:51, Iain Sandoe wrote: >>> On 8 Feb 2024, at 17:16, Jason Merrill wrote: >>> >>> On 2/8/24 12:12, Jason Merrill wrote: >>>> On 2/8/24 10:04, Iain Sandoe wrote: >>>>

Re: [PATCH RFA] build: drop target libs from LD_LIBRARY_PATH [PR105688]

2024-02-08 Thread Iain Sandoe
> On 8 Feb 2024, at 17:16, Jason Merrill wrote: > > On 2/8/24 12:12, Jason Merrill wrote: >> On 2/8/24 10:04, Iain Sandoe wrote: >>> Hi Jason, >>> >>> I have tested this on modern Darwin (with libc++ as the system library) and >>> on >&g

Re: [PATCH RFA] build: drop target libs from LD_LIBRARY_PATH [PR105688]

2024-02-08 Thread Iain Sandoe
Hi Jason, I have tested this on modern Darwin (with libc++ as the system library) and on older Darwin, where we do see the issue - because the system linker is written in C++ and links with libstdc++ (so sometimes we get a crash, or worse unpredictable beahviour). - For modern Darwin [ > m

Re: [PATCH] aarch64, acle header: Cast uint64_t pointers to DIMode.

2024-02-05 Thread Iain Sandoe
> On 5 Feb 2024, at 14:56, Iain Sandoe wrote: > > Tested on aarch64-linux,darwin and a cross from aarch64-darwin to linux, > OK for trunk, or some alternative is needed? Hmm.. apparently, this fails the linaro pre-commit CI for g++ with: error: invalid conversion from 'lo

[PATCH] aarch64, acle header: Cast uint64_t pointers to DIMode.

2024-02-05 Thread Iain Sandoe
Tested on aarch64-linux,darwin and a cross from aarch64-darwin to linux, OK for trunk, or some alternative is needed? thanks Iain --- 8< --- Currently, most of the acle tests fail on the Darwin port because DI mode is "long" and uint64 is "long long". The fix for this used in other headers is to

[pushed] testsuite, Darwin: Allow for undefined symbols in shared test.

2024-02-02 Thread Iain Sandoe
tested on i686, x86_64 Darwin, x86_64, aarch64 linux, pushed to trunk, thanks, Iain --- 8< --- Darwin's linker defaults to error on undefined (which makes it look as if we do not support shared, leading to tests being marked incorrectly as unsupported). This fixes the issue by allowing the symbo

Re: [PATCH] libgcc: Avoid warnings on __gcc_nested_func_ptr_created [PR113402]

2024-02-01 Thread Iain Sandoe
> On 1 Feb 2024, at 08:51, Richard Biener wrote: > > On Thu, Feb 1, 2024 at 9:23 AM Jakub Jelinek wrote: >> >> On Wed, Jan 31, 2024 at 01:04:20PM +0100, Jakub Jelinek wrote: >>> On Sun, Jan 28, 2024 at 11:02:33AM +, Iain Sandoe wrote: >>>>

Re: [PATCH] libgcc: Fix up i386/t-heap-trampoline [PR113403]

2024-02-01 Thread Iain Sandoe
> On 1 Feb 2024, at 08:22, Jakub Jelinek wrote: > > On Wed, Jan 31, 2024 at 12:59:27PM +0100, Jakub Jelinek wrote: >> On Sun, Jan 28, 2024 at 02:07:32PM +0000, Iain Sandoe wrote: >>> --- a/libgcc/config/aarch64/t-heap-trampoline >>> +++ b/libgcc/config/aarch

Re: [PATCH] libstdc++: Enable std::text_encoding for darwin and FreeBSD

2024-01-31 Thread Iain Sandoe
Hi Jonathan, > On 30 Jan 2024, at 15:02, Jonathan Wakely wrote: > > This should fix the std/text_encoding/* FAILs that Iain sees on darwin. > I assume it will make it work for FreeBSD too. > > I won't push this until I hear it works for at least one of those. It works on x86_64-darwin{19,21,23

[PATCH] testsuite, ubsan: Add libstdc++ deps where required.

2024-01-30 Thread Iain Sandoe
tested on i686, x86_64 (and aarch64) Darwin, x86_64, aarch64 Linux, OK for trunk? thanks Iain --- 8< --- We use the ubsan tests from both C, C++, D and Fortran. the sanitizer libraries link to libstdc++. When we are using the C/gdc/gfortran driver, and the target might require a path to the libs

[PATCH] testsuite, asan, hwsan: Add libstdc++ deps where required.

2024-01-30 Thread Iain Sandoe
tested on i686, x86_64 (and aarch64) Darwin, x86_64, aarch64 Linux, OK for trunk? thanks Iain --- 8< --- We use the shared asan/hwasan from both C,C++,D and Fortran. The sanitizer libraries link to libstdc++. When we are using the C/gdc/gfortran driver, and the target might require a path to the

Re: [PATCH] jit: Ensure ssize_t is defined.

2024-01-29 Thread Iain Sandoe
Hi David, I guess the solution here depends on the scope over which we expect the header to be used. > On 28 Jan 2024, at 23:13, Iain Sandoe wrote: >> On 28 Jan 2024, at 21:25, Eric Gallager wrote: >> On Sun, Jan 28, 2024 at 6:45 AM Iain Sandoe wrote: >>> >>&

Re: [PATCH] jit: Ensure ssize_t is defined.

2024-01-28 Thread Iain Sandoe
> On 28 Jan 2024, at 21:25, Eric Gallager wrote: > > On Sun, Jan 28, 2024 at 6:45 AM Iain Sandoe wrote: >> >> Tested on i686, x86_64 Darwin, x86_64 Linux, >> OK for trunk? >> >> --- 8< --- >> >> On some targets it seems that ssize_

[PATCH] testsuite, Objective-C++: Update link flags [PR112863].

2024-01-28 Thread Iain Sandoe
Tested on i686, x86_64, aarch64 Darwin, x86_64, aarch64 Linux, OK for trunk? thanks, Iain --- 8< --- These regressions are caused by missing or duplicate runpaths which now fire linker warnings. We need to add options to locate libobjc (and on Darwin libobjc-gnu) along with libstdc++. Usually '

[PATCH] testsuite, libphobos: Update link flags [PR112864].

2024-01-28 Thread Iain Sandoe
Tested on i686, x86_64, aarch64 Darwin, x86_64, aarch64 Linux, OK for trunk? thanks, Iain --- 8< --- The regressions here are primarily from duplicated '-B' additions. We remove the duplicate on the link line. We also make sure that platforms with extensions other than .so for shared libs will

[PATCH] testsuite, gfortan: Update link flags [PR112862].

2024-01-28 Thread Iain Sandoe
Tested on i686, x86_64, aarch64 Darwin, x86_64, aarch64 Linux, OK for trunk? thanks, Iain --- 8< --- The regressions here are caused by two issues: 1. In some cases there is no generated runpath for libatomic 2. In other cases there are duplicate paths. This patch simplifies the addition of the

[PATCH] testsuite, GDC: Update link flags [PR112861].

2024-01-28 Thread Iain Sandoe
Tested on i686, x86_64, aarch64 Darwin, x86_64, aarch64 Linux, OK for trunk? thanks, Iain --- 8< --- The regressions here are because we do not generate a runpath for the uninstalled libstdc++. This patch updates the link flags handling to simplify it. We need to add options to locate both lib

[PATCH 2/2] libgcc: Make heap trampoline support dynamic [PR113403].

2024-01-28 Thread Iain Sandoe
In order to handle system security constraints during GCC build and test and that most platform versions cannot link to libgcc_eh since the unwinder there is incompatible with the system one. 1. We make the support functions weak definitions. 2. We include them as a CRT for platform conditions tha

[PATCH 1/2] libgcc: Make heap trampoline support dynamic [PR113403].

2024-01-28 Thread Iain Sandoe
This removes the heap trampoline support functions from libgcc.a and adds them to libgcc_eh.a. They are also present in libgcc_s. PR libgcc/113403 libgcc/ChangeLog: * config/aarch64/t-heap-trampoline: Move the heap trampoline support functions from libgcc.a to libgcc_eh.

[PATCH 0/2] libgcc: Make heap trampoline support dynamic [PR113403].

2024-01-28 Thread Iain Sandoe
This series follows Jakub's suggestion in the PR (for Linux in the first patch) and handles Darwin-specific cases (in the second). Sorry this has taken a while, the Darwin permutations had some glitches which necessitated re-tests on several OS versions. Tested on x86_64 (and aarch64) Darwin, x86

[pushed] Objective-C, Darwin: Do not overalign CFStrings and Objective-C metadata.

2024-01-28 Thread Iain Sandoe
ise. (build_ehtype): Likewise. * objc-runtime-shared-support.cc (generate_strings): Likewise. Signed-off-by: Iain Sandoe --- gcc/config/darwin.cc| 1 + gcc/objc/objc-next-runtime-abi-02.cc| 18 +++--- gcc/objc/objc-runtime-shared-support.cc | 4 3 files chan

[PATCH] jit: Ensure ssize_t is defined.

2024-01-28 Thread Iain Sandoe
ble since that is where Posix specifies that ssize_t is defined. gcc/jit/ChangeLog: * libgccjit.h: Conditionally include where it is available to ensure declaration of ssize_t. Signed-off-by: Iain Sandoe --- gcc/jit/libgccjit.h | 3 +++ 1 file changed, 3 insertions(+) diff --gi

[pushed] testsuite, Objective-C: Fix duplicate libobjc cases.

2024-01-28 Thread Iain Sandoe
appear on the link line leading to spurious warnings from Darwin's new linker. gcc/testsuite/ChangeLog: * obj-c++.dg/encode-10.mm: Remove unneeded '-lobjc' option addition. * obj-c++.dg/encode-9.mm: Likewise. Signed-off-by: Iain Sandoe --- gcc/testsuite/obj-c+

Re: [PATCH v3] Fix __builtin_nested_func_ptr_{created, deleted} symbol versions [PR113402]

2024-01-28 Thread Iain Sandoe
> On 18 Jan 2024, at 15:05, Jakub Jelinek wrote: > > On Thu, Jan 18, 2024 at 02:59:23PM +0000, Iain Sandoe wrote: >> --- a/gcc/builtins.cc >> +++ b/gcc/builtins.cc >> @@ -8416,6 +8416,11 @@ expand_builtin (tree exp, rtx target, rtx subtarget, >&g

Re: [PATCH] jit, Darwin: Implement library exports list.

2024-01-25 Thread Iain Sandoe
Hi David, > On 24 Jan 2024, at 18:31, David Malcolm wrote: > > On Tue, 2024-01-16 at 11:10 +0000, Iain Sandoe wrote: >> Tested on x86_64, i686 Darwin and x86_64 Linux, >> OK for trunk? when ? >> thanks, >> Iain > > Hi Iain, thanks for the patch. > >

Re: [PATCH] testsuite, jit: Stabilize error output.

2024-01-22 Thread Iain Sandoe
gentle ping, with the increasing use of CI, it seems an idea to tackle this sooner rather than later. thanks Iain > On 16 Jan 2024, at 11:12, Iain Sandoe wrote: > > Tested on x86_64, i686 Darwin, x86_64 Linux, > OK for trunk? When? > thanks > Iain > > --- 8< ---

Re: [PATCH] jit, Darwin: Implement library exports list.

2024-01-22 Thread Iain Sandoe
gentle ping, this fixes quite a few of the new jit fails on darwin. thanks Iain > On 16 Jan 2024, at 11:10, Iain Sandoe wrote: > > Tested on x86_64, i686 Darwin and x86_64 Linux, > OK for trunk? when ? > thanks, > Iain > > --- 8< --- > > Currently, we have no

[pushed] Darwin, configure: Handle a missing substitution.

2024-01-18 Thread Iain Sandoe
exp when ENABLE_DARWIN_AT_RPATH_TRUE is not '#'. Signed-off-by: Iain Sandoe --- gcc/Makefile.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/Makefile.in b/gcc/Makefile.in index deb12e17d25..95caa54a52b 100644 --- a/gcc/Makefile.in +++ b/gcc/Makefile.in @@ -4

[PATCH v3] Fix __builtin_nested_func_ptr_{created, deleted} symbol versions [PR113402]

2024-01-18 Thread Iain Sandoe
cc-std.ver.in (GCC_7.0.0): Likewise and then move __gcc_nested_func_ptr_created and __gcc_nested_func_ptr_deleted from this symbol version to ... (GCC_14.0.0): ... this one. Signed-off-by: Iain Sandoe Co-authored-by: Jakub Jelinek --- gcc/builtins.cc |

[pushed] Objective-C/C++: Ensure sufficient setup for the preprocessor.

2024-01-18 Thread Iain Sandoe
are initialized before pre-process-only jobs are run. gcc/objc/ChangeLog: * objc-act.cc (objc_init): Initialize interface and class name hash maps before the preprocessor uses them. Signed-off-by: Iain Sandoe --- gcc/objc/objc-act.cc | 7 +-- 1 file changed, 5 insertions(+)

[pushed] Darwin: Suppress adding embedded rpaths for earlier OS versions.

2024-01-18 Thread Iain Sandoe
sent). gcc/ChangeLog: * config/darwin.h (DARWIN_RPATH_SPEC): Arrange for the %P spec to be conditional on macosx-version-min. Signed-off-by: Iain Sandoe --- gcc/config/darwin.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/gcc/config/darwin.h b/gcc/conf

[pushed] Darwin: Fix a typo in Objective-C meta-data.

2024-01-18 Thread Iain Sandoe
the properties of the DECLs. gcc/ChangeLog: * config/darwin.cc (darwin_objc1_section): Use the correct meta-data version for constant strings. (machopic_select_section): Assert if we fail to handle CFString sections as Obejctive-C meta-data or drectly. Signed-off-by: I

[pushed] Darwin: Fix constant CFString code-gen [PR105522].

2024-01-18 Thread Iain Sandoe
ing code. (darwin_libc_has_function): Likewise. (darwin_build_constant_cfstring): Create an anonymous var to hold each CFString. * config/darwin.h (ASM_OUTPUT_LABELREF): Handle constant CFstrings. Signed-off-by: Iain Sandoe --- gcc/config/darwin.cc

Re: [COMMITTED] rust_debug: Cast size_t values to unsigned long before printing.

2024-01-18 Thread Iain Sandoe
Hi Arthur, > On 18 Jan 2024, at 10:30, Arthur Cohen wrote: > On 1/18/24 10:13, Rainer Orth wrote: >> Arthur Cohen writes: >>> Using %lu to format size_t values breaks 32 bit targets, and %zu is not >>> supported by one of the hosts GCC aims to support - HPUX >> But we do have uses of %zu in gcc

Re: [PATCH v2] Fix __builtin_nested_func_ptr_{created, deleted} symbol versions [PR113402]

2024-01-17 Thread Iain Sandoe
> On 17 Jan 2024, at 08:55, Iain Sandoe wrote: > > Tested on x86_64, aarch64 Darwin21 (which default to heap-based trampolines) > and on x86_64 Darwin19 and Linux (which default to executable stack > trampolines). > OK for trunk? Hmm.. maybe this is not right and the builti

[PATCH v2] Fix __builtin_nested_func_ptr_{created, deleted} symbol versions [PR113402]

2024-01-17 Thread Iain Sandoe
and then move __gcc_nested_func_ptr_created and __gcc_nested_func_ptr_deleted from this symbol version to ... (GCC_14.0.0): ... this one. Signed-off-by: Iain Sandoe Co-authored-by: Jakub Jelinek --- gcc/builtins.def| 4 ++-- gcc/doc/invoke.t

[PATCH] lto, Darwin: Fix offload section names.

2024-01-16 Thread Iain Sandoe
ach. gcc/ChangeLog: * lto-section-names.h (OFFLOAD_SECTION_NAME_PREFIX, OFFLOAD_VAR_TABLE_SECTION_NAME, OFFLOAD_FUNC_TABLE_SECTION_NAME, OFFLOAD_IND_FUNC_TABLE_SECTION_NAME): Provide Mach-O syntax versions when the object format is Mach-O. Signed-off-by: Iain San

[PATCH] testsuite, jit, Darwin: Add libSystem to a test.

2024-01-16 Thread Iain Sandoe
Log: * jit.dg/test-ggc-bugfix.c: Add libSystem for Darwin. Signed-off-by: Iain Sandoe --- gcc/testsuite/jit.dg/test-ggc-bugfix.c | 5 + 1 file changed, 5 insertions(+) diff --git a/gcc/testsuite/jit.dg/test-ggc-bugfix.c b/gcc/testsuite/jit.dg/test-ggc-bugfix.c index 59eb374af8b..fb857fbf

[PATCH] testsuite, jit: Stabilize error output.

2024-01-16 Thread Iain Sandoe
ter error output to remove per-run variable content. Signed-off-by: Iain Sandoe --- gcc/testsuite/jit.dg/jit.exp | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/gcc/testsuite/jit.dg/jit.exp b/gcc/testsuite/jit.dg/jit.exp index 286cfa8192a..893ff5f6

[PATCH] jit, Darwin: Implement library exports list.

2024-01-16 Thread Iain Sandoe
(we are not bumping the SO name at this stage). This fixes a number of new failures in jit testing. gcc/jit/ChangeLog: * Make-lang.in: Implement exports list, and use a shared libgcc. * libgccjit.exp: New file. Signed-off-by: Iain Sandoe --- gcc/jit/Make-lang.i

[PATCH 3/4] testsuite, jit: Allow for target-specific assembler scans.

2024-01-13 Thread Iain Sandoe
} } } } or ... { jit-verify-assembler-output ".." { target *-*-darwin* } } } gcc/testsuite/ChangeLog: * jit.dg/jit.exp: Accept target clauses in jit-verify-assembler handling. Signed-off-by: Iain Sandoe --- gcc/testsuite/jit.dg/jit.exp | 28

[PATCH 4/4] testsuite,jit: Handle Darwin/Mach-O in assembler tests.

2024-01-13 Thread Iain Sandoe
: Iain Sandoe --- gcc/testsuite/jit.dg/test-always_inline-attribute.c | 10 +++--- gcc/testsuite/jit.dg/test-noinline-attribute.c | 10 +++--- gcc/testsuite/jit.dg/test-setting-alignment.c | 3 ++- gcc/testsuite/jit.dg/test-used-attribute.c | 10 +++--- gcc/testsuite

[PATCH 2/4] testsuite, jit: Handle whitespace in test-link-section-assembler.c.

2024-01-13 Thread Iain Sandoe
arguments. Signed-off-by: Iain Sandoe --- gcc/testsuite/jit.dg/test-link-section-assembler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/testsuite/jit.dg/test-link-section-assembler.c b/gcc/testsuite/jit.dg/test-link-section-assembler.c index a90b00e9a82..a78e9fd26ef

[PATCH 1/4] testsuite, jit: test-alias-attribute.c requires alias support.

2024-01-13 Thread Iain Sandoe
Add a dg-require-alias to cover this. gcc/testsuite/ChangeLog: * jit.dg/test-alias-attribute.c: Require target alias support. Signed-off-by: Iain Sandoe --- gcc/testsuite/jit.dg/test-alias-attribute.c | 1 + 1 file changed, 1 insertion(+) diff --git a/gcc/testsuite/jit.dg

Jit testsuite updates for Darwin

2024-01-13 Thread Iain Sandoe
This is a short series of patches to support non-ELF targets in the jit tests where these use target-specific capabilities (e.g. alias support, or scanning for assembler directives.) An alternative would be to skip these tests for Darwin. Tested on x86_64 Darwin, and about to test Linux, OK for t

[pushed] Objective-C, Darwin: Fix a regression in handling bad receivers.

2024-01-12 Thread Iain Sandoe
ady error_mark_node. gcc/objc/ChangeLog: * objc-next-runtime-abi-02.cc (build_v2_objc_method_fixup_call): Early exit for cases where the sender or receiver are known to be in error. Signed-off-by: Iain Sandoe --- gcc/objc/objc-next-runtime-abi-02.cc | 2 ++ 1 file changed

[pushed] Darwin, powerpc: Fix bootstrap.

2024-01-12 Thread Iain Sandoe
sed diagnostics class member name for abort of error. Signed-off-by: Iain Sandoe --- gcc/config/rs6000/host-darwin.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/config/rs6000/host-darwin.cc b/gcc/config/rs6000/host-darwin.cc index 691dcb39b6d..e0001776339 100644 --- a/gcc/con

Re: [RFC] Either fix or disable SME feature for `aarch64-w64-mingw32` target?

2024-01-10 Thread Iain Sandoe
> On 10 Jan 2024, at 09:02, Iain Sandoe wrote: >> On 10 Jan 2024, at 08:49, Jonathan Yong <10wa...@gmail.com> wrote: >> >> On 1/9/24 19:37, Radek Barton wrote: >>> Hello. >>> I forgot to add the target maintainers to the CC. My apologies for tha

Re: [RFC] Either fix or disable SME feature for `aarch64-w64-mingw32` target?

2024-01-10 Thread Iain Sandoe
> On 10 Jan 2024, at 08:49, Jonathan Yong <10wa...@gmail.com> wrote: > > On 1/9/24 19:37, Radek Barton wrote: >> Hello. >> I forgot to add the target maintainers to the CC. My apologies for that. >> Furthermore, I am adding also relevant changes in >> `libgcc/config/aarch64/lse.S` file to the

Re: c++/modules: Emit definitions of ODR-used static members imported from modules [PR112899]

2024-01-08 Thread Iain Sandoe
> On 6 Jan 2024, at 22:30, Nathan Sidwell wrote: > > Richard Smith & I discussed whether we should use the module interface's > capability of giving vague linkage entities a strong location. I didn't want > to go messing with that, 'cos it was changing yet more stuff. > > But, perhaps we sh

Re: Backport of "fixincludes: Update darwin_flt_eval_method for macOS 14"

2023-12-11 Thread Iain Sandoe
Hi FX, > On 11 Dec 2023, at 11:37, FX Coudert wrote: > I’d like to backport the fixincludes for macOS 14 SDK at > https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=93f803d53b5ccaabded9d7b4512b54da81c1c616 > to the active branches, i.e. 13, 12 and 11 (unless I am mistaken). > > The fix has been th

<    1   2   3   4   5   6   7   8   9   10   >