Re: [PATCH] Testsuite, asan, darwin: Adjust output pattern

2023-12-11 Thread Iain Sandoe
Hi FX, > On 11 Dec 2023, at 08:43, FX Coudert wrote: > > Since the last import from upstream libsanitizer, the output has changed > and now looks more like this: > > READ of size 6 at 0x7ff7beb2a144 thread T0 >#0 0x101cf7796 in MemcmpInterceptorCommon(void*, int (*)(void const*, void > con

Re: [PATCH] gcc: Disallow trampolines when -fhardened

2023-12-02 Thread Iain Sandoe
> On 2 Dec 2023, at 09:42, Martin Uecker wrote: > > >> Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? >> >> -- >8 -- >> It came up that a good hardening strategy is to disable trampolines >> which may require executable stack. Therefore the following patch >> adds -Werror=tram

Re: [11 PATCH] libiberty, Darwin: Fix a build warning. [PR112823]

2023-12-01 Thread Iain Sandoe
HI Sam, I think this qualifies as obvious (it’s on my list, but I did not get to it yet, so go ahead). Iain > On 2 Dec 2023, at 05:30, Sam James wrote: > > From: Iain Sandoe > > r12-3005-g220c410162ebece4f missed a cast for the set_32 call. > Fixed thus. > > Si

Re: [PATCH] ada: Fix Ada bootstrap on macOS

2023-12-01 Thread Iain Sandoe
> On 1 Dec 2023, at 15:14, Rainer Orth wrote: > > The recent warning changes broke Ada bootstrap on macOS: > > adaint.c: In function '__gnat_copy_attribs': > adaint.c:3336:10: error: implicit declaration of function 'utimes'; did you > mean 'utime'? [-Wimplicit-function-declaration] > 3336 |

Re: [r14-5930 Regression] FAIL: gcc.c-torture/compile/libcall-2.c -Os (test for excess errors) on Linux/x86_64

2023-12-01 Thread Iain Sandoe
Hi FX, > On 1 Dec 2023, at 13:55, FX Coudert wrote: > > That commit makes gcc.target/i386/libcall-1.c on darwin: > > FAIL: gcc.target/i386/libcall-1.c scan-assembler globl\t__divti3 > > because the pattern is not found, the only mention of divti3 in the generated > assembly is: > > LCFI0: >

Re: Darwin: Replace environment runpath with embedded [PR88590]

2023-11-30 Thread Iain Sandoe
Hi Ian > On 30 Nov 2023, at 19:43, Ian Lance Taylor wrote: > > On Sun, Oct 22, 2023 at 2:18 PM FX Coudert wrote: >> >> Thanks a lot Alexandre for the review! > > This patch changed the files lingo/configure.ac and libgo/configure. > Those files live in an upstream repository and should be cha

Re: [PATCH] Update GMP/MPFR/MPC/ISL/gettext to latest release

2023-11-26 Thread Iain Sandoe
> On 26 Nov 2023, at 14:24, Sebastian Huber > wrote: > > On 26.11.23 11:15, Iain Sandoe wrote: >>> On 26 Nov 2023, at 10:05, Sebastian >>> Huber wrote: >>> >>> On 26.11.23 01:35, Iain Sandoe wrote: >>>>> On 25 Nov 2023, at 21

Re: [PATCH] Update GMP/MPFR/MPC/ISL/gettext to latest release

2023-11-26 Thread Iain Sandoe
> On 26 Nov 2023, at 10:05, Sebastian Huber > wrote: > > On 26.11.23 01:35, Iain Sandoe wrote: >>> On 25 Nov 2023, at 21:44, Sebastian Huber >>> wrote: >>> >>> On 25.11.23 14:59, Richard Biener wrote: >>>> On Sat, Nov 25,

Re: [PATCH] Update GMP/MPFR/MPC/ISL/gettext to latest release

2023-11-25 Thread Iain Sandoe
> On 25 Nov 2023, at 21:44, Sebastian Huber > wrote: > > On 25.11.23 14:59, Richard Biener wrote: >> On Sat, Nov 25, 2023 at 12:26 PM Sebastian Huber >> wrote: >>> contrib/ChangeLog >> Did you verify an in-tree build with these works and the testsuite >> is clean? > > I was able to build a

Re: [PATCH] testsuite, lib: Re-allow mulitple function start labels.

2023-11-23 Thread Iain Sandoe
Hi > On 23 Nov 2023, at 16:11, Christophe Lyon wrote: > > Hi Iain, > > Thanks for dealing with this :-) > > On Thu, 23 Nov 2023 at 10:58, Iain Sandoe wrote: >> >> Tested on a cross to armv8l-unknown-linux-gnueabihf where the failing >> testcase is r

[PATCH] testsuite, lib: Re-allow mulitple function start labels.

2023-11-23 Thread Iain Sandoe
y incorrect case should be easily evident in the assembler). gcc/testsuite/ChangeLog: * lib/scanasm.exp: Allow multiple function start symbols, taking the last as the function name. Signed-off-by: Iain Sandoe --- gcc/testsuite/lib/scanasm.exp | 10 +- 1 file changed, 9 in

Re: [PATCH] testsuite, Darwin: Add support for Mach-O function body scans.

2023-11-23 Thread Iain Sandoe
Hi Christophe. > On 23 Nov 2023, at 09:02, Christophe Lyon wrote: > > Hi Iain, > > On Mon, 6 Nov 2023 at 11:58, Richard Sandiford > wrote: >> >> Iain Sandoe writes: >>> Hi Richard, >>> >>>> On 5 Nov 2023, at 12:11, Ri

Re: [PATCH] Fix PR ada/111909 On Darwin, determine filesystem case sensitivity at runtime

2023-11-22 Thread Iain Sandoe
> On 22 Nov 2023, at 14:48, Iain Sandoe wrote: > > > >> On 22 Nov 2023, at 13:55, Arnaud Charlet wrote: >> >>>>> #if defined (__APPLE__) >>>>> -#include >>>> >>>> If removing unistd.h is intentional (i.e. yo

[pushed] testsuite: Update path to intl include.

2023-11-22 Thread Iain Sandoe
tly. gcc/testsuite/ChangeLog: * lib/plugin-support.exp: Update the expected path to an in-tree build of libintl. Signed-off-by: Iain Sandoe --- gcc/testsuite/lib/plugin-support.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/testsuite/lib/plu

Re: [PATCH] Fix PR ada/111909 On Darwin, determine filesystem case sensitivity at runtime

2023-11-22 Thread Iain Sandoe
> On 22 Nov 2023, at 13:55, Arnaud Charlet wrote: > #if defined (__APPLE__) -#include >>> >>> If removing unistd.h is intentional (i.e. you determined that it’s no longer >>> needed for Darwin), then we should make that a separate patch. >> >> I thought that I’d had to include uni

Re: Darwin: Replace environment runpath with embedded [PR88590]

2023-11-22 Thread Iain Sandoe
Hi FX, > On 17 Nov 2023, at 14:20, FX Coudert wrote: > >>> I have done a full rebuild, and having looked more at the structure of >>> libtool.m4 I am now convinced that having that line outside of the scope of >>> _LT_DARWIN_LINKER_FEATURES is simply wrong (probably a copy-pasto or >>> leftov

Re: [PATCH] Fix PR ada/111909 On Darwin, determine filesystem case sensitivity at runtime

2023-11-21 Thread Iain Sandoe
ote: > > On 21 Nov 2023, at 11:22, Iain Sandoe wrote: >> >> Hello Simon, Arno, >> >>> On 17 Nov 2023, at 13:43, Simon Wright wrote: >>> >>>> >>>>> Apple’s naming is definitely confusing in this area! >>>>> &

Re: [PATCH 1/4] libsanitizer: merge from upstream (c425db2eb558c263)

2023-11-21 Thread Iain Sandoe
Hi FX > On 17 Nov 2023, at 11:57, FX Coudert wrote: > >> If they accept it say within a day, wait for it + cherry-pick to GCC, >> otherwise apply to GCC as a local patch in anticipation they accept it. >> If it is all that fixes Darwin support, great. > > With that patch, I can finish bootstrap

Re: [PATCH] Fix PR ada/111909 On Darwin, determine filesystem case sensitivity at runtime

2023-11-21 Thread Iain Sandoe
Hello Simon, Arno, > On 17 Nov 2023, at 13:43, Simon Wright wrote: > >> >>> Apple’s naming is definitely confusing in this area! >>> >>> In current SDKs, TARGET_OS_MAC means code is being generated for a Mac OS X >>> variant, >>> which covers OSX, IOS, Watch … ; to determine which kind of de

Re: gfortran.dg/dg.exp debug messages pollute test output

2023-11-13 Thread Iain Sandoe
386-pc-solaris2.11/./libatomic/.libs > > (quite a number of instances). Those messages are from > gfortran.dg/dg.exp, introduced by your patch > > commit a0673ec5f9236dca6ada23f28343c591ccd575e4 > Author: Iain Sandoe > Date: Fri Apr 16 20:01:40 2021 +0100 > >Testsu

[PATCH 3/4] c-family, C++: Handle clang attributes [PR109877].

2023-11-12 Thread Iain Sandoe
attributes. (cp_parser_gnu_attribute_list): Switch to clang-form parsing where needed. * parser.h : New flag to signal lexing clang-form attributes. Signed-off-by: Iain Sandoe --- gcc/cp/parser.cc | 230 +-- gcc/cp/parser.h | 3 + 2 fil

[PATCH 4/4] Darwin: Implement clang availability attribute [PR109877].

2023-11-12 Thread Iain Sandoe
UM_AV_OSES, NUM_AV_CLAUSES): New. (darwin_handle_availability_attribute): New. (darwin_attribute_takes_identifier_p): New. (darwin_override_options): New. * config/darwin.h (TARGET_ATTRIBUTE_TAKES_IDENTIFIER_P): New. Signed-off-by: Iain Sandoe --- gcc/config/darwi

[PATCH 2/4] c-family, C: handle clang attributes [PR109877].

2023-11-12 Thread Iain Sandoe
ents): New. (c_parser_gnu_attribute): Allow for clang-form GNU-style attributes. Signed-off-by: Iain Sandoe --- gcc/c-family/c-lex.cc | 15 ++ gcc/c-family/c-pragma.h | 3 ++ gcc/c/c-parser.cc | 109 ++-- 3 files changed, 122 insertions(+), 5 deletions(-) di

[PATCH 1/4] c-family: Add handling for clang-style attributes [PR109877].

2023-11-12 Thread Iain Sandoe
rval enclosing the attribute arguments of cases notified as 'clang-form'. PR c++/109877 gcc/c-family/ChangeLog: * c-attribs.cc (attribute_clang_form_p): New. * c-common.h (attribute_clang_form_p): New. Signed-off-by: Iain Sandoe --- gcc/c-family/c-attribs.cc | 12

[no subject]

2023-11-12 Thread Iain Sandoe
This patch set is not actually particulalry new, I have been maintaining it locally one Darwin branches and it has been tested on several versions of Darwin both with and without Alex's __has_{feature, extension} patch. This is one of the three most significant blockers to importing the macOS SDKs

Re: [PATCH] Fix PR ada/111909 On Darwin, determine filesystem case sensitivity at runtime

2023-11-11 Thread Iain Sandoe
> On 11 Nov 2023, at 07:47, Simon Wright wrote: > > On 6 Nov 2023, at 08:36, Arnaud Charlet wrote: >> So without changing fundamentally the model, you can't decide dynamically for the whole system. Making the choice based on the current directory is pretty random, since

Re: [PATCH] testsuite, Darwin: Add support for Mach-O function body scans.

2023-11-05 Thread Iain Sandoe
Hi Richard, > On 5 Nov 2023, at 12:11, Richard Sandiford wrote: > > Iain Sandoe writes: >>> On 26 Oct 2023, at 21:00, Iain Sandoe wrote: >> >>>> On 26 Oct 2023, at 20:49, Richard Sandiford >> wrote: >>>> >>>> Iain Sandoe

Re: [PATCH] Testsuite, i386: Mark test as requiring dfp

2023-11-05 Thread Iain Sandoe
Hi FX > On 5 Nov 2023, at 10:33, FX Coudert wrote: > > kind ping for this easy patch IMO adding feature tests for features required by a test falls into the “obvious” category, Iain > > >> Le 30 oct. 2023 à 15:19, FX Coudert a écrit : >> >> Hi, >> >> The test is currently failing on x86

Re: [PATCH] Fix PR ada/111909 On Darwin, determine filesystem case sensitivity at runtime

2023-11-04 Thread Iain Sandoe
Hi Folks > On 4 Nov 2023, at 17:02, Simon Wright wrote: > > On 3 Nov 2023, at 08:39, Arnaud Charlet wrote: >> So without changing fundamentally the model, you can't decide dynamically >> for the whole >> system. Making the choice based on the current directory is pretty random, >> since the

Re: [PATCH] Fix PR ada/111909 On Darwin, determine filesystem case sensitivity at runtime

2023-10-31 Thread Iain Sandoe
Hi Simon, (please cc me on Darwin-related patches) > On 29 Oct 2023, at 11:51, Simon Wright wrote: > > This change affects only Ada. > > In gcc/ada/adaint.c(__gnat_get_file_names_case_sensitive), the > assumption for __APPLE__ is that file names are case-insensitive > unless __arm__ or __arm64

Re: Darwin: Replace environment runpath with embedded [PR88590]

2023-10-30 Thread Iain Sandoe
Hi Folks > On 30 Oct 2023, at 16:31, FX Coudert wrote: > >> +enable_darwin_at_rpath_$1=no > > I actually don’t understand why this one would have $1 in the name, unlike > all other regenerated configure files. What value do we expect for $1 at this > point in the file? That’s just plain weird

Re: Darwin: Replace environment runpath with embedded [PR88590]

2023-10-30 Thread Iain Sandoe
Hi Martin, > On 30 Oct 2023, at 16:17, Martin Jambor wrote: > On Tue, Aug 15 2023, FX Coudert via Gcc-patches wrote: >> > > [...] > >> From e1cf04cadb9fa065fb3f7d6bccf9ed6f1e9e3fc1 Mon Sep 17 00:00:00 2001 >> From: Iain Sandoe >> Date: Sun, 28 Mar 202

Re: [PATCH] Testsuite, Darwin: Fix trampoline warning

2023-10-30 Thread Iain Sandoe
Hi FX, > On 30 Oct 2023, at 13:50, FX Coudert wrote: > > Heap-based trampolines are enabled on darwin20 and later, meaning that no > warning is emitted. > Fixes the test failure on x86_64-apple-darwin21 > > OK to push? OK, thanks Iain

Re: [PATCH] Testsuite, i386: Fix test by passing -march

2023-10-30 Thread Iain Sandoe
> On 30 Oct 2023, at 11:53, FX Coudert wrote: > The newly introduced test gcc.target/i386/pr111698.c currently fails on > Darwin, where the default arch is core2. > Andrew suggested in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112287 to > pass a recent value to -march, and I can confirm t

Re: [PATCH] Testsuite, Darwin: skip PIE test

2023-10-30 Thread Iain Sandoe
HI FX, > On 30 Oct 2023, at 11:43, FX Coudert wrote: > The recent commit of > https://gcc.gnu.org/pipermail/gcc-patches/2023-October/634347.html has made > this test invalid. We now don’t emit __PIE__, and the test should be skipped > on darwin. > > Fixes the new failure on x86_64-apple-darw

[PATCH] testsuite, x86: Handle a broken assembler.

2023-10-29 Thread Iain Sandoe
gcc/testsuite/ChangeLog: * lib/target-supports.exp: Test an asm line that fails on broken Darwin assembler versions. Signed-off-by: Iain Sandoe --- gcc/testsuite/lib/target-supports.exp | 1 + 1 file changed, 1 insertion(+) diff --git a/gcc/testsuite/lib/target-supports.exp b/

[pushed] testsuite, X86, Darwin: Skip a test for mcmodel=large.

2023-10-29 Thread Iain Sandoe
Tested on x86_64-darwin, pushed to trunk, thanks Iain --- 8< --- The large model is not implemented so far for Darwin (and the codegen will be different when it is). gcc/testsuite/ChangeLog: * gcc.target/i386/large-data.c: Skip for Darwin. Signed-off-by: Iain Sandoe ---

[pushed] testsuite, X86, Darwin: Skip tests with incompatible output.

2023-10-29 Thread Iain Sandoe
2-1.c: Likewise. * gcc.target/i386/apx-push2pop2_force_drap-1.c: Likewise. Signed-off-by: Iain Sandoe --- gcc/testsuite/gcc.target/i386/apx-interrupt-1.c| 1 + gcc/testsuite/gcc.target/i386/apx-push2pop2-1.c| 1 + gcc/testsuite/gcc.target/i386/apx-push2pop2_force_d

Re: Ping: [PATCH v2 0/2] Replace intl/ with out-of-tree GNU gettext

2023-10-28 Thread Iain Sandoe
Hi Arsen, > On 28 Oct 2023, at 10:22, Arsen Arsenović wrote: > Andrew Pinski writes: > >> One comment from me. It would be nice to update install.texi in >> gcc/doc/ to make a mention of this requirement for non-glibc hosts. > > What do you think of the following: The hiccup for me is that w

Re: [PATCH] testsuite, aarch64: Normalise options to aarch64.exp.

2023-10-27 Thread Iain Sandoe
Hi Andrew, > On 26 Oct 2023, at 20:00, Andrew Pinski wrote: > > On Thu, Oct 26, 2023 at 11:58 AM Iain Sandoe wrote: >> >> tested on cfarm185 (aarch64-linux-gnu, xgene1) and with the aarch64 >> Darwin prototype. It is possible that some initial fallout could o

Re: [PATCH] testsuite, Darwin: Add support for Mach-O function body scans.

2023-10-27 Thread Iain Sandoe
Hi Richard, > On 26 Oct 2023, at 21:00, Iain Sandoe wrote: >> On 26 Oct 2023, at 20:49, Richard Sandiford >> wrote: >> >> Iain Sandoe writes: >>> This was written before Thomas' modification to the ELF-handling to allow >>> a config-based c

Re: [PATCH v2 2/4] libgrust: Add libproc_macro and build system

2023-10-27 Thread Iain Sandoe
> On 26 Oct 2023, at 09:21, Thomas Schwinge wrote: > > Hi! > > First, I've pushed into GCC upstream Git branch devel/rust/libgrust-v2 > the "v2" libgrust changes as posted by Arthur, so that people can easily > test this before it getting into Git master branch. > > I'll myself later try this

Re: [PATCH] testsuite, Darwin: Add support for Mach-O function body scans.

2023-10-26 Thread Iain Sandoe
Hi Richard, > On 26 Oct 2023, at 20:49, Richard Sandiford wrote: > > Iain Sandoe writes: >> This was written before Thomas' modification to the ELF-handling to allow >> a config-based change for target details. I did consider updating this >> to try and use

[PATCH] aarch64: Make assembler bug workaround configurable.

2023-10-26 Thread Iain Sandoe
ase architecture supports it. However, that also triggers a different bug in another assembler. So make the fix configurable. gcc/ChangeLog: * common/config/aarch64/aarch64-common.cc: Make the asm crc bug workaround configurable. Signed-off-by: Iain Sandoe --- gcc/common/con

[PATCH] testsuite, Darwin: Add support for Mach-O function body scans.

2023-10-26 Thread Iain Sandoe
not delineate functions when frame output is switched off. TODO: consider adding -mtest-markers or something similar to inject assembler comments that can be scanned for. gcc/testsuite/ChangeLog: * lib/scanasm.exp: Initial handling for Mach-O function body scans. Signed-off-by: Iain San

[PATCH] testsuite, aarch64: Normalise options to aarch64.exp.

2023-10-26 Thread Iain Sandoe
lts. e.g. for --with-cpu=xgene1 we see over 100 excess fails which are removed by this change. gcc/testsuite/ChangeLog: * gcc.target/aarch64/aarch64.exp: Use aarch64-with-arch-dg-options to normaize the options to the tests in aarch64.exp. Signed-off-by: Iain Sandoe ---

[pushed] Darwin: Make metadata symbol lables linker-visible for GNU objc.

2023-10-26 Thread Iain Sandoe
for NeXT the names are in separate sections). gcc/ChangeLog: * config/darwin.h (darwin_label_is_anonymous_local_objc_name): Make metadata names linker-visibile for GNU objective C. Signed-off-by: Iain Sandoe --- gcc/config/darwin.h | 2 +- 1 file changed, 1 insertion(+)

[PATCH] Darwin: Handle the fPIE option specially.

2023-10-26 Thread Iain Sandoe
ime change. For almost all Darwin, we do not report __PIE__; the exception is 32bit X86 and from Darwin12 to 17 only (32 bit is no longer supported after Darwin17). gcc/ChangeLog: * config/darwin.cc (darwin_override_options): Handle fPIE. Signed-off-by: Iain Sandoe --- gcc/config/darwin

Re: [PATCH v3] gcc: Introduce -fhardened

2023-10-24 Thread Iain Sandoe
> On 24 Oct 2023, at 20:03, Marek Polacek wrote: > > On Tue, Oct 24, 2023 at 10:34:22AM +0100, Iain Sandoe wrote: >> hi Marek, >> >>> On 24 Oct 2023, at 08:44, Iain Sandoe wrote: >>> On 23 Oct 2023, at 20:25, Marek Polacek wrote: >>>> >

[PATCH] config, aarch64: Use a more compatible sed invocation.

2023-10-24 Thread Iain Sandoe
ent, since we should only require a Posix sed (but it seems supported for BSD-derivatives). gcc/ChangeLog: * config.gcc: Use -E to to sed to indicate that we are using extended REs. Signed-off-by: Iain Sandoe --- gcc/config.gcc | 12 ++-- 1 file changed, 6 insertions(+)

Re: [PATCH v3] gcc: Introduce -fhardened

2023-10-24 Thread Iain Sandoe
hi Marek, > On 24 Oct 2023, at 08:44, Iain Sandoe wrote: > On 23 Oct 2023, at 20:25, Marek Polacek wrote: >> >> On Thu, Oct 19, 2023 at 02:24:11PM +0200, Richard Biener wrote: >>> On Wed, Oct 11, 2023 at 10:48 PM Marek Polacek wrote: >>>> >>>&

Re: [PATCH v3] gcc: Introduce -fhardened

2023-10-24 Thread Iain Sandoe
Hi Marek, > On 23 Oct 2023, at 20:25, Marek Polacek wrote: > > On Thu, Oct 19, 2023 at 02:24:11PM +0200, Richard Biener wrote: >> On Wed, Oct 11, 2023 at 10:48 PM Marek Polacek wrote: >>> >>> On Tue, Sep 19, 2023 at 10:58:19AM -0400, Marek Polacek wrote: On Mon, Sep 18, 2023 at 08:57:39AM

[pushed] configure, libquadmath: Remove unintended AC_CHECK_LIBM [PR111928]

2023-10-23 Thread Iain Sandoe
--- 8< --- This was a rebase error, that managed to pass testing on Darwin and Linux (but fails on bare metal). PR libquadmath/111928 libquadmath/ChangeLog: * Makefile.in: Regenerate. * configure: Regenerate. * configure.ac: Remove AC_CHECK_LIBM. Signed-off-by: I

Re: [PATCH] libgcc: make heap-based trampolines conditional on libc presence

2023-10-23 Thread Iain Sandoe
hi Sergei, > On 23 Oct 2023, at 13:43, Sergei Trofimovich wrote: > > From: Sergei Trofimovich > > To build `libc` for a target one needs to build `gcc` without `libc` > support first. Commit r14-4823-g8abddb187b3348 "libgcc: support > heap-based trampolines" added unconditional `libc` dependen

Re: Darwin: Replace environment runpath with embedded [PR88590]

2023-10-21 Thread Iain Sandoe
Hi Jeff, > On 21 Oct 2023, at 19:05, Jeff Law wrote: > On 10/8/23 16:14, Iain Sandoe wrote: >> + Jeff >>> On 8 Oct 2023, at 14:07, Nathanael Nerode wrote: >>> >>> I hope a global maintainer can step up. I've been on hiatus from GCC work >>&

[pushed] Darwin: Check as for .build_version support and use it if available.

2023-10-18 Thread Iain Sandoe
* configure: Regenerate. * configure.ac: Check for assembler support of .build_version directives. Signed-off-by: Iain Sandoe --- gcc/config.in| 6 ++ gcc/config/darwin.cc | 34 -- gcc/configure| 33 ++

Re: [PATCH] Fix coroutine tests for libstdc++ gnu-version-namespace mode

2023-10-11 Thread Iain Sandoe
Hi François, > On 11 Oct 2023, at 05:49, François Dumont wrote: > On 08/10/2023 15:59, Iain Sandoe wrote: >>> On 23 Sep 2023, at 21:10, François Dumont wrote: >>> >>> I'm eventually fixing those tests the same way we manage this problem in >>>

Re: [PATCH] sso-string@gnu-versioned-namespace [PR83077]

2023-10-09 Thread Iain Sandoe
> On 9 Oct 2023, at 15:42, Iain Sandoe wrote: >> On 7 Oct 2023, at 20:32, François Dumont wrote: >> >> I've been told that previous patch generated with 'git diff -b' was not >> applying properly so here is the same patch again with a simple '

Re: [PATCH] sso-string@gnu-versioned-namespace [PR83077]

2023-10-09 Thread Iain Sandoe
Hi François, > On 7 Oct 2023, at 20:32, François Dumont wrote: > > I've been told that previous patch generated with 'git diff -b' was not > applying properly so here is the same patch again with a simple 'git diff'. Thanks, that did fix it - There are some training whitespaces in the config

Re: [PATCH][_GLIBCXX_INLINE_VERSION] Fix

2023-10-09 Thread Iain Sandoe
e. Thanks; works for me, (g++ tests with your patches + a local one to enable versioned-namespace on Darwin). Iain > > François > > > On 08/10/2023 16:06, Iain Sandoe wrote: >> Hi François, >> >>> On 21 Sep 2023, at 05:41, François Dumont wrote: >>>

Re: Darwin: Replace environment runpath with embedded [PR88590]

2023-10-08 Thread Iain Sandoe
+ Jeff > On 8 Oct 2023, at 14:07, Nathanael Nerode wrote: > > I hope a global maintainer can step up. I've been on hiatus from GCC work > for some years, and this was never my part of the build system anyway -- and > I don't use Darwin -- so I'm not qualified to review it. It looks fine but

Re: [PATCH][_GLIBCXX_INLINE_VERSION] Fix

2023-10-08 Thread Iain Sandoe
Hi François, > On 21 Sep 2023, at 05:41, François Dumont wrote: > > Tests were successful, ok to commit ? > > On 20/09/2023 19:51, François Dumont wrote: >> libstdc++: [_GLIBCXX_INLINE_VERSION] Add handle_contract_violation symbol >> alias >> >> libstdc++-v3/ChangeLog: >> >> * src/experi

Re: [PATCH] Fix coroutine tests for libstdc++ gnu-version-namespace mode

2023-10-08 Thread Iain Sandoe
Hi François, > On 23 Sep 2023, at 21:10, François Dumont wrote: > > I'm eventually fixing those tests the same way we manage this problem in > libstdc++ testsuite. > >testsuite: Add optional libstdc++ version namespace in expected diagnostic > > When libstdc++ is build with --enable-s

Re: [PATCH] Support g++ 4.8 as a host compiler.

2023-10-08 Thread Iain Sandoe
> On 8 Oct 2023, at 05:40, Jeff Law wrote: > On 10/7/23 15:30, Sam James wrote: >> Jeff Law writes: >>> On 10/4/23 16:19, Roger Sayle wrote: The recent patch to remove poly_int_pod triggers a bug in g++ 4.8.5's C++ 11 support which mistakenly believes poly_uint16 has a non-trivi

[pushed] contrib: Update Darwin entries in config-list.mk

2023-10-02 Thread Iain Sandoe
ilers. Signed-off-by: Iain Sandoe --- contrib/config-list.mk | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/contrib/config-list.mk b/contrib/config-list.mk index e570b13c71b..c090be13147 100644 --- a/contrib/config-list.mk +++ b/contrib/config-list

[pushed] testsuite, Darwin: Skip g++.dg/debug/dwarf2/pr85550.C

2023-10-02 Thread Iain Sandoe
ise DW_FORM_ref_sig8. Disable ths test until we get DWARF-5 support in the external Darwin toolchain components. gcc/testsuite/ChangeLog: * g++.dg/debug/dwarf2/pr85550.C: Skip for Darwin. Signed-off-by: Iain Sandoe --- gcc/testsuite/g++.dg/debug/dwarf2/pr85550.C | 1 + 1 file changed, 1 insert

[pushed] Darwin, configure: Allow for an unrecognisable dsymutil [PR111610].

2023-09-27 Thread Iain Sandoe
ename this to DET_UNKNOWN (for Darwin External Toolchain). PR target/111610 gcc/ChangeLog: * configure: Regenerate. * configure.ac: Rename the missing dsymutil case to "DET_UNKNOWN". Signed-off-by: Iain Sandoe --- gcc/configure| 2 +- gcc/configure.ac | 2 +- 2 file

[pushed] Darwin: Handle -dynamiclib on cc1 lines.

2023-09-26 Thread Iain Sandoe
n.h (DARWIN_CC1_SPEC): Remove -dynamiclib. Signed-off-by: Iain Sandoe --- gcc/config/darwin.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/config/darwin.h b/gcc/config/darwin.h index 61e46f76b22..2ee66c1a3d1 100644 --- a/gcc/config/darwin.h +++ b/gcc/config/darwin.h @@ -30

[pushed] Darwin: Move checking of the 'shared' driver spec.

2023-09-20 Thread Iain Sandoe
Tested on x86_64-darwin21, pushed to trunk, thanks Iain --- 8< --- This avoids a bunch of irrelevant diagnostics if the user passes '-shared' to gnatmake. Currently, we push '-dynamiclib' back onto the command line (since that is the Darwin spelling of 'shared') but this is not handled by gnat1,

[pushed] Darwin, debug : Switch to DWARF 3 or 4 when dsymutil supports it.

2023-09-18 Thread Iain Sandoe via Gcc-patches
sed off a closed source base "dwarfutils" and those based off LLVM. For dsymutil versions based off LLVM-7+ we can use up to DWARF-4, and for versions based on dwarfutils 121+ we can use DWARF-3. Signed-off-by: Iain Sandoe gcc/ChangeLog: * config/darwin-protos.h (enum darwi

[pushed] configure, Darwin: Adjust handing of stdlib option.

2023-09-18 Thread Iain Sandoe via Gcc-patches
lative to the compiler install (similar logic to that used for libstdc++ headers). Signed-off-by: Iain Sandoe gcc/ChangeLog: * configure: Regenerate. * configure.ac: Handle explict disable of stdlib option, set defaults for Darwin. --- gcc/conf

Re: [PATCH] core: Support heap-based trampolines

2023-09-16 Thread Iain Sandoe
Hi Richard, > On 14 Sep 2023, at 11:18, Richard Biener wrote: > > On Wed, Sep 6, 2023 at 5:44 PM FX Coudert wrote: >> >> ping**2 on the revised patch, for Richard or another global reviewer. So far >> all review feedback is that it’s a step forward, and it’s been widely used >> for both aar

Re: gcc-patches From rewriting mailman settings (Was: [Linaro-TCWG-CI] gcc patch #75674: FAIL: 68 regressions)

2023-09-13 Thread Iain Sandoe
Hi Mark, > On 12 Sep 2023, at 16:00, Mark Wielaard wrote: > Adding Jeff to CC who is the official gcc-patches mailinglist admin. > > On Tue, 2023-09-12 at 11:08 +0400, Maxim Kuvyrkov wrote: >> Normally, notifications from Linaro TCWG precommit CI are sent only to >> patch author and patch submi

[pushed] Darwin: Partial reversion of r14-3648 (Inits Section).

2023-09-10 Thread Iain Sandoe via Gcc-patches
fig/darwin.cc (darwin_function_section): Place unlikely executed global init code into the standard cold section. Signed-off-by: Iain Sandoe --- gcc/config/darwin.cc | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/gcc/config/darwin.cc b/gcc/config/darwin

[pushed] Darwin, ppc: Add system stubs for all 32b PPC

2023-09-04 Thread Iain Sandoe via Gcc-patches
Tested on powerpc-darwin9, pushed to trunk, thanks Iain --- 8< --- This is a minor adjustment to make the GCC behaviour better match the old system tools. Signed-off-by: Iain Sandoe gcc/ChangeLog: * config/rs6000/darwin.h (LIB_SPEC): Include libSystemStubs for all 32b Dar

[PATCH] Darwin: Place global inits in the correct section.

2023-09-04 Thread Iain Sandoe via Gcc-patches
Tested on x86_64-darwin21, i686-darwin9, aarch64-darwin21 and powerpc-darwin9, pushed to trunk, thanks Iain --- 8< --- This handles placement of global initializers into __TEXT,__StaticInit as used by other platform toolchains. Signed-off-by: Iain Sandoe gcc/ChangeLog: * con

[pushed] Darwin: Match system sections and relocs for exception tables.

2023-09-04 Thread Iain Sandoe via Gcc-patches
in fact the tools there are equally happy with the revised scheme - and therefore at present there seems no reason to special-case it. Signed-off-by: Iain Sandoe gcc/ChangeLog: * config/darwin-sections.def (darwin_exception_section): Move to the __TEXT segment. * con

[pushed] Darwin, machopic: Debug printer for macho symbol flags.

2023-09-04 Thread Iain Sandoe via Gcc-patches
Tested on x86_64-darwin21 and i686-darwin9, pushed to trunk, thanks. Iain --- 8< --- There are now quite a few symbol flags, so it is sometimes useful to get them in a text form, rather than decoding the hex number printed by debug_rtx(). Signed-off-by: Iain Sandoe gcc/Change

Re: [PATCH] Darwin: homogenize spelling of macOS

2023-08-31 Thread Iain Sandoe
Hi FX, +Sandra > On 31 Aug 2023, at 12:13, FX Coudert wrote: > > This patch homogenizes to some extent the use of “Mac OS X” or “OS X” or “Mac > OS” in the gcc/ folder to “macOS”, which is the modern way of writing it. It > is not a global replacement though, and each use was audited. > > -

Re: [PATCH] Testsuite: mark IPA test as requiring alias support

2023-08-20 Thread Iain Sandoe
Hi FX, > On 20 Aug 2023, at 13:15, FX Coudert via Gcc-patches > wrote: > The fact that this test needs alias support was indicated in > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85656 but never committed. > Without it, the test fails on darwin. > > OK to commit? IMO, changes like this qu

Re: [PATCH] Testsuite: fix analyzer tests on Darwin

2023-08-19 Thread Iain Sandoe via Gcc-patches
Hi FX, thanks for chasing these fails down, > On 19 Aug 2023, at 22:28, FX Coudert wrote: > > gcc.dg/analyzer/ currently has 80 failures on Darwin (both > x86_64-apple-darwin and aarch64-apple-darwin). All those come from two issues: > > 1. Many tests use memset() without including the head

Re: Darwin: Replace environment runpath with embedded [PR88590]

2023-08-18 Thread Iain Sandoe via Gcc-patches
> On 18 Aug 2023, at 23:59, Joseph Myers wrote: > > On Fri, 18 Aug 2023, Iain Sandoe via Gcc-patches wrote: > >> There is quite extensive Apple Developer documentation on delivering >> packages with co-installed libraries using @rpath (that is the intended >>

Re: Darwin: Replace environment runpath with embedded [PR88590]

2023-08-18 Thread Iain Sandoe via Gcc-patches
Hi Joseph, > On 18 Aug 2023, at 21:17, Joseph Myers wrote: > > On Tue, 15 Aug 2023, FX Coudert via Gcc-patches wrote: > >> I am currently retesting the patches on various archs (Linux and Darwin) >> after a final rebase, but various previous versions were >> regression-tested, and have been s

Re: [PATCH] improve error for when /usr/include isn't found [PR90835]

2023-08-17 Thread Iain Sandoe
Hi Eric, thanks for working on this. > On 17 Aug 2023, at 20:35, Eric Gallager wrote: > > This is a pretty simple patch that ought to help Darwin users understand > better why their build is failing when they forget to pass the > --with-sysroot= flag to configure. > > gcc/ChangeLog: > >PR

Re: [PATCH v3][RFC] c-family: Implement __has_feature and __has_extension [PR60512]

2023-08-16 Thread Iain Sandoe
Hi Alex, > On 3 Aug 2023, at 10:21, Alex Coplan wrote: > > This patch implements clang's __has_feature and __has_extension in GCC. > This is a v3 which addresses feedback for the v2 patch posted here: > > https://gcc.gnu.org/pipermail/gcc-patches/2023-August/626058.html > > Main changes sinc

Re: [PATCH] fixincludes: Update darwin_flt_eval_method for macOS 14

2023-08-16 Thread Iain Sandoe
Hi Rainer, > On 16 Aug 2023, at 20:20, Rainer Orth wrote: > > On macOS 14, a guard in changed: > > -- MacOSX13.3.sdk/usr/include/math.h 2023-04-19 01:54:44 > +++ MacOSX14.0.sdk/usr/include/math.h 2023-08-01 08:42:43 > @@ -22,0 +23 @@ > + > @@ -43 +44 @@ > -#if __FLT_EVAL_METHOD__ == 0 > +#if

Re: [PATCH] build: Allow for Xcode 15 ld -v output

2023-08-16 Thread Iain Sandoe
Hi Rainer, > On 16 Aug 2023, at 20:13, Rainer Orth wrote: > > Since Xcode 15 beta 6, ld -v output differs from previous versions: > > * macOS 13/Xcode 14: > > @(#)PROGRAM:ld PROJECT:ld64-857.1 > > * macOS 14/Xcode 15: > > @(#)PROGRAM:ld PROJECT:dyld-1015.1 > > configure cannot handle th

Re: [PATCH] config-list.mk Darwin: Use --with-gnu-as

2023-08-15 Thread Iain Sandoe
Hi Jan-Benedict, > On 15 Aug 2023, at 20:36, Jan-Benedict Glaw wrote: > config-list.mk Darwin: Use --with-gnu-as for mass-building tests > > As `config-list.mk` is probably mostly used on Linux system, where > Apple's tools aren't around. Let's use --with-gnu-as instead to have > an useable as

[pushed] modula-2, plugin: Fix Darwin bootstrap issues.

2023-08-13 Thread Iain Sandoe via Gcc-patches
f Darwin, the linker complains if libSystem is not linked, so we disable all the default libs, but add libc back. Signed-off-by: Iain Sandoe gcc/m2/ChangeLog: * Make-lang.in: Update suffix spellings to use 'soext'. Add libc to the plugin link. --- gcc/m2/Make-lang.in |

Re: [PATCH 00/24] Sync shared build infrastructure with binutils-gdb

2023-08-08 Thread Iain Sandoe
Hi Joseph > On 8 Aug 2023, at 20:41, Joseph Myers wrote: > > On Tue, 8 Aug 2023, Arsen Arsenović via Gcc-patches wrote: > >> Yes. Libtool was forked over a decade ago. My next project is syncing >> upstream and us back up. Unsure about pkg.m4. > > Note as per previous discussions that libto

Re: [PATCH 4/9] vect: Adjust vectorizable_load costing on VMAT_ELEMENTWISE and VMAT_STRIDED_SLP

2023-07-22 Thread Iain Sandoe
Hi Kewen, This patch breaks bootstrap on powerpc-darwin (which has Altivec, but not VSX) while building libgfortran. > On 3 Jul 2023, at 04:19, Kewen.Lin via Gcc-patches > wrote: Please see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110776 thanks Iain

[pushed] Darwin: Handle linker '-demangle' option.

2023-07-21 Thread Iain Sandoe via Gcc-patches
Tested with Darwin linker versions that do/do not support the option and on x86_64-linux-gnu, pushed to trunk, thanks Iain --- 8< --- Most of the Darwin linkers in use support this option which we will now pass by default (matching the Xcode clang impl.)> Signed-off-by: Iain Sandoe

Re: [PATCH] core: Support heap-based trampolines

2023-07-19 Thread Iain Sandoe
Hi Martin, > On 19 Jul 2023, at 11:43, Martin Uecker via Gcc-patches > wrote: > > Am Mittwoch, dem 19.07.2023 um 10:29 +0100 schrieb Iain Sandoe: >>> On 19 Jul 2023, at 10:04, Martin Uecker >>> wrote: >> >>>>> On 17 Jul 2023, >>&

Re: [PATCH] core: Support heap-based trampolines

2023-07-19 Thread Iain Sandoe
Hi Martin, > On 19 Jul 2023, at 10:04, Martin Uecker wrote: >>> On 17 Jul 2023, >> > You mention setjmp/longjmp - on darwin and other platforms >> requiring non-stack based trampolines does the system runtime provide means to deal with this issue like >> an alternate alloc

Re: [PATCH] core: Support heap-based trampolines

2023-07-17 Thread Iain Sandoe
> On 17 Jul 2023, at 07:58, Iain Sandoe wrote > >> On 17 Jul 2023, at 07:43, FX Coudert wrote: >> >> >> There is an alternate mechanism relying on system libraries that is possible >> on darwin specifically (I don’t know for other targets) but it wi

Re: [PATCH] core: Support heap-based trampolines

2023-07-16 Thread Iain Sandoe
> On 17 Jul 2023, at 07:43, FX Coudert wrote: > > Hi, > >> Since this affects the ABI of libgcc I think we don't want that part >> to be user configurable but rather determined by >> some static list of targets that opt-in to this config. > > If I do that, do the Linux maintainers want Linux

[pushed] Darwin: Use -platform_version when available [PR110624].

2023-07-13 Thread Iain Sandoe via Gcc-patches
his replaces the functionality of '-mmacosx_version_min' (which is now deprecated, leading to the diagnostic described in the PR). We now use the platform_version flag when available which avoids the diagnostic. Signed-off-by: Iain Sandoe PR target/110624 gcc/ChangeLog:

Re: [PATCH][RFC] c-family: Implement __has_feature and __has_extension [PR60512]

2023-07-06 Thread Iain Sandoe
Hi Alex, > On 6 Jul 2023, at 15:01, Alex Coplan wrote: > > On 20/06/2023 15:08, Iain Sandoe wrote: >> again, thanks for working on this and for fixing the SDK blocker. >> >>> On 20 Jun 2023, at 13:30, Alex Coplan wrote: >>> >> >>> T

[pushed] testsuite, Darwin: Remove an unnecessary flags addition.

2023-07-03 Thread Iain Sandoe via Gcc-patches
ove it from the testsuite libs. Avoid duplicates in the specs. Signed-off-by: Iain Sandoe gcc/ChangeLog: * config/darwin.h: Avoid duplicate multiply_defined specs on earlier Darwin versions with shared libgcc. libstdc++-v3/ChangeLog: * testsuite/lib/libstdc++.exp: Rem

[pushed] Darwin, Objective-C: Support -fconstant-cfstrings [PR108743].

2023-07-02 Thread Iain Sandoe via Gcc-patches
The documentation is also updated to reflect that the 'f' option is only available on Darwin, and to add the 'm' option to the Darwin section of the invocation text. Signed-off-by: Iain Sandoe PR target/108743 gcc/ChangeLog: * config/darwin.opt: Add fcons

<    1   2   3   4   5   6   7   8   9   10   >