Re: [PING] genattrab.c generate switch

2016-03-04 Thread Jesper Broge Jørgensen
On 04/03/16 16:13, Bernd Schmidt wrote: On 03/04/2016 03:27 PM, Patrick Palka wrote: I still suggest to try making write_test_expr() avoid emitting redundant parentheses for chains of || or &&, which would fix the original issue all the same. Previously you claimed that such a change would

Re: [PING] genattrab.c generate switch

2016-03-03 Thread Jesper Broge Jørgensen
On 18/02/16 13:22, Bernd Schmidt wrote: On 01/19/2016 12:47 PM, Jesper Broge Jørgensen wrote: Here is the reformatted patch: This will probably have to wait until stage1. + const int code = GET_CODE (op2); + if (code != IOR) +{ + if (code == EQ_ATTR) All the formatting

Re: [PING] genattrab.c generate switch

2016-02-18 Thread Jesper Broge Jørgensen
On 18/02/16 13:22, Bernd Schmidt wrote: On 01/19/2016 12:47 PM, Jesper Broge Jørgensen wrote: Here is the reformatted patch: This will probably have to wait until stage1. + const int code = GET_CODE (op2); + if (code != IOR) +{ + if (code == EQ_ATTR) All the formatting

Re: [PING] genattrab.c generate switch

2016-02-17 Thread Jesper Broge Jørgensen
On 19/01/16 10:44, Richard Biener wrote: On Mon, Jan 18, 2016 at 7:48 PM, Jeff Law <l...@redhat.com> wrote: On 01/18/2016 07:09 AM, Jesper Broge Jørgensen wrote: Ping patch: https://gcc.gnu.org/ml/gcc-patches/2016-01/msg00784.html I'd put it in my gcc-7 queue. But if Richard, Bernd,

Re: genattrab.c generate switch

2016-02-01 Thread Jesper Broge Jørgensen
On 01/02/16 20:19, Patrick Palka wrote: On Tue, Jan 12, 2016 at 7:53 PM, Jesper Broge Jørgensen <jesperbr...@gmail.com> wrote: Hello genattrab.c can generate if statements that have very deep bracket nesting causing clang to produce errors (when target=arm-none-eabi) as explained at

Re: genattrab.c generate switch

2016-02-01 Thread Jesper Broge Jørgensen
On 19/01/16 13:18, Bernd Schmidt wrote: On 01/18/2016 11:44 PM, Jesper Broge Jørgensen wrote: I found a formatting tool called uncrustify that comes with a gnu style config https://github.com/bengardner/uncrustify/blob/master/etc/gnu-indent.cfg that needed a few tweaks to format code

Re: [PING] genattrab.c generate switch

2016-01-19 Thread Jesper Broge Jørgensen
On 19/01/16 10:44, Richard Biener wrote: On Mon, Jan 18, 2016 at 7:48 PM, Jeff Law <l...@redhat.com> wrote: On 01/18/2016 07:09 AM, Jesper Broge Jørgensen wrote: Ping patch: https://gcc.gnu.org/ml/gcc-patches/2016-01/msg00784.html I'd put it in my gcc-7 queue. But if Richard, Bernd,

Re: genattrab.c generate switch

2016-01-18 Thread Jesper Broge Jørgensen
On 18/01/16 15:15, Bernd Schmidt wrote: On 01/13/2016 01:53 AM, Jesper Broge Jørgensen wrote: genattrab.c can generate if statements that have very deep bracket nesting causing clang to produce errors (when target=arm-none-eabi) as explained at https://gcc.gnu.org/ml/gcc/2014-05/msg00032.html

[PING] genattrab.c generate switch

2016-01-18 Thread Jesper Broge Jørgensen
Ping patch: https://gcc.gnu.org/ml/gcc-patches/2016-01/msg00784.html thanks

Re: genattrab.c generate switch

2016-01-18 Thread Jesper Broge Jørgensen
On 18/01/16 18:39, Manuel López-Ibáñez wrote: On 18/01/16 14:39, Jesper Broge Jørgensen wrote: No i have not gone through copyright assignment. This is my first time trying to contribute to a GNU project so i have tried following the "Contributing to GCC"@ https://gcc.gnu.org/contr

genattrab.c generate switch

2016-01-12 Thread Jesper Broge Jørgensen
instead. I have made a patch that does just that. gcc/ChangeLog: 2016-01-13 Jesper Broge Jørgensen <jesperbr...@gmail.com> * genattrtab.c (check_attr_set_switch): implemented the function (write_attr_set): Check if expression can be written as a switch diff --git a/gcc/genattrtab.c