Re: [PATCH] Fixing SEH exceptions for languages != C++

2014-02-20 Thread Jonathan Schleifer
There is also definitely a use-after-free if you call _Unwind_DeleteException in your personality before returning _URC_INSTALL_CONTEXT (which you should, if you don't want to leak and your landing pad doesn't call it). I'm not sure though how to fix it. It seems the problem that register 0 is

Re: [PATCH] Fixing SEH exceptions for languages != C++

2014-02-19 Thread Jonathan Schleifer
Am Tue, 18 Feb 2014 17:51:00 +0100 schrieb Kai Tietz ktiet...@googlemail.com: So patch is ok with proper ChangeLog mentioning PR. Patch is ok for back-port too. I wonder if the instaned of RtlUnwindEx that come before the patched line should be changed as well, though. -- Jonathan

Re: [PATCH] Fixing SEH exceptions for languages != C++

2014-02-18 Thread Jonathan Schleifer
Am 18.02.2014 um 17:41 schrieb Kai Tietz ktiet...@googlemail.com: Hi Mike, the patch is reasonable, and my testings haven't shown any regressions. So from that POV patch would be ok. Nevertheless it would be good to have a bug-report for it, and it is a regression from SjLj. I reported

Re: [PATCH] Fixing SEH exceptions for languages != C++

2014-02-17 Thread Jonathan Schleifer
Am 16.02.2014 um 16:47 schrieb Mike Stump mikest...@comcast.net: On Feb 15, 2014, at 9:27 AM, Jonathan Schleifer j...@webkeks.org wrote: The following patch fixes a bug in SEH exception handling that made it crash with ObjC From an ObjC perspective, I’m fine with the work; though, an seh

[PATCH] Fixing SEH exceptions for languages != C++

2014-02-15 Thread Jonathan Schleifer
Hi! The following patch fixes a bug in SEH exception handling that made it crash with ObjC (and most likely other languages as well). The problem is that the SEH exception handler always passes the unwind exception as 4th parameter to RtlUnwindEx, which RtlUnwindEx then later passes to the