gers could no doubt optimize
things in their packages, if in fact some libraries are identical when
built both with and without MPX).
--
Joseph S. Myers
jos...@codesourcery.com
On Wed, 7 Aug 2013, Xinliang David Li wrote:
> Updated patch attached (fixed header, buffer overflow, and warning -->
> error problems).
You still have diagnostics starting with a capital letter, contrary to the
GNU Coding Standards.
--
Joseph S. Myers
jos...@codesourcery.com
ng
target macros used on the target from those used on the host.
--
Joseph S. Myers
jos...@codesourcery.com
le with a name that includes the program name, its
pid, and a random string, to reduce the chance of conflicts.
* In any case, always open with O_NOFOLLOW (if defined) and O_EXCL to
avoid symlink attacks.
--
Joseph S. Myers
jos...@codesourcery.com
of
> +MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +GNU General Public License for more details.
> +
> +Under Section 7 of GPL version 3, you are granted additional
> +permissions described in the GCC Runtime Library Exception, version
> +3.1, as published by the Free Software Foundation.
Again, why the exception?
--
Joseph S. Myers
jos...@codesourcery.com
ver to the driver should
result in ICEs, including undocumented options.
--
Joseph S. Myers
jos...@codesourcery.com
ems far more useful to
> have __typeof__ for an atomic qualified type to return the non-atomic variant.
What typeof should do in general for qualified types is unclear
(especially in the case of rvalues, where the movement in ISO C seems to
be to say that rvalues can't have qualified
uld
preferably be about building *extra* library variants, for example, rather
than changing the options with which existing variants are built).
--
Joseph S. Myers
jos...@codesourcery.com
ets need 64-bit
HOST_WIDE_INT always needs to be kept in sync with that in gcc/config.gcc.
--
Joseph S. Myers
jos...@codesourcery.com
mit it, no warning should be
given (soft float) and need to emit it but patterns not yet written so
warning should be given (hard float but patterns not yet implemented for
the architecture).
--
Joseph S. Myers
jos...@codesourcery.com
any implementation of the functions in libm). The target
should also be able to declare that there's no support for floating-point
exceptions (e.g. for soft-float) and so floating-point cases don't need
any special handling.
--
Joseph S. Myers
jos...@codesourcery.com
t
> with the atomic builtins, we'll maintain the entire thing as we need.
You have things in a fairly complicated form, building up COMPLEX_EXPRs
out of operations on the individual parts of the complex operands.
--
Joseph S. Myers
jos...@codesourcery.com
d so the
compare-and-exchange needs to work on the whole number) although only the
real part is modified by the addition.
--
Joseph S. Myers
jos...@codesourcery.com
Lv2.1+ with exception; soft-fp code is shared by
glibc, libgcc and potentially the Linux kernel although the copy there
hasn't been merged from glibc for years), although in this case for some
reason the AArch64 file in libgcc is substantially different from that in
glibc.
--
Jos
libm dependencies, so back
ends will need to provide appropriate insn patterns to do those operations
inline.
--
Joseph S. Myers
jos...@codesourcery.com
ct for "atomic"; did you find that including "atomic" in
qualifiers in the implementation made for fewer changes?
--
Joseph S. Myers
jos...@codesourcery.com
you build with make 3.81, touch Makefile.in and then do make -j2 cc1, it
does not produce the hang previously observed. (Or just verify this for
the state after all 18 are applied; no need to try intermediate states
without evidence that the series as a whole has problems with the make
bug.
C, but install.texi is documentation
for people installing GCC.
I think codingconventions.html is the right place for information about
awk coding conventions just like the C/C++ conventions there.
--
Joseph S. Myers
jos...@codesourcery.com
liably with -fwrapv anyway), but the intention
should be clear for when overflow checks are added.
--
Joseph S. Myers
jos...@codesourcery.com
ostics generated at compile time, seem like good goals.
--
Joseph S. Myers
jos...@codesourcery.com
Is there a way to fix it?
The normal way to have compatibility in such cases is a header that
#defines the other-compiler names to the GCC names.
At least is_builtin_name would need updating for any new built-in function
name prefix - but as noted, I don't advise adding such new prefixes at
all.
--
Joseph S. Myers
jos...@codesourcery.com
t-in function naming
conventions (with consequent checks in various places based on function
name) - do we really need yet another such prefix?
--
Joseph S. Myers
jos...@codesourcery.com
*" type.
> It is different to the declaration:
> "static char* const nds32_intrinsic_register_names[] ="
The question is whether it can be "static const char *const" - or do you
need to modify the array itself at runtime (which would be unfortunate in
terms of the aim to avoid global state)?
--
Joseph S. Myers
jos...@codesourcery.com
e fields are used in such a type - it's not a standard C
concept.
--
Joseph S. Myers
jos...@codesourcery.com
=
--- ChangeLog (revision 201177)
+++ ChangeLog (working copy)
@@ -1,3 +1,7 @@
+2013-07-23 Joseph Myers
+
+ * c-parser.c (struct c_generic_association): Fix typo.
+
2013-07-23 Tom Tromey
Joseph Myers
--
Joseph S. Myers
jos...@codesourcery.com
On Tue, 23 Jul 2013, Joseph S. Myers wrote:
> The committee discussion includes a further point to ensure rvalues
> can have qualified type: treating qualified function return types the
(to ensure they *can't* have qualified type, that is)
--
Joseph S. Myers
jos...@codesourcery.com
*/
+ /* Type must be complete. */
+ _Generic (n, struct incomplete: 0, default: 1); /* { dg-error "incomplete
type" } */
+ _Generic (n, void: 0, default: 1); /* { dg-error "incomplete type" } */
+
+ /* Type must be object type. */
+ _Generic (n, void (void): 0, default: 1); /* { dg-error "function type" } */
+
+ /* Two compatible types in association list. */
+ _Generic (&n, int: 5, signed int: 7, default: 23); /* { dg-error "two
compatible types" } */
+
+ /* No matching association. */
+ _Generic (n, void *: 5); /* { dg-error "not compatible with any
association" } */
+}
--
Joseph S. Myers
jos...@codesourcery.com
> Again, throught -> through.
>
> Fixed.
Again, the checked-in change is incorrect ("though").
(This file originally came from glibc, but glibc no longer uses this regex
implementation so there's no issue of fixing upstream ... really libiberty
ought to inherit from gnulib wh
n version of this file is still wrong, it now has "though"
which should be "through".
--
Joseph S. Myers
jos...@codesourcery.com
on should be more conservative about
English style than code comments need to be.
--
Joseph S. Myers
jos...@codesourcery.com
nough to post directly to the list, and post them rather than URLs;
split up further if necessary (really I'd suggest keeping the amount of
such changes you have pending review in total down to about 2000 lines -
wait for the pending patches to be reviewed before sending more).
--
Joseph S.
On Sat, 20 Jul 2013, Marek Polacek wrote:
> Ok for ubsan branch?
I explicitly have no comments on this branch patch. When there's
something for trunk I'll review that patch as a whole.
--
Joseph S. Myers
jos...@codesourcery.com
On Sat, 20 Jul 2013, Jakub Jelinek wrote:
> Joseph, any comments?
I have no comments here.
--
Joseph S. Myers
jos...@codesourcery.com
tic
forward declarations only if needed because of recursion (otherwise
topologically sort the functions in the source file).
--
Joseph S. Myers
jos...@codesourcery.com
ompatible way, and only those
changes require a different dynamic linker name.
--
Joseph S. Myers
jos...@codesourcery.com
instead of fsanitize=address.
> * config/arm/linux-eabi.h (ASAN_CC1_SPEC): Use %:sanitize(address)
> instead of fsanitize=address*.
This seems fine to me.
--
Joseph S. Myers
jos...@codesourcery.com
,
treating it as 0, rather than treating it as an error (i.e., you need to
check there is at least one hex digit after the "0x" or "0X" before
passing the string to strtol).
--
Joseph S. Myers
jos...@codesourcery.com
-1,3 +1,9 @@
+2013-07-10 Joseph Myers
+
+ * doc/tm.texi.in (TARGET_CANONICALIZE_COMPARISON): Remove stray
+ text on @hook line.
+ * doc/tm.texi: Regenerate.
+
2013-07-10 Paolo Carlini
PR c++/57869
--
Joseph S. Myers
jos...@codesourcery.com
Don't you have built-in functions to document as well?
Use "@:" (or a comma) after "i.e." in Texinfo sources. The range "16-47"
should use an en dash (so "16--47").
--
Joseph S. Myers
jos...@codesourcery.com
r the invalid input you expect to
give such diagnostics, etc. (Of course the gcc.target/nds32 testsuite
will grow over time with testcases for bugs in such architecture-specific
functionality that get found and fixed over time.)
--
Joseph S. Myers
jos...@codesourcery.com
GPLv3+exception, not GPLv2 with the old version
of the exception which you have in
libgcc/config/nds32/lib1asmsrc-mculib.S and some other files.
--
Joseph S. Myers
jos...@codesourcery.com
n the default endianness.
--
Joseph S. Myers
jos...@codesourcery.com
case OPT_misa_:
> + /* Check valid ISA: v2 v3 v3m. */
> + if (strcmp (arg, "v2") == 0)
Use Enum in the .opt file and get all the conversion from strings to
integer values, and errors for unknown values, done automatically.
--
Joseph S. Myers
jos...@codesourcery.com
+ " %{mfull-regs:%emay not use both -mreduced-regs and -mfull-regs}}"
If you put these options in Negative() loops in the .opt file, then you
can have the last option on the command line winning (with only the last
option being visible to specs), which is the usual practice, instead of
having such errors.
> +#define LINK_SPEC \
> + " %{v} %{mbig-endian:-EB} %{mlittle-endian:-EL}"
Do you really need %{v} here? Such things shouldn't generally be
architecture-specific.
--
Joseph S. Myers
jos...@codesourcery.com
according to --with-arch=X setting.
Now, given that you add a -march= option, there's the possibility that
someone might do a build with multilibs for different -march= values. So
the choice here (libgcc configuration) needs to depend on the actual
configuration of the compiler for the multil
Ping. This patch
<http://gcc.gnu.org/ml/gcc-patches/2013-07/msg00164.html> is pending
review.
--
Joseph S. Myers
jos...@codesourcery.com
CC will optimize away the test for 0 when the instruction
semantics make it unnecessary - if it doesn't, it should be fixed to do
so. And it's certainly fine to put such code in an intrinsic header if
useful.)
--
Joseph S. Myers
jos...@codesourcery.com
ot be
complete - but if you fix all the issues listed above then
before-and-after comparison for lots of targets using config-list.mk would
be a good way of gaining confidence in the lack of unintended changes in
the patch.
--
Joseph S. Myers
jos...@codesourcery.com
produce patches relative to current upstream
versions of those projects.
It is not generally desirable to apply such cleanups to testcases.
--
Joseph S. Myers
jos...@codesourcery.com
On Thu, 4 Jul 2013, Joern Rennecke wrote:
> Quoting "Joseph S. Myers" :
>
> > On Thu, 4 Jul 2013, Joern Rennecke wrote:
> >
> > > For this fix I've assumed that it is now the job of the various places
> > > that
> > > do calcula
nstants like you do is necessarily safe.
Also note c/ and c-family/ have their own ChangeLog files.
--
Joseph S. Myers
jos...@codesourcery.com
On Wed, 3 Jul 2013, Joseph S. Myers wrote:
> That change has the effect that reload thinks TFmode (and no doubt
> TDmode) only takes two registers even when in general registers,
> causing a segfault in glibc's test-ldouble built for soft float.
>
> I'm testing this pa
ASS_P (c)
+ && (m == TDmode || m == TFmode))
reg_size2 = UNITS_PER_FP_WORD;
rs6000_class_max_nregs[m][c]
--
Joseph S. Myers
jos...@codesourcery.com
tt
* Makefile.in (c-family-warn): Define to $(WARN_STRICT).
--
Joseph S. Myers
jos...@codesourcery.com
ont ends that don't currently expect to be linked together,
although actually making it possible to link them together is probably
only a few days' work).
--
Joseph S. Myers
jos...@codesourcery.com
os __SIZEOF_INT__,
__SIZEOF_LONG__, __SIZEOF_LONG_LONG__ and __SIZEOF_POINTER__ have been
around for a long time, so new macros would just be for convenience (which
may nevertheless be a sensible reason to define macros) at the expense of
startup time.
--
Joseph S. Myers
jos...@codesourcery.com
in architecture-independent code
for LP64 systems. Libraries can use those to distinguish the two models
for AArch64, so I don't see any need to add architecture-specific macros
with the opposite sense.
--
Joseph S. Myers
jos...@codesourcery.com
ven't yet been produced for GCC trunk so can't be
considered for release branch fixing yet.)
--
Joseph S. Myers
jos...@codesourcery.com
g that shouldn't depend on
the target architecture. In the absence of explicit
-fstrict-volatile-bitfields, semantics conflicting with the memory model
should only be enabled by one of the --param options to allow data races,
and not by some default option relating to something in a targe
t with atexit.
This is OK. Using atexit seems to me to be the right approach for such
cleanup.
--
Joseph S. Myers
jos...@codesourcery.com
? Since the option handling is in
opts.c it should get run in the driver so flag_sanitize should be set
correctly there; as long as the specs in question run after the relevant
option processing, a spec function should work for this.
--
Joseph S. Myers
jos...@codesourcery.com
ese early convert_to_* optimizations (optimizing later on
GIMPLE if possible) rather than adding to them.
--
Joseph S. Myers
jos...@codesourcery.com
nteger is what's
wanted here.
--
Joseph S. Myers
jos...@codesourcery.com
races=1, anyway) in those cases where AAPCS would
indicate writing to an object outside the maximal sequence of consecutive
non-zero-width bit-fields.
--
Joseph S. Myers
jos...@codesourcery.com
declaration is fine as well.
>
> Ok for trunk?
>
> 2013-06-17 Marek Polacek
>
> PR c/57630
> * c-decl.c (check_for_loop_decls): Improve diagnostics messages.
OK.
--
Joseph S. Myers
jos...@codesourcery.com
s adjusting committed content are likely to work at all.
--
Joseph S. Myers
jos...@codesourcery.com
In general I think no formatting fixes should be made to GCC testcases,
including removal of trailing whitespace; it's good if they cover a range
of coding styles and oddities as that reflects how GCC is used in
practice.
--
Joseph S. Myers
jos...@codesourcery.com
double, and I'm less certain there.
That variant was used for IRIX, for which support was removed over a year
ago. It would be good to remove the code that I noted in
<http://gcc.gnu.org/ml/gcc-patches/2012-03/msg00819.html> was thereby made
obsolete.
--
Joseph S. Myers
jos...@codesourcery.com
; I looked into it and they were an artifact of previous implementation.
> Those while loops were not even being entered. Thus, I took them out.
> Here is a fixed patch.
Thanks, this patch is OK.
--
Joseph S. Myers
jos...@codesourcery.com
that also cause type mismatches (at least if the
conversions are to types that count as sufficiently different for GIMPLE
purposes - say conversions between 32-bit and 64-bit integers)? Maybe you
actually need to fold without removing any such wrappers first at all?
--
Joseph S. Myers
jos...@codesourcery.com
if this is the expression of an expression statement, or
otherwise will go inside a tree that c_fully_fold does not recurse
inside), or the operand of the EXCESS_PRECISION_EXPR should be converted
to the semantic type with the "convert" function. In neither case is
generati
-debug.
>
> Ok for trunk?
OK.
--
Joseph S. Myers
jos...@codesourcery.com
C_MAYBE_CONST_EXPR as well (e.g. try using 0 / 0, or compound literals of
variably modified type, in various places in the affected expressions),
which should be fixed by using c_fully_fold but not by inserting a cast.
--
Joseph S. Myers
jos...@codesourcery.com
On Sat, 8 Jun 2013, Marek Polacek wrote:
> + if (code == LSHIFT_EXPR
> + && !TYPE_UNSIGNED (TREE_TYPE (op0))
> + && (flag_isoc99 || flag_isoc11))
flag_isoc11 implies flag_isoc99, you only need to check flag_isoc99 here.
--
Joseph S. Myers
jos...@codesourcery.com
, gcc.dg/*const-expr* and gcc.dg/overflow-warn*. Generating
extra diagnostics for code in those tests that already gets a diagnostic
is OK, as long as it doesn't generate diagnostics for non-overflow cases
in those tests that aren't meant to be treated as overflow, or lose
diag
nable UndefinedBehaviorSanitizer, a fast undefined behavior detector
> +Various computations will be instrumented to detect
> +undefined behavior, e.g. division by zero or various overflows.
e.g.@:
--
Joseph S. Myers
jos...@codesourcery.com
d to set up the former.)
We are, it appears, still missing stdint.h type information in GCC for
NetBSD, VxWorks, Symbian, LynxOS, QNX, Interix, TPF. Maybe we need to
issue a last call to maintainers caring about those targets to fill in
this information, and failing that deprecate them.
-
On Tue, 4 Jun 2013, Kyrylo Tkachov wrote:
> It creates a command line option, -mrestrict-it, that can be used to
Command-line options need documenting in invoke.texi.
--
Joseph S. Myers
jos...@codesourcery.com
undefined."
>
> While seriously underspecified for signed negative values (always undefined?!
> or well-defined?!), I wonder why CLang requires
Always undefined for signed negative values (compared to the
implementation-defined of C90; DR#081).
--
Joseph S. Myers
jos...@codesourcery.com
>
> A user actually hit this in rather trivial code with memory spaces.
>
> Tested on two platforms, one with memory spaces and one without.
>
> Ok?
This patch is OK.
--
Joseph S. Myers
jos...@codesourcery.com
On Wed, 22 May 2013, Jeff Law wrote:
> On 05/22/2013 03:58 PM, Joseph S. Myers wrote:
> >
> > Regarding commonality between OpenMP and Cilk, note also the new C
> > Parallel Language Extensions WG14 study group chaired by Clark Nelson and
> > aiming to propose a stand
#x27;m OK with the array notation patch as it stands now, although certainly
as discussed today there is still some scope for further improvements.
--
Joseph S. Myers
jos...@codesourcery.com
_FloatN types, where the particular set
supported depends on the implementation (and so for GCC would depend on
the architecture). Again, these should be keywords.
(I don't think any of the above should be particularly hard to implement.)
--
Joseph S. Myers
jos...@codesourcery.com
ound - that after Bernd's fixes (July
2011) towards support for 40-bit integers, FRACTIONAL_INT_MODE worked
better than PARTIAL_INT_MODE.
--
Joseph S. Myers
jos...@codesourcery.com
On Fri, 10 May 2013, Sriraman Tallam wrote:
> On Fri, May 10, 2013 at 6:34 AM, Joseph S. Myers
> wrote:
> > On Thu, 9 May 2013, Sriraman Tallam wrote:
> >
> >> Then, I plan to add the following hooks to libgcc (in a different patch) :
> >>
> >> in
ames are in the user's namespace; I think libgcc should only
provide or use symbols in the implementation namespace.
--
Joseph S. Myers
jos...@codesourcery.com
ing with a bootstrapped native compiler
from the same GCC trunk version as you are building. Make sure this works
for both 32-bit and 64-bit host compilers, and that those produce the same
test results (so you don't have bugs depending on whether the host is
32-bit or 64-bit).
--
Jose
bler to use this GCC port, so users
can use whatever symbol names in the user namespace they like.
(Prefixing registers is better than starting to use leading underscores on
C symbols; leading underscores in ELF are contrary to the ELF gABI, which
says that symbol names in ELF symbol tables are the same as in C.)
--
Joseph S. Myers
jos...@codesourcery.com
\
> +{ \
> + builtin_define ("NO_TRAMPOLINES");\
Don't define NO_TRAMPOLINES; that's in the user's namespace. (For
testcases testing NO_TRAMPOLINES, lib/gcc.exp defines it if the board file
defines gcc,no_trampolines.)
--
Joseph S. Myers
jos...@codesourcery.com
s problematic, and there are
enough differences not covered by them that I doubt linking objects for
one OS using a compiler built for another is actually going to work well.
--
Joseph S. Myers
jos...@codesourcery.com
expect it would be possible to use config/gnu-user.h and
config/linux.h the way all GNU/Linux architectures other than Alpha and
PowerPC do, so eliminating an unnecessary source of complication in global
changes.
--
Joseph S. Myers
jos...@codesourcery.com
7;t allow the option.
--
Joseph S. Myers
jos...@codesourcery.com
ption is accepted
for one of compiling and linking but not the other (which would be
especially confusing).
--
Joseph S. Myers
jos...@codesourcery.com
On Tue, 30 Apr 2013, Shakthi Kannan wrote:
> Hi,
>
> - Original Message -
> | From: "Joseph S. Myers"
> |
> | onlinedocs copies of manuals are generated by
> | maintainer-scripts/update_web_docs_svn, which doesn't use any makefiles.
> \--
>
dability and clarity.
>
> 2013-04-30 Shakthi Kannan
>
> PR wwwdocs/50642
> * Makefile.in: Use --css-include with makeinfo.
onlinedocs copies of manuals are generated by
maintainer-scripts/update_web_docs_svn, which doesn't use any makefiles.
--
Joseph S. Myers
jos...@codesourcery.com
quot;);
> + return;
> +}
> + if (flag_enable_cilkplus && contains_array_notation_expr (incr) && 0)
> +{
> + error_at (start_locus, "array notation expression cannot be used in a "
> + "loop's increment expression");
> + return;
> +}
Use %' in the second error here, as you did in the first.
> diff --git a/gcc/tree-pretty-print.c b/gcc/tree-pretty-print.c
> +case ARRAY_NOTATION_REF:
Since this is a C-family tree node, I'd think the handling in
c-pretty-print.c should suffice, without needing anything in
tree-pretty-print.c as well.
--
Joseph S. Myers
jos...@codesourcery.com
On Thu, 25 Apr 2013, Senthil Kumar Selvaraj wrote:
> On Wed, Apr 24, 2013 at 03:18:51PM +0000, Joseph S. Myers wrote:
> > On Wed, 3 Apr 2013, Senthil Kumar Selvaraj wrote:
> >
> > > 2013-04-03Senthil Kumar Selvaraj
> > >
> > >
> > >
s), @option{zlib} (use zlib
> +compression in ELF gABI format), or @option{zlib-gnu} (use zlib
> +compression in tradition GNU format).
"traditional".
--
Joseph S. Myers
jos...@codesourcery.com
ere
as is done for decimal arguments (but using ISXDIGIT), in order to ensure
that no locale-specific form is accepted by strtol.
--
Joseph S. Myers
jos...@codesourcery.com
and 64-bit
hosts, to detect any dependencies on whether the host is 32-bit or 64-bit.
--
Joseph S. Myers
jos...@codesourcery.com
601 - 700 of 1676 matches
Mail list logo
