Re: [i386] Replace builtins with vector extensions

2014-06-28 Thread Marc Glisse
On Sat, 28 Jun 2014, Ulrich Drepper wrote: On Sat, Jun 28, 2014 at 6:42 AM, Marc Glisse marc.gli...@inria.fr wrote: Ping, nobody has an opinion on this? Or some explanation why I am mistaken to believe that #pragma target makes it safer now? It would enable a number of optimizations, like

Re: [PATCH] Fix vector rotate regression (PR tree-optimization/57233)

2014-06-26 Thread Marc Glisse
= lshr_optab; + opr = optab_for_tree_code (RSHIFT_EXPR, type, optab_scalar); Looks like there are some typos in there, you are assigning to oprv twice. -- Marc Glisse

Re: [PATCH] Change default for --param allow-...-data-races to off

2014-06-25 Thread Marc Glisse
thread is created. I hope that not too many libraries use threads internally in a way that would break this. -- Marc Glisse

strlen: update datastructure when replacing malloc with calloc

2014-06-25 Thread Marc Glisse
Hello, in my calloc patch, I forgot to update the datastructure when replacing malloc with calloc. Bootstrap+testsuite on x86_64-linux-gnu. 2014-06-25 Marc Glisse marc.gli...@inria.fr PR tree-optimization/57742 gcc/ * tree-ssa-strlen.c (handle_builtin_memset): Update

Re: [GSoC][match-and-simplify] mark some more operators as commutative

2014-06-23 Thread Marc Glisse
)) + (minus @0 (plus:c @0 @1)) (negate @0)) seems pointless Why? a-(a+b) and a-(b+a) are both wanted and don't appear elsewhere in the file, no? Should simplify to (negate @1) though. -- Marc Glisse

Re: calloc = malloc + memset

2014-06-23 Thread Marc Glisse
commit it tomorrow if there aren't any comments on the pass placement. 2014-06-24 Marc Glisse marc.gli...@inria.fr PR tree-optimization/57742 gcc/ * tree-ssa-strlen.c (get_string_length): Ignore malloc. (handle_builtin_malloc, handle_builtin_memset): New functions

Re: calloc = malloc + memset

2014-06-23 Thread Marc Glisse
On Mon, 23 Jun 2014, Richard Biener wrote: On June 23, 2014 5:51:30 PM CEST, Marc Glisse marc.gli...@inria.fr wrote: On Mon, 23 Jun 2014, Jakub Jelinek wrote: Ok for trunk, sorry for the delay. Thanks. Richard has moved the passes a bit since then, but I still have exactly one spot where

Re: calloc = malloc + memset

2014-06-23 Thread Marc Glisse
benchmarks, and their authors would be disappointed if the compiler didn't mess it up regularly in new and entertaining ways ;-) -- Marc Glisse

Re: calloc = malloc + memset

2014-06-23 Thread Marc Glisse
the compiler that we are doing memset(malloc(n),0,n). -- Marc Glisse

[doc] Remove duplicate -Wmaybe-uninitialized

2014-06-22 Thread Marc Glisse
Hello, a trivial patch to remove a duplicated option, you can see the second one 4 lines below in the patch. (the mixed use of single or double spaces in this list is strange) This was included in the bootstrap of another patch. 2014-06-23 Marc Glisse marc.gli...@inria.fr * doc

Warn when returning the address of a temporary (middle-end) v2

2014-06-22 Thread Marc Glisse
-unknown-linux-gnu. (by the way, contrib/compare_tests is confused when I use all languages, it prints comm: file 1 is not in sorted order and tons of spurious differences) 2014-06-23 Marc Glisse marc.gli...@inria.fr PR c++/60517 gcc/c/ * c-typeck.c (c_finish_return): Return 0

Re: [i386] logical shift right in shrd

2014-06-21 Thread Marc Glisse
On Sat, 21 Jun 2014, Uros Bizjak wrote: On Fri, Jun 20, 2014 at 10:42 PM, Marc Glisse marc.gli...@inria.fr wrote: as reported in PR 61503, there seems to be a typo in the shrd pattern. I think it is quite unlikely to cause any problem, because the pattern is 1 instruction too long for combine

Re: [patch] change specific int128 - generic intN

2014-06-21 Thread Marc Glisse
)) That seems complicated. You just need to call emit_support_tinfo_1 on each of the types (see how fundamentals is used at the end of the function), no need to put everything in the array. -- Marc Glisse

[RTL] (vec_select (vec_concat a b) c) may be just a or b

2014-06-21 Thread Marc Glisse
, as in the original testcase in the PR, we won't notice that those are the original vectors. Still, better than nothing... (we output a vzeroupper for the testcase, that seems unnecessary) Bootstrap+testsuite on x86_64-linux-gnu. 2014-06-22 Marc Glisse marc.gli...@inria.fr PR target/44551

[i386] logical shift right in shrd

2014-06-20 Thread Marc Glisse
it. Bootstrap+testsuite on x86_64-linux-gnu. 2014-06-21 Marc Glisse marc.gli...@inria.fr PR target/61503 * config/i386/i386.md (x86_64_shrd, x86_shrd): Replace ashiftrt with lshiftrt. -- Marc GlisseIndex: gcc/config/i386/i386.md

Re: C++ PATCH for c++/59296 (rvalue object and lvalue ref-qualifier)

2014-06-19 Thread Marc Glisse
differently from regular function calls. -- Marc Glisse

Re: [RTL, i386] Use subreg instead of UNSPEC_CAST

2014-06-10 Thread Marc Glisse
at -O0 (and vice versa), but it might be redundant with some other tests. Bootstrap+testsuite on x86_64-linux-gnu. 2014-06-10 Marc Glisse marc.gli...@inria.fr PR target/50829 gcc/ * config/i386/sse.md (enum unspec): Remove UNSPEC_CAST. (avx_castmodeavxsizesuffix_castmode

PR54442 build_qualified_type produces a non-canonical type

2014-06-09 Thread Marc Glisse
to return a canonical type. I doubt the patch can be wrong, but it may be that this is a situation that is not supposed to happen and should be fixed elsewhere? Bootstrap+testsuite on x86_64-linux-gnu. 2014-06-09 Marc Glisse marc.gli...@inria.fr PR c++/54442 gcc/ * tree.c

Re: PR54442 build_qualified_type produces a non-canonical type

2014-06-09 Thread Marc Glisse
On Mon, 9 Jun 2014, Jason Merrill wrote: On 06/09/2014 10:18 AM, Marc Glisse wrote: I doubt the patch can be wrong, but it may be that this is a situation that is not supposed to happen and should be fixed elsewhere? Seems likely. What is the difference between the type returned from

Re: __float128 typeinfo

2014-06-07 Thread Marc Glisse
On Fri, 6 Jun 2014, Paolo Carlini wrote: On 06/06/2014 04:16 PM, Marc Glisse wrote: abi_check is broken before my patch (134 incompatible symbols). Isn't broken for me, though. Likewise, AFAICS, on gcc-testresults. I would recommend investigating in some detail what's going on at your end

__float128 typeinfo

2014-06-06 Thread Marc Glisse
it as a pass. 2014-06-06 Marc Glisse marc.gli...@inria.fr PR libstdc++/43622 gcc/cp/ * rtti.c (emit_support_tinfos): Handle __float128. libstdc++-v3/ * config/abi/pre/float128.ver: New file. * configure.ac: Use float128.ver when relevant. * configure: Regenerate

Re: __float128 typeinfo

2014-06-06 Thread Marc Glisse
On Fri, 6 Jun 2014, Ramana Radhakrishnan wrote: On Fri, Jun 6, 2014 at 3:16 PM, Marc Glisse marc.gli...@inria.fr wrote: Hello, here is a new try on adding __float128 typeinfo to libsupc++. The front-end part is based on the discussion with Jason yesterday. The libstdc++ part is copied from

Re: __float128 typeinfo

2014-06-06 Thread Marc Glisse
On Fri, 6 Jun 2014, Jason Merrill wrote: On 06/06/2014 10:16 AM, Marc Glisse wrote: * config/abi/pre/float128.ver: New file. +CXXABI_FLOAT128_1.3.9 { What's your rationale for keeping this in a separate version block rather than in 1.3.9 (like __int128)? https://gcc.gnu.org/bugzilla

Re: __float128 typeinfo

2014-06-06 Thread Marc Glisse
On Fri, 6 Jun 2014, Jason Merrill wrote: On 06/06/2014 11:58 AM, Marc Glisse wrote: On Fri, 6 Jun 2014, Jason Merrill wrote: What's your rationale for keeping this in a separate version block rather than in 1.3.9 (like __int128)? Powerpc already has those symbols in CXXABI_LDBL_1.3

Re: PR61385: phiopt drops some PHIs

2014-06-04 Thread Marc Glisse
, etc. bootstrap+testsuite on x86_64-linux-gnu as usual. 2014-06-04 Marc Glisse marc.gli...@inria.fr PR tree-optimization/61385 gcc/ * tree-ssa-phiopt.c (value_replacement): Replace singleton PHIs with assignments. gcc/testsuite/ * gcc.dg/tree-ssa/pr61385.c: New

Re: PR61385: phiopt drops some PHIs

2014-06-04 Thread Marc Glisse
On Wed, 4 Jun 2014, Richard Biener wrote: So I'd say we should instead simply bail out if the middle-bb has a PHI node. Sounds good to me, so I am testing the mini-patch I had originally posted to bugzilla: 2014-06-04 Marc Glisse marc.gli...@inria.fr PR tree-optimization/61385

Re: emit __float128 typeinfo

2014-06-04 Thread Marc Glisse
type is not in the list 0/float/double/long double. I think it should be ok with arm (it would be good if they removed their unused XFmode, but I don't even think it is necessary). Is that what you were suggesting? I'll try to write a patch, thanks. -- Marc Glisse

Re: [PATCH][match-and-simplify]

2014-06-03 Thread Marc Glisse
On Tue, 3 Jun 2014, Richard Biener wrote: On Mon, 2 Jun 2014, Marc Glisse wrote: (plus (bit_not @0) @0) if (INTEGRAL_TYPE_P (TREE_TYPE (@0))) { build_int_cst (TREE_TYPE (@0), -1); }) +(match_and_simplify + (plus @0 (bit_not @0)) + if (INTEGRAL_TYPE_P (TREE_TYPE (@0

PR61385: phiopt drops some PHIs

2014-06-03 Thread Marc Glisse
yesterday). 2014-06-03 Marc Glisse marc.gli...@inria.fr PR tree-optimization/61385 gcc/ * tree-ssa-phiopt.c (value_replacement): Copy PHI nodes before removing the basic block. gcc/testsuite/ * gcc.dg/tree-ssa/pr61385.c: New file. -- Marc GlisseIndex: gcc/testsuite

Re: calloc = malloc + memset

2014-06-03 Thread Marc Glisse
Ping? On Sat, 17 May 2014, Marc Glisse wrote: Ping Jakub? https://gcc.gnu.org/ml/gcc-patches/2014-04/msg01104.html On Wed, 23 Apr 2014, Richard Biener wrote: On Fri, Apr 18, 2014 at 8:27 PM, Marc Glisse marc.gli...@inria.fr wrote: Thanks for the comments! On Fri, 18 Apr 2014, Jakub

Re: PR61385: phiopt drops some PHIs

2014-06-03 Thread Marc Glisse
On Tue, 3 Jun 2014, Richard Biener wrote: On Tue, Jun 3, 2014 at 3:48 PM, Marc Glisse marc.gli...@inria.fr wrote: Hello, apparently it is possible to have a PHI in the middle basic block of value_replacement, so I need to move it as well when I move the statement and remove the block

Re: [PATCH][match-and-simplify]

2014-06-02 Thread Marc Glisse
(bit_not @0)) { build_all_ones_cst (TREE_TYPE (@0)); }) ? Works for vector/complex, I don't know what type a bit_not_expr can have where the simplification wouldn't be true. -- Marc Glisse

Re: [patch] libstdc++/61374 fix string_view conversion and update to latest draft

2014-06-01 Thread Marc Glisse
. -- Marc Glisse

Re: [C++11, C++14 PATCH 2/3] Support for SD-6: SG10 Feature Test Recommendations - c-family and testsuite

2014-05-31 Thread Marc Glisse
constexpr, we shouldn't define those macros lightly. -- Marc Glisse

Re: [C++11, C++14 PATCH 3/3] Support for SD-6: SG10 Feature Test Recommendations - libstdc++

2014-05-31 Thread Marc Glisse
On Fri, 30 May 2014, Ed Smith-Rowland wrote: +#define __cpp_lib_constexpr_functions 201210 appears quite a few times, I believe it will warn with -Wsystem-headers. I think you should check if it is already defined (or undefine it first). (you forgot to Cc: libstdc++) -- Marc Glisse

Re: [PATCH] Warn on and fold NULL checks against inline functions

2014-05-26 Thread Marc Glisse
. In the comments of that PR, Honza seems to have a different idea of what the fold-const test should look like. -- Marc Glisse

Re: [PATCH] Warn on and fold NULL checks against inline functions

2014-05-26 Thread Marc Glisse
On Mon, 26 May 2014, Patrick Palka wrote: On Mon, May 26, 2014 at 4:26 PM, Marc Glisse marc.gli...@inria.fr wrote: On Mon, 26 May 2014, Patrick Palka wrote: This patch teaches the C++ frontend to warn on NULL checks against inline functions and it teaches the middle-end to fold NULL checks

Re: emit __float128 typeinfo

2014-05-23 Thread Marc Glisse
On Wed, 21 May 2014, Jason Merrill wrote: On 04/25/2014 05:04 AM, Marc Glisse wrote: Does this approach seem ok, or do we need to try harder to find a way to get this typeinfo into libsupc++? The latter, I think; these are base types, so they should go in the library. Hmm, ok. Because

Re: [i386] Replace builtins with vector extensions

2014-05-17 Thread Marc Glisse
Ping On Mon, 28 Apr 2014, Marc Glisse wrote: Ping http://gcc.gnu.org/ml/gcc-patches/2014-04/msg00590.html (note that ARM seems to be doing the same thing for their neon intrinsics, see Ramana's patch series posted today) On Fri, 11 Apr 2014, Marc Glisse wrote: Hello, the previous

Re: calloc = malloc + memset

2014-05-17 Thread Marc Glisse
Ping Jakub? https://gcc.gnu.org/ml/gcc-patches/2014-04/msg01104.html On Wed, 23 Apr 2014, Richard Biener wrote: On Fri, Apr 18, 2014 at 8:27 PM, Marc Glisse marc.gli...@inria.fr wrote: Thanks for the comments! On Fri, 18 Apr 2014, Jakub Jelinek wrote: The passes.def change makes me

Re: [v3] Slightly improve operator new

2014-05-17 Thread Marc Glisse
Ping. On Tue, 15 Apr 2014, Marc Glisse wrote: Ping http://gcc.gnu.org/ml/gcc-patches/2014-03/msg00051.html On Sun, 2 Mar 2014, Marc Glisse wrote: Hello, inlining operator new (with LTO or otherwise), I noticed that it has a complicated implementation, which makes it hard to use

Re: PR61140: check the phi is unique in value_replacement

2014-05-11 Thread Marc Glisse
On Sat, 10 May 2014, Andrew Pinski wrote: On Sat, May 10, 2014 at 3:53 PM, Marc Glisse marc.gli...@inria.fr wrote: Hello, in my recent phiopt patch enhancing value_replacement to optimize x!=0?x+y:y, I forgot to check that there is no other PHI (not sure how I managed to miss that since I

PR61140: check the phi is unique in value_replacement

2014-05-10 Thread Marc Glisse
in the function. Bootstrap+testsuite on x86_64-linux-gnu. 2014-05-12 Marc Glisse marc.gli...@inria.fr PR tree-optimization/61140 gcc/ * tree-ssa-phiopt.c (value_replacement): Punt on multiple phis. gcc/testsuite/ * gcc.dg/tree-ssa/pr61140.c: New file. -- Marc GlisseIndex: gcc

Re: [patch] change specific int128 - generic intN

2014-05-09 Thread Marc Glisse
think of another way... -- Marc Glisse

Re: emit __float128 typeinfo

2014-05-08 Thread Marc Glisse
Ping http://gcc.gnu.org/ml/gcc-patches/2014-04/msg01651.html On Fri, 25 Apr 2014, Marc Glisse wrote: On Fri, 25 Apr 2014, Marc Glisse wrote: the previous patch had to be reverted as it broke the strange handling of vectors in the ARM target. This new patch should be much more conservative

Re: [patch] change specific int128 - generic intN

2014-05-08 Thread Marc Glisse
, type_traits and numeric_limits). -- Marc Glisse

Re: Optimize n?rotate(x,n):x

2014-05-01 Thread Marc Glisse
substituting the tested value and see if the result matches the other phi argument (it might handle (a!=b)?a|b:a for instance), instead of the *_element_p tests. I may try that later, but I guess the current patch is good enough for now. 2014-05-06 Marc Glisse marc.gli...@inria.fr PR tree

Re: [PATCH], RFC, add support for __float128/__ibm128 types on PowerPC

2014-04-29 Thread Marc Glisse
to __FLOAT128__). If you really don't like it, we can ask x86 maintainers if they like __FLOAT128__. -- Marc Glisse

Re: [i386] Replace builtins with vector extensions

2014-04-28 Thread Marc Glisse
Ping http://gcc.gnu.org/ml/gcc-patches/2014-04/msg00590.html (note that ARM seems to be doing the same thing for their neon intrinsics, see Ramana's patch series posted today) On Fri, 11 Apr 2014, Marc Glisse wrote: Hello, the previous discussion on the topic was before we added all those

Re: [PATCH] Implement -fsanitize=float-divide-by-zero

2014-04-28 Thread Marc Glisse
say, it is well defined (except when finite-math-only is in effect). If you want a meta-category for this kind of valid thing, maybe -fsanitize=unusual or -fsanitize=suspicious. -- Marc Glisse

Re: version typeinfo for 128bit types

2014-04-25 Thread Marc Glisse
On Fri, 25 Apr 2014, Jonathan Wakely wrote: On 24/04/14 20:03 +0200, Marc Glisse wrote: Grep seems to indicate that the manual is the only other place that needs updating, but that can wait. Is this patch ok, assuming the tests pass? OK, and sorry for forgetting about that file

emit __float128 typeinfo

2014-04-25 Thread Marc Glisse
, both regtested fine. Does this approach seem ok, or do we need to try harder to find a way to get this typeinfo into libsupc++? 2014-04-25 Marc Glisse marc.gli...@inria.fr PR libstdc++/43622 * rtti.c (emit_support_tinfos): Move the array... (fundamentals

Re: emit __float128 typeinfo

2014-04-25 Thread Marc Glisse
On Fri, 25 Apr 2014, Marc Glisse wrote: the previous patch had to be reverted as it broke the strange handling of vectors in the ARM target. This new patch should be much more conservative I hope. Instead of adding this typeinfo to libsupc++, I am letting the FE know that it isn't available

Re: [c++] typeinfo for target types

2014-04-24 Thread Marc Glisse
On Thu, 24 Apr 2014, Ramana Radhakrishnan wrote: On Wed, Apr 23, 2014 at 8:43 PM, Marc Glisse marc.gli...@inria.fr wrote: On Wed, 23 Apr 2014, Richard Henderson wrote: On 04/13/2014 01:41 AM, Marc Glisse wrote: Hello, this patch generates typeinfo for target types. On x86_64, it adds

Re: [c++] typeinfo for target types

2014-04-24 Thread Marc Glisse
quite some time back so there is some digging needed here. Problematic part of the patch was reverted, arm and aarch64 should be ok now. Please do investigate... -- Marc Glisse

Re: version typeinfo for 128bit types

2014-04-24 Thread Marc Glisse
On Thu, 24 Apr 2014, Rainer Orth wrote: Marc Glisse marc.gli...@inria.fr writes: this is a follow-up for this patch: http://gcc.gnu.org/ml/gcc-patches/2014-04/msg00618.html once committed, g++ will generate typeinfo for __float128, and it needs versioning. While there, I noticed

Re: [C PATCH] Improve error on attrs after declarator in a fndef (PR c/60915)

2014-04-24 Thread Marc Glisse
, instead of forbidden, you said move the attribute so users would know that writing the attribute *before* was fine? That sounded much better to me. -- Marc Glisse

Re: Optimize n?rotate(x,n):x

2014-04-23 Thread Marc Glisse
Honza, any comment on Richard's question? On Tue, 15 Apr 2014, Richard Biener wrote: On Mon, Apr 14, 2014 at 6:40 PM, Marc Glisse marc.gli...@inria.fr wrote: On Mon, 14 Apr 2014, Richard Biener wrote: + /* If the special case has a high probability, keep it. */ + if (EDGE_PRED (middle_bb

Re: [i386] define __SIZEOF_FLOAT128__

2014-04-23 Thread Marc Glisse
(Adding an i386 maintainer in Cc) http://gcc.gnu.org/ml/gcc-patches/2014-04/msg00620.html On Sun, 13 Apr 2014, Marc Glisse wrote: Hello, some people like having a macro to test if a type is available (__SIZEOF_INT128__ for instance). This adds macros for __float80 and __float128. The types

Re: [c++] typeinfo for target types

2014-04-23 Thread Marc Glisse
On Wed, 23 Apr 2014, Richard Henderson wrote: On 04/13/2014 01:41 AM, Marc Glisse wrote: Hello, this patch generates typeinfo for target types. On x86_64, it adds these 6 lines to nm -C libsupc++.a. A follow-up patch will be needed to export and version those in the shared library

Re: Optimize n?rotate(x,n):x

2014-04-23 Thread Marc Glisse
) threshold = PROB_EVEN; if (EDGE_PRED (middle_bb, 0)-probability threshold) return 0; Is that ok, after re-testing? -- Marc Glisse

Re: [i386] define __SIZEOF_FLOAT128__

2014-04-23 Thread Marc Glisse
On Wed, 23 Apr 2014, H.J. Lu wrote: On Wed, Apr 23, 2014 at 11:48 AM, Marc Glisse marc.gli...@inria.fr wrote: (Adding an i386 maintainer in Cc) http://gcc.gnu.org/ml/gcc-patches/2014-04/msg00620.html On Sun, 13 Apr 2014, Marc Glisse wrote: Hello, some people like having a macro to test

Re: [PATCH] Simplify a VEC_SELECT fed by its own inverse

2014-04-22 Thread Marc Glisse
. -- Marc Glisse

Re: version typeinfo for 128bit types

2014-04-22 Thread Marc Glisse
On Tue, 22 Apr 2014, Jonathan Wakely wrote: On 14 April 2014 11:28, Jonathan Wakely wrote: On 14 April 2014 10:39, Marc Glisse wrote: PR libstdc++/43622 * config/abi/pre/gnu.ver (CXXABI_1.3.9): New version, new symbols. * config/abi/pre/gnu-versioned-namespace.ver

Re: version typeinfo for 128bit types

2014-04-22 Thread Marc Glisse
-04-23 Marc Glisse marc.gli...@inria.fr PR libstdc++/43622 * config/abi/pre/float128.ver: New file. * config/abi/pre/gnu.ver (CXXABI_1.3.9): Move __float128 typeinfo to the new file. * config/abi/post/x86_64-linux-gnu/baseline_symbols.txt: Update

Re: [PATCH] Simplify a VEC_SELECT fed by its own inverse

2014-04-21 Thread Marc Glisse
is smaller than op0_subop1. Starting from a vector of size 2, extracting {1,0,1,0} then {3,0} gives the initial vector just fine. -- Marc Glisse

Re: [build] PR 43538: Don't overwrite CXXFLAGS_FOR_TARGET in config/mt-gnu

2014-04-18 Thread Marc Glisse
Ping http://gcc.gnu.org/ml/gcc-patches/2014-01/msg01480.html On Thu, 23 Jan 2014, Marc Glisse wrote: Hello, although setting CFLAGS_FOR_TARGET before compiling gcc works fine, CXXFLAGS_FOR_TARGET is ignored. I don't see any good reason for that. I tested the patch by doing a regular

Re: [C PATCH] Warn if switch has boolean value (PR c/60439)

2014-04-18 Thread Marc Glisse
== LT_EXPR + || exp_code == GT_EXPR) Is there a TREE_CODE_CLASS or a #define for this? truth_value_p -- Marc Glisse

Re: calloc = malloc + memset

2014-04-18 Thread Marc Glisse
one, so I think we should be ok, but I don't mind treating calloc like malloc here if you think it is too risky, I don't think people call strlen(calloc(a,b)) very often, and it would let me remove the don't use si-length comment. Updated and tested on x86_64-linux-gnu. 2014-04-18 Marc

Re: [PATCH] Fix PR60849

2014-04-17 Thread Marc Glisse
On Thu, 17 Apr 2014, Richard Biener wrote: This fixes PR60849 by properly rejecting non-boolean typed comparisons from valid_gimple_rhs_p so they go through the gimplification paths. Could you also accept vector comparisons please? -- Marc Glisse

Re: [patch] change specific int128 - generic intN

2014-04-17 Thread Marc Glisse
new types, no need to touch the array. Do the entries in the array need to be in a particular order? No, any random order would do. -- Marc Glisse

Re: [C PATCH] Warn if switch has boolean value (PR c/60439)

2014-04-17 Thread Marc Glisse
Manuel insists regularly that no new warning should use 0 (and old ones should progressively lose it). -- Marc Glisse

Re: C++ PATCH for c++/51747 (list-initialization from same type)

2014-04-15 Thread Marc Glisse
On Tue, 15 Apr 2014, Jason Merrill wrote: On 04/14/2014 06:02 PM, Marc Glisse wrote: shouldn't the same also apply if VECTOR_TYPE_P (type), not just for CLASS_TYPE_P (type)? Sure. Do you want to make that change? I can add || VECTOR_TYPE_P (type), yes, but I thought you might have ideas

Re: [v3] Slightly improve operator new

2014-04-15 Thread Marc Glisse
Ping http://gcc.gnu.org/ml/gcc-patches/2014-03/msg00051.html On Sun, 2 Mar 2014, Marc Glisse wrote: Hello, inlining operator new (with LTO or otherwise), I noticed that it has a complicated implementation, which makes it hard to use this inlined code for optimizations. This patch does two

Re: calloc = malloc + memset

2014-04-15 Thread Marc Glisse
Let me ping this. There's no hurry, but it may have got lost with 4.9 approaching. http://gcc.gnu.org/ml/gcc-patches/2014-03/msg01205.html On Sun, 23 Mar 2014, Marc Glisse wrote: On Mon, 3 Mar 2014, Richard Biener wrote: That's a bit much of ad-hoc pattern-matching ... wouldn't be p

Re: C++ PATCH for c++/51747 (list-initialization from same type)

2014-04-15 Thread Marc Glisse
On Tue, 15 Apr 2014, Jason Merrill wrote: It's just vectors, because they're an extension; the patch I checked in covered the standard language. Like this? (regtested on x86_64-linux-gnu) 2014-04-16 Marc Glisse marc.gli...@inria.fr gcc/cp/ * decl.c (reshape_init_r): Handle

Re: [PATCH 1/3] libstdc++: Add time_get::get support.

2014-04-15 Thread Marc Glisse
On Tue, 15 Apr 2014, Paolo Carlini wrote: Anyway, the real issue is indeed that implementing those bits requires a new virtual function, and that would break the ABI. What is the status of the ABI half-break plan (abi_tag and such), necessary to get the remaining pieces of C++11? -- Marc

version typeinfo for 128bit types

2014-04-14 Thread Marc Glisse
:_ZNSt20bad_array_new_lengthC2Ev@@CXXABI_1.3.8 FUNC:_ZNSt14numeric_limitsIdE8infinityEv@@GLIBCXX_3.4 FUNC:_ZN10__cxxabiv117__class_type_info16__dyncast_resultC1Ei@@CXXABI_1.3 etc. Bootstrap+testsuite on x86_64-linux-gnu. 2014-04-14 Marc Glisse marc.gli...@inria.fr PR libstdc++/43622

Re: [C PATCH] Make attributes accept enum values (PR c/50459)

2014-04-14 Thread Marc Glisse
); +} + return val; +} If val is NULL, it seems you still end up looking at its TREE_CODE? (don't know if that can happen) In C++, default_conversion probably handles IDENTIFIER_NODE just fine, but having different code for the 2 languages would not be nice, right? -- Marc Glisse

Re: Optimize n?rotate(x,n):x

2014-04-14 Thread Marc Glisse
On Mon, 14 Apr 2014, Richard Biener wrote: + /* If the special case has a high probability, keep it. */ + if (EDGE_PRED (middle_bb, 0)-probability PROB_EVEN) I suppose Honza has a comment on how to test this properly (not sure if -probability or -frequency is always initialized properly).

Re: C++ PATCH for c++/51747 (list-initialization from same type)

2014-04-14 Thread Marc Glisse
the same also apply if VECTOR_TYPE_P (type), not just for CLASS_TYPE_P (type)? Testcase in: http://stackoverflow.com/questions/23070982/c-initialization-of-intel-simd-intrinsics-class-members -- Marc Glisse

Re: [patch] change specific int128 - generic intN

2014-04-14 Thread Marc Glisse
On Mon, 14 Apr 2014, DJ Delorie wrote: * rtti.c (emit_support_tinfos): Remove __int128-specific entries. Hello, I wanted to check the interaction with: http://gcc.gnu.org/ml/gcc-patches/2014-04/msg00618.html but I don't see where you moved the __int128 typeinfo generation.

[c++] typeinfo for target types

2014-04-13 Thread Marc Glisse
* + V typeinfo for __float128* + V typeinfo name for __float128 + V typeinfo name for __float128 const* + V typeinfo name for __float128* Bootstrap and testsuite on x86_64-linux-gnu (a bit of noise in tsan/tls_race.c). 2014-04-13 Marc

[i386] define __SIZEOF_FLOAT128__

2014-04-13 Thread Marc Glisse
+testsuite on x86_64-linux-gnu. 2014-04-13 Marc Glisse marc.gli...@inria.fr PR preprocessor/56540 * config/i386/i386-c.c (ix86_target_macros): Define __SIZEOF_FLOAT80__ and __SIZEOF_FLOAT128__. -- Marc GlisseIndex: gcc/config/i386/i386-c.c

Re: Optimize n?rotate(x,n):x

2014-04-13 Thread Marc Glisse
On Mon, 3 Mar 2014, Richard Biener wrote: On Sat, Mar 1, 2014 at 3:33 PM, Marc Glisse marc.gli...@inria.fr wrote: Hello, again, a stage 1 patch that I will ping then, but early comments are welcome. PR 59100 was asking to transform n?rotate(x,n):x to rotate(x,n) (because it can be hard

Re: [v3] complex functions with expression template reals

2014-04-12 Thread Marc Glisse
won't do it again in the future :-) -- Marc Glisse

Re: [v3] complex functions with expression template reals

2014-04-11 Thread Marc Glisse
date) -- Marc Glisse

Re: [v3] LWG 2106: move_iterator::reference

2014-04-11 Thread Marc Glisse
On Wed, 5 Mar 2014, Jonathan Wakely wrote: On 5 March 2014 19:36, Marc Glisse wrote: Hello, this issue got delayed in LWG, apparently because of a failed improvement to the wording along the way (happens, that's ok), but there seems to be a consensus on the resolution and I don't really see

[i386] Replace builtins with vector extensions

2014-04-11 Thread Marc Glisse
waiting to see if this patch is accepted before doing more. Bootstrap+testsuite on x86_64-linux-gnu. 2014-04-11 Marc Glisse marc.gli...@inria.fr * config/i386/xmmintrin.h (_mm_add_ps, _mm_sub_ps, _mm_mul_ps, _mm_div_ps, _mm_store_ss, _mm_cvtss_f32): Use vector extensions

Re: [PATCH] Fix PR c++/60764

2014-04-09 Thread Marc Glisse
should be counted from two, not one, when giving values for string-index and first-to-check. It would be strange to count arguments differently for different attributes. -- Marc Glisse

Re: Warn when returning the address of a temporary (middle-end)

2014-04-07 Thread Marc Glisse
(gimple_location (stmt), OPT_Wreturn_local_addr, + function returns address of local variable)) That's a front-end option, I should either move it to gcc/common.opt or use a different option. -- Marc Glisse

Re: Warn when returning the address of a temporary (middle-end)

2014-04-07 Thread Marc Glisse
On Mon, 7 Apr 2014, Jeff Law wrote: On 04/05/14 07:52, Marc Glisse wrote: Hello, we have front-end warnings about returning the address of a local variable. However, quite often in C++, people don't directly return the address of a temporary, it goes through a few functions which hide

Re: Warn when returning the address of a temporary (middle-end)

2014-04-07 Thread Marc Glisse
the return value in those cases, we can warn, but maybe we don't want to introduce a trap? Replacing the address with a null pointer seemed like a compromise, it will trap when you try to read it, but not if you ignore it. But if you think we can trap, ok. -- Marc Glisse

Warn when returning the address of a temporary (middle-end)

2014-04-05 Thread Marc Glisse
fix PR 60517, for that I was thinking of checking for memory reads if the first stop of walk_aliased_vdefs is a clobber (could also check __builtin_free), though I don't know in which pass to do that yet. 2014-04-05 Marc Glisse marc.gli...@inria.fr PR c++/60517 gcc/c/ * c

Re: Fix ipa-devirt ICE

2014-04-03 Thread Marc Glisse
provably instead of probably in the first two? -- Marc Glisse

Re: [PATCH][2/3] Fix PR54733 Optimize endian independent load/store

2014-04-02 Thread Marc Glisse
in b-a. Richard+GSoC will supposedly soon provide a function that does that. -- Marc Glisse

Re: [PATCH] Fix undefined behavior in IRA

2014-03-26 Thread Marc Glisse
like long long (HOST_WIDEST_INT?) make more sense than unsigned? -- Marc Glisse

Re: [PATCH] Add test for PR c++/53711

2014-03-24 Thread Marc Glisse
entries, but don't be surprised when some go missing. -- Marc Glisse

Re: calloc = malloc + memset

2014-03-23 Thread Marc Glisse
be another option I guess (it would require implementing the clone method), but without a testcase showing it is needed... Passes bootstrap+testsuite on x86_64-linux-gnu. 2014-03-23 Marc Glisse marc.gli...@inria.fr PR tree-optimization/57742 gcc/ * tree-ssa-strlen.c

Re: How my codes comply with gcc code formatting?

2014-03-05 Thread Marc Glisse
yet: http://gcc.gnu.org/wiki/FormattingCodeForGCC (you can wrap that in a function and use an autocmd to enable it only for some directories for instance) -- Marc Glisse

<    5   6   7   8   9   10   11   12   13   14   >