Re: [Patch] sext_hwi: Avoid left shift of negative value undefined behaviour

2015-08-13 Thread Markus Trippelsdorf
On 2015.08.13 at 15:40 +0200, Marek Polacek wrote: > On Thu, Aug 13, 2015 at 01:11:53PM +0200, Richard Biener wrote: > > Rather ubsan should not complain about implementation defined behavior (or > > should separate those cases out with a different switch compared to > > undefined > > behavior). >

Re: [Patch] sext_hwi: Avoid left shift of negative value undefined behaviour

2015-08-13 Thread Markus Trippelsdorf
On 2015.08.13 at 12:56 +0200, Mikael Morin wrote: > Le 12/08/2015 22:07, Richard Sandiford a écrit : > > Jeff Law writes: > >> On 08/12/2015 12:32 PM, Richard Biener wrote: > >>> On August 12, 2015 8:07:13 PM GMT+02:00, Jeff Law wrote: > On 08/12/2015 11:12 AM, Richard Biener wrote: > >

Re: [PATCH 2/2] replace several uses of the anon namespace with GCC_FINAL

2015-08-12 Thread Markus Trippelsdorf
On 2015.08.12 at 13:03 -0600, Jeff Law wrote: > On 08/12/2015 12:57 PM, Richard Sandiford wrote: > > Jeff Law writes: > >> On 08/10/2015 06:05 AM, tbsaunde+...@tbsaunde.org wrote: > >>> From: Trevor Saunders > >>> > >>> Hi, > >>> > >>> In many places gcc puts classes in the anon namespace so the

Re: [PATCH][1/2] Make SCCVN use conditional equivalences

2015-08-12 Thread Markus Trippelsdorf
On 2015.08.12 at 09:32 +0200, Richard Biener wrote: > > This is the first patch in the series to make SCCVN able to remove > redundant comparisons by recording conditionals being true on > visited edges. This part of the series fully transitions the > toplevel walk gathering entries to SCCs we va

Re: [Patch] sext_hwi: Avoid left shift of negative value undefined behaviour

2015-08-12 Thread Markus Trippelsdorf
On 2015.08.12 at 13:01 +0200, Richard Biener wrote: > On Tue, Aug 11, 2015 at 9:49 PM, Jeff Law wrote: > > On 08/06/2015 04:25 AM, Mikael Morin wrote: > >> > >> Hello, > >> > >> this avoids an error found with bootstrap-ubsan. > >> Regression tested on x86_64-unknown-linux-gnu. OK for trunk? > >>

Re: [PATCH 2/2] replace several uses of the anon namespace with GCC_FINAL

2015-08-10 Thread Markus Trippelsdorf
On 2015.08.10 at 08:05 -0400, tbsaunde+...@tbsaunde.org wrote: > > In many places gcc puts classes in the anon namespace so the compiler can tell > they do not get inheritted from to enable better devirtualization. However > debugging code in the anon namespace can be a pain, and the same thing c

Re: [PATCH] Make SSA propagator iteration order consistent

2015-07-08 Thread Markus Trippelsdorf
On 2015.07.06 at 14:40 +0200, Richard Biener wrote: > > The intent (as I read it) of the iteration order in ssa_propagate is > to process stmts in the following order: > > 1) complete simulation of BBs from making one of their entries executable > 2) simulation of stmts fed by stmts that change

Re: Add .def file for public target instructions

2015-06-26 Thread Markus Trippelsdorf
On 2015.06.23 at 19:41 +0100, Richard Sandiford wrote: > > gcc/ > * Makefile.in (TARGET_DEF): Add target-insns.def. > (.PRECIOUS, simple_rtl_generated_h): Add insn-target-def.h. > (build/gentarget-def.o): New rule. > (genprogrtl): Add target-def. > * target-insns.def,

Re: ODR merging and implicit typedefs

2015-05-19 Thread Markus Trippelsdorf
On 2015.05.19 at 19:33 +0200, Jan Hubicka wrote: > > Jason, > I just noticed that there are bogus ODR violation warnings during > LTO-bootstrap > (that breaks -Werror builds). It was caused by my work-around for > type_in_anonymous_namespace > for the issue discussed in: > https://gcc.gnu.org/m

Re: C PATCH for -Wshift-negative-value (PR c/66066)

2015-05-11 Thread Markus Trippelsdorf
On 2015.05.11 at 17:54 +0200, Marek Polacek wrote: > On Mon, May 11, 2015 at 05:09:26PM +0200, Manuel López-Ibáñez wrote: > > On 11/05/15 16:21, Marek Polacek wrote: > > >The -Wshift-negative-value patch caused grief since it breaks building > > >some programs. The following patch should alleviate

Re: PATCHes to help with C++11 bootstrap

2015-05-11 Thread Markus Trippelsdorf
This broke bootstrap on ppc64. Fix committed as obvious. 2015-05-11 Markus Trippelsdorf PR bootstrap/66105 * config/rs6000/option-defaults.h: Add space between string literal and macro name. diff --git a/gcc/config/rs6000/option-defaults.h b/gcc/config/rs6000/o

Re: PATCHes to help with C++11 bootstrap

2015-05-09 Thread Markus Trippelsdorf
On 2015.05.08 at 23:30 -0500, Jason Merrill wrote: > One C++11 compatibility issue that turns up a lot in the GCC sources is > that in C++98, > > #define BAR "bar" > const char *p = "foo"BAR; > > is well-formed, giving p the value "foobar". But in C++11 this is a > user-defined literal with th

Re: [C/C++ PATCH] Implement -Wshift-negative-value (PR c/65179)

2015-05-08 Thread Markus Trippelsdorf
On 2015.05.08 at 09:38 -0700, Steve Ellcey wrote: > > This patch has broken the glibc build. I am not sure if the problem is > a bug in your patch or a bug in the code used by glibc. Here is a > cutdown test case from glibc (timezone/scheck.c). This code compiled > before your patch but now it

Re: C++ PATCH for c++/50800 (ICE with may_alias and templates)

2015-04-29 Thread Markus Trippelsdorf
On 2015.04.28 at 10:42 -0400, Jason Merrill wrote: > On 04/23/2015 01:45 PM, H.J. Lu wrote: > > On Thu, Apr 23, 2015 at 8:52 AM, Jason Merrill wrote: > >> We try to strip attributes that aren't reflected in mangling from template > >> arguments, but were failing to do that in this case. Fixed by

[PATCH] Fix PR65911

2015-04-28 Thread Markus Trippelsdorf
During the removal of "#if ARGS_GROW_DOWNWARD" in r222508, Trevor forgot to add parentheses around a ternary operator. Tested on powerpc64-unknown-linux-gnu. Preapproved by Jakub and Richard on bugzilla. Commited to trunk. 2015-04-28 Markus Trippelsdorf PR o

Re: [PATCH, libmpx, i386, PR driver/65444] Pass '-z bndplt' when building dynamic objects with MPX

2015-04-07 Thread Markus Trippelsdorf
On 2015.04.07 at 12:28 -0700, H.J. Lu wrote: > You can't have it both ways. If the common usage is targeting > distributions, -z bndplt should always be passed to ld for MPX > since distributions should have the proper linker for MPX. Why don't you just implement -z bndplt for gold? -- Markus

Re: C++ PATCH for c++/65046 (ABI tags and functions/variables)

2015-04-06 Thread Markus Trippelsdorf
On 2015.04.06 at 16:45 -0400, Jason Merrill wrote: > On 04/06/2015 09:23 AM, Markus Trippelsdorf wrote: > > The issue is that clang uses the new libstdc++ ABI just fine. And before > > this commit one could switch compilers without any problems... > > Hmm, I suppose that when

Re: C++ PATCH for c++/65046 (ABI tags and functions/variables)

2015-04-06 Thread Markus Trippelsdorf
On 2015.04.06 at 08:41 -0400, Jason Merrill wrote: > On 04/04/2015 07:38 AM, Markus Trippelsdorf wrote: > > This breaks compatibility with other compilers. Consider the case when > > a user compiles a library, that contains e.g. some member function with > > a std::string re

Re: C++ PATCH for c++/65046 (ABI tags and functions/variables)

2015-04-04 Thread Markus Trippelsdorf
On 2015.03.19 at 15:17 -0400, Jason Merrill wrote: > This patch makes some significant changes to attribute abi_tag. > > First, it allows explicit naming of tags on inline namespaces, which > previously always had a tag with the same name as the namespace itself; > this is still the default if n

Re: Fix can_inline_edge_p and code marking calls unreachable

2015-03-26 Thread Markus Trippelsdorf
On 2015.03.27 at 00:46 +0100, Jan Hubicka wrote: > > On 26 March 2015 at 22:12, Jan Hubicka wrote: > > After this fix, I can see build failures in glibc: > > key_call.c:574:1: internal compiler error: in inline_call, at > > ipa-inline-transform.c:386 > > Can you please send me preprocessed testca

Re: [PATCH, libmpx, i386, PR driver/65444] Pass '-z bndplt' when building dynamic objects with MPX

2015-03-18 Thread Markus Trippelsdorf
On 2015.03.18 at 10:03 -0400, Robert Dewar wrote: > Do we really want to quote to this level? This message has 11 levels of > quotes, the most I have ever seen. If everyone does this, the whole > thread is in every message and that seems unnecessary. I don't know if > there are gcc guidelines on

Re: Add a blurb about __has_cpp_attribute and __has_attribute to gcc-5/changes.

2015-03-10 Thread Markus Trippelsdorf
On 2015.01.26 at 23:22 -0500, Ed Smith-Rowland wrote: > Gerald, > > Could I get a hand on checking in this last addition? > > -m 'Add a blurb to htdocs/gcc-5/changes.html to explain the > __has_cpp_attribute and > the equivalent __has_attribute macros.' > > Thanks, Ping? And maybe add a word

Re: [PATCH] target/65286 - Disable multilib for ppc64le

2015-03-10 Thread Markus Trippelsdorf
On 2015.03.10 at 08:56 +0100, Jakub Jelinek wrote: > On Tue, Mar 10, 2015 at 08:32:59AM +0100, Markus Trippelsdorf wrote: > > On 2015.03.10 at 17:58 +1030, Alan Modra wrote: > > > On Tue, Mar 10, 2015 at 07:13:48AM +0100, Markus Trippelsdorf wrote: > > > > This pat

Re: [PATCH] target/65286 - Disable multilib for ppc64le

2015-03-10 Thread Markus Trippelsdorf
On 2015.03.10 at 17:58 +1030, Alan Modra wrote: > On Tue, Mar 10, 2015 at 07:13:48AM +0100, Markus Trippelsdorf wrote: > > This patch breaks the build on ppc64le: > > Works for me with your configure options. > > > trippels@gcc2-power8 gcc_build_dir % ../gcc/con

Re: [PATCH] target/65286 - Disable multilib for ppc64le

2015-03-09 Thread Markus Trippelsdorf
On 2015.03.09 at 14:00 -0400, David Edelsohn wrote: > On Thu, Mar 5, 2015 at 6:14 PM, Alan Modra wrote: > > This arranges to build a powerpc64le-linux compiler without -m32 > > support by default. Bootstrapped and regression tested on Ubuntu > > powerpc64le-linux without --disable-multilib, and o

Re: [PATCH] Fix PR65261

2015-03-02 Thread Markus Trippelsdorf
On 2015.03.02 at 18:53 +0100, Marek Polacek wrote: > On Mon, Mar 02, 2015 at 06:22:49PM +0100, Markus Trippelsdorf wrote: > > --- a/libcpp/lex.c > > +++ b/libcpp/lex.c > > @@ -519,6 +519,7 @@ init_vectorized_lexer (void) > > and VSX unaligned loads (when VSX is ava

[PATCH] Fix PR65261

2015-03-02 Thread Markus Trippelsdorf
to forced-alignment on POWER8. So just silence the ubsan errors. Tested with bootstrap-ubsan on ppc64le. OK for trunk? Thanks. 2015-03-02 Markus Trippelsdorf PR target/65261 * lex.c (init_vectorized_lexer): Silence ubsan errors. diff --git a/libcpp/lex.c b/libcpp/lex.c ind

Re: [PATCH, libsanitizer] Enable for PowerPC little endian

2015-02-27 Thread Markus Trippelsdorf
On 2015.02.27 at 07:47 -0600, Peter Bergner wrote: > > Ok, since the results met your criteria for inclusion, I committed the > change as revision 221060. Thanks. Are there any plans to fix: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63927 ? -- Markus

Re: ipa-icf::merge TLC

2015-02-25 Thread Markus Trippelsdorf
On 2015.02.25 at 19:32 +0100, Martin Liška wrote: > On 02/25/2015 06:15 PM, Jan Hubicka wrote: > >> On 2015.02.25 at 09:38 +0100, Jan Hubicka wrote: > >>> this patch reorganize sem_function::merge and sem_variable::merge. > >>> I read the code in detail and found several issues that are fixed in th

Re: ipa-icf::merge TLC

2015-02-25 Thread Markus Trippelsdorf
On 2015.02.25 at 09:38 +0100, Jan Hubicka wrote: > this patch reorganize sem_function::merge and sem_variable::merge. > I read the code in detail and found several issues that are fixed in the > following patch. I gave your patch a quick spin. It breaks Chromium. Its protocol buffer compiler gets

Re: [PATCH] Use !implicit_section in the recent set_section change (PR ipa/65087)

2015-02-18 Thread Markus Trippelsdorf
On 2015.02.18 at 10:17 +0100, Jan Hubicka wrote: > > On 2015.02.17 at 22:00 +0100, Jan Hubicka wrote: > > > > Hi! > > > > > > > > Markus reported an ICE, that is fixed by following patch, which limits > > > > the earlier change to !implicit_section only (which I assume is the user > > > > supplied

Re: [PATCH] Use !implicit_section in the recent set_section change (PR ipa/65087)

2015-02-17 Thread Markus Trippelsdorf
On 2015.02.17 at 22:00 +0100, Jan Hubicka wrote: > > Hi! > > > > Markus reported an ICE, that is fixed by following patch, which limits > > the earlier change to !implicit_section only (which I assume is the user > > supplied __attribute__((section (. > > > > Bootstrapped/regtested on > > {x

Re: PR lto/64837: lto plugin doesn't call ld_plugin_release_input_file

2015-02-06 Thread Markus Trippelsdorf
On 2015.02.06 at 05:10 -0800, H.J. Lu wrote: > On Fri, Feb 6, 2015 at 4:56 AM, Markus Trippelsdorf > wrote: > > On 2015.02.05 at 12:57 -0800, H.J. Lu wrote: > >> > >> We should pass handle, not file, to release_input_file. > >> I checked it in as an

Re: PR lto/64837: lto plugin doesn't call ld_plugin_release_input_file

2015-02-06 Thread Markus Trippelsdorf
On 2015.02.05 at 12:57 -0800, H.J. Lu wrote: > > We should pass handle, not file, to release_input_file. > I checked it in as an obvious fix. This commit causes: % echo "int main () {}" | gcc -fuse-ld=gold -flto -x c++ - ld.gold: internal error in remove_writer, at token.h:132 collect2: error:

Re: Fix profile merging WRT speculative edges

2015-01-20 Thread Markus Trippelsdorf
On 2015.01.20 at 21:04 +0100, Jan Hubicka wrote: > this patch fixes ICE in ipa_merge_profiles on speculative edges. > > Bootstrapped/regtested x86_64-linux, comitted. Also tested by Markus on > Firefox build. This needs one additional fix. See below. > PR ipa/63576 > * ipa-utils.c (

Re: [RFC, PATCH][LRA, MIPS] ICE: in decompose_normal_address, at rtlanal.c:5817

2015-01-16 Thread Markus Trippelsdorf
On 2015.01.16 at 14:56 +0100, Markus Trippelsdorf wrote: > On 2015.01.14 at 17:10 +, Robert Suchanek wrote: > > + u = v; > > + r = b | a[4]; > > + return e; > > + > > There is a missing } in the testcase. Fixed in r219740 as obvious. -- Markus

Re: [RFC, PATCH][LRA, MIPS] ICE: in decompose_normal_address, at rtlanal.c:5817

2015-01-16 Thread Markus Trippelsdorf
On 2015.01.14 at 17:10 +, Robert Suchanek wrote: > Here is the revised patch that would handle the other cases as per Richard's > comments. > > I slightly modified Matthew's proposed patch and used split_const > instead of get_related_value. AFAICS, the canonical form would always have > the '

Re: Fix profiledbootstrap with release checking

2015-01-16 Thread Markus Trippelsdorf
On 2015.01.16 at 12:03 +0100, Richard Biener wrote: > On Fri, Jan 16, 2015 at 9:34 AM, Markus Trippelsdorf > wrote: > > On 2015.01.16 at 00:15 +0100, Jan Hubicka wrote: > >> Hi, > >> can_remove_node_now_p assumes that the node in question has no direct > &

Re: Fix profiledbootstrap with release checking

2015-01-16 Thread Markus Trippelsdorf
egtested x86_64-linux, comitted. Here's a testcase for this issue. OK for trunk? 2015-01-16 Markus Trippelsdorf PR ipa/64163 PR ipa/64612 * g++.dg/ipa/pr64612.C: New test. /* { dg-do compile } */ /* { dg-options "-fPIC -O3 -std=c++11"

Re: Simplify badness metrics in inliner, take 2

2015-01-12 Thread Markus Trippelsdorf
On 2015.01.12 at 10:59 +0100, Markus Trippelsdorf wrote: > On 2015.01.12 at 10:30 +0100, Jan Hubicka wrote: > > this is variant of my earlier patch I comited. It solves issues with > > -fprofile-use > > and various roundoff errors that triggered sanity checks (partly b

Re: Simplify badness metrics in inliner, take 2

2015-01-12 Thread Markus Trippelsdorf
On 2015.01.12 at 10:30 +0100, Jan Hubicka wrote: > this is variant of my earlier patch I comited. It solves issues with > -fprofile-use > and various roundoff errors that triggered sanity checks (partly by disabling > them). The new assert triggers during Firefox LTO build on ppc64: (final libx

Re: Strenghten early inliner analysis

2014-12-30 Thread Markus Trippelsdorf
On 2014.12.30 at 12:37 +0100, Jan Hubicka wrote: > Hi, > this patch enables inline predicates for early inlining, too. This is easy > to do because > we do have call stmt around and know if parameters are constants. > > Bootstrapped/regtested x86_64-linux, comitted. This causes Firefox LTO buil

Re: [Patch] Improving jump-thread pass for PR 54742

2014-11-25 Thread Markus Trippelsdorf
On 2014.11.24 at 22:05 +, Sebastian Pop wrote: > I got my scripts installed on the gcc-farm. I first used an x86_64 gcc75 and > valgrind was crashing not recognizing how to decode an instruction. Then I > moved to gcc112 a powerpc64-linux where I got this data from stage2 cc1plus > compiling

[PATCH] Fix PR64059

2014-11-24 Thread Markus Trippelsdorf
This fixes PR64059 where a call to get_dynamic_type wasn't guarded by flag_devirtualize. Tested on powerpc64-unknown-linux-gnu. Preapproved by Honza on bugzilla. Commited to trunk. PR ipa/64059 * ipa-prop.c (ipa_analyze_call_uses): Don't call get_dynamic_type when devirtua

Re: [PATCH] IPA ICF: memory leak fix

2014-11-23 Thread Markus Trippelsdorf
On 2014.11.22 at 17:46 +0100, Markus Trippelsdorf wrote: > On 2014.11.22 at 16:04 +0100, Martin Liška wrote: > > On 11/22/2014 10:09 AM, Markus Trippelsdorf wrote: > > > On 2014.11.22 at 09:05 +0100, Martin Liška wrote: > > >> > > >> Following patch remov

Re: [PATCH] IPA ICF: memory leak fix

2014-11-22 Thread Markus Trippelsdorf
On 2014.11.22 at 16:04 +0100, Martin Liška wrote: > On 11/22/2014 10:09 AM, Markus Trippelsdorf wrote: > > On 2014.11.22 at 09:05 +0100, Martin Liška wrote: > >> > >> Following patch removes memory leak that was introduced by very first IPA > >> ICF patch.

Re: [PATCH] IPA ICF: memory leak fix

2014-11-22 Thread Markus Trippelsdorf
On 2014.11.22 at 09:05 +0100, Martin Liška wrote: > Hello. > > Following patch removes memory leak that was introduced by very first IPA ICF > patch. > I would like to thank David for hunting the leak. > > Patch an bootstrap on x86_86-linux-pc and no regression is introduced. I gave the patch a

Re: [PATCH]Add myself to MAINTAINERS

2014-11-21 Thread Markus Trippelsdorf
On 2014.11.21 at 11:42 +, Richard Earnshaw wrote: > On 21/11/14 11:16, Renlin Li wrote: > > Hi, > > > > This patch is to add myself into section of > > MAINTAINERS file. > > > > Is it Okay to commit? > > OK There is no need to ask for permission in this case: http://gcc.gnu.org/svnwrite.h

Re: [PATCH] rs6000: Follow up for signed integer overflow fix

2014-11-20 Thread Markus Trippelsdorf
On 2014.11.20 at 19:44 +0100, Jakub Jelinek wrote: > On Thu, Nov 20, 2014 at 07:41:43PM +0100, Markus Trippelsdorf wrote: > > 2014-11-20 Markus Trippelsdorf > > > > * config/rs6000/rs6000.c (includes_rldic_lshift_p): Cast 0 to unsigned. > > (includes

[PATCH] rs6000: Follow up for signed integer overflow fix

2014-11-20 Thread Markus Trippelsdorf
On 2014.11.20 at 08:59 -0500, David Edelsohn wrote: > On Thu, Nov 20, 2014 at 8:27 AM, Markus Trippelsdorf > wrote: > > Running the testsuite after bootstrap-ubsan on gcc112 shows several issues. > > See > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63426 for the full

[PATCH] PR63426 Fix various signed integer overflows

2014-11-20 Thread Markus Trippelsdorf
Running the testsuite after bootstrap-ubsan on gcc112 shows several issues. See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63426 for the full list. This patch fixes several of them. Tested on powerpc64-unknown-linux-gnu. OK for trunk? Thanks. 2014-11-20 Markus Trippelsdorf

Re: [PATCH] rs6000: Fix signed integer overflows

2014-11-19 Thread Markus Trippelsdorf
On 2014.11.19 at 11:20 -0500, David Edelsohn wrote: > On Wed, Nov 19, 2014 at 10:24 AM, Markus Trippelsdorf > wrote: > > bootstrap-ubsan on gcc112 shows a couple of signed integer overflows: > > > The fix was tested on powerpc64-unknown-linux-gnu. > > OK f

[PATCH] rs6000: Fix signed integer overflows

2014-11-19 Thread Markus Trippelsdorf
n unsigned type to negate this value to itself config/rs6000/predicates.md:955:12: runtime error: negation of -9223372036854775808 cannot be represented in type 'long int'; cast to an unsigned type to negate this value to itself The fix was tested on powerpc64-unknown-linux-gnu. OK for trunk

Re: [BUILDROBOT] Build breakage in builtin.c (was: [PATCH, Pointer Bounds Checker, Builtins instrumentation 3/5] Expand instrumented builtin calls)

2014-11-17 Thread Markus Trippelsdorf
On 2014.11.17 at 15:52 +0100, Jan-Benedict Glaw wrote: > On Thu, 2014-11-06 15:24:59 +0300, Ilya Enkovich > wrote: > > Hi, > > > > This patch adds support of instrumented builtin calls in expand. > > Calls are mostly expanded as calls. But some of them reuse existing > > string function calls e

Re: [patch] New std::string implementation

2014-11-17 Thread Markus Trippelsdorf
On 2014.11.14 at 15:43 +, Jonathan Wakely wrote: > Tested on x86_64-linux and powerpc64-linux, also with > --disable-libstdcxx11-abi to verify all the incompatible changes can > be disabled if needed. On ppc64 I get: FAIL: libstdc++-abi/abi_check FAIL: 27_io/basic_ios/copyfmt/char/1.cc execut

[PATCH] Add testcase for PR 63894

2014-11-17 Thread Markus Trippelsdorf
PR 63894 was fixed by r217634, so I'm just adding the testcase. Tested on powerpc64-unknown-linux-gnu. Commited. 2014-11-17 Markus Trippelsdorf PR ipa/63894 * g++.dg/ipa/pr63894.C: New test. diff --git a/gcc/testsuite/g++.dg/ipa/pr63894.C b/gcc/testsuite/g++.dg/ipa/pr63894.C new

Re: Drop target_option_node reconstruction logic.

2014-11-14 Thread Markus Trippelsdorf
On 2014.11.14 at 20:13 +0100, Jan Hubicka wrote: > this patch kills lto's code to rebuilt DECL_FUNCTION_SPECIFIC_TARGET from > target > attributes. This code was never complete and it should be no-op now when we > save > tehe target nodes. > It also makes free_land_data_in_decl to actually anota

Re: [PATCH 2/4] New data structure for cgraph_summary introduced.

2014-11-13 Thread Markus Trippelsdorf
On 2014.11.14 at 01:19 -0500, Trevor Saunders wrote: > On Thu, Nov 13, 2014 at 03:48:34PM +0100, Markus Trippelsdorf wrote: > > On 2014.11.13 at 15:11 +0100, mliska wrote: > > > > > + /* Destructor. */ > > > + virtual ~cgraph_summary

Re: [PATCH 2/4] New data structure for cgraph_summary introduced.

2014-11-13 Thread Markus Trippelsdorf
On 2014.11.13 at 15:11 +0100, mliska wrote: Just two remarks: > +template > +class GTY((user)) cgraph_summary > +{ > +public: > + /* Default construction takes SYMTAB as an argument. */ > + cgraph_summary (symbol_table *symtab, bool ggc = false): m_ggc (ggc), > +m_insertion_enabled (true

Re: [PATCH] PR36312

2014-11-12 Thread Markus Trippelsdorf
On 2014.11.05 at 18:32 +0100, Manuel López-Ibáñez wrote: > > I committed this as r217149. This patch causes kernel build failures when using GCC_COMPARE_DEBUG=1. "GCC_COMPARE_DEBUG=1 make CC=/var/tmp/gcc_trunk/usr/local/bin/gcc" is enough to reproduce. See: https://gcc.gnu.org/bugzilla/show_bug

Re: Add the latest C++ SD-6 additions.

2014-11-12 Thread Markus Trippelsdorf
On 2014.11.11 at 19:15 +0100, Markus Trippelsdorf wrote: > On 2014.11.10 at 10:55 -0500, Ed Smith-Rowland wrote: > > On 11/09/2014 11:45 PM, Jason Merrill wrote: > > > On 11/09/2014 08:33 PM, Ed Smith-Rowland wrote: > > >> + //cpp_hashnode *node = 0; > > >

Re: [PATCH] Fix PR56480 aka DR374. Allow explicit specialization in enclosing namespace.

2014-11-11 Thread Markus Trippelsdorf
On 2014.11.11 at 13:39 -0500, Jason Merrill wrote: > On 11/11/2014 10:37 AM, Markus Trippelsdorf wrote: > > On 2014.11.11 at 10:11 -0500, Jason Merrill wrote: > >> On 11/08/2014 06:57 AM, Markus Trippelsdorf wrote: > >>> +++ b/gcc/testsuite/g++.old-deja/g++.pt/e

Re: Add the latest C++ SD-6 additions.

2014-11-11 Thread Markus Trippelsdorf
On 2014.11.10 at 10:55 -0500, Ed Smith-Rowland wrote: > On 11/09/2014 11:45 PM, Jason Merrill wrote: > > On 11/09/2014 08:33 PM, Ed Smith-Rowland wrote: > >> + //cpp_hashnode *node = 0; > >> + //node = token->val.node.node; > >> + //if (node) > >> + // pfile->mi_ind_cmacro = node; > > > >

Re: [PATCH] Fix PR56480 aka DR374. Allow explicit specialization in enclosing namespace.

2014-11-11 Thread Markus Trippelsdorf
On 2014.11.11 at 10:11 -0500, Jason Merrill wrote: > On 11/08/2014 06:57 AM, Markus Trippelsdorf wrote: > > +++ b/gcc/testsuite/g++.old-deja/g++.pt/explicit73.C > > @@ -7,9 +7,9 @@ > > // the template > > > > namespace N { > > - template class foo;

Re: PATCH: PR bootstrap/63784: [5 Regression] profiledbootstrap failure with bootstrap-lto

2014-11-10 Thread Markus Trippelsdorf
On 2014.11.10 at 12:05 -0800, H.J. Lu wrote: > On Mon, Nov 10, 2014 at 11:57 AM, Markus Trippelsdorf > wrote: > > On 2014.11.10 at 11:43 -0800, H.J. Lu wrote: > >> On Mon, Nov 10, 2014 at 6:24 AM, Jakub Jelinek wrote: > >> > On Mon, Nov 10, 2014 at 02:44

Re: PATCH: PR bootstrap/63784: [5 Regression] profiledbootstrap failure with bootstrap-lto

2014-11-10 Thread Markus Trippelsdorf
On 2014.11.10 at 11:43 -0800, H.J. Lu wrote: > On Mon, Nov 10, 2014 at 6:24 AM, Jakub Jelinek wrote: > > On Mon, Nov 10, 2014 at 02:44:55PM +0100, Richard Biener wrote: > >> >> > I admit I haven't tried LTO bootstrap, but from normal bootstrap logs, > >> >> > libcc1 is built normally using libtool

[PATCH] Fix PR56480 aka DR374. Allow explicit specialization in enclosing namespace.

2014-11-08 Thread Markus Trippelsdorf
testsuite and building Firefox.) OK for trunk? Thanks again. 2014-11-08 Markus Trippelsdorf gcc/cp/ChangeLog: * decl.c (grokfndecl): Also pass through in_namespace. * pt.c (check_instant_or_special_namespace): Consolidate check_specialization_namespace and

[RFC PATCH v4] Fix PR56480 aka DR374. Allow explicit specialization in enclosing namespace.

2014-11-04 Thread Markus Trippelsdorf
On 2014.11.03 at 08:47 -0600, Jason Merrill wrote: > On 11/03/2014 05:27 AM, Markus Trippelsdorf wrote: > > BTW both EDG and clang reject g++.dg/template/spec17.C: > > > > namespace io { > >template int foo(); > > } > > using namespace io; > > temp

Re: [PATCH v3] Fix PR56480 aka DR374. Allow explicit specialization in enclosing namespace.

2014-11-03 Thread Markus Trippelsdorf
On 2014.11.03 at 08:47 -0600, Jason Merrill wrote: > On 11/03/2014 05:27 AM, Markus Trippelsdorf wrote: > > BTW both EDG and clang reject g++.dg/template/spec17.C: > > > > namespace io { > >template int foo(); > > } > > using namespace io; > > temp

[PATCH v3] Fix PR56480 aka DR374. Allow explicit specialization in enclosing namespace.

2014-11-03 Thread Markus Trippelsdorf
On 2014.11.02 at 21:12 -0500, Jason Merrill wrote: > On 11/02/2014 09:15 AM, Markus Trippelsdorf wrote: > > + if (cxx_dialect < cxx11) > > + { > > + permerror (input_location, "specialization of %qD in different " > > +

[PATCH v2] Fix PR56480 aka DR374. Allow explicit specialization in enclosing namespace.

2014-11-02 Thread Markus Trippelsdorf
skip the calls to permerror(). Tested on powerpc64-unknown-linux-gnu. OK for trunk? Thanks again. 2014-11-02 Markus Trippelsdorf DR 374 PR c++/56480 * pt.c (check_explicit_instantiation_namespace): Move above. * pt.c (check_specialization_namespace): Skip

Re: [PATCH] Fix PR56480 aka DR374. Allow explicit specialization in enclosing namespace.

2014-11-02 Thread Markus Trippelsdorf
On 2014.11.02 at 13:58 +0100, Markus Trippelsdorf wrote: > diff --git a/gcc/testsuite/g++.dg/template/spec25.C > b/gcc/testsuite/g++.dg/template/spec25.C > index 385d19ada0c4..d41c5fce1297 100644 > --- a/gcc/testsuite/g++.dg/template/spec25.C > +++ b/gcc/testsuite/g++.dg/te

[PATCH] Fix PR56480 aka DR374. Allow explicit specialization in enclosing namespace.

2014-11-02 Thread Markus Trippelsdorf
powerpc64-unknown-linux-gnu. OK for trunk? Thanks. 2014-11-02 Markus Trippelsdorf DR 374 PR c++/56480 * pt.c (check_specialization_namespace): Skip permerror() for C++11 and up. DR 374 PR c++/56480 * g++.dg/template/spec17.C: Don't dg-

[PATCH] Fix PR63649

2014-10-27 Thread Markus Trippelsdorf
When assigning symbols to sections in ipa-comdats.c we currently segfault when val is NULL. Fix by guarding against this case. Tested on powerpc64-unknown-linux-gnu. OK for trunk? 2014-10-27 Markus Trippelsdorf PR ipa/63649 * ipa-comdats.c (ipa_comdats): Guard against NULL

[PATCH] Fix bootstrap/PR63632

2014-10-23 Thread Markus Trippelsdorf
d and tested on powerpc64-unknown-linux-gnu. Preapproved by Jakub on IRC. Applied to trunk and 4.9 branch. 2014-10-24 Markus Trippelsdorf PR bootstrap/63632 * collect2.c (main): Filter out -fno-lto. PR bootstrap/63632 * g++.dg/torture/pr63632.C: New test. diff --git

Re: PR lto/63603: Fix -fno-lto handling in driver (gcc/gcc.c)

2014-10-23 Thread Markus Trippelsdorf
On 2014.10.22 at 13:57 +0200, Tobias Burnus wrote: > I intent to commit the following patch this evening, which was > pre-proved for 4.9/trunk by Richard in the PR. > However, I still need to do the bootstrapping and regtesting. This breaks bootstrap-lto: ... configure: error: Link tests are not a

Re: [PATCH] AutoFDO patch for trunk

2014-10-21 Thread Markus Trippelsdorf
On 2014.10.21 at 15:31 -0700, Dehao Chen wrote: > Looks like the perf data type is incompatible with quipper (perf data > parser). Can you send me the perf.data file so that I can take a look. PERF_RECORD_MMAP2 (aka 10) was added in Linux 3.12 (commit 13d7a2410f). So your autofdo tool simply doesn

Re: [PATCH] AutoFDO patch for trunk

2014-10-21 Thread Markus Trippelsdorf
On 2014.10.21 at 13:53 -0700, Dehao Chen wrote: > Everything will be the same on non-intel CPUs except for the perf command: > > perf record -e instructions -- your program. > > i.e. you need to drop "-b" and use instructions as event. > > Note that the current algorithm is tuned for accurate in

Re: [PATCH] AutoFDO patch for trunk

2014-10-21 Thread Markus Trippelsdorf
On 2014.10.20 at 14:21 -0700, Dehao Chen wrote: > >> +If @var{path} is specified, GCC looks at the @var{path} to find > >> +the profile feedback data files. > >> + > >> +In order to collect AutoFDO profile, you need to have: > >> + > >> +1. A linux system with linux perf support > >> +2. An Intel p

[PATCH v2] Fix pr61848, linux kernel miscompile

2014-10-16 Thread Markus Trippelsdorf
Override existing olddecl section name. Set tls_model for all thread-local vars, not just OMP thread-private ones. Remove incorrect comment. 2014-10-16 Markus Trippelsdorf PR middle-end/61848 g++.dg/torture/pr61848.C: New testcase. gcc.c-torture/compile

Re: __intN patch 3/5: main __int128 -> __intN conversion.

2014-10-15 Thread Markus Trippelsdorf
On 2014.10.15 at 17:00 -0400, DJ Delorie wrote: > > > If you could implement the second option, it would be appreciated. > > Could you please test this for me? It builds as a powerpc-elf > cross-compiler (at least the host half) but I don't have a power > machine here to test on. > > Index: rs6

Re: __intN patch 3/5: main __int128 -> __intN conversion.

2014-10-15 Thread Markus Trippelsdorf
On 2014.10.14 at 17:10 -0400, DJ Delorie wrote: > > > ../../gcc/gcc/config/rs6000/rs6000-c.c:237:24: error: ‘RID_INT128’ was not > > declared in this scope > > Two options: > > 1. If you know the RS6000 will never have any __intN other than >__int128, just use RID_INT_N_0, although this is

Re: __intN patch 3/5: main __int128 -> __intN conversion.

2014-10-14 Thread Markus Trippelsdorf
On 2014.08.25 at 23:03 -0400, DJ Delorie wrote: > > > I'd like to see the updated version of the whole of patch 3 (tested > > to be actually independent of the other patches) for review, though > > I won't be reviewing the C++ parts. > > Here it is. Tested on x86_64. I include the msp430-modes.

[PATCH] Fix r216010 fallout

2014-10-09 Thread Markus Trippelsdorf
This fixes fallout from r216010, which causes Firefox build failures. Just move the gcc_assert below the new if statement. Boostrapped and tested on powerpc64-unknown-linux-gnu. Ok for trunk? Thanks. 2014-10-09 Markus Trippelsdorf * pa-polymorphic-call.c (check_stmt_for_type_change

Re: RFA: one more version of the patch for PR61360

2014-10-02 Thread Markus Trippelsdorf
On 2014.10.02 at 09:17 +0200, Markus Trippelsdorf wrote: > On 2014.09.26 at 16:31 -0400, Vladimir Makarov wrote: > > I guess we achieved the consensus about the following patch to fix PR61360 > > > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61360 > > >

Re: RFA: one more version of the patch for PR61360

2014-10-02 Thread Markus Trippelsdorf
On 2014.09.26 at 16:31 -0400, Vladimir Makarov wrote: > I guess we achieved the consensus about the following patch to fix PR61360 > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61360 > > The patch was successfully bootstrapped and tested (w/wo > -march=amdfam10) on x86/x86-64. > > Is it ok t

Re: [PATCH v2] Fix signed integer overflow in gcc/data-streamer.c

2014-09-30 Thread Markus Trippelsdorf
On 2014.09.28 at 14:57 +0200, Markus Trippelsdorf wrote: > On 2014.09.28 at 14:36 +0200, Steven Bosscher wrote: > > > > Can you use HOST_WIDE_INT_1U for this? > > Sure. Thanks for the suggestion. > (Fix now resembles similar idiom in data-streamer-in.c) I check

[PATCH v2] Fix signed integer overflow in gcc/data-streamer.c

2014-09-28 Thread Markus Trippelsdorf
On 2014.09.28 at 14:36 +0200, Steven Bosscher wrote: > > Can you use HOST_WIDE_INT_1U for this? Sure. Thanks for the suggestion. (Fix now resembles similar idiom in data-streamer-in.c) 2014-09-28 Markus Trippelsdorf * data-streamer.c (bp_unpack_var_len_int): Avoid

[PATCH] Fix signed integer overflow in gcc/data-streamer.c

2014-09-28 Thread Markus Trippelsdorf
g int'; cast to an unsigned type to negate this value to itself The fix is obvious. Boostrapped and tested on x86_64-unknown-linux-gnu. OK for trunk? Thanks. 2014-09-28 Markus Trippelsdorf * data-streamer.c (bp_unpack_var_len_int): Avoid signed integer overflow. diff --git

Re: [PATCH 3/5] IPA ICF pass

2014-09-27 Thread Markus Trippelsdorf
On 2014.09.27 at 07:59 +0200, Markus Trippelsdorf wrote: > > > It seems that in this case we reject too many of equality candidates? > > It think the original numbers was about 4-5% but later some equivalences was > > disabled because of devirt/aliasing issues. Do you com

Re: [PATCH 3/5] IPA ICF pass

2014-09-26 Thread Markus Trippelsdorf
On 2014.09.27 at 01:27 +0200, Jan Hubicka wrote: > > While a plain Firefox -flto build works fine. LTO/PGO build fails with: > > > > lto1: internal compiler error: in ipa_merge_profiles, at ipa-utils.c:540 > > 0x7d6165 ipa_merge_profiles(cgraph_node*, cgraph_node*) > > ../../gcc/gcc/ipa-ut

Re: [PATCH 3/5] IPA ICF pass

2014-09-26 Thread Markus Trippelsdorf
On 2014.09.26 at 14:20 +0200, Martin Liška wrote: > After couple of weeks I spent with fixing new issues connected to the > pass: 1) Inliner failed in case I created a thunk and release body of > a function. In such situation we need to preserve DECL_ARGUMENTS. I > added new argument for: cgraph_no

Re: Avoid privatization of TLS variables

2014-09-25 Thread Markus Trippelsdorf
On 2014.09.26 at 04:50 +0200, Jan Hubicka wrote: > What is the earlierst binutils release fixing the bug? I will add it into > changes.html for 5.0. binutils-2.24 -- Markus

Re: Avoid privatization of TLS variables

2014-09-24 Thread Markus Trippelsdorf
On 2014.09.24 at 20:18 +0200, Jan Hubicka wrote: > > On 2014.09.20 at 05:16 +0200, Jan Hubicka wrote: > > > Hi, > > > libreoffice fails to build with TLS because of "Cannot load any more > > > object > > > with static TLS". Iant pointed out to me the difference that the initial > > > exec > > > T

Re: Avoid privatization of TLS variables

2014-09-24 Thread Markus Trippelsdorf
On 2014.09.20 at 05:16 +0200, Jan Hubicka wrote: > Hi, > libreoffice fails to build with TLS because of "Cannot load any more object > with static TLS". Iant pointed out to me the difference that the initial exec > TLS model is also used by static TLS variables. > > This patch prevents turning TLS

[PATCH] Fix PR61998

2014-09-19 Thread Markus Trippelsdorf
index c2200fcdc426..0dc7b3325922 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,8 @@ +2014-09-19 Markus Trippelsdorf + + PR ipa/61998 + * ipa-devirt.c (ipa_devirt): Bail out if odr_types_ptr is NULL. + 2014-09-19 James Greenhalgh * doc/md.texi (Modifiers

[PATCH] doc/install.texi: add documentation for --disable-libsanitizer

2014-09-10 Thread Markus Trippelsdorf
This patch adds an item for --disable-libsanitizer to the configuration documentation. The option is especially useful during bisection, because it reduces build time a lot. Ok for trunk and 4.9 branch? Thanks. 2014-09-10 Markus Trippelsdorf * doc/install.texi (Options

Re: C++ PATCH to set DECL_COMDAT on undefined inlines/templates

2014-07-30 Thread Markus Trippelsdorf
On 2014.07.30 at 17:31 -0400, Jason Merrill wrote: > I think this should fix it. Indeed it does. Thanks. -- Markus

Re: C++ PATCH to set DECL_COMDAT on undefined inlines/templates

2014-07-30 Thread Markus Trippelsdorf
On 2014.07.30 at 13:26 -0400, Jason Merrill wrote: > Since can_refer_decl_in_current_unit_p doesn't allow references to > DECL_COMDAT entities that aren't defined in the current unit, by setting > that flag we can avoid problems with devirtualization introducing > references to vague linkage fun

Re: [PATCH] LTO streamer reorg - try to reduce WPA memory use

2014-07-30 Thread Markus Trippelsdorf
On 2014.07.30 at 10:31 +0200, Richard Biener wrote: > On Wed, Jul 30, 2014 at 7:51 AM, Markus Trippelsdorf > wrote: > > On 2014.07.29 at 15:10 +0200, Richard Biener wrote: > >> On Tue, 29 Jul 2014, Richard Biener wrote: > >> > >> > > >> >

<    1   2   3   4   >