Re: [PATCH] Port libgccjit to Windows.

2020-06-15 Thread Nicolas Bértolo via Gcc-patches
> Thanks, pushed to git master. Thanks, Nicolas.

Re: [PATCH] Port libgccjit to Windows.

2020-06-11 Thread Nicolas Bértolo via Gcc-patches
Hi, On 6/7/20 11:12 PM, JonY wrote: > Ideally, libtool is used so we get libgccjit-0.dll, unfortunately it is > not. So the only way to ABI version the dll would be to use Unix style > soname to mark when an ABI has changed. I tried generating the library as libgccjit-0.dll and naming its import

Re: [PATCH] Port libgccjit to Windows.

2020-06-07 Thread Nicolas Bértolo via Gcc-patches
Hi, Sorry for the super late reply. > 1. Using .so on Windows for DLLs is fine. I know, but using the standard suffix for the platform seems better, IMHO. > 2. The DLL name on Windows should use LIBGCCJIT_SONAME rather than > LIBGCCJIT_LINKER_NAME, so applications would load libgccjit.so.0

Re: [PATCH] Port libgccjit to Windows.

2020-05-28 Thread Nicolas Bértolo via Gcc-patches
> I'm going to have to trust your Windows expertise here; the tempdir > code looks convoluted to me, but perhaps that's the only way to do it. > (Microsoft's docs for "SECURITY_ATTRIBUTES" suggest to me that if > lpSecurityDescriptor is NULL, then the directory gets a default > security

Re: [PATCH] Port libgccjit to Windows.

2020-05-27 Thread Nicolas Bértolo via Gcc-patches
Hi, > Do you have commit/push access to the gcc repository? No I don't. > BTW, why isn't it necessary to use --enable-host-shared in Windows? > Can we document that? That's because all code is position independent in Windows. > On the subject of nitpicking, I find myself getting distracted by

Re: [PATCH] Port libgccjit to Windows.

2020-05-25 Thread Nicolas Bértolo via Gcc-patches
Hi Dave, Thanks for your feedback. > Do you have copyright assignment paperwork on file? > https://gcc.gnu.org/contribute.html#legal My paperwork is done. > The autotools are not my strongest suit. > In a previous life I was a Windows developer, but I think it's been > about 18 years since

[PATCH] Port libgccjit to Windows.

2020-05-24 Thread Nicolas Bértolo via Gcc-patches
Hello gcc devs. I have ported libgccjit to Windows. I have tested it with the native-compilation branch of Emacs so I'm confident that it works well. The work is not finished though, I could use some help with these two points: I have had to concede defeat to libtool and Automake. I could not