Re: [f...@deneb.enyo.de: [PATCH] ada/77535: GNAT.Perfect_Hash_Generators for non-1-based strings]

2016-09-19 Thread Thomas Quinot
* Thomas Quinot, 2016-09-18 : > Sorry for the delay in reviewing your patch. It looks good on the > surface; we're QAing it internally to make sure it does not break > PolyORB (which is the primary consumer of g-pehage). I'll let you know > as soon as I have the results from that r

Re: [f...@deneb.enyo.de: [PATCH] ada/77535: GNAT.Perfect_Hash_Generators for non-1-based strings]

2016-09-18 Thread Thomas Quinot
-pehage). I'll let you know as soon as I have the results from that run. In any case it would be good to include a regression test for this issue. Thanks! Thomas. -- Thomas Quinot, Ph.D. ** qui...@adacore.com ** IT Lead Engineer AdaCore -- Paris, France -- New York, USA

Re: [Ada] Add DragonFly support to System.OS_Constants template

2015-07-06 Thread Thomas Quinot
* John Marino, 2015-07-06 : The System.OS_Constants templates for GNAT has three preprocessor checks for FreeBSD. In all three cases, DragonFly BSD needs to be treated the same as FreeBSD. The attached patch accomplishes this. Thanks John, looks good to me! Thomas.

Re: [patch] Implement Ada support for DragonFly, improve it for FreeBSD

2015-06-03 Thread Thomas Quinot
straightforward approach (replacing the macro with a variable that would be initialized by some back-end-specific startup routine?) is in order. -- Thomas Quinot, Ph.D. ** qui...@adacore.com ** Senior Software Engineer AdaCore -- Paris, France -- New York, USA

Re: [patch] Implement Ada support for DragonFly, improve it for FreeBSD

2015-06-03 Thread Thomas Quinot
no longer work after some time, with nobody bothering fixing them. John has been actively maintaining these changes for the past few years, so I'm confident these files won't bitrot. -- Thomas Quinot, Ph.D. ** qui...@adacore.com ** Senior Software Engineer AdaCore -- Paris, France -- New

[PATCH] gcc/tree-complex.c: Fix minor typo in comment

2013-07-05 Thread Thomas Quinot
2013-07-06 Thomas Quinot qui...@adacore.com gcc/ * tree-complex.c: Fix minor typo in comment OK to commit? diff --git a/gcc/tree-complex.c b/gcc/tree-complex.c index c45ba19..acd0169 100644 --- a/gcc/tree-complex.c +++ b/gcc/tree-complex.c @@ -1476,7 +1476,7

Re: [PATCH] Instance information in DWARF discriminators

2012-12-05 Thread Thomas Quinot
* Tom Tromey, 2012-11-29 : Thomas Now, an alternative might be to have an array of instance IDs stored at Thomas the struct line_maps level, with the same indices at the set of ordinary Thomas maps, which would be allocated only when flag_debug_instances is used; Thomas when it is not

Re: [PATCH] Instance information in DWARF discriminators

2012-11-29 Thread Thomas Quinot
be used from within libcpp. So, I'll have to either change that (but that seems like a pretty significant change) or else manually manage this array through xrealloc. Thomas. -- Thomas Quinot, Ph.D. ** qui...@adacore.com ** Senior Software Engineer AdaCore -- Paris, France -- New

[PATCH] Instance information in DWARF discriminators

2012-11-28 Thread Thomas Quinot
), in order to allow per-instance source coverage analysis of generics. However this might also be useful for other language front-ends, e.g. with C++ templates. Change tested on x86_64-linux. OK to commit? 2012-08-08 Thomas Quinot qui...@adacore.com gcc/ * common.opt (flag_debug_instances

Re: [PATCH] New command line switch -fada-spec-parent

2012-09-07 Thread Thomas Quinot
-spec@r{[}-slim@r{]} -fdump-go-spec=@var{file}} +-fdump-ada-spec@r{[}-slim@r{]} -fada-spec-parent=@var{arg} -fdump-go-spec=@var{file}} @item C Language Options @xref{C Dialect Options,,Options Controlling C Dialect}. -- Thomas Quinot, Ph.D. ** qui...@adacore.com ** Senior Software Engineer

Re: [PATCH] New command line switch -fada-spec-parent

2012-08-31 Thread Thomas Quinot
* Steven Bosscher, 2012-08-24 : * common.opt (-fada-spec-parent): Define new command line switch. Why here instead of in c-family/c.opt? Makes sense indeed, I'll move the definition there. -- Thomas Quinot, Ph.D. ** qui...@adacore.com ** Senior Software Engineer

[PATCH] New command line switch -fada-spec-parent

2012-08-24 Thread Thomas Quinot
}=@var{arg} @gol --fdump-ada-spec@r{[}-slim@r{]} -fdump-go-spec=@var{file}} +-fdump-ada-spec@r{[}-slim@r{]} -fada-spec-parent=@var{arg} -fdump-go-spec=@var{file}} @item C Language Options @xref{C Dialect Options,,Options Controlling C Dialect}. -- Thomas Quinot, Ph.D. ** qui...@adacore.com

Re: [PATCH] GCC Ada/GNAT configuration for GNU/Hurd

2012-08-08 Thread Thomas Quinot
different from glibc? Posibly yes. Thomas (Quinot), any comment on the above? No strong opinion either way. What is important is that the comment be consistent with what we actually test. If we want the comment to say For glibc, blah... then we need to change the test to something that actually tests