Re: [Dwarf Patch] Implement split debug info proposal (issue 6305113)

http://codereview.appspot.com/6305113/diff/3001/gcc/dwarf2out.c File gcc/dwarf2out.c (right): http://codereview.appspot.com/6305113/diff/3001/gcc/dwarf2out.c#newcode8517 gcc/dwarf2out.c:8517: Should use SKELETON_COMP_DIE_ABBREV here instead of 1.

Re: [google] Patch to enable efficient function level instrumentation (issue 5416043)

http://codereview.appspot.com/5416043/diff/12001/gcc/config/i386/i386.c File gcc/config/i386/i386.c (left): http://codereview.appspot.com/5416043/diff/12001/gcc/config/i386/i386.c#oldcode10928 gcc/config/i386/i386.c:10928: if (current_function_decl != NULL_TREE If I understand correctly, this

Re: [patch] Fix DWARF so types with subprogram definitions don't get moved to type unit (issue4433068)

It's a good check to add, but if it returns true we should abort rather than just returning 0. I couldn't convince myself that a subprogram definition inside a type declaration would never happen, so I took the defensive approach. If you're confident that it can't (or shouldn't) ever happen,