Re: [ patch, testsuite, fortran] Replace "call abort" by "stop n"

2018-02-18 Thread Janus Weil
2018-02-18 1:38 GMT+01:00 Thomas Koenig : > Hi Janus, > >> Regarding "-fall-intrinsics": Your commit has greatly reduced its >> usage, but I still see a few cases that you left in, although the flag >> does not really seem to be required. >> >> Is there a reason why did not treat these? > > I was s

Re: [ patch, testsuite, fortran] Replace "call abort" by "stop n"

2018-02-17 Thread Thomas Koenig
Hi Janus, Regarding "-fall-intrinsics": Your commit has greatly reduced its usage, but I still see a few cases that you left in, although the flag does not really seem to be required. Is there a reason why did not treat these? I was specifically chaning those cases which contained STOP [1-9]

Re: [ patch, testsuite, fortran] Replace "call abort" by "stop n"

2018-02-17 Thread Janus Weil
Hi Thomas, >> as a result of this, you should be able to remove the vast majority of >> -fall-intrinsics extra options. Please do that as well. > > > Done, in r257782. Regarding "-fall-intrinsics": Your commit has greatly reduced its usage, but I still see a few cases that you left in, although t

Re: [ patch, testsuite, fortran] Replace "call abort" by "stop n"

2018-02-17 Thread Thomas Koenig
Am 16.02.2018 um 09:11 schrieb Janne Blomqvist: as a result of this, you should be able to remove the vast majority of -fall-intrinsics extra options. Please do that as well. Done, in r257782. I actually liked the usage of "call abort" in testcases, as a failing testcase provided a backtrace

Re: [ patch, testsuite, fortran] Replace "call abort" by "stop n"

2018-02-16 Thread Janus Weil
2018-02-16 0:37 GMT+01:00 Steve Kargl : > On Fri, Feb 16, 2018 at 12:25:11AM +0100, Thomas Koenig wrote: >> I wrote: >> >> > OK for trunk? >> >> Following a remark by Steve, here is an additional test case which >> checks if abort actually works. I'll add that to the patch >> when it is committed.

Re: [ patch, testsuite, fortran] Replace "call abort" by "stop n"

2018-02-16 Thread Janne Blomqvist
On Fri, Feb 16, 2018 at 12:30 AM, Thomas Koenig wrote: > Hello world, > > the attached patch replaces the non-standard "call abort" by > "STOP n", where n is a number counted up from 1 for each occurrence. > This numbering was suggested by Neil Carlson. > > This makes the gfortran testsuite _much_

Re: [ patch, testsuite, fortran] Replace "call abort" by "stop n"

2018-02-15 Thread Steve Kargl
On Fri, Feb 16, 2018 at 12:25:11AM +0100, Thomas Koenig wrote: > I wrote: > > > OK for trunk? > > Following a remark by Steve, here is an additional test case which > checks if abort actually works. I'll add that to the patch > when it is committed. > The patch is ok from my viewpoint. You m

Re: [ patch, testsuite, fortran] Replace "call abort" by "stop n"

2018-02-15 Thread Thomas Koenig
I wrote: OK for trunk? Following a remark by Steve, here is an additional test case which checks if abort actually works. I'll add that to the patch when it is committed. Regards Thomas ! { dg-do run } ! { dg-shouldfail "Program aborted." } program main call abort end program mai