Re: [6 Regession] Usage of unitialized pointer io/list_read.c (

2016-02-17 Thread Jerry DeLisle
On 02/16/2016 05:37 PM, Jerry DeLisle wrote: > See patch to fix this below. > Committed on trunk, r233500 after regression testing, -fsanitize=address testing, and valgrind testing. Jerry

Re: [6 Regession] Usage of unitialized pointer io/list_read.c (

2016-02-17 Thread Christophe Lyon
On 16 February 2016 at 18:49, Jerry DeLisle wrote: > On 02/16/2016 12:06 AM, Christophe Lyon wrote: >> On 15 February 2016 at 23:16, Janne Blomqvist >> wrote: >>> On Mon, Feb 15, 2016 at 11:45 PM, Jerry DeLisle >>>

Re: [6 Regession] Usage of unitialized pointer io/list_read.c (

2016-02-16 Thread Jerry DeLisle
See patch to fix this below. On 02/16/2016 11:38 AM, Dominique d'Humières wrote: > With the following reduced test > > program test > implicit none > integer :: i, j, k, ios > integer, parameter :: big = 600 > character(kind=4,len=big) :: str1, str2 > > do i=1,big, 10 > do j = 0,

Re: [6 Regession] Usage of unitialized pointer io/list_read.c (

2016-02-16 Thread Dominique d'Humières
With the following reduced test program test implicit none integer :: i, j, k, ios integer, parameter :: big = 600 character(kind=4,len=big) :: str1, str2 do i=1,big, 10 do j = 0, 9 k = i + j str2(k:k) = char(65+j) end do end do open(15, status='scratch',

Re: [6 Regession] Usage of unitialized pointer io/list_read.c (

2016-02-16 Thread Jerry DeLisle
On 02/16/2016 05:17 AM, Dominique d'Humières wrote: > Hi Jerry, > >> Thanks for review. Committed to trunk r233436. > > The test gfortran.dg/read_bang4.f90 fails on x86_64-apple-darwin15: > > a.out(15552,0x7fff7b2e3000) malloc: *** error for object 0x7fb472804c00: > pointer being freed was not

Re: [6 Regession] Usage of unitialized pointer io/list_read.c (

2016-02-16 Thread Jerry DeLisle
On 02/16/2016 12:06 AM, Christophe Lyon wrote: > On 15 February 2016 at 23:16, Janne Blomqvist > wrote: >> On Mon, Feb 15, 2016 at 11:45 PM, Jerry DeLisle >> wrote: >>> The title of the PR should be "Mishandling of namelist comments" or >>>

Re: [6 Regession] Usage of unitialized pointer io/list_read.c (

2016-02-16 Thread Dominique d'Humières
Hi Jerry, > Thanks for review. Committed to trunk r233436. The test gfortran.dg/read_bang4.f90 fails on x86_64-apple-darwin15: a.out(15552,0x7fff7b2e3000) malloc: *** error for object 0x7fb472804c00: pointer being freed was not allocated *** set a breakpoint in malloc_error_break to debug

Re: [6 Regession] Usage of unitialized pointer io/list_read.c (

2016-02-16 Thread Christophe Lyon
On 15 February 2016 at 23:16, Janne Blomqvist wrote: > On Mon, Feb 15, 2016 at 11:45 PM, Jerry DeLisle wrote: >> The title of the PR should be "Mishandling of namelist comments" or >> "Interpreting '!' as a comment in non-namelist reads". >> >>

Re: [6 Regession] Usage of unitialized pointer io/list_read.c (

2016-02-15 Thread Janne Blomqvist
On Mon, Feb 15, 2016 at 11:45 PM, Jerry DeLisle wrote: > The title of the PR should be "Mishandling of namelist comments" or > "Interpreting '!' as a comment in non-namelist reads". > > The attached patch fixes the regression by reverting the previous attempt at > namelist

[6 Regession] Usage of unitialized pointer io/list_read.c (

2016-02-15 Thread Jerry DeLisle
The title of the PR should be "Mishandling of namelist comments" or "Interpreting '!' as a comment in non-namelist reads". The attached patch fixes the regression by reverting the previous attempt at namelist comments that used only CASE_SEPARATOR to enable comments in namelists. The approach