Re: [AARCH64] [PATCH 3/3] AArch64 Port

2012-05-31 Thread Tejas Belagod
Richard Sandiford wrote: Tejas Belagod tbela...@arm.com writes: Hi Richard, Thanks for your comments. Some questions inline below. Richard Sandiford wrote: Marcus Shawcroft marcus.shawcr...@arm.com writes: This patch adds an implementation of integer iterators. Nice. A few comments from

Re: [AARCH64] [PATCH 3/3] AArch64 Port

2012-05-31 Thread Richard Sandiford
Tejas Belagod tbela...@arm.com writes: In the currect scheme, when multiple code/mode iterators are in an rtx pattern, they are expanded for each combination of iterator values in apply_iterator_traverse () and a repeated traversal of the expanded rtx's for each iterator achieves the

Re: [AARCH64] [PATCH 3/3] AArch64 Port

2012-05-28 Thread Tejas Belagod
Hi Richard, Thanks for your comments. Some questions inline below. Richard Sandiford wrote: Marcus Shawcroft marcus.shawcr...@arm.com writes: This patch adds an implementation of integer iterators. Nice. A few comments from an onlooker (on top of what Stephen said). +/* Since GCC does

Re: [AARCH64] [PATCH 3/3] AArch64 Port

2012-05-28 Thread Richard Sandiford
Tejas Belagod tbela...@arm.com writes: Hi Richard, Thanks for your comments. Some questions inline below. Richard Sandiford wrote: Marcus Shawcroft marcus.shawcr...@arm.com writes: This patch adds an implementation of integer iterators. Nice. A few comments from an onlooker (on top of

Re: [AARCH64] [PATCH 3/3] AArch64 Port

2012-05-27 Thread Richard Sandiford
Marcus Shawcroft marcus.shawcr...@arm.com writes: This patch adds an implementation of integer iterators. Nice. A few comments from an onlooker (on top of what Stephen said). +/* Since GCC does not construct a table of valid constants, + we have to accept any int as valid. No

[AARCH64] [PATCH 3/3] AArch64 Port

2012-05-25 Thread Marcus Shawcroft
This patch adds an implementation of integer iterators. Index: gcc/ChangeLog.aarch64 * read-rtl.c (rtx_list): New data structure. (int_iterator_mapping): New data structure. (int_iterator_data): New. List of int iterator details. (num_int_iterator_data): New.

Re: [AARCH64] [PATCH 3/3] AArch64 Port

2012-05-25 Thread Steven Bosscher
On Fri, May 25, 2012 at 1:19 PM, Marcus Shawcroft marcus.shawcr...@arm.com wrote: This patch adds an implementation of integer iterators. Index: gcc/ChangeLog.aarch64        * read-rtl.c (rtx_list): New data structure.        (int_iterator_mapping): New data structure.