Re: [ARM] Fix CLZ_DEFINED_VALUE_AT_ZERO for vector modes

2014-11-13 Thread Christophe Lyon
On 12 November 2014 14:46, Ramana Radhakrishnan wrote: > > > On 12/11/14 13:06, Christophe Lyon wrote: >> >> On 12 November 2014 04:50, Yangfei (Felix) wrote: On Wed, Oct 22, 2014 at 10:49 PM, Michael Collison wrote: > > > Patch that removes extraneous comment att

Re: [ARM] Fix CLZ_DEFINED_VALUE_AT_ZERO for vector modes

2014-11-12 Thread Ramana Radhakrishnan
On 12/11/14 13:06, Christophe Lyon wrote: On 12 November 2014 04:50, Yangfei (Felix) wrote: On Wed, Oct 22, 2014 at 10:49 PM, Michael Collison wrote: Patch that removes extraneous comment attached. The CLZ_DEFINED_VALUE_AT_ZERO macro is hard coded to return 32. For the vector intrinsic vc

Re: [ARM] Fix CLZ_DEFINED_VALUE_AT_ZERO for vector modes

2014-11-12 Thread Christophe Lyon
On 12 November 2014 04:50, Yangfei (Felix) wrote: >> On Wed, Oct 22, 2014 at 10:49 PM, Michael Collison >> >> wrote: >> > >> > Patch that removes extraneous comment attached. >> > >> > The CLZ_DEFINED_VALUE_AT_ZERO macro is hard coded to return 32. For >> > the vector intrinsic vclz this is inco

Re: [ARM] Fix CLZ_DEFINED_VALUE_AT_ZERO for vector modes

2014-11-12 Thread Christophe Lyon
On 12 November 2014 04:50, Yangfei (Felix) wrote: >> On Wed, Oct 22, 2014 at 10:49 PM, Michael Collison >> >> wrote: >> > >> > Patch that removes extraneous comment attached. >> > >> > The CLZ_DEFINED_VALUE_AT_ZERO macro is hard coded to return 32. For >> > the vector intrinsic vclz this is inco

Re: [ARM] Fix CLZ_DEFINED_VALUE_AT_ZERO for vector modes

2014-11-11 Thread Yangfei (Felix)
> On Wed, Oct 22, 2014 at 10:49 PM, Michael Collison > > wrote: > > > > Patch that removes extraneous comment attached. > > > > The CLZ_DEFINED_VALUE_AT_ZERO macro is hard coded to return 32. For > > the vector intrinsic vclz this is incorrect and should return the > > value > > vclz_{s,u}8 ...

Re: [ARM] Fix CLZ_DEFINED_VALUE_AT_ZERO for vector modes

2014-10-31 Thread Ramana Radhakrishnan
On Wed, Oct 22, 2014 at 10:49 PM, Michael Collison wrote: > > Patch that removes extraneous comment attached. > > The CLZ_DEFINED_VALUE_AT_ZERO macro is hard coded to return 32. For the > vector intrinsic vclz this is incorrect and should return the value vclz_{s,u}8 ... > eight. The CTZ_DEFINED

Re: [ARM] Fix CLZ_DEFINED_VALUE_AT_ZERO for vector modes

2014-10-22 Thread Michael Collison
Patch that removes extraneous comment attached. The CLZ_DEFINED_VALUE_AT_ZERO macro is hard coded to return 32. For the vector intrinsic vclz this is incorrect and should return the value eight. The CTZ_DEFINED_VALUE_AT_ZERO has the same issue. Tested on arm-linux-gnueabihf, arm-linux-gnueabi.

Re: [ARM] Fix CLZ_DEFINED_VALUE_AT_ZERO for vector modes

2014-10-09 Thread Michael Collison
Tejas, You are correct. I will update the comment. On 10/9/2014 12:55 AM, Tejas Belagod wrote: On 09/10/14 08:05, Michael Collison wrote: The CLZ_DEFINED_VALUE_AT_ZERO macro is harded to return 32. For the vector intrinsic vclz this is incorrect and should return the value eight. The CTZ_DEF

Re: [ARM] Fix CLZ_DEFINED_VALUE_AT_ZERO for vector modes

2014-10-09 Thread Tejas Belagod
On 09/10/14 08:05, Michael Collison wrote: The CLZ_DEFINED_VALUE_AT_ZERO macro is harded to return 32. For the vector intrinsic vclz this is incorrect and should return the value eight. The CTZ_DEFINED_VALUE_AT_ZERO has the same issue. Tested on arm-linux-gnueabihf, arm-linux-gnueabi. 2014-10-

Re: [ARM] Fix CLZ_DEFINED_VALUE_AT_ZERO for vector modes

2014-10-09 Thread Michael Collison
Yes this problem was found with Christophe's neon intrinsic tests which are awaiting approval. The problem was found by passing a value of zero to the vclz vector intrinsic. On 10/09/2014 12:11 AM, Andrew Pinski wrote: On Thu, Oct 9, 2014 at 12:05 AM, Michael Collison wrote: The CLZ_DEFINE

Re: [ARM] Fix CLZ_DEFINED_VALUE_AT_ZERO for vector modes

2014-10-09 Thread Andrew Pinski
On Thu, Oct 9, 2014 at 12:05 AM, Michael Collison wrote: > > The CLZ_DEFINED_VALUE_AT_ZERO macro is harded to return 32. For the vector > intrinsic vclz this is incorrect and should return the value eight. The > CTZ_DEFINED_VALUE_AT_ZERO has the same issue. Do you have a testcase? I almost thin

[ARM] Fix CLZ_DEFINED_VALUE_AT_ZERO for vector modes

2014-10-09 Thread Michael Collison
The CLZ_DEFINED_VALUE_AT_ZERO macro is harded to return 32. For the vector intrinsic vclz this is incorrect and should return the value eight. The CTZ_DEFINED_VALUE_AT_ZERO has the same issue. Tested on arm-linux-gnueabihf, arm-linux-gnueabi. 2014-10-08 Michael Collison * config/arm/