Re: [C++ PATCH] Diagnose conversions from string constants to char* as forbidden, not deprecated, in c++11 and above

2014-11-26 Thread Jason Merrill
On 11/26/2014 10:48 AM, Manuel López-Ibáñez wrote: If I understand correctly, the cxx11 standard requires to diagnose this. Thus, it should be always a pedwarn, independently of Wpedantic. I agree. This is what I checked in: commit 2aeccf739475ee181f4ca6422776b46bc9526352 Author: jason Date:

Re: [C++ PATCH] Diagnose conversions from string constants to char* as forbidden, not deprecated, in c++11 and above

2014-11-26 Thread Manuel López-Ibáñez
Sorry to be pedantic, but I think this is not exactly right: +if (cxx_dialect >= cxx11) + { + if (pedantic) + pedwarn (input_location, OPT_Wpedantic, + "ISO C++ forbids converting a string constant to %qT", + totype); + else + warning (OPT_Wwrite_strings, + "ISO C++ forbids conver

Re: [C++ PATCH] Diagnose conversions from string constants to char* as forbidden, not deprecated, in c++11 and above

2014-11-25 Thread Ville Voutilainen
On 26 November 2014 at 04:42, Jason Merrill wrote: > On 11/25/2014 09:41 PM, Jason Merrill wrote: >> >> Tested how, exactly? It doesn't seem to have run old-deja.exp. I tend Too hastily, sorry. I managed to notice that the tests adjusted in the patch failed, and then blissfully didn't look at t

Re: [C++ PATCH] Diagnose conversions from string constants to char* as forbidden, not deprecated, in c++11 and above

2014-11-25 Thread Jason Merrill
On 11/25/2014 09:41 PM, Jason Merrill wrote: Tested how, exactly? It doesn't seem to have run old-deja.exp. I tend to use the toplevel make-c++ target. Er, check-c++. Jason

Re: [C++ PATCH] Diagnose conversions from string constants to char* as forbidden, not deprecated, in c++11 and above

2014-11-25 Thread Jason Merrill
Tested how, exactly? It doesn't seem to have run old-deja.exp. I tend to use the toplevel make-c++ target. +FAIL: g++.old-deja/g++.bob/inherit1.C -std=c++11 depr (test for warnings, line 14) +FAIL: g++.old-deja/g++.bob/inherit1.C -std=c++11 (test for excess errors) +FAIL: g++.old-deja/g++.

[C++ PATCH] Diagnose conversions from string constants to char* as forbidden, not deprecated, in c++11 and above

2014-11-25 Thread Ville Voutilainen
Tested on Linux-x64. Remotely related to pr50645, which we should probably close as invalid. /cp 2014-11-26 Ville Voutilainen Diagnose string constant conversion to char* in c++11 and above as forbidden, not deprecated. * typeck.c (string_conv_p): Do a pedwarn in c++11 and above,