Re: [C++ PATCH] Fix up building of GCC 8 and earlier with GCC 9/10 (PR c/90677)

2020-01-02 Thread Jakub Jelinek
On Thu, Jan 02, 2020 at 10:52:38AM -0500, Nathan Sidwell wrote: > On 12/31/19 6:05 AM, Jakub Jelinek wrote: > > My PR90677 fix actually made building older GCCs with newer ones worse. > > The problem is that identifier_global_value used earlier returned either the > > type decl on success or

Re: [C++ PATCH] Fix up building of GCC 8 and earlier with GCC 9/10 (PR c/90677)

2020-01-02 Thread Nathan Sidwell
On 12/31/19 6:05 AM, Jakub Jelinek wrote: Hi! My PR90677 fix actually made building older GCCs with newer ones worse. The problem is that identifier_global_value used earlier returned either the type decl on success or NULL_TREE on failure and the caller in that case just defers handling it

[C++ PATCH] Fix up building of GCC 8 and earlier with GCC 9/10 (PR c/90677)

2019-12-31 Thread Jakub Jelinek
Hi! My PR90677 fix actually made building older GCCs with newer ones worse. The problem is that identifier_global_value used earlier returned either the type decl on success or NULL_TREE on failure and the caller in that case just defers handling it until later, and that is also what the C