Re: [C++ PATCH] New warning for extra semicolons after in-class function definitions

2017-04-10 Thread Jason Merrill
On Mon, Apr 10, 2017 at 12:32 PM, Mike Stump wrote: > On Apr 9, 2017, at 1:53 PM, Volker Reichelt wrote: +Wextra-semi +C++ Var(warn_extra_semi) Warning +Warn about semicolon after in-class function definition. + > >> Right now,

Re: [C++ PATCH] New warning for extra semicolons after in-class function definitions

2017-04-10 Thread Mike Stump
On Apr 9, 2017, at 1:53 PM, Volker Reichelt wrote: >>> +Wextra-semi >>> +C++ Var(warn_extra_semi) Warning >>> +Warn about semicolon after in-class function definition. >>> + > Right now, the patch enables the warning only for C++. > Would it make sense to enable it also

Re: [C++ PATCH] New warning for extra semicolons after in-class function definitions

2017-04-09 Thread Volker Reichelt
On 7 Apr, David Malcolm wrote: > On Fri, 2017-04-07 at 21:55 +0200, Volker Reichelt wrote: >> Hi, >> >> with the following patch I suggest to add a diagnostic for extra >> semicolons after in-class member function definitions: >> >> struct A >> { >> A() {}; >> void foo() {}; >>

Re: [C++ PATCH] New warning for extra semicolons after in-class function definitions

2017-04-07 Thread David Malcolm
On Fri, 2017-04-07 at 21:55 +0200, Volker Reichelt wrote: > Hi, > > with the following patch I suggest to add a diagnostic for extra > semicolons after in-class member function definitions: > > struct A > { > A() {}; > void foo() {}; > friend void bar() {}; > }; > > Although

[C++ PATCH] New warning for extra semicolons after in-class function definitions

2017-04-07 Thread Volker Reichelt
Hi, with the following patch I suggest to add a diagnostic for extra semicolons after in-class member function definitions: struct A { A() {}; void foo() {}; friend void bar() {}; }; Although they are allowed in the C++ standard, people (including me) often like to get rid of

[C++ PATCH] New warning for extra semicolons after in-class function definitions

2017-04-07 Thread Volker Reichelt
Hi, with the following patch I suggest to add a diagnostic for extra semicolons after in-class member function definitions: struct A { A() {}; void foo() {}; friend void bar() {}; }; Although they are allowed in the C++ standard, people (including me) often like to get rid of