Re: [C++ PATCH] PR c++/62101

2014-08-14 Thread Jason Merrill
On 08/13/2014 08:48 PM, Ville Voutilainen wrote: Ok, modified patch attached. The changelog entry was attached to the previous mail as an evil binary attachment (gmail...) Ah, so it was. here, for convenience: Thanks; having it in the body of the mail is more convenient for me as 'git am'

Re: [C++ PATCH] PR c++/62101

2014-08-13 Thread Ville Voutilainen
On 14 August 2014 03:41, Jason Merrill wrote: > On 08/13/2014 07:06 PM, Ville Voutilainen wrote: > > Looks good, but > >> + int friendp = 0; > > > Let's declare friendp when it's initialized. > > And I still need a ChangeLog entry. Ok, modified patch attached. The changelog entry was attached to

Re: [C++ PATCH] PR c++/62101

2014-08-13 Thread Jason Merrill
On 08/13/2014 07:06 PM, Ville Voutilainen wrote: Looks good, but + int friendp = 0; Let's declare friendp when it's initialized. And I still need a ChangeLog entry. Jason

[C++ PATCH] PR c++/62101

2014-08-13 Thread Ville Voutilainen
We didn't allow deleted friend definitions, because that was diagnosed in grokdeclarator, which doesn't have knowledge of the kind of a function declaration "initializer". Move the test to grokfield and adjust where necessary. Tested on Linux x86-64. diff --git a/gcc/cp/decl.c b/gcc/cp/decl.c index