Re: [C++ Patch] Add default arguments to cp_parser_assignment_expression and cp_parser_constant_expression

2014-10-02 Thread Jason Merrill
On 08/19/2014 08:18 AM, Paolo Carlini wrote: - /*non_constant_p=*/dummy); + dummy); Why remove the comment? The rest of the patch is OK. Jason

Re: [C++ Patch] Add default arguments to cp_parser_assignment_expression and cp_parser_constant_expression

2014-10-02 Thread Paolo Carlini
Hi, On 10/02/2014 08:03 PM, Jason Merrill wrote: On 08/19/2014 08:18 AM, Paolo Carlini wrote: - /*non_constant_p=*/dummy); + dummy); Why remove the comment? Oh well, the rationale was that normally we use that sort of comment only to explain integer

Re: [C++ Patch] Add default arguments to cp_parser_assignment_expression and cp_parser_constant_expression

2014-09-10 Thread Paolo Carlini
Hi, On 08/19/2014 02:18 PM, Paolo Carlini wrote: Hi, two more functions. Tested x86_64-linux. I'm pinging this. https://gcc.gnu.org/ml/gcc-patches/2014-08/msg01853.html Frankly, the cp_parser_constant_expression bits seem rather straightforward to me. As regards the

[C++ Patch] Add default arguments to cp_parser_assignment_expression and cp_parser_constant_expression

2014-08-19 Thread Paolo Carlini
Hi, two more functions. Tested x86_64-linux. Thanks, Paolo. /// 2014-08-19 Paolo Carlini paolo.carl...@oracle.com * parser.c (cp_parser_assignment_expression, cp_parser_constant_expression): Add default arguments. (cp_parser_primary_expression,