[C++ Patch] Fix pastos (?) in make_typename_type calls

2012-07-24 Thread Paolo Carlini
Hi, while looking into the re-opened c++/51213 (doesn't seem trivial: details soon, I hope) I noticed things which look like old pastos: in convert_template_argument and tsubst we are computing complain tf_error for the - tsubst_flags_t, not bool - fourth argument of make_typename_type.

Re: [C++ Patch] Fix pastos (?) in make_typename_type calls

2012-07-24 Thread Jason Merrill
On 07/24/2012 10:23 AM, Paolo Carlini wrote: while looking into the re-opened c++/51213 (doesn't seem trivial: details soon, I hope) I noticed things which look like old pastos: in convert_template_argument and tsubst we are computing complain tf_error for the - tsubst_flags_t, not bool -

Re: [C++ Patch] Fix pastos (?) in make_typename_type calls

2012-07-24 Thread Paolo Carlini
On 07/24/2012 08:06 PM, Jason Merrill wrote: On 07/24/2012 10:23 AM, Paolo Carlini wrote: while looking into the re-opened c++/51213 (doesn't seem trivial: details soon, I hope) I noticed things which look like old pastos: in convert_template_argument and tsubst we are computing complain

Re: [C++ Patch] Fix pastos (?) in make_typename_type calls

2012-07-24 Thread Jason Merrill
On 07/24/2012 03:05 PM, Paolo Carlini wrote: Thus, all in all, I propose doing the change anyway, of course with a different ChangeLog: if what I summarized above is correct the risk of breaking something is really tiny and the code would become a tad simpler. OK. Jason