Re: [C++ Patch] Improve delete_sanity locations

2019-08-05 Thread Jason Merrill
On 8/2/19 8:27 AM, David Malcolm wrote: On Fri, 2019-08-02 at 14:02 +0200, Paolo Carlini wrote: Hi, On 31/07/19 21:39, David Malcolm wrote: [snip] I don't care for "cp_expr_loc_or_loc". By "_or_here" do you mean "or input_location"? Calling it "cp_expr_loc_or_input_location" would spell out

Re: [C++ Patch] Improve delete_sanity locations

2019-08-02 Thread David Malcolm
On Fri, 2019-08-02 at 14:02 +0200, Paolo Carlini wrote: > Hi, > > On 31/07/19 21:39, David Malcolm wrote: > > [snip] > > I don't care for "cp_expr_loc_or_loc". > > > > By "_or_here" do you mean "or input_location"? > > > > Calling it "cp_expr_loc_or_input_location" would spell out what it > > d

Re: [C++ Patch] Improve delete_sanity locations

2019-08-02 Thread Paolo Carlini
Hi, On 31/07/19 21:39, David Malcolm wrote: [snip] I don't care for "cp_expr_loc_or_loc". By "_or_here" do you mean "or input_location"? Calling it "cp_expr_loc_or_input_location" would spell out what it does, but would be rather long. Thanks for your feedback. At this point I don't feel ve

Re: [C++ Patch] Improve delete_sanity locations

2019-07-31 Thread David Malcolm
On Wed, 2019-07-31 at 15:14 -0400, Jason Merrill wrote: > On 7/24/19 5:24 PM, Paolo Carlini wrote: > > this takes care of the four locations, two warnings and two errors. > > I'm > > also adding the missing complain & tf_warning or tf_error guards, > > I > > don't have a SFINAE testcase failing b

Re: [C++ Patch] Improve delete_sanity locations

2019-07-31 Thread Jason Merrill
On 7/24/19 5:24 PM, Paolo Carlini wrote: this takes care of the four locations, two warnings and two errors. I'm also adding the missing complain & tf_warning or tf_error guards, I don't have a SFINAE testcase failing but since the function takes a tsubst_flags_t argument I think it's the right

[C++ Patch] Improve delete_sanity locations

2019-07-24 Thread Paolo Carlini
Hi, this takes care of the four locations, two warnings and two errors. I'm also adding the missing complain & tf_warning or tf_error guards, I don't have a SFINAE testcase failing but since the function takes a tsubst_flags_t argument I think it's the right thing to do. Tested x86_64-linux.