Re: [C++ Patch] PR 51290

2011-11-24 Thread Paolo Carlini
On 11/24/2011 03:58 AM, Jason Merrill wrote: On 11/23/2011 08:09 PM, Paolo Carlini wrote: if (null_test) { - tree zero = cp_convert (TREE_TYPE (expr), integer_zero_node); + tree zero = cp_convert (TREE_TYPE (expr), + want_pointer ? nullptr_node : integer_zero_n

Re: [C++ Patch] PR 51290

2011-11-23 Thread Jason Merrill
On 11/23/2011 08:09 PM, Paolo Carlini wrote: if (null_test) { - tree zero = cp_convert (TREE_TYPE (expr), integer_zero_node); + tree zero = cp_convert (TREE_TYPE (expr), + want_pointer ? nullptr_node : integer_zero_node); This ?: is unnecessary; if

[C++ Patch] PR 51290

2011-11-23 Thread Paolo Carlini
Hi, another case of spurious -Wzero-as-null-pointer-constant, rather straightforward fix, IMHO. Well, with hindsight, I should have grepped more carefully for integer_zero_node, a couple of weeks ago ;) Anyway, tested x86_64-linux. Ok? Thanks, Paolo. /// /cp 2011-11-23 Paol