Re: [C++ Patch] PR 59270

2014-01-17 Thread Paolo Carlini
.. patchlet fixes c++/58811 too. Paolo.

Re: [C++ Patch] PR 59270

2014-01-17 Thread Jason Merrill
OK. Does returning error_mark_node from build_value_init in the case of erroneous type not work? Jason

[C++ Patch] PR 59270

2014-01-15 Thread Paolo Carlini
Hi, this is a 4.9 Regression, but just an ICE on invalid. It's a little tricky to fix, because, eg, in mainline (vs 4_8-branch) we want to produce somewhat more concise diagnostic in this area (eg, a single error for init/array26.C). It seems Ok to me, and passes testing, to return NULL_TREE

Re: [C++ Patch] PR 59270

2014-01-15 Thread Jason Merrill
On 01/15/2014 07:54 AM, Paolo Carlini wrote: It seems Ok to me, and passes testing, to return NULL_TREE from build_value_init. Alternately, more conservatively, we could change build_value_init_noctor to not call build_value_init at all when ftype == error_mark_node. I think I would prefer

Re: [C++ Patch] PR 59270

2014-01-15 Thread Paolo Carlini
Hi, On 01/15/2014 08:45 PM, Jason Merrill wrote: On 01/15/2014 07:54 AM, Paolo Carlini wrote: It seems Ok to me, and passes testing, to return NULL_TREE from build_value_init. Alternately, more conservatively, we could change build_value_init_noctor to not call build_value_init at all when