Re: [C++ Patch] PR 60978

2014-12-02 Thread Paolo Carlini
Hi, On 12/02/2014 11:01 PM, Jason Merrill wrote: See my comment on the PR; I think the testcase illustrates why we still want this warning for anonymous enums. Ok... Thus, barring further discussion, I will simply close the Bug as invalid. Thanks! Paolo.

Re: [C++ Patch] PR 60978

2014-12-02 Thread Jason Merrill
See my comment on the PR; I think the testcase illustrates why we still want this warning for anonymous enums. Jason

[C++ Patch] PR 60978

2014-12-02 Thread Paolo Carlini
Hi, another simple issue: this one argues that the warning is overeager when anonymous enums are involved, which often are just used as named constants. Details: maybe write the conditional in a different way; maybe even use && instead of ||. Tested x86_64-linux. Thanks, Paolo.