Re: [C++ Patch] PR 70972 ("[6/7 Regression] Inheriting constructors taking parameters by value should move them, not copy")

2016-05-31 Thread Jason Merrill
On Tue, May 31, 2016 at 12:29 PM, Paolo Carlini wrote: > Hi, > > On 23/05/2016 19:32, Jason Merrill wrote: >> >> OK. > > What about gcc-6-branch? Assuming no issues show up in mainline I think we > want it there too in time for 6.2, right? Definitely. Jason

Re: [C++ Patch] PR 70972 ("[6/7 Regression] Inheriting constructors taking parameters by value should move them, not copy")

2016-05-31 Thread Paolo Carlini
Hi, On 23/05/2016 19:32, Jason Merrill wrote: OK. What about gcc-6-branch? Assuming no issues show up in mainline I think we want it there too in time for 6.2, right? Thanks, Paolo.

Re: [C++ Patch] PR 70972 ("[6/7 Regression] Inheriting constructors taking parameters by value should move them, not copy")

2016-05-23 Thread Jason Merrill
OK. Jason

[C++ Patch] PR 70972 ("[6/7 Regression] Inheriting constructors taking parameters by value should move them, not copy")

2016-05-23 Thread Paolo Carlini
Hi, admittedly I didn't spend much time on this issue, but submitter himself provided a strong hint and a fix may be very simple... Essentially, he noticed that the implementation of forward_parm, being kind of a std::forward for internal uses, misses a cp_build_reference (*, true) when