Re: [C++ Patch] PR 71248

2016-05-31 Thread Jason Merrill
OK. Jason On Tue, May 31, 2016 at 8:54 AM, Paolo Carlini wrote: > Hi, > > the primary issue is already fixed, we don't ICE anymore, but the location > of the error message is (badly) incorrect, because > check_static_variable_definition doesn't use

[C++ Patch] PR 71248

2016-05-31 Thread Paolo Carlini
Hi, the primary issue is already fixed, we don't ICE anymore, but the location of the error message is (badly) incorrect, because check_static_variable_definition doesn't use DECL_SOURCE_LOCATION. Just doing that, consistently, plus a number of additional column checks in existing testcases