Re: [C PATCH] Better column info for initializers (PR c/60139)

2014-05-05 Thread Marek Polacek
On Thu, May 01, 2014 at 11:55:38PM +, Joseph S. Myers wrote: On Fri, 25 Apr 2014, Marek Polacek wrote: Another minor fix: use loc instead of input_location. Also add missing OPT_Wpedantic. Why do you say it's missing? A default pedwarn generally means this is dubious code, not

Re: [C PATCH] Better column info for initializers (PR c/60139)

2014-05-01 Thread Joseph S. Myers
On Fri, 25 Apr 2014, Marek Polacek wrote: Another minor fix: use loc instead of input_location. Also add missing OPT_Wpedantic. Why do you say it's missing? A default pedwarn generally means this is dubious code, not allowed by ISO C, but we don't want to make it a hard error (and the

Re: [C PATCH] Better column info for initializers (PR c/60139)

2014-04-29 Thread Richard Henderson
On 04/25/2014 08:44 AM, Marek Polacek wrote: 2014-04-25 Marek Polacek pola...@redhat.com PR c/60139 * c-typeck.c (output_init_element): Pass OPT_Wpedantic to pedwarn and pedwarn_init. Use loc insted of input_location. * gcc.dg/pr60139.c: New test. Ok. r~

[C PATCH] Better column info for initializers (PR c/60139)

2014-04-25 Thread Marek Polacek
Another minor fix: use loc instead of input_location. Also add missing OPT_Wpedantic. After this is in, my plan is to make pedwarn_init and error_init static (I already have a patch for that) and then add location argument to error_init and pass proper location to it, and to pedwarn_init as