Re: [COMMITTED V3 1/4] RISC-V: Add non-vector types to dfa pipelines

2024-02-15 Thread Edwin Lu
On 2/15/2024 1:25 AM, Li, Pan2 wrote: Sorry for late reply due to holiday. I double-checked the calling-convernsion-*.c dump, it is safe to adjust the asm check to the number as you mentioned. Hi Pan, I hope you had a good holiday! I already changed the numbers and added a bit more checks

RE: [COMMITTED V3 1/4] RISC-V: Add non-vector types to dfa pipelines

2024-02-15 Thread Li, Pan2
-patches Cc: Robin Dapp ; kito.cheng ; jeffreyalaw ; palmer ; vineetg ; Patrick O'Neill Subject: Re: [COMMITTED V3 1/4] RISC-V: Add non-vector types to dfa pipelines On 2/2/2024 11:10 PM, Li, Pan2 wrote: > Hi Edwin > >> I believe the only problematic failures are the 5 vls callin

Re: [COMMITTED V3 1/4] RISC-V: Add non-vector types to dfa pipelines

2024-02-05 Thread Edwin Lu
On 2/2/2024 11:10 PM, Li, Pan2 wrote: Hi Edwin I believe the only problematic failures are the 5 vls calling convention ones where only 24 ld\\s+a[0-1],\\s*[0-9]+\\(sp\\) are found. Does this "only 24" comes from calling-convention-1.c? Oops sorry about that. I said I would include all the

RE: [COMMITTED V3 1/4] RISC-V: Add non-vector types to dfa pipelines

2024-02-02 Thread Li, Pan2
rned by a[0-1]. Pan -Original Message- From: Edwin Lu Sent: Saturday, February 3, 2024 8:29 AM To: Li, Pan2 ; juzhe.zh...@rivai.ai; gcc-patches Cc: Robin Dapp ; kito.cheng ; jeffreyalaw ; palmer ; vineetg ; Patrick O'Neill Subject: Re: [COMMITTED V3 1/4] RISC-V: Add non-vector types

Re: [COMMITTED V3 1/4] RISC-V: Add non-vector types to dfa pipelines

2024-02-02 Thread Edwin Lu
On 2/1/2024 8:28 PM, Li, Pan2 wrote: Hi Edwin, Just rerun the newlib and there is no ICE but still 160 dump failures as below. Pan Hi Pan, Thanks for confirming! Having dump failures is expected. There are around 7 more unique failures than I expected

RE: [COMMITTED V3 1/4] RISC-V: Add non-vector types to dfa pipelines

2024-02-01 Thread Li, Pan2
; Patrick O'Neill Subject: RE: [COMMITTED V3 1/4] RISC-V: Add non-vector types to dfa pipelines Sorry, it seems the log was eliminated by my cleanup script(s). Let me know rerun one newlib for commit id 23cd2961bd2ff63583f46e3499a07bd54491d45c. Pan -Original Message- From: Edwin Lu Sent

RE: [COMMITTED V3 1/4] RISC-V: Add non-vector types to dfa pipelines

2024-02-01 Thread Li, Pan2
: Robin Dapp ; kito.cheng ; jeffreyalaw ; palmer ; vineetg ; Patrick O'Neill Subject: Re: [COMMITTED V3 1/4] RISC-V: Add non-vector types to dfa pipelines On 1/31/2024 11:29 PM, Li, Pan2 wrote: > I can somehow reproduce the failures on commit id > 23cd2961bd2ff63583f46e3499a07bd544

Re: [COMMITTED V3 1/4] RISC-V: Add non-vector types to dfa pipelines

2024-02-01 Thread Edwin Lu
;mailto:rdapp@gmail.com>; kito.cheng <mailto:kito.ch...@gmail.com>; jeffreyalaw <mailto:jeffreya...@gmail.com>; palmer <mailto:pal...@rivosinc.com>; vineetg <mailto:vine...@rivosinc.com>; Patrick O'Neill <mailto:patr...@rivosinc.com> *Subject:* Re

Re: [COMMITTED V3 1/4] RISC-V: Add non-vector types to dfa pipelines

2024-02-01 Thread Edwin Lu
rick O'Neill <mailto:patr...@rivosinc.com> *Subject:* Re: [COMMITTED V3 1/4] RISC-V: Add non-vector types to dfa pipelines From what I know, if it was a problem with my dfa reservation assert, it would have ICEd in riscv.cc and not riscv-v.cc. For now I reverted

Re: Re: [COMMITTED V3 1/4] RISC-V: Add non-vector types to dfa pipelines

2024-01-31 Thread juzhe.zh...@rivai.ai
; jeffreyalaw; palmer; vineetg; Patrick O'Neill Subject: Re: [COMMITTED V3 1/4] RISC-V: Add non-vector types to dfa pipelines From what I know, if it was a problem with my dfa reservation assert, it would have ICEd in riscv.cc and not riscv-v.cc. For now I reverted the changes since I don't want to leave

Re: Re: [COMMITTED V3 1/4] RISC-V: Add non-vector types to dfa pipelines

2024-01-31 Thread juzhe.zh...@rivai.ai
; Patrick O'Neill Subject: Re: [COMMITTED V3 1/4] RISC-V: Add non-vector types to dfa pipelines From what I know, if it was a problem with my dfa reservation assert, it would have ICEd in riscv.cc and not riscv-v.cc. For now I reverted the changes since I don't want to leave things possibly broken

Re: Re: [COMMITTED V3 1/4] RISC-V: Add non-vector types to dfa pipelines

2024-01-31 Thread juzhe.zh...@rivai.ai
Maybe I do the wrong testing. Let me use a clean linux environment and try again. juzhe.zh...@rivai.ai From: Edwin Lu Date: 2024-02-01 14:13 To: juzhe.zh...@rivai.ai; gcc-patches CC: Robin Dapp; kito.cheng; jeffreyalaw; palmer; vineetg; Patrick O'Neill Subject: Re: [COMMITTED V3 1/4] RISC-V

Re: [COMMITTED V3 1/4] RISC-V: Add non-vector types to dfa pipelines

2024-01-31 Thread Edwin Lu
From what I know, if it was a problem with my dfa reservation assert, it would have ICEd in riscv.cc and not riscv-v.cc. For now I reverted the changes since I don't want to leave things possibly broken overnight and not knowing which patch is the root cause. I kicked off another set of test

Re: [COMMITTED V3 1/4] RISC-V: Add non-vector types to dfa pipelines

2024-01-31 Thread Edwin Lu
Hi Juzhe, I didn't see any ICEs when I tested locally (tested on https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=8123f3ca3fd891034a8366518e756f161c4ff40d). Can you tell me what config you're using? Edwin On 1/31/2024 6:57 PM, juzhe.zh...@rivai.ai wrote: Hi, all.

[COMMITTED V3 1/4] RISC-V: Add non-vector types to dfa pipelines

2024-01-31 Thread juzhe.zh...@rivai.ai
Hi, all. https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=26c34b809cd1a6249027730a8b52bbf6a1c0f4a8 https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=e56fb037d9d265682f5e7217d8a4c12a8d3fddf8 https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=4b799a16ae59fc0f508c5931ebf1851a3446b707

Re: [COMMITTED V3 1/4] RISC-V: Add non-vector types to dfa pipelines

2024-01-31 Thread Edwin Lu
On 1/25/2024 9:06 AM, Robin Dapp wrote: LGTM, thanks. Regards Robin Committed! Edwin