Re: [Committed] PR fortran/54072 -- More fun with BOZ

2019-08-08 Thread Steve Kargl
On Thu, Aug 08, 2019 at 09:23:11AM -0700, Steve Kargl wrote: > On Thu, Aug 08, 2019 at 10:11:39AM +0100, Mark Eggleston wrote: > > > > >> Comparisons with BOZ constants was allowed using 9.1 with > > >> -Wconversion-extra: > > >> > > >>     5 | if (i4 .eq. z'1000') then > > >>   | 

Re: [Committed] PR fortran/54072 -- More fun with BOZ

2019-08-08 Thread Steve Kargl
On Thu, Aug 08, 2019 at 10:11:39AM +0100, Mark Eggleston wrote: > > >> Comparisons with BOZ constants was allowed using 9.1 with > >> -Wconversion-extra: > >> > >>     5 | if (i4 .eq. z'1000') then > >>   |    1 > >> Warning: Conversion from INTEGER(4) to INTEGER(16) at

Re: [Committed] PR fortran/54072 -- More fun with BOZ

2019-08-08 Thread Steve Kargl
On Thu, Aug 08, 2019 at 09:31:37AM +0100, Mark Eggleston wrote: > > On 07/08/2019 19:56, Steve Kargl wrote: > > On Wed, Aug 07, 2019 at 09:09:49AM -0700, Steve Kargl wrote: > >> On Wed, Aug 07, 2019 at 01:58:17PM +0100, Mark Eggleston wrote: > >>> DATA statements for logical and character

Re: [Committed] PR fortran/54072 -- More fun with BOZ

2019-08-08 Thread Mark Eggleston
On 07/08/2019 17:09, Steve Kargl wrote: On Wed, Aug 07, 2019 at 01:58:17PM +0100, Mark Eggleston wrote: BOZ problems in the following areas * use of logical and character variables with BOZ constants * comparisons with BOZ constants * DATA statements Comparing 9.1 and trunk: The

Re: [Committed] PR fortran/54072 -- More fun with BOZ

2019-08-08 Thread Mark Eggleston
On 07/08/2019 19:56, Steve Kargl wrote: On Wed, Aug 07, 2019 at 09:09:49AM -0700, Steve Kargl wrote: On Wed, Aug 07, 2019 at 01:58:17PM +0100, Mark Eggleston wrote: DATA statements for logical and character variable compile but do not work: program test   character(4) :: c   data c /

Re: [Committed] PR fortran/54072 -- More fun with BOZ

2019-08-07 Thread Steve Kargl
On Wed, Aug 07, 2019 at 09:09:49AM -0700, Steve Kargl wrote: > On Wed, Aug 07, 2019 at 01:58:17PM +0100, Mark Eggleston wrote: > > > > DATA statements for logical and character variable compile but do not work: > > > > program test > >   character(4) :: c > >   data c / z'41424344' / > >  

Re: [Committed] PR fortran/54072 -- More fun with BOZ

2019-08-07 Thread Steve Kargl
On Wed, Aug 07, 2019 at 01:58:17PM +0100, Mark Eggleston wrote: > > BOZ problems in the following areas > > * use of logical and character variables with BOZ constants > * comparisons with BOZ constants > * DATA statements > > Comparing 9.1 and trunk: The comparison is somewhat

Re: [Committed] PR fortran/54072 -- More fun with BOZ

2019-08-07 Thread Mark Eggleston
Steve, BOZ problems in the following areas * use of logical and character variables with BOZ constants * comparisons with BOZ constants * DATA statements Comparing 9.1 and trunk: character variables (9.1) * old style initialisation - not allowed (Incompatible types) * new style

[Committed] PR fortran/54072 -- More fun with BOZ

2019-07-23 Thread Steve Kargl
I've committed the attached patch as a follow-up to the recent BOZ (r273747). It removes a few leftover comments as well as fixes the PR. 2019-07-23 Steven G. Kargl PR fortran/54072 * check.c (gfc_invalid_boz): Fix comment. (illegal_boz_arg): New function. (gfc_check_transfer): Use to