Re: [DOC Patch] Add sample for @cc constraint

On 4/25/2016 2:51 AM, Bernd Schmidt wrote: On 04/16/2016 01:12 AM, David Wohlferd wrote: There were basically 3 changes I was trying for in that doc patch. Are any of them worth keeping? Or are we done? 1) "Do not clobber flags if they are being used as outputs." 2) Output flags sample (with

Re: [DOC Patch] Add sample for @cc constraint

On 04/16/2016 01:12 AM, David Wohlferd wrote: There were basically 3 changes I was trying for in that doc patch. Are any of them worth keeping? Or are we done? 1) "Do not clobber flags if they are being used as outputs." 2) Output flags sample (with #if removed). 3) "On the x86 platform,

Re: [DOC Patch] Add sample for @cc constraint

I've had it in a successful test run, and committed it with a minor tweak (__builtin_abort vs return 1). It didn't find anything, but it's probably good to have. As for the docs, I think you are unnecessarily worried about things that are never going to be a problem in practice. Perhaps

Re: [DOC Patch] Add sample for @cc constraint

On 04/12/2016 12:49 AM, David Wohlferd wrote: First draft is attached. It tests all 28 (14 conditions plus 14 inverted). I wasn't sure what to set for optimization (O2? O3? O0?), so I left the default. I've had it in a successful test run, and committed it with a minor tweak

Re: [DOC Patch] Add sample for @cc constraint

Ping? dw On 4/1/2016 4:39 PM, David Wohlferd wrote: > I would like executable code that verifies that this feature is indeed working as intended. First draft is attached. It tests all 28 (14 conditions plus 14 inverted). I wasn't sure what to set for optimization (O2? O3? O0?), so I left

Re: [DOC Patch] Add sample for @cc constraint

> I would like executable code that verifies that this feature is indeed working as intended. First draft is attached. It tests all 28 (14 conditions plus 14 inverted). I wasn't sure what to set for optimization (O2? O3? O0?), so I left the default. It looks like even at O3 there are some

Re: [DOC Patch] Add sample for @cc constraint

On 03/28/2016 12:03 AM, David Wohlferd wrote: On 3/24/2016 8:00 AM, Bernd Schmidt wrote: > More problematic than a lack of documentation is that I haven't been able to find an executable testcase. If you could adapt your example for use in gcc.target/i386, that would be even more important. It

Re: [DOC Patch] Add sample for @cc constraint

Thanks for the feedback. While I agree with some of this, there are parts that I want to defend. If after explaining why I did what I did you still feel it should be changed, I'm prepared to do that. On 3/24/2016 8:00 AM, Bernd Schmidt wrote: > More problematic than a lack of documentation

Re: [DOC Patch] Add sample for @cc constraint

On 03/24/2016 09:00 AM, Bernd Schmidt wrote: In principle we probably should have an example, but once again I have some problems with the style of the added documentation. I prefer concise writing without unnecessary repetition. Any other reviewers can of course override me, but the following

Re: [DOC Patch] Add sample for @cc constraint

In principle we probably should have an example, but once again I have some problems with the style of the added documentation. I prefer concise writing without unnecessary repetition. Any other reviewers can of course override me, but the following is my opinion on these changes. More

Re: [DOC Patch] Add sample for @cc constraint

Ping? (link to original post: https://gcc.gnu.org/ml/gcc-patches/2016-03/msg00743.html ) This patch adds a sample for a new-to-v6 feature. Is this not the right time for doc improvements? I considered adding some assembler output. Something like: Before this

[DOC Patch] Add sample for @cc constraint

The docs for the new(-ish) @cc constraint need an example. Attached. ChangeLog: 2016-03-12 David Wohlferd * doc/extend.texi: Add sample for @cc constraint Note that while I have a release on file with FSF, I don't have write access to SVN. dw Index: