Re: [GOOGLE] update ssa before compute_inline_parameters

2014-03-20 Thread Xinliang David Li
The patch is ok. David On Thu, Mar 20, 2014 at 1:10 PM, Dehao Chen wrote: > On Thu, Mar 20, 2014 at 1:02 PM, Xinliang David Li wrote: >> On Thu, Mar 20, 2014 at 12:40 PM, Dehao Chen wrote: >>> Patch updated to add a wrapper early_inline function >>> >>> Index: gcc/auto-profile.c >>> ==

Re: [GOOGLE] update ssa before compute_inline_parameters

2014-03-20 Thread Dehao Chen
On Thu, Mar 20, 2014 at 1:02 PM, Xinliang David Li wrote: > On Thu, Mar 20, 2014 at 12:40 PM, Dehao Chen wrote: >> Patch updated to add a wrapper early_inline function >> >> Index: gcc/auto-profile.c >> === >> --- gcc/auto-profile.c

Re: [GOOGLE] update ssa before compute_inline_parameters

2014-03-20 Thread Xinliang David Li
On Thu, Mar 20, 2014 at 12:40 PM, Dehao Chen wrote: > Patch updated to add a wrapper early_inline function > > Index: gcc/auto-profile.c > === > --- gcc/auto-profile.c (revision 208726) > +++ gcc/auto-profile.c (working copy) > @@ -14

Re: [GOOGLE] update ssa before compute_inline_parameters

2014-03-20 Thread Dehao Chen
Patch updated to add a wrapper early_inline function Index: gcc/auto-profile.c === --- gcc/auto-profile.c (revision 208726) +++ gcc/auto-profile.c (working copy) @@ -1449,8 +1449,6 @@ afdo_vpt_for_early_inline (stmt_set *promoted_stmt

Re: [GOOGLE] update ssa before compute_inline_parameters

2014-03-20 Thread Xinliang David Li
I think the right way to fix this is to wrap the call to early_inliner and check the TODO flags. See execute_function_todo: if (flags & TODO_cleanup_cfg) { cleanup_tree_cfg (); if (!(flags & TODO_update_ssa_any) && need_ssa_update_p (cfun)) flags |= TODO_update_ssa;

Fwd: [GOOGLE] update ssa before compute_inline_parameters

2014-03-20 Thread Dehao Chen
This patch calls update_ssa before compute_inline_paramters. Bootstrapped and perf test on-going. OK for google-4_8? Thanks, Dehao Index: gcc/auto-profile.c === --- gcc/auto-profile.c (revision 208726) +++ gcc/auto-profile.c (worki