Re: [GSoC] Addition of ISL AST generation to Graphite

2014-07-20 Thread Roman Gareev
I am not aware of any problems with isl 0.12 and would be surprised if such problems exist. Are you? I'm not aware of them, too. P.S: As Richard suggested, we may also want to forbid CLooG 0.17. I've attached the patch, which adds the requirement for ClooG 0.18.1. Is it fine for trunk? --

Re: [GSoC] Addition of ISL AST generation to Graphite

2014-07-20 Thread Tobias Grosser
On July 20, 2014 1:29:30 PM CEST, Roman Gareev gareevro...@gmail.com wrote: I am not aware of any problems with isl 0.12 and would be surprised if such problems exist. Are you? I'm not aware of them, too. P.S: As Richard suggested, we may also want to forbid CLooG 0.17. I've attached the

Re: [GSoC] Addition of ISL AST generation to Graphite

2014-07-17 Thread Roman Gareev
I've attached the patch, which adds the requirement for isl 0.12. Tobias, is it important to accept only 0.12.1, 0.12.2 and forbid 0.12? -- Cheers, Roman Gareev 2014-07-12 Roman Gareev gareevro...@gmail.com * configure.ac: Don't accept isl 0.11.

Re: [GSoC] Addition of ISL AST generation to Graphite

2014-07-17 Thread Tobias Grosser
On 17/07/2014 16:11, Roman Gareev wrote: I've attached the patch, which adds the requirement for isl 0.12. Tobias, is it important to accept only 0.12.1, 0.12.2 and forbid 0.12? I am not aware of any problems with isl 0.12 and would be surprised if such problems exist. Are you? The patch

Re: [GSoC] Addition of ISL AST generation to Graphite

2014-07-16 Thread Richard Biener
On Tue, Jul 15, 2014 at 5:34 PM, Tobias Grosser tob...@grosser.es wrote: On 15/07/2014 17:02, Roman Gareev wrote: I'm seeing the error: gcc/graphite-isl-ast-to-gimple.c:31:25: warning: isl/val_gmp.h: No such file or directory when building for aarch64. isl/val_gmp.h is included in 0.12

Re: [GSoC] Addition of ISL AST generation to Graphite

2014-07-16 Thread Tobias Grosser
On 16/07/2014 11:36, Richard Biener wrote: On Tue, Jul 15, 2014 at 5:34 PM, Tobias Grosser tob...@grosser.es wrote: On 15/07/2014 17:02, Roman Gareev wrote: I'm seeing the error: gcc/graphite-isl-ast-to-gimple.c:31:25: warning: isl/val_gmp.h: No such file or directory when building for

Re: [GSoC] Addition of ISL AST generation to Graphite

2014-07-16 Thread Roman Gareev
Could you prepare such a patch? Yes, I've started working on it. I have a question about isl. Can we require that isl is always compiled with GMP support? -- Cheers, Roman Gareev

Re: [GSoC] Addition of ISL AST generation to Graphite

2014-07-16 Thread Tobias Grosser
On 16/07/2014 14:03, Roman Gareev wrote: Could you prepare such a patch? Yes, I've started working on it. I have a question about isl. Can we require that isl is always compiled with GMP support? isl 0.12.2 is always compiled with GMP support. Only for the unreleased isl-0.14 imath was

Re: [GSoC] Addition of ISL AST generation to Graphite

2014-07-15 Thread Roman Gareev
I'm seeing the error: gcc/graphite-isl-ast-to-gimple.c:31:25: warning: isl/val_gmp.h: No such file or directory when building for aarch64. isl/val_gmp.h is included in 0.12 AFAICS so perhaps we should demand 0.12 instead of 0.11 ? According to isl's ChangeLog, isl_val abstraction was

Re: [GSoC] Addition of ISL AST generation to Graphite

2014-07-15 Thread Tobias Grosser
On 15/07/2014 17:02, Roman Gareev wrote: I'm seeing the error: gcc/graphite-isl-ast-to-gimple.c:31:25: warning: isl/val_gmp.h: No such file or directory when building for aarch64. isl/val_gmp.h is included in 0.12 AFAICS so perhaps we should demand 0.12 instead of 0.11 ? According to isl's

Re: [GSoC] Addition of ISL AST generation to Graphite

2014-07-14 Thread Kyrill Tkachov
On 05/07/14 21:20, Rainer Orth wrote: Rainer Orth r...@cebitec.uni-bielefeld.de writes: Roman Gareev gareevro...@gmail.com writes: It seems the patch1/patch2 files you attach have the Content-Type: application/octet-stream. This makes it impossible to view them inline. Could you send them

Re: [GSoC] Addition of ISL AST generation to Graphite

2014-07-06 Thread Roman Gareev
Sorry, I was going to fix this. Thank you very much! -- Cheers, Roman Gareev

Re: [GSoC] Addition of ISL AST generation to Graphite

2014-07-05 Thread Rainer Orth
Rainer Orth r...@cebitec.uni-bielefeld.de writes: Roman Gareev gareevro...@gmail.com writes: It seems the patch1/patch2 files you attach have the Content-Type: application/octet-stream. This makes it impossible to view them inline. Could you send them as text files? Just calling them

Re: [GSoC] Addition of ISL AST generation to Graphite

2014-07-04 Thread Rainer Orth
Roman Gareev gareevro...@gmail.com writes: It seems the patch1/patch2 files you attach have the Content-Type: application/octet-stream. This makes it impossible to view them inline. Could you send them as text files? Just calling them patch1.patch or patch1.txt should make this work. Yes,

Re: [GSoC] Addition of ISL AST generation to Graphite

2014-06-29 Thread Gerald Pfeifer
I'm pretty it's the following that causes bootstrap to fail for me: 2014-06-29 Roman Gareev gareevro...@gmail.com * Makefile.in: Add the compilation of graphite-isl-ast-to-gimple.o. * common.opt: Add new switch fgraphite-code-generator=[isl|cloog]. *

Re: [GSoC] Addition of ISL AST generation to Graphite

2014-06-29 Thread Tobias Grosser
On 29/06/2014 19:31, Gerald Pfeifer wrote: I'm pretty it's the following that causes bootstrap to fail for me: 2014-06-29 Roman Gareev gareevro...@gmail.com * Makefile.in: Add the compilation of graphite-isl-ast-to-gimple.o. * common.opt: Add new switch

Re: [GSoC] Addition of ISL AST generation to Graphite

2014-06-29 Thread Gerald Pfeifer
On Sun, 29 Jun 2014, Tobias Grosser wrote: sorry for the breakage. This seems to be caused by forgotten include guards. I attached a patch (not bootstrapped yet), that should fix the issue. I will start a gcc (non-graphite) bootstrap to see if it works and will commit it immediately after.

Re: [GSoC] Addition of ISL AST generation to Graphite

2014-06-23 Thread Sebastian Pop
Please add a FIXME note in graphite_regenerate_ast_isl saying that this is not yet a full implementation of the code generator with ISL ASTs. It would be useful to make the current graphite_regenerate_ast_isl working by calling graphite_regenerate_ast_cloog and adding the fixme note above saying

Re: [GSoC] Addition of ISL AST generation to Graphite

2014-06-23 Thread Tobias Grosser
Thanks Sebastian for the review! It is good to see you again on the mailing list! On 23/06/2014 11:29, Sebastian Pop wrote: Please add a FIXME note in graphite_regenerate_ast_isl saying that this is not yet a full implementation of the code generator with ISL ASTs. It would be useful to make

Re: [GSoC] Addition of ISL AST generation to Graphite

2014-06-23 Thread Roman Gareev
Thank you for the review! -- Cheers, Roman Gareev ChangeLog_entry1 Description: Binary data ChangeLog_entry2 Description: Binary data patch1 Description: Binary data patch2 Description: Binary data

Re: [GSoC] Addition of ISL AST generation to Graphite

2014-06-23 Thread Roman Gareev
It seems the patch1/patch2 files you attach have the Content-Type: application/octet-stream. This makes it impossible to view them inline. Could you send them as text files? Just calling them patch1.patch or patch1.txt should make this work. Yes, sure. diff --git

[GSoC] Addition of ISL AST generation to Graphite

2014-06-18 Thread Roman Gareev
These patches add ISL AST generation to graphite, which can be chosen by the fgraphite-code-generator=[isl|cloog] switch. The first patch makes initial renaming of gloog and gloog_error to graphite_regenerate_ast_cloog and graphite_regenerate_error, respectively. The second one adds new files with

Re: [GSoC] Addition of ISL AST generation to Graphite

2014-06-18 Thread Tobias Grosser
On 18/06/2014 21:00, Roman Gareev wrote: These patches add ISL AST generation to graphite, which can be chosen by the fgraphite-code-generator=[isl|cloog] switch. The first patch makes initial renaming of gloog and gloog_error to graphite_regenerate_ast_cloog and graphite_regenerate_error,