Re: [Ping] [Google] Fix profiledbootstrap failure

2013-08-01 Thread Xinliang David Li
Sorry for the delay. The patch is ok and I have committed it to the google branch. thanks, David On Thu, Aug 1, 2013 at 4:51 PM, Dinar Temirbulatov wrote: > Ping? > Hi, > Here is the patch, Tested by profiledbootstrap. Ok for google gcc-4.8? > thanks, Dinar.

[Ping] [Google] Fix profiledbootstrap failure

2013-08-01 Thread Dinar Temirbulatov
Ping? Hi, Here is the patch, Tested by profiledbootstrap. Ok for google gcc-4.8? thanks, Dinar. profiledbootstrap-fix1.patch Description: Binary data

Re: [Google] Fix profiledbootstrap failure

2013-07-31 Thread Dinar Temirbulatov
Hi, Here is the patch, Tested by profiledbootstrap. Ok for google gcc-4.8? thanks, Dinar. On Wed, Jul 31, 2013 at 12:01 AM, Rong Xu wrote: > Will do. > > The patch was in gcc-4_7 by Dehao. > > r194713 | dehao | 2012-12-24 16:49:06 -0800 (Mon, 24 Dec 2012) | 5 lines > > Fix the pro

Re: [Google] Fix profiledbootstrap failure

2013-07-30 Thread Rong Xu
Will do. The patch was in gcc-4_7 by Dehao. r194713 | dehao | 2012-12-24 16:49:06 -0800 (Mon, 24 Dec 2012) | 5 lines Fix the profiled bootstrap: 1. Set the default value of gcov-debug to be 0. 2. Merge profile summaries from different instrumented binaries. On Tue, Jul 30, 2013 at 12:58 PM, Xi

Re: [Google] Fix profiledbootstrap failure

2013-07-30 Thread Xinliang David Li
Ok. Rong, can you help commit the parameter default setting patch? thanks, David On Tue, Jul 30, 2013 at 12:48 PM, Rong Xu wrote: > We have seen the issue before. It does fail the profile boostrap as it > reads a wrong gcda file. > I thought it had been fixed. (The fix was as David mentioned, s

Re: [Google] Fix profiledbootstrap failure

2013-07-30 Thread Dinar Temirbulatov
>I need to understand why this affects profile bootstrap -- is this due >to file name conflict? Yes, It is simple. During the profiledbootstrap on x86_64 platform for libiberty the compiler picks an incorrect profile from the current directory(non-pic version), while compiling pic version, and prof

Re: [Google] Fix profiledbootstrap failure

2013-07-30 Thread Rong Xu
We have seen the issue before. It does fail the profile boostrap as it reads a wrong gcda file. I thought it had been fixed. (The fix was as David mentioned, setting the default value of the parameter to 0). -Rong On Tue, Jul 30, 2013 at 12:02 PM, Xinliang David Li wrote: > I need to understand

Re: [Google] Fix profiledbootstrap failure

2013-07-30 Thread Xinliang David Li
I need to understand why this affects profile bootstrap -- is this due to file name conflict? The fix is wrong -- please do not remove the parameter. If it is a problem, a better fix is to change the default parameter value to 0. David On Tue, Jul 30, 2013 at 11:56 AM, Teresa Johnson wrote: >

Re: [Google] Fix profiledbootstrap failure

2013-07-30 Thread Teresa Johnson
cc'ing Rong and David since this came from LIPO support. The patch as-is removes the one use of PARAM_GCOV_DEBUG (which is on by default) without removing the parameter itself. What is the failure mode you see from this code? Thanks, Teresa On Tue, Jul 30, 2013 at 11:50 AM, Dinar Temirbulatov w

[Google] Fix profiledbootstrap failure

2013-07-30 Thread Dinar Temirbulatov
Hello This change allows to complete profiledbootstrap on the google gcc-4.8 branch, tested with make bootstrap with no new regressions. OK for google 4.8? thanks, Dinar. profiledbootstrap-fix.patch Description: Binary data