Re: [PATCH, MPX, 2/X] Pointers Checker [2/25] Builtins

2013-10-30 Thread Richard Biener
On Tue, Oct 29, 2013 at 8:48 PM, Ilya Enkovich enkovich@gmail.com wrote: 2013/10/29 Jeff Law l...@redhat.com: On 10/29/13 07:52, Ilya Enkovich wrote: Yeah. I'm working on it right now. I've fixed known issues and now I'm looking for others. Meanwhile here is a new patch version with

Re: [PATCH, MPX, 2/X] Pointers Checker [2/25] Builtins

2013-10-30 Thread Ilya Enkovich
2013/10/30 Richard Biener richard.guent...@gmail.com: On Tue, Oct 29, 2013 at 8:48 PM, Ilya Enkovich enkovich@gmail.com wrote: 2013/10/29 Jeff Law l...@redhat.com: On 10/29/13 07:52, Ilya Enkovich wrote: Yeah. I'm working on it right now. I've fixed known issues and now I'm looking

Re: [PATCH, MPX, 2/X] Pointers Checker [2/25] Builtins

2013-10-29 Thread Richard Biener
On Mon, Oct 28, 2013 at 10:21 PM, Jeff Law l...@redhat.com wrote: On 10/25/13 11:57, Ilya Enkovich wrote: There are currently two known issues with LTO. The first one is ICE in LTO streamer when it reads instrumented code. The second one is unitialized flag_check_pointers when code is

Re: [PATCH, MPX, 2/X] Pointers Checker [2/25] Builtins

2013-10-29 Thread Jeff Law
On 10/29/13 04:17, Richard Biener wrote: On Mon, Oct 28, 2013 at 10:21 PM, Jeff Law l...@redhat.com wrote: On 10/25/13 11:57, Ilya Enkovich wrote: There are currently two known issues with LTO. The first one is ICE in LTO streamer when it reads instrumented code. The second one is

Re: [PATCH, MPX, 2/X] Pointers Checker [2/25] Builtins

2013-10-29 Thread Ilya Enkovich
On 29 Oct 06:59, Jeff Law wrote: On 10/29/13 04:17, Richard Biener wrote: On Mon, Oct 28, 2013 at 10:21 PM, Jeff Law l...@redhat.com wrote: On 10/25/13 11:57, Ilya Enkovich wrote: There are currently two known issues with LTO. The first one is ICE in LTO streamer when it reads

Re: [PATCH, MPX, 2/X] Pointers Checker [2/25] Builtins

2013-10-29 Thread Jeff Law
On 10/29/13 07:52, Ilya Enkovich wrote: Yeah. I'm working on it right now. I've fixed known issues and now I'm looking for others. Meanwhile here is a new patch version with required renames and without LTO restriction. I can't help but but curious, what turned out to be the root cause of

Re: [PATCH, MPX, 2/X] Pointers Checker [2/25] Builtins

2013-10-29 Thread Ilya Enkovich
2013/10/29 Jeff Law l...@redhat.com: On 10/29/13 07:52, Ilya Enkovich wrote: Yeah. I'm working on it right now. I've fixed known issues and now I'm looking for others. Meanwhile here is a new patch version with required renames and without LTO restriction. I can't help but but curious,

Re: [PATCH, MPX, 2/X] Pointers Checker [2/25] Builtins

2013-10-28 Thread Jeff Law
On 10/25/13 11:57, Ilya Enkovich wrote: There are currently two known issues with LTO. The first one is ICE in LTO streamer when it reads instrumented code. The second one is unitialized flag_check_pointers when code is compiled by lto1 (do you know why it may happen BTW?). It also causes ICE

Re: [PATCH, MPX, 2/X] Pointers Checker [2/25] Builtins

2013-10-25 Thread Ilya Enkovich
2013/10/25 Jeff Law l...@redhat.com: On 10/21/13 05:49, Ilya Enkovich wrote: Hi, This patch introduces built-in functions used by Pointers Checker and flag to enable Pointers Checker. Builtins available for user are expanded in expand_builtin. All other builtins are not allowed in expand

Re: [PATCH, MPX, 2/X] Pointers Checker [2/25] Builtins

2013-10-24 Thread Ilya Enkovich
2013/10/24 Richard Henderson r...@redhat.com: On 10/23/2013 02:41 PM, Jeff Law wrote: Out of curiosity, did you consider and/or discuss with Richard whether or not to make these target-dependent or target-independent builtins? I realize it's a bit problematic with Richard being involved

Re: [PATCH, MPX, 2/X] Pointers Checker [2/25] Builtins

2013-10-24 Thread Ilya Enkovich
esOn 21 Oct 12:08, Joseph S. Myers wrote: On Mon, 21 Oct 2013, Ilya Enkovich wrote: + if (flag_check_pointers) +{ + if (flag_lto) + sorry (Pointers checker is not yet fully supported for link-time optimization); That sounds wrong. It suggests some bug somewhere in

Re: [PATCH, MPX, 2/X] Pointers Checker [2/25] Builtins

2013-10-24 Thread Jeff Law
On 10/23/13 16:31, Richard Henderson wrote: On 10/23/2013 02:41 PM, Jeff Law wrote: Out of curiosity, did you consider and/or discuss with Richard whether or not to make these target-dependent or target-independent builtins? I realize it's a bit problematic with Richard being involved during

Re: [PATCH, MPX, 2/X] Pointers Checker [2/25] Builtins

2013-10-24 Thread Jeff Law
On 10/24/13 02:36, Ilya Enkovich wrote: 2013/10/24 Richard Henderson r...@redhat.com: On 10/23/2013 02:41 PM, Jeff Law wrote: Out of curiosity, did you consider and/or discuss with Richard whether or not to make these target-dependent or target-independent builtins? I realize it's a bit

Re: [PATCH, MPX, 2/X] Pointers Checker [2/25] Builtins

2013-10-24 Thread Jeff Law
On 10/21/13 05:49, Ilya Enkovich wrote: Hi, This patch introduces built-in functions used by Pointers Checker and flag to enable Pointers Checker. Builtins available for user are expanded in expand_builtin. All other builtins are not allowed in expand until generic version of Pointers Cheker

Re: [PATCH, MPX, 2/X] Pointers Checker [2/25] Builtins

2013-10-23 Thread Jeff Law
On 10/21/13 05:49, Ilya Enkovich wrote: Hi, This patch introduces built-in functions used by Pointers Checker and flag to enable Pointers Checker. Builtins available for user are expanded in expand_builtin. All other builtins are not allowed in expand until generic version of Pointers Cheker

Re: [PATCH, MPX, 2/X] Pointers Checker [2/25] Builtins

2013-10-23 Thread Richard Henderson
On 10/23/2013 02:41 PM, Jeff Law wrote: Out of curiosity, did you consider and/or discuss with Richard whether or not to make these target-dependent or target-independent builtins? I realize it's a bit problematic with Richard being involved during the NDA portion and someone else during the

[PATCH, MPX, 2/X] Pointers Checker [2/25] Builtins

2013-10-21 Thread Ilya Enkovich
Hi, This patch introduces built-in functions used by Pointers Checker and flag to enable Pointers Checker. Builtins available for user are expanded in expand_builtin. All other builtins are not allowed in expand until generic version of Pointers Cheker is implemented. Bootstrapped and tested

Re: [PATCH, MPX, 2/X] Pointers Checker [2/25] Builtins

2013-10-21 Thread Joseph S. Myers
On Mon, 21 Oct 2013, Ilya Enkovich wrote: + if (flag_check_pointers) +{ + if (flag_lto) + sorry (Pointers checker is not yet fully supported for link-time optimization); That sounds wrong. It suggests some bug somewhere in your patch series failing to allow for LTO, which

Re: [PATCH, MPX, 2/X] Pointers Checker [2/25] Builtins

2013-10-21 Thread Ilya Enkovich
On 21 Oct 12:08, Joseph S. Myers wrote: On Mon, 21 Oct 2013, Ilya Enkovich wrote: + if (flag_check_pointers) +{ + if (flag_lto) + sorry (Pointers checker is not yet fully supported for link-time optimization); That sounds wrong. It suggests some bug somewhere in your