Re: [PATCH, OpenACC] Support Fortran derived type members in "acc update" directives

2018-12-04 Thread Julian Brown
On Tue, 4 Dec 2018 20:12:58 +0100 Jakub Jelinek wrote: > On Tue, Dec 04, 2018 at 07:06:43PM +, Julian Brown wrote: > > Thanks for the review! As it happened though, I had to rewrite a > > lot of the code in this patch for the attach/detach patch, and I > > had meant to withdraw this one.

Re: [PATCH, OpenACC] Support Fortran derived type members in "acc update" directives

2018-12-04 Thread Jakub Jelinek
On Tue, Dec 04, 2018 at 07:06:43PM +, Julian Brown wrote: > Thanks for the review! As it happened though, I had to rewrite a lot of > the code in this patch for the attach/detach patch, and I had meant to > withdraw this one. Many apologies about the wasted time! I mentioned > the superseding

Re: [PATCH, OpenACC] Support Fortran derived type members in "acc update" directives

2018-12-04 Thread Julian Brown
Hi Jakub, On Tue, 4 Dec 2018 15:17:08 +0100 Jakub Jelinek wrote: > On Mon, Sep 03, 2018 at 08:46:54PM -0400, Julian Brown wrote: > > 2018-09-03 Cesar Philippidis > > > > gcc/fortran/ > > * openmp.c (gfc_match_omp_variable_list): New allow_derived > > argument.

Re: [PATCH, OpenACC] Support Fortran derived type members in "acc update" directives

2018-12-04 Thread Jakub Jelinek
On Mon, Sep 03, 2018 at 08:46:54PM -0400, Julian Brown wrote: > 2018-09-03 Cesar Philippidis > > gcc/fortran/ > * openmp.c (gfc_match_omp_variable_list): New allow_derived > argument. (gfc_match_omp_map_clause): Update call to > gfc_match_omp_variable_list.

[PATCH, OpenACC] Support Fortran derived type members in "acc update" directives

2018-09-03 Thread Julian Brown
Hi, This patch (by Cesar) adds support for Fortran derived type members in "acc update" directives (as specified in OpenACC 2.5 2.14.4., Update Directive). Seemingly only "update" directives may specify derived type members in this way as of OpenACC 2.5. Tested with offloading to NVPTX and