Re: [PATCH, OpenMP, v4] Implement uses_allocators clause for target regions

2022-06-13 Thread Jakub Jelinek via Gcc-patches
On Mon, Jun 13, 2022 at 09:29:34PM +0800, Chung-Lin Tang wrote: > > I was hoping you'd drop all this. > > Seehttps://gcc.gnu.org/r13-1002 > > for implementation (both C and C++ FE) of something very similar, > > the only difference there is that in the case of linear clause, it is > > looking for >

Re: [PATCH, OpenMP, v4] Implement uses_allocators clause for target regions

2022-06-13 Thread Chung-Lin Tang
On 2022/6/9 8:22 PM, Jakub Jelinek wrote: + OpenMP 5.2: + + uses_allocators ( modifier : allocator-list ) Please drop the -list above. + uses_allocators ( modifier , modifier : allocator-list ) and here too. Thanks for catching. + struct item_tok + { +location_t loc; +tree

Re: [PATCH, OpenMP, v4] Implement uses_allocators clause for target regions

2022-06-09 Thread Jakub Jelinek via Gcc-patches
On Thu, Jun 09, 2022 at 02:21:13PM +0800, Chung-Lin Tang wrote: > @@ -15651,6 +15653,213 @@ c_parser_omp_clause_allocate (c_parser *parser, > tree list) >return nl; > } > > +/* OpenMP 5.0: > + uses_allocators ( allocator-list ) > + > + allocator-list: > + allocator > + allocator , a

[PATCH, OpenMP, v4] Implement uses_allocators clause for target regions

2022-06-08 Thread Chung-Lin Tang
Hi Jakub, this is v4 of the uses_allocators patch. On 2022/5/31 6:02 PM, Jakub Jelinek wrote: The response I got on omp-lang is that it is intentional that in the new syntax only a single allocator is allowed. So I'd suggest to implement: 1) if has_modifiers (i.e. certainly new syntax), only all