Re: [PATCH, OpenMP 5.0] More implementation of the requires directive

2022-03-29 Thread Andrew Stubbs
On 13/01/2021 15:07, Chung-Lin Tang wrote: We currently emit errors, but do not fatally cause exit of the program if those are not met. We're still unsure if complete block-out of program execution is the right thing for the user. This can be discussed later. After the Unified Shared Memory

Re: [PATCH, OpenMP 5.0] More implementation of the requires directive

2021-03-25 Thread Thomas Schwinge
Hi! On 2021-01-13T23:07:44+0800, Chung-Lin Tang wrote: > this patch provides more implementation of the requires directive, basically: > > (1) The collection of the reverse_offload, unified_address, and > unified_shared_memory > clauses into a .gnu.gomp_requires section > > (2) libgomp checking

Re: [PATCH, OpenMP 5.0] More implementation of the requires directive

2021-01-13 Thread Jakub Jelinek via Gcc-patches
On Wed, Jan 13, 2021 at 11:07:44PM +0800, Chung-Lin Tang wrote: > 2021-01-13 Chung-Lin Tang ... Looks mostly ok, with some nits. > * parse.c ("tree.h"): Add include. > ("omp-general.h"): Likewise. I think the usual way is to write: * parse.c: Include "tree.h" and

[PATCH, OpenMP 5.0] More implementation of the requires directive

2021-01-13 Thread Chung-Lin Tang
Hi Jakub, this patch provides more implementation of the requires directive, basically: (1) The collection of the reverse_offload, unified_address, and unified_shared_memory clauses into a .gnu.gomp_requires section (2) libgomp checking of consistency across the entire .gnu.gomp_requires