Re: [PATCH, aarch64] v2: Preparatory patch to place target independent and,dependent changed code in one file

2024-05-09 Thread Ajit Agarwal
Hello Alex: On 08/05/24 6:18 pm, Alex Coplan wrote: > Hi Ajit, > > Sorry for the long delay in reviewing this. > > This is really getting there now. I've left a few more comments below. > > Apart from minor style things, the main remaining issues are mostly > around comments. It's important

Re: [PATCH, aarch64] v2: Preparatory patch to place target independent and,dependent changed code in one file

2024-05-08 Thread Alex Coplan
Hi Ajit, Sorry for the long delay in reviewing this. This is really getting there now. I've left a few more comments below. Apart from minor style things, the main remaining issues are mostly around comments. It's important to have good clear comments for functions with the parameters (and

[PATCH, aarch64] v2: Preparatory patch to place target independent and,dependent changed code in one file

2024-04-21 Thread Ajit Agarwal
Hello Alex/Richard: All review comments are addressed and changes are made to transform_for_base function as per consensus. Common infrastructure of load store pair fusion is divided into target independent and target dependent changed code. Target independent code is the Generic code with pure