Re: [PATCH, fortran] Support Fortran 2018 teams

Committed revision 257105. Thanks. On Wed, Jan 24, 2018 at 3:17 PM, Jakub Jelinek wrote: > On Wed, Jan 24, 2018 at 08:19:58PM +, Paul Richard Thomas wrote: >> (Jakub, This is all hidden behind the -fcoarray option. To my mind >> this is safe for release.) > > Ok from RM

Re: [PATCH, fortran] Support Fortran 2018 teams

On Wed, Jan 24, 2018 at 08:19:58PM +, Paul Richard Thomas wrote: > (Jakub, This is all hidden behind the -fcoarray option. To my mind > this is safe for release.) Ok from RM POV. Jakub

Re: [PATCH, fortran] Support Fortran 2018 teams

On January 24, 2018 at 1:29:12 PM, Steve Kargl (s...@troutmask.apl.washington.edu) wrote: Yes, thanks, Paul. Unfortunately, I've run out of time. Damian, GCC is in stage 3, we need to wait for approval from the release manager (aka Jakub) before committing the patch. Will do.  

Re: [PATCH, fortran] Support Fortran 2018 teams

On Wed, Jan 24, 2018 at 01:25:51PM -0800, Damian Rouson wrote: > Thank you, Paul. I think Alessandro has commit rights. > If so, then I’ll ask him to make the requested edits and commit it. > > Damian > Yes, thanks, Paul. Unfortunately, I've run out of time. Damian, GCC is in stage 3, we need

Re: [PATCH, fortran] Support Fortran 2018 teams

Thank you, Paul.   I think Alessandro has commit rights.  If so, then I’ll ask him to make the requested edits and commit it. Damian On January 24, 2018 at 12:19:58 PM, Paul Richard Thomas (paul.richard.tho...@gmail.com) wrote: Hi All, Given the delay relative to the start of stage 3, I

Re: [PATCH, fortran] Support Fortran 2018 teams

Hi All, Given the delay relative to the start of stage 3, I thought that I had better deal with this asap: + /* TODO: this works on any derived type when + it should only work with team_type. */ + if (team->ts.type != BT_DERIVED) Why don't you give the team_type derived type

Re: [PATCH, fortran] Support Fortran 2018 teams

I'm heading out of town for a meeting at the end of week, so gfortran patches/reviews are on hold at the moment. If someone else wants to step up to review the patch, I won't object. -- steve On Mon, Jan 22, 2018 at 08:29:41PM -0800, Damian Rouson wrote: > Is Fortran 2018 teams patch ok for

Re: [PATCH, fortran] Support Fortran 2018 teams

Is Fortran 2018 teams patch ok for trunk?    Damian On January 19, 2018 at 2:47:39 PM, Alessandro Fanfarillo (elfa...@ucar.edu) wrote: I can confirm that the little change suggested by Steve passes the regtests (on x86_64-pc-linux-gnu) and the regular tests using OpenCoarrays. On Fri,

Re: [PATCH, fortran] Support Fortran 2018 teams

I can confirm that the little change suggested by Steve passes the regtests (on x86_64-pc-linux-gnu) and the regular tests using OpenCoarrays. On Fri, Jan 19, 2018 at 10:33 AM, Steve Kargl wrote: > On Fri, Jan 19, 2018 at 09:18:14AM -0800, Damian Rouson wrote:

Re: [PATCH, fortran] Support Fortran 2018 teams

On Fri, Jan 19, 2018 at 09:18:14AM -0800, Damian Rouson wrote: > Thanks for catching that, Steve, and for responding, Alessandro. > > Anything else? > I've only just started to look at the patch. Unfortunately, I know zero about teams, so need to read the patch and F2018 standard

Re: [PATCH, fortran] Support Fortran 2018 teams

Thanks for catching that, Steve, and for responding, Alessandro. Anything else? Damian On January 19, 2018 at 9:17:03 AM, Alessandro Fanfarillo (elfa...@ucar.edu) wrote: Yes, definitively ar->team. On Fri, Jan 19, 2018 at 8:36 AM, Steve Kargl wrote: >

Re: [PATCH, fortran] Support Fortran 2018 teams

Yes, definitively ar->team. On Fri, Jan 19, 2018 at 8:36 AM, Steve Kargl wrote: > index 882fe577b76..b4baf5be554 100644 > --- a/gcc/fortran/array.c > +++ b/gcc/fortran/array.c > @@ -158,6 +158,7 @@ gfc_match_array_ref (gfc_array_ref *ar, gfc_array_spec > *as,

Re: [PATCH, fortran] Support Fortran 2018 teams

index 882fe577b76..b4baf5be554 100644 --- a/gcc/fortran/array.c +++ b/gcc/fortran/array.c @@ -158,6 +158,7 @@ gfc_match_array_ref (gfc_array_ref *ar, gfc_array_spec *as, int init, bool matched_bracket = false; gfc_expr *tmp; bool stat_just_seen = false; + bool team_just_seen = false;

[PATCH, fortran] Support Fortran 2018 teams

  All, Attached please find what I hope is the final version of the patch that adds partial support for teams of images, the last remaining major Fortran 2018 feature without current support in gfortran (or any other Fortran compiler of which I’m aware).  I submitted the first draft of this