Re: [PATCH, gcc7, aarch64] Add arithmetic overflow patterns

2016-02-08 Thread Richard Henderson
On 02/07/2016 10:58 AM, Michael Collison wrote: Richard, One other question on the patch. I note that when you expand the addv and uaddv patterns you emit rtl using gen_add3_compareV and en_add3_compareC respectively. These patterns use sign_extend and zero_extend respectively. Why do you not

Re: [PATCH, gcc7, aarch64] Add arithmetic overflow patterns

2016-02-06 Thread Michael Collison
Richard, One other question on the patch. I note that when you expand the addv and uaddv patterns you emit rtl using gen_add3_compareV and en_add3_compareC respectively. These patterns use sign_extend and zero_extend respectively. Why do you not do the same thing for the subv and usubv

Re: [PATCH, gcc7, aarch64] Add arithmetic overflow patterns

2016-01-28 Thread Richard Henderson
On 01/28/2016 01:50 AM, Michael Collison wrote: > Hi Richard, > > Note that this patch appears to depend on your previous patch: > > https://gcc.gnu.org/ml/gcc-patches/2016-01/txtDPaXOBMuOB.txt > > for the definition of define_mode_attr DWI. I was looking at this patch as I > was working on

Re: [PATCH, gcc7, aarch64] Add arithmetic overflow patterns

2016-01-28 Thread Michael Collison
Hi Richard, Note that this patch appears to depend on your previous patch: https://gcc.gnu.org/ml/gcc-patches/2016-01/txtDPaXOBMuOB.txt for the definition of define_mode_attr DWI. I was looking at this patch as I was working on Bugzilla 68543 which this will address. Regards, Michael

[PATCH, gcc7, aarch64] Add arithmetic overflow patterns

2016-01-25 Thread Richard Henderson
After having just spent a few days looking through dumps of builtin-overflow-*.c for regressions while testing the patch for the TImode arithmetic PR, I thought I'd go ahead and post a patch to make use of the overflow bit on aarch64. Consider this queued for stage1. r~ *