Re: [PATCH, i386, Pointer Bounds Checker 31/x] Pointer Bounds Checker builtins for i386 target

2014-10-14 Thread Ilya Enkovich
On 10 Oct 21:20, Ilya Enkovich wrote: 2014-10-10 20:45 GMT+04:00 Jeff Law l...@redhat.com: On 10/09/14 10:54, Uros Bizjak wrote: On Thu, Oct 9, 2014 at 4:07 PM, Ilya Enkovich enkovich@gmail.com wrote: It appeared I changed a semantics of BNDMK expand when replaced tree

Re: [PATCH, i386, Pointer Bounds Checker 31/x] Pointer Bounds Checker builtins for i386 target

2014-10-10 Thread Jeff Law
On 10/09/14 10:54, Uros Bizjak wrote: On Thu, Oct 9, 2014 at 4:07 PM, Ilya Enkovich enkovich@gmail.com wrote: It appeared I changed a semantics of BNDMK expand when replaced tree operations with rtl ones. Original code: + op1 = expand_normal (fold_build2 (PLUS_EXPR, TREE_TYPE

Re: [PATCH, i386, Pointer Bounds Checker 31/x] Pointer Bounds Checker builtins for i386 target

2014-10-10 Thread Ilya Enkovich
2014-10-10 20:45 GMT+04:00 Jeff Law l...@redhat.com: On 10/09/14 10:54, Uros Bizjak wrote: On Thu, Oct 9, 2014 at 4:07 PM, Ilya Enkovich enkovich@gmail.com wrote: It appeared I changed a semantics of BNDMK expand when replaced tree operations with rtl ones. Original code: + op1

Re: [PATCH, i386, Pointer Bounds Checker 31/x] Pointer Bounds Checker builtins for i386 target

2014-10-09 Thread Ilya Enkovich
It appeared I changed a semantics of BNDMK expand when replaced tree operations with rtl ones. Original code: + op1 = expand_normal (fold_build2 (PLUS_EXPR, TREE_TYPE (arg1), + arg1, integer_minus_one_node)); + op1 = force_reg (Pmode, op1);

Re: [PATCH, i386, Pointer Bounds Checker 31/x] Pointer Bounds Checker builtins for i386 target

2014-10-09 Thread Uros Bizjak
On Thu, Oct 9, 2014 at 4:07 PM, Ilya Enkovich enkovich@gmail.com wrote: It appeared I changed a semantics of BNDMK expand when replaced tree operations with rtl ones. Original code: + op1 = expand_normal (fold_build2 (PLUS_EXPR, TREE_TYPE (arg1), +

Re: [PATCH, i386, Pointer Bounds Checker 31/x] Pointer Bounds Checker builtins for i386 target

2014-09-19 Thread Ilya Enkovich
On 18 Sep 19:33, Uros Bizjak wrote: On Thu, Sep 18, 2014 at 3:47 PM, Ilya Enkovich enkovich@gmail.com wrote: Thanks for your comments. Below is a fixed verison. Ilya -- OK with a few nits below. Thanks, Uros. + +case IX86_BUILTIN_BNDRET: + arg0 =

Re: [PATCH, i386, Pointer Bounds Checker 31/x] Pointer Bounds Checker builtins for i386 target

2014-09-18 Thread Ilya Enkovich
On 17 Sep 20:06, Uros Bizjak wrote: On Wed, Sep 17, 2014 at 6:31 PM, Ilya Enkovich enkovich@gmail.com wrote: I don't like the way arguments are prepared. For the case above, bnd_ldx should have index_register_operand predicate in its pattern, and this predicate (and its mode)

Re: [PATCH, i386, Pointer Bounds Checker 31/x] Pointer Bounds Checker builtins for i386 target

2014-09-18 Thread Uros Bizjak
On Thu, Sep 18, 2014 at 3:47 PM, Ilya Enkovich enkovich@gmail.com wrote: Thanks for your comments. Below is a fixed verison. Ilya -- 2014-09-17 Ilya Enkovich ilya.enkov...@intel.com * config/i386/i386-builtin-types.def (BND): New. (ULONG): New.

Re: [PATCH, i386, Pointer Bounds Checker 31/x] Pointer Bounds Checker builtins for i386 target

2014-09-17 Thread Ilya Enkovich
On 16 Sep 12:02, Uros Bizjak wrote: Hm, can this patch be compiled as part of the series? The expanders refer to various gen_bnd patterns that I don't see. Also, I don't see BND mode introduced. Hi, Here is a patch from the series that introduces modes and instructions:

Re: [PATCH, i386, Pointer Bounds Checker 31/x] Pointer Bounds Checker builtins for i386 target

2014-09-17 Thread Uros Bizjak
On Wed, Sep 17, 2014 at 10:11 AM, Ilya Enkovich enkovich@gmail.com wrote: On 16 Sep 12:02, Uros Bizjak wrote: Hm, can this patch be compiled as part of the series? The expanders refer to various gen_bnd patterns that I don't see. Also, I don't see BND mode introduced. Hi, Here is a

Re: [PATCH, i386, Pointer Bounds Checker 31/x] Pointer Bounds Checker builtins for i386 target

2014-09-17 Thread Ilya Enkovich
On 17 Sep 11:42, Uros Bizjak wrote: On Wed, Sep 17, 2014 at 10:11 AM, Ilya Enkovich enkovich@gmail.com wrote: On 16 Sep 12:02, Uros Bizjak wrote: Hm, can this patch be compiled as part of the series? The expanders refer to various gen_bnd patterns that I don't see. Also, I don't see

Re: [PATCH, i386, Pointer Bounds Checker 31/x] Pointer Bounds Checker builtins for i386 target

2014-09-17 Thread Uros Bizjak
On Wed, Sep 17, 2014 at 6:31 PM, Ilya Enkovich enkovich@gmail.com wrote: I don't like the way arguments are prepared. For the case above, bnd_ldx should have index_register_operand predicate in its pattern, and this predicate (and its mode) should be checked in the expander code.

Re: [PATCH, i386, Pointer Bounds Checker 31/x] Pointer Bounds Checker builtins for i386 target

2014-09-16 Thread Uros Bizjak
2014-06-11 Ilya Enkovich ilya.enkov...@intel.com * config/i386/i386-builtin-types.def (BND): New. (ULONG): New. (BND_FTYPE_PCVOID_ULONG): New. (VOID_FTYPE_BND_PCVOID): New. (VOID_FTYPE_PCVOID_PCVOID_BND): New. (BND_FTYPE_PCVOID_PCVOID):

Re: [PATCH, i386, Pointer Bounds Checker 31/x] Pointer Bounds Checker builtins for i386 target

2014-09-15 Thread Ilya Enkovich
Ping 2014-06-11 17:58 GMT+04:00 Ilya Enkovich enkovich@gmail.com: Hi, This patch adds i386 target builtins for Pointer Bounds Checker. Bootstrapped and tested on linux-x86_64. Thanks, Ilya -- gcc/ 2014-06-11 Ilya Enkovich ilya.enkov...@intel.com *

[PATCH, i386, Pointer Bounds Checker 31/x] Pointer Bounds Checker builtins for i386 target

2014-06-11 Thread Ilya Enkovich
Hi, This patch adds i386 target builtins for Pointer Bounds Checker. Bootstrapped and tested on linux-x86_64. Thanks, Ilya -- gcc/ 2014-06-11 Ilya Enkovich ilya.enkov...@intel.com * config/i386/i386-builtin-types.def (BND): New. (ULONG): New.