Re: [PATCH, libstdc++] PR libstdc++/64656

2015-01-19 Thread Jonathan Wakely
On 19/01/15 02:48 +0200, Ville Voutilainen wrote: Minor additions: - add a comment to the #endif for the c++14 #if - fix the doc comments to talk about reverse iterators Thanks, I like the new comments more. This passes the testsuite. Posted during stage3 so OK for trunk. diff --git

Re: [PATCH, libstdc++] PR libstdc++/64656

2015-01-18 Thread Ville Voutilainen
On 19 January 2015 at 00:11, Ville Voutilainen ville.voutilai...@gmail.com wrote: This patch implements the free functions std::cbegin, std::cend, std::rbegin, std::rend, std::crbegin and std::crend, which were missing from our C++14 iterator library. I have run the added test manually but I

[PATCH, libstdc++] PR libstdc++/64656

2015-01-18 Thread Ville Voutilainen
This patch implements the free functions std::cbegin, std::cend, std::rbegin, std::rend, std::crbegin and std::crend, which were missing from our C++14 iterator library. I have run the added test manually but I haven't finished running the full testsuite yet. I will send the patch now anyway, if