Re: [PATCH, rs6000] Port cleanup patch, use rtl.h convenience macros, etc.

2019-01-24 Thread Peter Bergner
On 1/23/19 10:31 AM, Segher Boessenkool wrote: >> (rs6000_init_hard_regno_mode_ok, direct_move_p): Use >> HARD_REGISTER_NUM_P. > > This line is too long. Fixed. > And that is the worst I see in that whole patch! Please apply it. Committed after a svn update and another self review of

Re: [PATCH, rs6000] Port cleanup patch, use rtl.h convenience macros, etc.

2019-01-23 Thread Segher Boessenkool
Hi! On Tue, Dec 04, 2018 at 10:12:51AM -0600, Peter Bergner wrote: > We talked about replacing rs6000'c regno_or_subregno() with the generic > reg_or_subregno() function from jump.c. I agree the geberic version is > better because it has an assert that ensures we have a REG. There were > also a

Re: [PATCH, rs6000] Port cleanup patch, use rtl.h convenience macros, etc.

2019-01-07 Thread Peter Bergner
On 12/12/18 1:58 PM, Peter Bergner wrote: > Ping. Ping * 2. https://gcc.gnu.org/ml/gcc-patches/2018-12/msg00212.html Peter

Re: [PATCH, rs6000] Port cleanup patch, use rtl.h convenience macros, etc.

2018-12-12 Thread Peter Bergner
Ping. Peter On 12/4/18 10:12 AM, Peter Bergner wrote: > Hi Segher, > > We talked about replacing rs6000'c regno_or_subregno() with the generic > reg_or_subregno() function from jump.c. I agree the geberic version is > better because it has an assert that ensures we have a REG. There were >

[PATCH, rs6000] Port cleanup patch, use rtl.h convenience macros, etc.

2018-12-04 Thread Peter Bergner
Hi Segher, We talked about replacing rs6000'c regno_or_subregno() with the generic reg_or_subregno() function from jump.c. I agree the geberic version is better because it has an assert that ensures we have a REG. There were also a couple of places that could use reg_or_subregno() where we