Re: [PATCH, rtl-optimization]: Fix PR88948, store-motion pass creates unrecognisable insn

2019-01-24 Thread Uros Bizjak
On Thu, Jan 24, 2019 at 12:52 PM Richard Sandiford wrote: > Another potential problem is that gen_move_insn should only really > be used for general_operands. > > process_insert_insn seems to get this right, so it'd probably be > cleanest to split the innards out into something that takes the

Re: [PATCH, rtl-optimization]: Fix PR88948, store-motion pass creates unrecognisable insn

2019-01-24 Thread Richard Sandiford
Uros Bizjak writes: > On Thu, Jan 24, 2019 at 12:52 PM Richard Sandiford > wrote: > >> Another potential problem is that gen_move_insn should only really >> be used for general_operands. >> >> process_insert_insn seems to get this right, so it'd probably be >> cleanest to split the innards out

Re: [PATCH, rtl-optimization]: Fix PR88948, store-motion pass creates unrecognisable insn

2019-01-24 Thread Richard Sandiford
Uros Bizjak writes: > Hello! > > RTL store motion pass transforms: > > (insn 19 18 20 4 (parallel [ > (set (mem/c:SI (symbol_ref:SI ("bar_arg") [flags 0x2] > ) [1 bar_arg+0 S4 A32]) > (fix:SI (reg:DF 89))) > (clobber (scratch:XF)) > ])

[PATCH, rtl-optimization]: Fix PR88948, store-motion pass creates unrecognisable insn

2019-01-22 Thread Uros Bizjak
Hello! RTL store motion pass transforms: (insn 19 18 20 4 (parallel [ (set (mem/c:SI (symbol_ref:SI ("bar_arg") [flags 0x2] ) [1 bar_arg+0 S4 A32]) (fix:SI (reg:DF 89))) (clobber (scratch:XF)) ]) "stdarg-3.c":63:7 156 {fix_truncsi_i387_fisttp}